* [PATCH v2] tracing: fix "gfp_t" format for synthetic events
@ 2019-10-18 1:20 Zhengjun Xing
2019-10-18 14:14 ` Steven Rostedt
2019-10-18 14:41 ` Zanussi, Tom
0 siblings, 2 replies; 4+ messages in thread
From: Zhengjun Xing @ 2019-10-18 1:20 UTC (permalink / raw)
To: rostedt, mingo, tom.zanussi; +Cc: linux-kernel, zhengjun.xing
In the format of synthetic events, the "gfp_t" is shown as "signed:1",
but in fact the "gfp_t" is "unsigned", should be shown as "signed:0".
The issue can be reproduced by the following commands:
echo 'memlatency u64 lat; unsigned int order; gfp_t gfp_flags; int migratetype' > /sys/kernel/debug/tracing/synthetic_events
cat /sys/kernel/debug/tracing/events/synthetic/memlatency/format
name: memlatency
ID: 2233
format:
field:unsigned short common_type; offset:0; size:2; signed:0;
field:unsigned char common_flags; offset:2; size:1; signed:0;
field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
field:int common_pid; offset:4; size:4; signed:1;
field:u64 lat; offset:8; size:8; signed:0;
field:unsigned int order; offset:16; size:4; signed:0;
field:gfp_t gfp_flags; offset:24; size:4; signed:1;
field:int migratetype; offset:32; size:4; signed:1;
print fmt: "lat=%llu, order=%u, gfp_flags=%x, migratetype=%d", REC->lat, REC->order, REC->gfp_flags, REC->migratetype
Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
---
kernel/trace/trace_events_hist.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index 57648c5aa679..7482a1466ebf 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -679,6 +679,8 @@ static bool synth_field_signed(char *type)
{
if (str_has_prefix(type, "u"))
return false;
+ if (strcmp(type, "gfp_t") == 0)
+ return false;
return true;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tracing: fix "gfp_t" format for synthetic events
2019-10-18 1:20 [PATCH v2] tracing: fix "gfp_t" format for synthetic events Zhengjun Xing
@ 2019-10-18 14:14 ` Steven Rostedt
2019-10-18 14:41 ` Zanussi, Tom
1 sibling, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2019-10-18 14:14 UTC (permalink / raw)
To: Zhengjun Xing; +Cc: mingo, tom.zanussi, linux-kernel
On Fri, 18 Oct 2019 09:20:34 +0800
Zhengjun Xing <zhengjun.xing@linux.intel.com> wrote:
> In the format of synthetic events, the "gfp_t" is shown as "signed:1",
> but in fact the "gfp_t" is "unsigned", should be shown as "signed:0".
>
> The issue can be reproduced by the following commands:
>
> echo 'memlatency u64 lat; unsigned int order; gfp_t gfp_flags; int migratetype' > /sys/kernel/debug/tracing/synthetic_events
> cat /sys/kernel/debug/tracing/events/synthetic/memlatency/format
>
> name: memlatency
> ID: 2233
> format:
> field:unsigned short common_type; offset:0; size:2; signed:0;
> field:unsigned char common_flags; offset:2; size:1; signed:0;
> field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
> field:int common_pid; offset:4; size:4; signed:1;
>
> field:u64 lat; offset:8; size:8; signed:0;
> field:unsigned int order; offset:16; size:4; signed:0;
> field:gfp_t gfp_flags; offset:24; size:4; signed:1;
> field:int migratetype; offset:32; size:4; signed:1;
>
> print fmt: "lat=%llu, order=%u, gfp_flags=%x, migratetype=%d", REC->lat, REC->order, REC->gfp_flags, REC->migratetype
>
Tom,
Can you give a Reviewed-by for this?
-- Steve
> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> ---
> kernel/trace/trace_events_hist.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 57648c5aa679..7482a1466ebf 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -679,6 +679,8 @@ static bool synth_field_signed(char *type)
> {
> if (str_has_prefix(type, "u"))
> return false;
> + if (strcmp(type, "gfp_t") == 0)
> + return false;
>
> return true;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tracing: fix "gfp_t" format for synthetic events
2019-10-18 1:20 [PATCH v2] tracing: fix "gfp_t" format for synthetic events Zhengjun Xing
2019-10-18 14:14 ` Steven Rostedt
@ 2019-10-18 14:41 ` Zanussi, Tom
2019-10-18 14:54 ` Steven Rostedt
1 sibling, 1 reply; 4+ messages in thread
From: Zanussi, Tom @ 2019-10-18 14:41 UTC (permalink / raw)
To: Zhengjun Xing, rostedt, mingo; +Cc: linux-kernel
On 10/17/2019 8:20 PM, Zhengjun Xing wrote:
> In the format of synthetic events, the "gfp_t" is shown as "signed:1",
> but in fact the "gfp_t" is "unsigned", should be shown as "signed:0".
>
> The issue can be reproduced by the following commands:
>
> echo 'memlatency u64 lat; unsigned int order; gfp_t gfp_flags; int migratetype' > /sys/kernel/debug/tracing/synthetic_events
> cat /sys/kernel/debug/tracing/events/synthetic/memlatency/format
>
> name: memlatency
> ID: 2233
> format:
> field:unsigned short common_type; offset:0; size:2; signed:0;
> field:unsigned char common_flags; offset:2; size:1; signed:0;
> field:unsigned char common_preempt_count; offset:3; size:1; signed:0;
> field:int common_pid; offset:4; size:4; signed:1;
>
> field:u64 lat; offset:8; size:8; signed:0;
> field:unsigned int order; offset:16; size:4; signed:0;
> field:gfp_t gfp_flags; offset:24; size:4; signed:1;
> field:int migratetype; offset:32; size:4; signed:1;
>
> print fmt: "lat=%llu, order=%u, gfp_flags=%x, migratetype=%d", REC->lat, REC->order, REC->gfp_flags, REC->migratetype
>
> Signed-off-by: Zhengjun Xing <zhengjun.xing@linux.intel.com>
> ---
> kernel/trace/trace_events_hist.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 57648c5aa679..7482a1466ebf 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -679,6 +679,8 @@ static bool synth_field_signed(char *type)
> {
> if (str_has_prefix(type, "u"))
> return false;
> + if (strcmp(type, "gfp_t") == 0)
> + return false;
>
> return true;
> }
>
Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] tracing: fix "gfp_t" format for synthetic events
2019-10-18 14:41 ` Zanussi, Tom
@ 2019-10-18 14:54 ` Steven Rostedt
0 siblings, 0 replies; 4+ messages in thread
From: Steven Rostedt @ 2019-10-18 14:54 UTC (permalink / raw)
To: Zanussi, Tom; +Cc: Zhengjun Xing, mingo, linux-kernel
On Fri, 18 Oct 2019 09:41:05 -0500
"Zanussi, Tom" <tom.zanussi@linux.intel.com> wrote:
> Reviewed-by: Tom Zanussi <tom.zanussi@linux.intel.com>
Thanks Zhengjun and Tom!
I'll apply this to my urgent branch and get it upstream (even though
it's a minor fix).
-- Steve
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-18 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 1:20 [PATCH v2] tracing: fix "gfp_t" format for synthetic events Zhengjun Xing
2019-10-18 14:14 ` Steven Rostedt
2019-10-18 14:41 ` Zanussi, Tom
2019-10-18 14:54 ` Steven Rostedt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.