* [PATCH] drm/i915/perf: fix oa config reconfiguration
@ 2019-10-19 21:46 Lionel Landwerlin
2019-10-19 22:28 ` ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lionel Landwerlin @ 2019-10-19 21:46 UTC (permalink / raw)
To: intel-gfx
The current logic just reapplies the same configuration already stored
into stream->oa_config instead of the newly selected one.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Fixes: 7831e9a965ea ("drm/i915/perf: Allow dynamic reconfiguration of the OA stream")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
drivers/gpu/drm/i915/i915_perf.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 54ec1c4190ac..d2ac51fe4f04 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -1863,13 +1863,14 @@ get_oa_vma(struct i915_perf_stream *stream, struct i915_oa_config *oa_config)
}
static int emit_oa_config(struct i915_perf_stream *stream,
+ struct i915_oa_config *oa_config,
struct intel_context *ce)
{
struct i915_request *rq;
struct i915_vma *vma;
int err;
- vma = get_oa_vma(stream, stream->oa_config);
+ vma = get_oa_vma(stream, oa_config);
if (IS_ERR(vma))
return PTR_ERR(vma);
@@ -1927,7 +1928,7 @@ static int hsw_enable_metric_set(struct i915_perf_stream *stream)
intel_uncore_rmw(uncore, GEN6_UCGCTL1,
0, GEN6_CSUNIT_CLOCK_GATE_DISABLE);
- return emit_oa_config(stream, oa_context(stream));
+ return emit_oa_config(stream, stream->oa_config, oa_context(stream));
}
static void hsw_disable_metric_set(struct i915_perf_stream *stream)
@@ -2250,7 +2251,7 @@ static int gen8_configure_all_contexts(struct i915_perf_stream *stream,
static int gen8_enable_metric_set(struct i915_perf_stream *stream)
{
struct intel_uncore *uncore = stream->uncore;
- const struct i915_oa_config *oa_config = stream->oa_config;
+ struct i915_oa_config *oa_config = stream->oa_config;
int ret;
/*
@@ -2291,7 +2292,7 @@ static int gen8_enable_metric_set(struct i915_perf_stream *stream)
if (ret)
return ret;
- return emit_oa_config(stream, oa_context(stream));
+ return emit_oa_config(stream, oa_config, oa_context(stream));
}
static void gen8_disable_metric_set(struct i915_perf_stream *stream)
@@ -2895,7 +2896,7 @@ static long i915_perf_config_locked(struct i915_perf_stream *stream,
* When set globally, we use a low priority kernel context,
* so it will effectively take effect when idle.
*/
- err = emit_oa_config(stream, oa_context(stream));
+ err = emit_oa_config(stream, config, oa_context(stream));
if (err == 0)
config = xchg(&stream->oa_config, config);
else
--
2.24.0.rc0.303.g954a862665
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/perf: fix oa config reconfiguration
2019-10-19 21:46 [PATCH] drm/i915/perf: fix oa config reconfiguration Lionel Landwerlin
@ 2019-10-19 22:28 ` Patchwork
2019-10-20 0:08 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-20 9:00 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-10-19 22:28 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: fix oa config reconfiguration
URL : https://patchwork.freedesktop.org/series/68261/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7134 -> Patchwork_14893
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/index.html
Known issues
------------
Here are the changes found in Patchwork_14893 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_execlists:
- fi-kbl-7500u: [PASS][1] -> [INCOMPLETE][2] ([fdo#112065])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-kbl-7500u/igt@i915_selftest@live_execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-kbl-7500u/igt@i915_selftest@live_execlists.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-icl-u2: [PASS][3] -> [FAIL][4] ([fdo#109483])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-icl-u2/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@prime_vgem@basic-wait-default:
- fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
#### Possible fixes ####
* igt@gem_mmap_gtt@basic-read-write-distinct:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-icl-u3/igt@gem_mmap_gtt@basic-read-write-distinct.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-icl-u3/igt@gem_mmap_gtt@basic-read-write-distinct.html
* igt@i915_selftest@live_execlists:
- fi-whl-u: [INCOMPLETE][9] ([fdo#112065] / [fdo#112066]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-whl-u/igt@i915_selftest@live_execlists.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-whl-u/igt@i915_selftest@live_execlists.html
- fi-bxt-dsi: [INCOMPLETE][11] ([fdo#103927] / [fdo#112065]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-bxt-dsi/igt@i915_selftest@live_execlists.html
- fi-skl-6260u: [INCOMPLETE][13] ([fdo#111934]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-skl-6260u/igt@i915_selftest@live_execlists.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-skl-6260u/igt@i915_selftest@live_execlists.html
- fi-skl-lmem: [INCOMPLETE][15] ([fdo#111934]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-skl-lmem/igt@i915_selftest@live_execlists.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-skl-lmem/igt@i915_selftest@live_execlists.html
- fi-cfl-8109u: [INCOMPLETE][17] -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-cfl-8109u/igt@i915_selftest@live_execlists.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-cfl-8109u/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_hangcheck:
- {fi-icl-u4}: [INCOMPLETE][19] ([fdo#107713] / [fdo#108569]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/fi-icl-u4/igt@i915_selftest@live_hangcheck.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/fi-icl-u4/igt@i915_selftest@live_hangcheck.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111934]: https://bugs.freedesktop.org/show_bug.cgi?id=111934
[fdo#112065]: https://bugs.freedesktop.org/show_bug.cgi?id=112065
[fdo#112066]: https://bugs.freedesktop.org/show_bug.cgi?id=112066
Participating hosts (51 -> 44)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7134 -> Patchwork_14893
CI-20190529: 20190529
CI_DRM_7134: 0754519bf1b610be8b7b5fd96dd2223bf23e462a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5234: 1205552397bd8a19dc6e5abdaa727cc091dabbfe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14893: fba87fbfee85a2e5b4cb78cbd7b630abc675cf5a @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
fba87fbfee85 drm/i915/perf: fix oa config reconfiguration
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/perf: fix oa config reconfiguration
2019-10-19 21:46 [PATCH] drm/i915/perf: fix oa config reconfiguration Lionel Landwerlin
2019-10-19 22:28 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-10-20 0:08 ` Patchwork
2019-10-20 9:00 ` [PATCH] " Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2019-10-20 0:08 UTC (permalink / raw)
To: Lionel Landwerlin; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: fix oa config reconfiguration
URL : https://patchwork.freedesktop.org/series/68261/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7134_full -> Patchwork_14893_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14893_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_whisper@normal:
- {shard-tglb}: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-tglb1/igt@gem_exec_whisper@normal.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-tglb6/igt@gem_exec_whisper@normal.html
Known issues
------------
Here are the changes found in Patchwork_14893_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#108566]) +6 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-apl4/igt@gem_ctx_isolation@rcs0-s3.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-apl3/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_switch@legacy-bsd1-heavy-queue:
- shard-apl: [PASS][5] -> [INCOMPLETE][6] ([fdo#103927]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-apl7/igt@gem_ctx_switch@legacy-bsd1-heavy-queue.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-apl2/igt@gem_ctx_switch@legacy-bsd1-heavy-queue.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-snb: [PASS][7] -> [FAIL][8] ([fdo#111925])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-snb2/igt@gem_eio@in-flight-contexts-1us.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-snb6/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][9] -> [SKIP][10] ([fdo#111325]) +5 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb5/igt@gem_exec_async@concurrent-writes-bsd.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb2/igt@gem_exec_async@concurrent-writes-bsd.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [PASS][11] -> [SKIP][12] ([fdo#109276]) +18 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb7/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [PASS][13] -> [DMESG-WARN][14] ([fdo#111870]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [PASS][15] -> [DMESG-WARN][16] ([fdo#105763] / [fdo#106538])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-glk2/igt@i915_pm_rpm@modeset-stress-extra-wait.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
* igt@i915_pm_rpm@system-suspend:
- shard-kbl: [PASS][17] -> [INCOMPLETE][18] ([fdo#103665] / [fdo#107807])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-kbl1/igt@i915_pm_rpm@system-suspend.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-kbl4/igt@i915_pm_rpm@system-suspend.html
* igt@kms_big_fb@x-tiled-32bpp-rotate-180:
- shard-snb: [PASS][19] -> [SKIP][20] ([fdo#109271])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-snb4/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-snb2/igt@kms_big_fb@x-tiled-32bpp-rotate-180.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [PASS][21] -> [DMESG-WARN][22] ([fdo#106107]) +1 similar issue
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl7/igt@kms_color@pipe-a-ctm-0-5.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl3/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-skl: [PASS][23] -> [INCOMPLETE][24] ([fdo#110741])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#103232])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl5/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-256x256-offscreen.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [PASS][27] -> [INCOMPLETE][28] ([fdo#109507])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl10/igt@kms_flip@flip-vs-suspend.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl4/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite:
- shard-iclb: [PASS][29] -> [FAIL][30] ([fdo#103167]) +6 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb8/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_plane@plane-panning-top-left-pipe-a-planes:
- shard-skl: [PASS][31] -> [FAIL][32] ([fdo#103166])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl4/igt@kms_plane@plane-panning-top-left-pipe-a-planes.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl5/igt@kms_plane@plane-panning-top-left-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][33] -> [FAIL][34] ([fdo#108145])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl5/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][35] -> [FAIL][36] ([fdo#108145] / [fdo#110403])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl4/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][37] -> [SKIP][38] ([fdo#109441]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb4/igt@kms_psr@psr2_no_drrs.html
#### Possible fixes ####
* igt@gem_ctx_shared@q-smoketest-all:
- {shard-tglb}: [INCOMPLETE][39] ([fdo#111735]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-tglb3/igt@gem_ctx_shared@q-smoketest-all.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-tglb7/igt@gem_ctx_shared@q-smoketest-all.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][41] ([fdo#111325]) -> [PASS][42] +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive:
- shard-apl: [TIMEOUT][43] -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-apl6/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-apl2/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrash-inactive.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][45] ([fdo#112037]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [DMESG-WARN][47] ([fdo#111870]) -> [PASS][48] +1 similar issue
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [DMESG-WARN][49] ([fdo#111870]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-hsw1/igt@gem_userptr_blits@sync-unmap-cycles.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-hsw4/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_rpm@system-suspend:
- {shard-tglb}: [INCOMPLETE][51] ([fdo#111747] / [fdo#111850]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-tglb8/igt@i915_pm_rpm@system-suspend.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-tglb1/igt@i915_pm_rpm@system-suspend.html
* igt@i915_selftest@live_execlists:
- shard-skl: [INCOMPLETE][53] ([fdo#111934]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl8/igt@i915_selftest@live_execlists.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl5/igt@i915_selftest@live_execlists.html
- shard-apl: [INCOMPLETE][55] ([fdo#103927] / [fdo#112065]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-apl7/igt@i915_selftest@live_execlists.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-apl7/igt@i915_selftest@live_execlists.html
- shard-glk: [INCOMPLETE][57] ([fdo#103359] / [k.org#198133]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-glk3/igt@i915_selftest@live_execlists.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-glk4/igt@i915_selftest@live_execlists.html
* igt@i915_selftest@live_hangcheck:
- {shard-tglb}: [INCOMPLETE][59] ([fdo#111747]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-tglb7/igt@i915_selftest@live_hangcheck.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-tglb3/igt@i915_selftest@live_hangcheck.html
* igt@i915_suspend@sysfs-reader:
- shard-skl: [INCOMPLETE][61] ([fdo#104108]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl9/igt@i915_suspend@sysfs-reader.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl7/igt@i915_suspend@sysfs-reader.html
- shard-apl: [DMESG-WARN][63] ([fdo#108566]) -> [PASS][64] +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-apl1/igt@i915_suspend@sysfs-reader.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-apl8/igt@i915_suspend@sysfs-reader.html
* igt@kms_color@pipe-b-ctm-0-25:
- shard-skl: [DMESG-WARN][65] ([fdo#106107]) -> [PASS][66] +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl3/igt@kms_color@pipe-b-ctm-0-25.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl1/igt@kms_color@pipe-b-ctm-0-25.html
* igt@kms_flip_tiling@flip-y-tiled:
- shard-skl: [FAIL][67] ([fdo#108303]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl10/igt@kms_flip_tiling@flip-y-tiled.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl10/igt@kms_flip_tiling@flip-y-tiled.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][69] ([fdo#103167]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- {shard-tglb}: [FAIL][71] ([fdo#103167]) -> [PASS][72] +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [FAIL][73] ([fdo#103166]) -> [PASS][74] +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-x.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb2/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][75] ([fdo#109441]) -> [PASS][76] +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][77] ([fdo#109276]) -> [PASS][78] +15 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb8/igt@prime_busy@hang-bsd2.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb1/igt@prime_busy@hang-bsd2.html
* igt@prime_busy@hang-render:
- shard-hsw: [INCOMPLETE][79] ([fdo#103540]) -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-hsw1/igt@prime_busy@hang-render.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-hsw6/igt@prime_busy@hang-render.html
* igt@prime_vgem@sync-bsd:
- shard-skl: [INCOMPLETE][81] -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-skl3/igt@prime_vgem@sync-bsd.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-skl5/igt@prime_vgem@sync-bsd.html
#### Warnings ####
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [FAIL][83] ([fdo#111330]) -> [SKIP][84] ([fdo#109276]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb4/igt@gem_mocs_settings@mocs-settings-bsd2.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb6/igt@gem_mocs_settings@mocs-settings-bsd2.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][85] ([fdo#109349]) -> [DMESG-WARN][86] ([fdo#107724])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7134/shard-iclb6/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108303]: https://bugs.freedesktop.org/show_bug.cgi?id=108303
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109507]: https://bugs.freedesktop.org/show_bug.cgi?id=109507
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110548]: https://bugs.freedesktop.org/show_bug.cgi?id=110548
[fdo#110741]: https://bugs.freedesktop.org/show_bug.cgi?id=110741
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
[fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
[fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111886]: https://bugs.freedesktop.org/show_bug.cgi?id=111886
[fdo#111925]: https://bugs.freedesktop.org/show_bug.cgi?id=111925
[fdo#111934]: https://bugs.freedesktop.org/show_bug.cgi?id=111934
[fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
[fdo#112065]: https://bugs.freedesktop.org/show_bug.cgi?id=112065
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7134 -> Patchwork_14893
CI-20190529: 20190529
CI_DRM_7134: 0754519bf1b610be8b7b5fd96dd2223bf23e462a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5234: 1205552397bd8a19dc6e5abdaa727cc091dabbfe @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14893: fba87fbfee85a2e5b4cb78cbd7b630abc675cf5a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14893/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/i915/perf: fix oa config reconfiguration
2019-10-19 21:46 [PATCH] drm/i915/perf: fix oa config reconfiguration Lionel Landwerlin
2019-10-19 22:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-20 0:08 ` ✓ Fi.CI.IGT: " Patchwork
@ 2019-10-20 9:00 ` Chris Wilson
2 siblings, 0 replies; 4+ messages in thread
From: Chris Wilson @ 2019-10-20 9:00 UTC (permalink / raw)
To: Lionel Landwerlin, intel-gfx
Quoting Lionel Landwerlin (2019-10-19 22:46:47)
> The current logic just reapplies the same configuration already stored
> into stream->oa_config instead of the newly selected one.
>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Fixes: 7831e9a965ea ("drm/i915/perf: Allow dynamic reconfiguration of the OA stream")
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> @@ -2895,7 +2896,7 @@ static long i915_perf_config_locked(struct i915_perf_stream *stream,
> * When set globally, we use a low priority kernel context,
> * so it will effectively take effect when idle.
> */
> - err = emit_oa_config(stream, oa_context(stream));
> + err = emit_oa_config(stream, config, oa_context(stream));
> if (err == 0)
> config = xchg(&stream->oa_config, config);
Oh crikey.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-20 9:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-19 21:46 [PATCH] drm/i915/perf: fix oa config reconfiguration Lionel Landwerlin
2019-10-19 22:28 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-20 0:08 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-20 9:00 ` [PATCH] " Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.