[PATCH] staging: sm750fb: Edit CamelCase in ddk750_power.h

[PATCH] staging: sm750fb: Edit CamelCase in ddk750_power.h

[Jamal Shareef]

Removes instances of CamelCase. Issue found by checkpatch.

Signed-off-by: Jamal Shareef <jamal.k.shareef@gmail.com>
---
 drivers/staging/sm750fb/ddk750_power.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
index 7002567a47d2..cd892f2b717f 100644
--- a/drivers/staging/sm750fb/ddk750_power.h
+++ b/drivers/staging/sm750fb/ddk750_power.h
@@ -3,10 +3,10 @@
 #define DDK750_POWER_H__
 
 enum dpms {
-	crtDPMS_ON = 0x0,
-	crtDPMS_STANDBY = 0x1,
-	crtDPMS_SUSPEND = 0x2,
-	crtDPMS_OFF = 0x3,
+	crt_DPMS_ON = 0x0,
+	crt_DPMS_STANDBY = 0x1,
+	crt_DPMS_SUSPEND = 0x2,
+	crt_DPMS_OFF = 0x3,
 };
 
 #define set_DAC(off) {							\
@@ -15,7 +15,7 @@ enum dpms {
 }
 
 void ddk750_set_dpms(enum dpms state);
-void sm750_set_power_mode(unsigned int powerMode);
+void sm750_set_power_mode(unsigned int power_mode);
 void sm750_set_current_gate(unsigned int gate);
 
 /*
-- 
2.17.1

Re: [Outreachy kernel] [PATCH] staging: sm750fb: Edit CamelCase in ddk750_power.h

[Julia Lawall]

You don't need to put the name of the file in the subject line.  One can
see that easily from the diffstat information.

On Thu, 17 Oct 2019, Jamal Shareef wrote:

> Removes instances of CamelCase. Issue found by checkpatch.
>
> Signed-off-by: Jamal Shareef <jamal.k.shareef@gmail.com>
> ---
>  drivers/staging/sm750fb/ddk750_power.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
> index 7002567a47d2..cd892f2b717f 100644
> --- a/drivers/staging/sm750fb/ddk750_power.h
> +++ b/drivers/staging/sm750fb/ddk750_power.h
> @@ -3,10 +3,10 @@
>  #define DDK750_POWER_H__
>
>  enum dpms {
> -	crtDPMS_ON = 0x0,
> -	crtDPMS_STANDBY = 0x1,
> -	crtDPMS_SUSPEND = 0x2,
> -	crtDPMS_OFF = 0x3,
> +	crt_DPMS_ON = 0x0,
> +	crt_DPMS_STANDBY = 0x1,
> +	crt_DPMS_SUSPEND = 0x2,
> +	crt_DPMS_OFF = 0x3,
>  };
>
>  #define set_DAC(off) {							\
> @@ -15,7 +15,7 @@ enum dpms {
>  }
>
>  void ddk750_set_dpms(enum dpms state);
> -void sm750_set_power_mode(unsigned int powerMode);
> +void sm750_set_power_mode(unsigned int power_mode);

This looks suspicious.  You shouldn't be updating only the prototype
without updating the definition as well.

julia

>  void sm750_set_current_gate(unsigned int gate);
>
>  /*
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191018020112.22226-1-jamal.k.shareef%40gmail.com.
>

Re: [Outreachy kernel] [PATCH] staging: sm750fb: Edit CamelCase in ddk750_power.h

[Jamal Shareef]

On Fri, Oct 18, 2019 at 08:30:01AM +0200, Julia Lawall wrote:
> You don't need to put the name of the file in the subject line.  One can
> see that easily from the diffstat information.
> 
> On Thu, 17 Oct 2019, Jamal Shareef wrote:
> 
> > Removes instances of CamelCase. Issue found by checkpatch.
> >
> > Signed-off-by: Jamal Shareef <jamal.k.shareef@gmail.com>
> > ---
> >  drivers/staging/sm750fb/ddk750_power.h | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/sm750fb/ddk750_power.h b/drivers/staging/sm750fb/ddk750_power.h
> > index 7002567a47d2..cd892f2b717f 100644
> > --- a/drivers/staging/sm750fb/ddk750_power.h
> > +++ b/drivers/staging/sm750fb/ddk750_power.h
> > @@ -3,10 +3,10 @@
> >  #define DDK750_POWER_H__
> >
> >  enum dpms {
> > -	crtDPMS_ON = 0x0,
> > -	crtDPMS_STANDBY = 0x1,
> > -	crtDPMS_SUSPEND = 0x2,
> > -	crtDPMS_OFF = 0x3,
> > +	crt_DPMS_ON = 0x0,
> > +	crt_DPMS_STANDBY = 0x1,
> > +	crt_DPMS_SUSPEND = 0x2,
> > +	crt_DPMS_OFF = 0x3,
> >  };
> >
> >  #define set_DAC(off) {							\
> > @@ -15,7 +15,7 @@ enum dpms {
> >  }
> >
> >  void ddk750_set_dpms(enum dpms state);
> > -void sm750_set_power_mode(unsigned int powerMode);
> > +void sm750_set_power_mode(unsigned int power_mode);
> 
> This looks suspicious.  You shouldn't be updating only the prototype
> without updating the definition as well.
> 
> julia
> 

A grep for these function names doesn't return any other hits. It does
look suspicious however. This enum is used by other function but not by
use of the enum labels themselves initially.

Jamal
> >  void sm750_set_current_gate(unsigned int gate);
> >
> >  /*
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191018020112.22226-1-jamal.k.shareef%40gmail.com.
> >