* [power-supply:for-next 18/29] drivers/power/supply/cpcap-charger.c:481:5: sparse: sparse: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
@ 2019-10-20 22:20 ` kbuild test robot
0 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2019-10-20 22:20 UTC (permalink / raw)
To: Tony Lindgren; +Cc: kbuild-all, Sebastian Reichel, linux-pm, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
head: 722f20d707b77bc7e3d241a3600b46b995474087
commit: d4ee021c410f72bf2aacc61069ad6305120d2127 [18/29] power: supply: cpcap-charger: Limit voltage to 4.2V for battery
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-dirty
git checkout d4ee021c410f72bf2aacc61069ad6305120d2127
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/power/supply/cpcap-charger.c:481:5: sparse: sparse: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread* [power-supply:for-next 18/29] drivers/power/supply/cpcap-charger.c:481:5: sparse: sparse: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
@ 2019-10-20 22:20 ` kbuild test robot
0 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2019-10-20 22:20 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1025 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
head: 722f20d707b77bc7e3d241a3600b46b995474087
commit: d4ee021c410f72bf2aacc61069ad6305120d2127 [18/29] power: supply: cpcap-charger: Limit voltage to 4.2V for battery
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-dirty
git checkout d4ee021c410f72bf2aacc61069ad6305120d2127
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> drivers/power/supply/cpcap-charger.c:481:5: sparse: sparse: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 6+ messages in thread* [RFC PATCH power-supply] power: supply: cpcap-charger: cpcap_charger_voltage_to_regval() can be static
2019-10-20 22:20 ` kbuild test robot
@ 2019-10-20 22:20 ` kbuild test robot
-1 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2019-10-20 22:20 UTC (permalink / raw)
To: Tony Lindgren; +Cc: kbuild-all, Sebastian Reichel, linux-pm, linux-kernel
Fixes: d4ee021c410f ("power: supply: cpcap-charger: Limit voltage to 4.2V for battery")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
cpcap-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
index 88bbab6e62f07..b4b7f9dc6c4ea 100644
--- a/drivers/power/supply/cpcap-charger.c
+++ b/drivers/power/supply/cpcap-charger.c
@@ -478,7 +478,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
dev_dbg(ddata->dev, "state: %s\n", status);
}
-int cpcap_charger_voltage_to_regval(int voltage)
+static int cpcap_charger_voltage_to_regval(int voltage)
{
int offset;
^ permalink raw reply related [flat|nested] 6+ messages in thread* [RFC PATCH power-supply] power: supply: cpcap-charger: cpcap_charger_voltage_to_regval() can be static
@ 2019-10-20 22:20 ` kbuild test robot
0 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2019-10-20 22:20 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 723 bytes --]
Fixes: d4ee021c410f ("power: supply: cpcap-charger: Limit voltage to 4.2V for battery")
Signed-off-by: kbuild test robot <lkp@intel.com>
---
cpcap-charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
index 88bbab6e62f07..b4b7f9dc6c4ea 100644
--- a/drivers/power/supply/cpcap-charger.c
+++ b/drivers/power/supply/cpcap-charger.c
@@ -478,7 +478,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
dev_dbg(ddata->dev, "state: %s\n", status);
}
-int cpcap_charger_voltage_to_regval(int voltage)
+static int cpcap_charger_voltage_to_regval(int voltage)
{
int offset;
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [RFC PATCH power-supply] power: supply: cpcap-charger: cpcap_charger_voltage_to_regval() can be static
2019-10-20 22:20 ` kbuild test robot
@ 2019-10-21 9:05 ` Sebastian Reichel
-1 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2019-10-21 9:05 UTC (permalink / raw)
To: kbuild test robot; +Cc: Tony Lindgren, kbuild-all, linux-pm, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
Hi,
On Mon, Oct 21, 2019 at 06:20:52AM +0800, kbuild test robot wrote:
> Fixes: d4ee021c410f ("power: supply: cpcap-charger: Limit voltage to 4.2V for battery")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
Thanks, I added a long description and queued it to power-supply's
-next branch. I did not fold it into the original patch, which is in
an immutable branch.
-- Sebastian
> cpcap-charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
> index 88bbab6e62f07..b4b7f9dc6c4ea 100644
> --- a/drivers/power/supply/cpcap-charger.c
> +++ b/drivers/power/supply/cpcap-charger.c
> @@ -478,7 +478,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
> dev_dbg(ddata->dev, "state: %s\n", status);
> }
>
> -int cpcap_charger_voltage_to_regval(int voltage)
> +static int cpcap_charger_voltage_to_regval(int voltage)
> {
> int offset;
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [RFC PATCH power-supply] power: supply: cpcap-charger: cpcap_charger_voltage_to_regval() can be static
@ 2019-10-21 9:05 ` Sebastian Reichel
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2019-10-21 9:05 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 1016 bytes --]
Hi,
On Mon, Oct 21, 2019 at 06:20:52AM +0800, kbuild test robot wrote:
> Fixes: d4ee021c410f ("power: supply: cpcap-charger: Limit voltage to 4.2V for battery")
> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
Thanks, I added a long description and queued it to power-supply's
-next branch. I did not fold it into the original patch, which is in
an immutable branch.
-- Sebastian
> cpcap-charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/cpcap-charger.c b/drivers/power/supply/cpcap-charger.c
> index 88bbab6e62f07..b4b7f9dc6c4ea 100644
> --- a/drivers/power/supply/cpcap-charger.c
> +++ b/drivers/power/supply/cpcap-charger.c
> @@ -478,7 +478,7 @@ static void cpcap_charger_update_state(struct cpcap_charger_ddata *ddata,
> dev_dbg(ddata->dev, "state: %s\n", status);
> }
>
> -int cpcap_charger_voltage_to_regval(int voltage)
> +static int cpcap_charger_voltage_to_regval(int voltage)
> {
> int offset;
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-21 9:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-20 22:20 [power-supply:for-next 18/29] drivers/power/supply/cpcap-charger.c:481:5: sparse: sparse: symbol 'cpcap_charger_voltage_to_regval' was not declared. Should it be static? kbuild test robot
2019-10-20 22:20 ` kbuild test robot
2019-10-20 22:20 ` [RFC PATCH power-supply] power: supply: cpcap-charger: cpcap_charger_voltage_to_regval() can be static kbuild test robot
2019-10-20 22:20 ` kbuild test robot
2019-10-21 9:05 ` Sebastian Reichel
2019-10-21 9:05 ` Sebastian Reichel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.