All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] include/linux/byteorder/generic.h: fix signed/unsigned warnings
@ 2019-10-20 17:22 Anatol Belski
  2019-10-21  6:52 ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Anatol Belski @ 2019-10-20 17:22 UTC (permalink / raw)
  To: linux-kernel, Mika Westerberg, Michael Jamet, Andy Shevchenko,
	Yehezkel Bernat, David S . Miller
  Cc: trivial

From: Anatol Belski <anbelski@microsoft.com>

Signed-off-by: Anatol Belski <anbelski@microsoft.com>
---
 include/linux/byteorder/generic.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/byteorder/generic.h b/include/linux/byteorder/generic.h
index 4b13e0a3e15b..c9a4c96c9943 100644
--- a/include/linux/byteorder/generic.h
+++ b/include/linux/byteorder/generic.h
@@ -190,7 +190,7 @@ static inline void be64_add_cpu(__be64 *var, u64 val)
 
 static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
 {
-	int i;
+	size_t i;
 
 	for (i = 0; i < len; i++)
 		dst[i] = cpu_to_be32(src[i]);
@@ -198,7 +198,7 @@ static inline void cpu_to_be32_array(__be32 *dst, const u32 *src, size_t len)
 
 static inline void be32_to_cpu_array(u32 *dst, const __be32 *src, size_t len)
 {
-	int i;
+	size_t i;
 
 	for (i = 0; i < len; i++)
 		dst[i] = be32_to_cpu(src[i]);
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] include/linux/byteorder/generic.h: fix signed/unsigned warnings
  2019-10-20 17:22 [PATCH] include/linux/byteorder/generic.h: fix signed/unsigned warnings Anatol Belski
@ 2019-10-21  6:52 ` Andy Shevchenko
  2019-10-21  8:43   ` Anatol Belski
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2019-10-21  6:52 UTC (permalink / raw)
  To: Anatol Belski
  Cc: linux-kernel, Mika Westerberg, Michael Jamet, Yehezkel Bernat,
	David S . Miller, trivial

On Sun, Oct 20, 2019 at 05:22:30PM +0000, Anatol Belski wrote:
> From: Anatol Belski <anbelski@microsoft.com>

Better to add commit message even for small patches like this.
Do you have compiler / sparse / etc warning? Cite it here as well!

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] include/linux/byteorder/generic.h: fix signed/unsigned warnings
  2019-10-21  6:52 ` Andy Shevchenko
@ 2019-10-21  8:43   ` Anatol Belski
  0 siblings, 0 replies; 3+ messages in thread
From: Anatol Belski @ 2019-10-21  8:43 UTC (permalink / raw)
  To: Andy Shevchenko
  Cc: linux-kernel, Mika Westerberg, Michael Jamet, Yehezkel Bernat,
	David S . Miller, trivial

Hi,

On Mon, 2019-10-21 at 09:52 +0300, Andy Shevchenko wrote:
> On Sun, Oct 20, 2019 at 05:22:30PM +0000, Anatol Belski wrote:
> > From: Anatol Belski <anbelski@microsoft.com>
> 
> Better to add commit message even for small patches like this.
> Do you have compiler / sparse / etc warning? Cite it here as well!
> 

yes, it's -Wsign-compare. I'll send a follow up with a better commit
message.

Thanks

Anatol


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-21  8:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-20 17:22 [PATCH] include/linux/byteorder/generic.h: fix signed/unsigned warnings Anatol Belski
2019-10-21  6:52 ` Andy Shevchenko
2019-10-21  8:43   ` Anatol Belski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.