From: Marco Felsch <m.felsch@pengutronix.de> To: Peng Fan <peng.fan@nxp.com> Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Andy Duan <fugang.duan@nxp.com>, Jacky Bai <ping.bai@nxp.com>, Anson Huang <anson.huang@nxp.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, dl-linux-imx <linux-imx@nxp.com>, Leonard Crestez <leonard.crestez@nxp.com>, Daniel Baluta <daniel.baluta@nxp.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Jun Li <jun.li@nxp.com> Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Date: Mon, 21 Oct 2019 11:50:13 +0200 [thread overview] Message-ID: <20191021095013.3lm2slv6glqx5nnh@pengutronix.de> (raw) In-Reply-To: <AM0PR04MB448170DA0486707775C3DABA88690@AM0PR04MB4481.eurprd04.prod.outlook.com> On 19-10-21 09:46, Peng Fan wrote: > > Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for > > fec1 > > > > Hi, > > > > On 19-10-21 09:21, Peng Fan wrote: > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > We should not rely on U-Boot to configure the phy reset. nitpick: s/U-Boot/bootloader/ ? > > > So introduce phy-reset-gpios property to let Linux handle phy reset > > > itself. > > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > > index faefb7182af1..e4d66f7db09d 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > > @@ -80,6 +80,7 @@ > > > pinctrl-0 = <&pinctrl_fec1>; > > > phy-mode = "rgmii-id"; > > > phy-handle = <ðphy0>; > > > + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; > > > > Where is the pinctrl done? > > https://elixir.bootlin.com/linux/v5.4-rc2/source/arch/arm64/boot/dts/freescale/imx8mm-evk.dts#L328 Thanks :) Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> Regards, Marco > Regards, > Peng. > > > > > Regards, > > Marco > > > > > fsl,magic-packet; > > > status = "okay"; > > > > > > -- > > > 2.16.4 > > > > > > > > > > > > > -- > > Pengutronix e.K. | > > | > > Industrial Linux Solutions | > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p > > engutronix.de%2F&data=02%7C01%7Cpeng.fan%40nxp.com%7Cb40bb6 > > 4c5e39449ade4808d7560b43ca%7C686ea1d3bc2b4c6fa92cd99c5c301635% > > 7C0%7C0%7C637072478688921047&sdata=xZI60uyyQ%2BkX%2Fpf07n > > CgVhGt1ApYBKSnndGB3Dk2578%3D&reserved=0 | > > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > > | > > Amtsgericht Hildesheim, HRA 2686 | Fax: > > +49-5121-206917-5555 | > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Marco Felsch <m.felsch@pengutronix.de> To: Peng Fan <peng.fan@nxp.com> Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, Andy Duan <fugang.duan@nxp.com>, Jacky Bai <ping.bai@nxp.com>, Anson Huang <anson.huang@nxp.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Daniel Baluta <daniel.baluta@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Leonard Crestez <leonard.crestez@nxp.com>, "festevam@gmail.com" <festevam@gmail.com>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Jun Li <jun.li@nxp.com> Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Date: Mon, 21 Oct 2019 11:50:13 +0200 [thread overview] Message-ID: <20191021095013.3lm2slv6glqx5nnh@pengutronix.de> (raw) In-Reply-To: <AM0PR04MB448170DA0486707775C3DABA88690@AM0PR04MB4481.eurprd04.prod.outlook.com> On 19-10-21 09:46, Peng Fan wrote: > > Subject: Re: [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for > > fec1 > > > > Hi, > > > > On 19-10-21 09:21, Peng Fan wrote: > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > We should not rely on U-Boot to configure the phy reset. nitpick: s/U-Boot/bootloader/ ? > > > So introduce phy-reset-gpios property to let Linux handle phy reset > > > itself. > > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > > b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > > index faefb7182af1..e4d66f7db09d 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts > > > @@ -80,6 +80,7 @@ > > > pinctrl-0 = <&pinctrl_fec1>; > > > phy-mode = "rgmii-id"; > > > phy-handle = <ðphy0>; > > > + phy-reset-gpios = <&gpio4 22 GPIO_ACTIVE_LOW>; > > > > Where is the pinctrl done? > > https://elixir.bootlin.com/linux/v5.4-rc2/source/arch/arm64/boot/dts/freescale/imx8mm-evk.dts#L328 Thanks :) Reviewed-by: Marco Felsch <m.felsch@pengutronix.de> Regards, Marco > Regards, > Peng. > > > > > Regards, > > Marco > > > > > fsl,magic-packet; > > > status = "okay"; > > > > > > -- > > > 2.16.4 > > > > > > > > > > > > > -- > > Pengutronix e.K. | > > | > > Industrial Linux Solutions | > > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.p > > engutronix.de%2F&data=02%7C01%7Cpeng.fan%40nxp.com%7Cb40bb6 > > 4c5e39449ade4808d7560b43ca%7C686ea1d3bc2b4c6fa92cd99c5c301635% > > 7C0%7C0%7C637072478688921047&sdata=xZI60uyyQ%2BkX%2Fpf07n > > CgVhGt1ApYBKSnndGB3Dk2578%3D&reserved=0 | > > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 > > | > > Amtsgericht Hildesheim, HRA 2686 | Fax: > > +49-5121-206917-5555 | > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-21 9:50 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-21 9:21 [PATCH 1/2] arm64: dts: imx8mm-evk: add phy-reset-gpios for fec1 Peng Fan 2019-10-21 9:21 ` Peng Fan 2019-10-21 9:21 ` [PATCH 2/2] arm64: dts: imx8mn-ddr4-evk: " Peng Fan 2019-10-21 9:21 ` Peng Fan 2019-10-21 9:44 ` [PATCH 1/2] arm64: dts: imx8mm-evk: " Marco Felsch 2019-10-21 9:44 ` Marco Felsch 2019-10-21 9:46 ` Peng Fan 2019-10-21 9:46 ` Peng Fan 2019-10-21 9:50 ` Marco Felsch [this message] 2019-10-21 9:50 ` Marco Felsch 2020-02-14 19:27 Alifer Moraes 2020-02-17 8:20 ` Marco Felsch 2020-02-18 13:02 ` Alifer Moraes 2020-02-19 1:15 ` Fabio Estevam 2020-02-24 1:37 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191021095013.3lm2slv6glqx5nnh@pengutronix.de \ --to=m.felsch@pengutronix.de \ --cc=anson.huang@nxp.com \ --cc=daniel.baluta@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=fugang.duan@nxp.com \ --cc=jun.li@nxp.com \ --cc=kernel@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=peng.fan@nxp.com \ --cc=ping.bai@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.