From: Lee Jones <lee.jones@linaro.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: robh@kernel.org, broonie@kernel.org, linus.walleij@linaro.org, vinod.koul@linaro.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spapothi@codeaurora.org, bgoswami@codeaurora.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec Date: Mon, 21 Oct 2019 12:45:20 +0100 [thread overview] Message-ID: <20191021114520.GD4365@dell> (raw) In-Reply-To: <1af8a875-8f55-6b7e-4204-ecedc1608889@linaro.org> On Mon, 21 Oct 2019, Srinivas Kandagatla wrote: > Thanks Lee for taking time to review. > > I agree with most of the style related comments, will fix them in next > version. For others I have replied it inline. [...] > > > +static int wcd934x_bring_up(struct wcd934x_data *wcd) > > > +{ > > > + struct regmap *rm = wcd->regmap; > > > > It's much more common to use 'regmap' or 'map'. > > Only reason to make it short here is to save some lines! > If you prefer regmap, I will add that in next version! I doubt it'd save many (any?) lines. [...] > > > +static int wcd934x_slim_status(struct slim_device *sdev, > > > + enum slim_device_status status) > > > +{ > > > + struct device *dev = &sdev->dev; > > > + struct wcd934x_data *wcd; > > > + int ret; > > > > This is semantically odd! Why are you doing most of the > > initialisation and bring-up in 'status' and not 'probe'. Seems > > broken to me. > > SLIMBus device will not be in a state to communicate before enumeration (at > probe), so all the device initialization is done in status callback where it > is ready for communication. Why do we need the device to be up *before* calling probe? > This is same with SoundWire Bus as well! [...] > > > + struct device *dev; > > > + struct clk *extclk; > > > + struct regmap *regmap; > > > + struct slim_device *sdev; > > > > You don't need 'sdev' and 'dev'. > > slim_device instance (sdev) is required by audio codec driver to allocate > stream runtime. You can extrapolate one from the other. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: robh@kernel.org, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, vinod.koul@linaro.org, devicetree@vger.kernel.org, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, broonie@kernel.org, spapothi@codeaurora.org Subject: Re: [alsa-devel] [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec Date: Mon, 21 Oct 2019 12:45:20 +0100 [thread overview] Message-ID: <20191021114520.GD4365@dell> (raw) In-Reply-To: <1af8a875-8f55-6b7e-4204-ecedc1608889@linaro.org> On Mon, 21 Oct 2019, Srinivas Kandagatla wrote: > Thanks Lee for taking time to review. > > I agree with most of the style related comments, will fix them in next > version. For others I have replied it inline. [...] > > > +static int wcd934x_bring_up(struct wcd934x_data *wcd) > > > +{ > > > + struct regmap *rm = wcd->regmap; > > > > It's much more common to use 'regmap' or 'map'. > > Only reason to make it short here is to save some lines! > If you prefer regmap, I will add that in next version! I doubt it'd save many (any?) lines. [...] > > > +static int wcd934x_slim_status(struct slim_device *sdev, > > > + enum slim_device_status status) > > > +{ > > > + struct device *dev = &sdev->dev; > > > + struct wcd934x_data *wcd; > > > + int ret; > > > > This is semantically odd! Why are you doing most of the > > initialisation and bring-up in 'status' and not 'probe'. Seems > > broken to me. > > SLIMBus device will not be in a state to communicate before enumeration (at > probe), so all the device initialization is done in status callback where it > is ready for communication. Why do we need the device to be up *before* calling probe? > This is same with SoundWire Bus as well! [...] > > > + struct device *dev; > > > + struct clk *extclk; > > > + struct regmap *regmap; > > > + struct slim_device *sdev; > > > > You don't need 'sdev' and 'dev'. > > slim_device instance (sdev) is required by audio codec driver to allocate > stream runtime. You can extrapolate one from the other. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-21 11:45 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-18 0:18 [PATCH v2 00/11] ASoC: Add support to WCD9340/WCD9341 codec Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-18 0:18 ` [PATCH v2 01/11] ASoC: dt-bindings: add dt bindings for WCD9340/WCD9341 audio codec Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-25 20:43 ` Rob Herring 2019-10-25 20:43 ` [alsa-devel] " Rob Herring 2019-10-28 12:40 ` Srinivas Kandagatla 2019-10-28 12:40 ` [alsa-devel] " Srinivas Kandagatla 2019-10-28 12:45 ` Srinivas Kandagatla 2019-10-28 12:45 ` [alsa-devel] " Srinivas Kandagatla 2019-10-29 20:47 ` Rob Herring 2019-10-29 20:47 ` [alsa-devel] " Rob Herring 2019-10-30 9:55 ` Srinivas Kandagatla 2019-10-30 9:55 ` [alsa-devel] " Srinivas Kandagatla 2019-11-05 19:08 ` Rob Herring 2019-11-05 19:08 ` [alsa-devel] " Rob Herring 2019-11-06 18:09 ` Srinivas Kandagatla 2019-11-06 18:09 ` [alsa-devel] " Srinivas Kandagatla 2019-11-06 19:20 ` Rob Herring 2019-11-06 19:20 ` [alsa-devel] " Rob Herring 2019-10-18 0:18 ` [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-21 10:46 ` Lee Jones 2019-10-21 10:46 ` [alsa-devel] " Lee Jones 2019-10-21 11:25 ` Srinivas Kandagatla 2019-10-21 11:25 ` [alsa-devel] " Srinivas Kandagatla 2019-10-21 11:45 ` Lee Jones [this message] 2019-10-21 11:45 ` Lee Jones 2019-10-21 12:14 ` Srinivas Kandagatla 2019-10-21 12:14 ` [alsa-devel] " Srinivas Kandagatla 2019-10-21 13:19 ` Lee Jones 2019-10-21 13:19 ` [alsa-devel] " Lee Jones 2019-10-18 0:18 ` [PATCH v2 03/11] ASoC: " Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-18 0:18 ` [PATCH v2 04/11] ASoC: wcd934x: add basic controls Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-18 0:18 ` [PATCH v2 05/11] ASoC: wcd934x: add playback dapm widgets Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-20 20:05 ` Cezary Rojewski 2019-10-20 20:05 ` [alsa-devel] " Cezary Rojewski 2019-10-21 9:46 ` Srinivas Kandagatla 2019-10-21 9:46 ` [alsa-devel] " Srinivas Kandagatla 2019-10-18 0:18 ` [PATCH v2 06/11] ASoC: wcd934x: add capture " Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-18 0:18 ` [PATCH v2 07/11] ASoC: wcd934x: add audio routings Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-18 0:18 ` [PATCH v2 08/11] dt-bindings: pinctrl: qcom-wcd934x: Add bindings for gpio Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-25 21:00 ` Rob Herring 2019-10-25 21:00 ` [alsa-devel] " Rob Herring 2019-10-28 12:41 ` Srinivas Kandagatla 2019-10-28 12:41 ` [alsa-devel] " Srinivas Kandagatla 2019-10-18 0:18 ` [PATCH v2 09/11] pinctrl: qcom-wcd934x: Add support to wcd934x pinctrl driver Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-18 0:18 ` [PATCH v2 10/11] ASoC: dt-bindings: Add compatible for DB845c and Lenovo Yoga Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla 2019-10-25 21:01 ` Rob Herring 2019-10-25 21:01 ` [alsa-devel] " Rob Herring 2019-10-18 0:18 ` [PATCH v2 11/11] ASoC: qcom: sdm845: add support to " Srinivas Kandagatla 2019-10-18 0:18 ` [alsa-devel] " Srinivas Kandagatla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191021114520.GD4365@dell \ --to=lee.jones@linaro.org \ --cc=alsa-devel@alsa-project.org \ --cc=bgoswami@codeaurora.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh@kernel.org \ --cc=spapothi@codeaurora.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=vinod.koul@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.