[ebiggers:inline-encryption-wip 1/17] include/linux/keyslot-manager.h:34:11: warning: 'enum blk_crypto_mode_num' declared inside parameter list

[ebiggers:inline-encryption-wip 1/17] include/linux/keyslot-manager.h:34:11: warning: 'enum blk_crypto_mode_num' declared inside parameter list

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 4173 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git inline-encryption-wip
head:   4e2ed92b65a08d009d8e5e1593f3a310a2567500
commit: 4f87b463abc596e36f15feeb252d22df571cadb5 [1/17] block: Keyslot Manager for Inline Encryption
config: x86_64-randconfig-a003-201942 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.2-10+deb8u1) 4.9.2
reproduce:
        git checkout 4f87b463abc596e36f15feeb252d22df571cadb5
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from <command-line>:0:0:
>> include/linux/keyslot-manager.h:34:11: warning: 'enum blk_crypto_mode_num' declared inside parameter list
              unsigned int slot);
              ^
>> include/linux/keyslot-manager.h:34:11: warning: its scope is only this definition or declaration, which is probably not what you want
   include/linux/keyslot-manager.h:38:9: warning: 'enum blk_crypto_mode_num' declared inside parameter list
            unsigned int slot);
            ^
   include/linux/keyslot-manager.h:41:11: warning: 'enum blk_crypto_mode_num' declared inside parameter list
              unsigned int data_unit_size);
              ^
   include/linux/keyslot-manager.h:44:8: warning: 'enum blk_crypto_mode_num' declared inside parameter list
           unsigned int data_unit_size);
           ^
   include/linux/keyslot-manager.h:88:7: warning: 'enum blk_crypto_mode_num' declared inside parameter list
          unsigned int data_unit_size)
          ^
   include/linux/keyslot-manager.h:87:32: error: parameter 2 ('crypto_mode') has incomplete type
          enum blk_crypto_mode_num crypto_mode,
                                   ^
   include/linux/keyslot-manager.h:86:1: error: function declaration isn't a prototype [-Werror=strict-prototypes]
    keyslot_manager_rq_crypto_mode_supported(struct request_queue *q,
    ^
   cc1: some warnings being treated as errors

vim +34 include/linux/keyslot-manager.h

    10	
    11	/**
    12	 * struct keyslot_mgmt_ll_ops - functions to manage keyslots in hardware
    13	 * @keyslot_program:	Program the specified key and algorithm into the
    14	 *			specified slot in the inline encryption hardware.
    15	 * @keyslot_evict:	Evict key from the specified keyslot in the hardware.
    16	 *			The key, crypto_mode and data_unit_size are also passed
    17	 *			down so that e.g. dm layers can evict keys from
    18	 *			the devices that they map over.
    19	 *			Returns 0 on success, -errno otherwise.
    20	 * @crypto_mode_supported:	Check whether a crypto_mode and data_unit_size
    21	 *				combo is supported.
    22	 * @keyslot_find:	Returns the slot number that matches the key,
    23	 *			or -ENOKEY if no match found, or -errno on
    24	 *			error.
    25	 *
    26	 * This structure should be provided by storage device drivers when they set up
    27	 * a keyslot manager - this structure holds the function ptrs that the keyslot
    28	 * manager will use to manipulate keyslots in the hardware.
    29	 */
    30	struct keyslot_mgmt_ll_ops {
    31		int (*keyslot_program)(void *ll_priv_data, const u8 *key,
    32				       enum blk_crypto_mode_num crypto_mode,
    33				       unsigned int data_unit_size,
  > 34				       unsigned int slot);
    35		int (*keyslot_evict)(void *ll_priv_data, const u8 *key,
    36				     enum blk_crypto_mode_num crypto_mode,
    37				     unsigned int data_unit_size,
    38				     unsigned int slot);
    39		bool (*crypto_mode_supported)(void *ll_priv_data,
    40					      enum blk_crypto_mode_num crypto_mode,
    41					      unsigned int data_unit_size);
    42		int (*keyslot_find)(void *ll_priv_data, const u8 *key,
    43				    enum blk_crypto_mode_num crypto_mode,
    44				    unsigned int data_unit_size);
    45	};
    46	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 34095 bytes --]