[PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>

[PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>

[Ben Dooks (Codethink)]

The parse_acpi_topology() is not declared anywhere which
causes the following sparse warning:

drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?

RFC: is this the best place to put it?

Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
---
Cc: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org
---
 include/linux/arch_topology.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
index 42f2b5126094..7ae32900d9a2 100644
--- a/include/linux/arch_topology.h
+++ b/include/linux/arch_topology.h
@@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);
 void reset_cpu_topology(void);
 #endif
 
+extern int parse_acpi_topology(void);
+
 #endif /* _LINUX_ARCH_TOPOLOGY_H_ */
-- 
2.23.0

Re: [PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>

[Sudeep Holla]

On Mon, Oct 21, 2019 at 05:25:30PM +0100, Ben Dooks (Codethink) wrote:
> The parse_acpi_topology() is not declared anywhere which
> causes the following sparse warning:
> 
> drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
> 
> RFC: is this the best place to put it?
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
> ---
> Cc: Sudeep Holla <sudeep.holla@arm.com>
> Cc: linux-kernel@vger.kernel.org
> ---
>  include/linux/arch_topology.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
> index 42f2b5126094..7ae32900d9a2 100644
> --- a/include/linux/arch_topology.h
> +++ b/include/linux/arch_topology.h
> @@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);
>  void reset_cpu_topology(void);
>  #endif
>  
> +extern int parse_acpi_topology(void);
> +

Can we drop extern like other declarations here ?
Also move this inside CONFIG_GENERIC_ARCH_TOPOLOGY ?

Please cc Greg with these changes, I will ack and ask Greg to pick up. Thanks.

--
Regards,
Sudeep

Re: [PATCH] RFC: cpu-topology: declare parse_acpi_topology in <linux/arch_topology.h>

[Ben Dooks]

On 21/10/2019 17:52, Sudeep Holla wrote:
> On Mon, Oct 21, 2019 at 05:25:30PM +0100, Ben Dooks (Codethink) wrote:
>> The parse_acpi_topology() is not declared anywhere which
>> causes the following sparse warning:
>>
>> drivers/base/arch_topology.c:522:19: warning: symbol 'parse_acpi_topology' was not declared. Should it be static?
>>
>> RFC: is this the best place to put it?
>>
>> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>
>> ---
>> Cc: Sudeep Holla <sudeep.holla@arm.com>
>> Cc: linux-kernel@vger.kernel.org
>> ---
>>   include/linux/arch_topology.h | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/include/linux/arch_topology.h b/include/linux/arch_topology.h
>> index 42f2b5126094..7ae32900d9a2 100644
>> --- a/include/linux/arch_topology.h
>> +++ b/include/linux/arch_topology.h
>> @@ -59,4 +59,6 @@ void remove_cpu_topology(unsigned int cpuid);
>>   void reset_cpu_topology(void);
>>   #endif
>>   
>> +extern int parse_acpi_topology(void);
>> +
> 
> Can we drop extern like other declarations here ?
> Also move this inside CONFIG_GENERIC_ARCH_TOPOLOGY ?
> 
> Please cc Greg with these changes, I will ack and ask Greg to pick up. Thanks.

Ok, thank you for the input.


-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html