* [PATCH] sae: remove unneeded NULL pointer check
@ 2019-10-21 22:02 James Prestwood
2019-10-21 22:15 ` Denis Kenzior
0 siblings, 1 reply; 2+ messages in thread
From: James Prestwood @ 2019-10-21 22:02 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
The frame was already validated, and mmpdu_body will never return
a NULL pointer.
---
src/sae.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/src/sae.c b/src/sae.c
index a17c2883..391ed4f8 100644
--- a/src/sae.c
+++ b/src/sae.c
@@ -1021,11 +1021,6 @@ static int sae_rx_authenticate(struct auth_proto *ap,
auth = mmpdu_body(hdr);
- if (!auth) {
- l_debug("Auth frame body did not validate");
- goto reject;
- }
-
len -= mmpdu_header_len(hdr);
ret = sae_verify_packet(sm, L_LE16_TO_CPU(auth->transaction_sequence),
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] sae: remove unneeded NULL pointer check
2019-10-21 22:02 [PATCH] sae: remove unneeded NULL pointer check James Prestwood
@ 2019-10-21 22:15 ` Denis Kenzior
0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2019-10-21 22:15 UTC (permalink / raw)
To: iwd
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
Hi James,
On 10/21/19 5:02 PM, James Prestwood wrote:
> The frame was already validated, and mmpdu_body will never return
> a NULL pointer.
> ---
> src/sae.c | 5 -----
> 1 file changed, 5 deletions(-)
>
Applied, thanks.
Regards,
-Denis
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-21 22:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-21 22:02 [PATCH] sae: remove unneeded NULL pointer check James Prestwood
2019-10-21 22:15 ` Denis Kenzior
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.