[Buildroot] [PATCH] package/ofono: use target ell library if enabled

[Buildroot] [PATCH] package/ofono: use target ell library if enabled

[Nicolas Serafini]

Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com>
---
 package/ofono/ofono.mk | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/ofono/ofono.mk b/package/ofono/ofono.mk
index ce05dfcadf..85e249a233 100644
--- a/package/ofono/ofono.mk
+++ b/package/ofono/ofono.mk
@@ -49,7 +49,9 @@ else
 OFONO_CONF_OPTS += --disable-bluetooth
 endif
 
-# required by 0003-build-Add-check-for-explicit_bzero-support.patch
+ifeq ($(BR2_PACKAGE_ELL),y)
 OFONO_AUTORECONF = YES
+OFONO_CONF_OPTS += --enable-external-ell
+endif
 
 $(eval $(autotools-package))
-- 
2.23.0

[Buildroot] [PATCH] package/ofono: use target ell library if enabled

[Thomas Petazzoni]

On Tue, 22 Oct 2019 10:48:31 +0000
Nicolas Serafini <nicolas.serafini@sensefly.com> wrote:

> Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com>
> ---
>  package/ofono/ofono.mk | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/package/ofono/ofono.mk b/package/ofono/ofono.mk
> index ce05dfcadf..85e249a233 100644
> --- a/package/ofono/ofono.mk
> +++ b/package/ofono/ofono.mk
> @@ -49,7 +49,9 @@ else
>  OFONO_CONF_OPTS += --disable-bluetooth
>  endif
>  
> -# required by 0003-build-Add-check-for-explicit_bzero-support.patch

Dropping this comment is correct, because indeed this patch no longer exists.

> +ifeq ($(BR2_PACKAGE_ELL),y)
>  OFONO_AUTORECONF = YES

But why are you keeping AUTORECONF = YES here ?

Also, dropping autoreconf should be in a separate patch.

> +OFONO_CONF_OPTS += --enable-external-ell

You forgot:

OFONO_DEPENDENCIES += ell
else
OFONO_CONF_OPTS += --disable-external-ell

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/ofono: use target ell library if enabled

[Nicolas Serafini]

Hello Thomas,

On Tue, 22 Oct 2019 13:59:39 +0200 Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:

>On Tue, 22 Oct 2019 10:48:31 +0000
>Nicolas Serafini <nicolas.serafini@sensefly.com> wrote:
>
>> Signed-off-by: Nicolas Serafini <nicolas.serafini@sensefly.com>
>> ---
>>  package/ofono/ofono.mk | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>> 
>> diff --git a/package/ofono/ofono.mk b/package/ofono/ofono.mk
>> index ce05dfcadf..85e249a233 100644
>> --- a/package/ofono/ofono.mk
>> +++ b/package/ofono/ofono.mk
>> @@ -49,7 +49,9 @@ else
>>  OFONO_CONF_OPTS += --disable-bluetooth
>>  endif
>>  
>> -# required by 0003-build-Add-check-for-explicit_bzero-support.patch
>
>Dropping this comment is correct, because indeed this patch no longer
>exists.
>
>> +ifeq ($(BR2_PACKAGE_ELL),y)
>>  OFONO_AUTORECONF = YES
>
>But why are you keeping AUTORECONF = YES here ?
>
>Also, dropping autoreconf should be in a separate patch.

Yeah, you're absolutely right, I don't know why I left that.

>
>> +OFONO_CONF_OPTS += --enable-external-ell
>
>You forgot:
>
>OFONO_DEPENDENCIES += ell
>else
>OFONO_CONF_OPTS += --disable-external-ell

I'm going to fix it in a new patch.

Thank you for your review.

Nicolas

>
>Thanks,
>
>Thomas