From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Wei Liu <wei.liu@kernel.org>,
Paul Durrant <paul@xen.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] xen/netback: cleanup init and deinit code
Date: Tue, 22 Oct 2019 11:35:27 -0700 [thread overview]
Message-ID: <20191022113527.6b6bf615@cakuba.netronome.com> (raw)
In-Reply-To: <20191021053052.31690-1-jgross@suse.com>
On Mon, 21 Oct 2019 07:30:52 +0200, Juergen Gross wrote:
> Do some cleanup of the netback init and deinit code:
>
> - add an omnipotent queue deinit function usable from
> xenvif_disconnect_data() and the error path of xenvif_connect_data()
> - only install the irq handlers after initializing all relevant items
> (especially the kthreads related to the queue)
> - there is no need to use get_task_struct() after creating a kthread
> and using put_task_struct() again after having stopped it.
> - use kthread_run() instead of kthread_create() to spare the call of
> wake_up_process().
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Paul Durrant <pdurrant@gmail.com>
Applied to net-next, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Juergen Gross <jgross@suse.com>
Cc: Wei Liu <wei.liu@kernel.org>, Paul Durrant <paul@xen.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Xen-devel] [PATCH] xen/netback: cleanup init and deinit code
Date: Tue, 22 Oct 2019 11:35:27 -0700 [thread overview]
Message-ID: <20191022113527.6b6bf615@cakuba.netronome.com> (raw)
In-Reply-To: <20191021053052.31690-1-jgross@suse.com>
On Mon, 21 Oct 2019 07:30:52 +0200, Juergen Gross wrote:
> Do some cleanup of the netback init and deinit code:
>
> - add an omnipotent queue deinit function usable from
> xenvif_disconnect_data() and the error path of xenvif_connect_data()
> - only install the irq handlers after initializing all relevant items
> (especially the kthreads related to the queue)
> - there is no need to use get_task_struct() after creating a kthread
> and using put_task_struct() again after having stopped it.
> - use kthread_run() instead of kthread_create() to spare the call of
> wake_up_process().
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> Reviewed-by: Paul Durrant <pdurrant@gmail.com>
Applied to net-next, thanks!
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-10-22 18:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 5:30 [PATCH] xen/netback: cleanup init and deinit code Juergen Gross
2019-10-21 5:30 ` [Xen-devel] " Juergen Gross
2019-10-22 18:35 ` Jakub Kicinski [this message]
2019-10-22 18:35 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2019-10-21 5:27 Juergen Gross
2019-10-21 5:30 ` Jürgen Groß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022113527.6b6bf615@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul@xen.org \
--cc=wei.liu@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.