* [PATCH] drm/i915: Fix PCH reference clock for FDI on HSW/BDW
@ 2019-10-22 18:56 Ville Syrjala
2019-10-23 1:17 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Ville Syrjala @ 2019-10-22 18:56 UTC (permalink / raw)
To: intel-gfx; +Cc: stable, Andrija
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
The change to skip the PCH reference initialization during fastboot
did end up breaking FDI. To fix that let's try to do the PCH reference
init whenever we're disabling a DPLL that was using said reference
previously.
Cc: stable@vger.kernel.org
Tested-by: Andrija <akijo97@gmail.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112084
Fixes: b16c7ed95caf ("drm/i915: Do not touch the PCH SSC reference if a PLL is using it")
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++-----
drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 15 +++++++++++++++
drivers/gpu/drm/i915/i915_drv.h | 2 ++
3 files changed, 23 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
index 236fdf122e47..da76f794a965 100644
--- a/drivers/gpu/drm/i915/display/intel_display.c
+++ b/drivers/gpu/drm/i915/display/intel_display.c
@@ -9359,7 +9359,6 @@ static bool wrpll_uses_pch_ssc(struct drm_i915_private *dev_priv,
static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
{
struct intel_encoder *encoder;
- bool pch_ssc_in_use = false;
bool has_fdi = false;
for_each_intel_encoder(&dev_priv->drm, encoder) {
@@ -9387,22 +9386,24 @@ static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
* clock hierarchy. That would also allow us to do
* clock bending finally.
*/
+ dev_priv->pch_ssc_use = 0;
+
if (spll_uses_pch_ssc(dev_priv)) {
DRM_DEBUG_KMS("SPLL using PCH SSC\n");
- pch_ssc_in_use = true;
+ dev_priv->pch_ssc_use |= BIT(DPLL_ID_SPLL);
}
if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL1)) {
DRM_DEBUG_KMS("WRPLL1 using PCH SSC\n");
- pch_ssc_in_use = true;
+ dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL1);
}
if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL2)) {
DRM_DEBUG_KMS("WRPLL2 using PCH SSC\n");
- pch_ssc_in_use = true;
+ dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL2);
}
- if (pch_ssc_in_use)
+ if (dev_priv->pch_ssc_use)
return;
if (has_fdi) {
diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
index ec10fa7d3c69..3ce0a023eee0 100644
--- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
+++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
@@ -526,16 +526,31 @@ static void hsw_ddi_wrpll_disable(struct drm_i915_private *dev_priv,
val = I915_READ(WRPLL_CTL(id));
I915_WRITE(WRPLL_CTL(id), val & ~WRPLL_PLL_ENABLE);
POSTING_READ(WRPLL_CTL(id));
+
+ /*
+ * Try to set up the PCH reference clock once all DPLLs
+ * that depend on it have been shut down.
+ */
+ if (dev_priv->pch_ssc_use & BIT(id))
+ intel_init_pch_refclk(dev_priv);
}
static void hsw_ddi_spll_disable(struct drm_i915_private *dev_priv,
struct intel_shared_dpll *pll)
{
+ enum intel_dpll_id id = pll->info->id;
u32 val;
val = I915_READ(SPLL_CTL);
I915_WRITE(SPLL_CTL, val & ~SPLL_PLL_ENABLE);
POSTING_READ(SPLL_CTL);
+
+ /*
+ * Try to set up the PCH reference clock once all DPLLs
+ * that depend on it have been shut down.
+ */
+ if (dev_priv->pch_ssc_use & BIT(id))
+ intel_init_pch_refclk(dev_priv);
}
static bool hsw_ddi_wrpll_get_hw_state(struct drm_i915_private *dev_priv,
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 8882c0908c3b..5332825e0ce4 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -1348,6 +1348,8 @@ struct drm_i915_private {
} contexts;
} gem;
+ u8 pch_ssc_use;
+
/* For i915gm/i945gm vblank irq workaround */
u8 vblank_enabled;
--
2.21.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Fix PCH reference clock for FDI on HSW/BDW
2019-10-22 18:56 [PATCH] drm/i915: Fix PCH reference clock for FDI on HSW/BDW Ville Syrjala
@ 2019-10-23 1:17 ` Patchwork
2019-10-23 12:44 ` Imre Deak
` (2 subsequent siblings)
3 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-10-23 1:17 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix PCH reference clock for FDI on HSW/BDW
URL : https://patchwork.freedesktop.org/series/68411/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7155 -> Patchwork_14935
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14935 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14935, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14935:
### IGT changes ###
#### Possible regressions ####
* igt@prime_vgem@basic-wait-default:
- fi-kbl-soraka: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-kbl-soraka/igt@prime_vgem@basic-wait-default.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-kbl-soraka/igt@prime_vgem@basic-wait-default.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@i915_selftest@live_gem:
- {fi-tgl-u2}: NOTRUN -> [INCOMPLETE][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-tgl-u2/igt@i915_selftest@live_gem.html
- {fi-tgl-u}: NOTRUN -> [INCOMPLETE][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-tgl-u/igt@i915_selftest@live_gem.html
* {igt@i915_selftest@live_gt_heartbeat}:
- fi-whl-u: [PASS][5] -> [DMESG-FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-whl-u/igt@i915_selftest@live_gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-whl-u/igt@i915_selftest@live_gt_heartbeat.html
Known issues
------------
Here are the changes found in Patchwork_14935 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_switch@rcs0:
- fi-icl-u2: [PASS][7] -> [INCOMPLETE][8] ([fdo#107713])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u2/igt@gem_ctx_switch@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-icl-u2/igt@gem_ctx_switch@rcs0.html
* igt@gem_mmap_gtt@basic-small-bo-tiledy:
- fi-icl-u3: [PASS][9] -> [DMESG-WARN][10] ([fdo#107724]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledy.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-icl-u3/igt@gem_mmap_gtt@basic-small-bo-tiledy.html
#### Possible fixes ####
* igt@gem_flink_basic@basic:
- fi-icl-u3: [DMESG-WARN][11] ([fdo#107724] / [fdo#112052 ]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u3/igt@gem_flink_basic@basic.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-icl-u3/igt@gem_flink_basic@basic.html
* igt@gem_sync@basic-many-each:
- {fi-tgl-u}: [INCOMPLETE][13] ([fdo#111880]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-tgl-u/igt@gem_sync@basic-many-each.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-tgl-u/igt@gem_sync@basic-many-each.html
* igt@i915_selftest@live_requests:
- {fi-tgl-u2}: [INCOMPLETE][15] ([fdo#112057]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-tgl-u2/igt@i915_selftest@live_requests.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-tgl-u2/igt@i915_selftest@live_requests.html
* igt@vgem_basic@setversion:
- fi-icl-u3: [DMESG-WARN][17] ([fdo#107724]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7155/fi-icl-u3/igt@vgem_basic@setversion.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/fi-icl-u3/igt@vgem_basic@setversion.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
[fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
[fdo#112052 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112052
[fdo#112057]: https://bugs.freedesktop.org/show_bug.cgi?id=112057
Participating hosts (52 -> 37)
------------------------------
Missing (15): fi-icl-u4 fi-ilk-m540 fi-hsw-4200u fi-byt-j1900 fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-snb-2520m fi-byt-clapper fi-elk-e7500 fi-icl-y fi-icl-guc fi-bsw-kefka fi-bdw-samus fi-cml-u
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7155 -> Patchwork_14935
CI-20190529: 20190529
CI_DRM_7155: 87aff128f9bafd90854e4691c3afcdf7a0e61ce2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5235: da9abbab69be80dd00812a4607a4ea2dffcc4544 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14935: 8ca76cfb0d91809001292459762857aa907805b4 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8ca76cfb0d91 drm/i915: Fix PCH reference clock for FDI on HSW/BDW
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14935/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix PCH reference clock for FDI on HSW/BDW
@ 2019-10-23 12:44 ` Imre Deak
0 siblings, 0 replies; 10+ messages in thread
From: Imre Deak @ 2019-10-23 12:44 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx, Andrija, stable
On Tue, Oct 22, 2019 at 09:56:43PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The change to skip the PCH reference initialization during fastboot
> did end up breaking FDI. To fix that let's try to do the PCH reference
> init whenever we're disabling a DPLL that was using said reference
> previously.
>
> Cc: stable@vger.kernel.org
> Tested-by: Andrija <akijo97@gmail.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112084
> Fixes: b16c7ed95caf ("drm/i915: Do not touch the PCH SSC reference if a PLL is using it")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++-----
> drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 15 +++++++++++++++
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> 3 files changed, 23 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 236fdf122e47..da76f794a965 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -9359,7 +9359,6 @@ static bool wrpll_uses_pch_ssc(struct drm_i915_private *dev_priv,
> static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
> {
> struct intel_encoder *encoder;
> - bool pch_ssc_in_use = false;
> bool has_fdi = false;
>
> for_each_intel_encoder(&dev_priv->drm, encoder) {
> @@ -9387,22 +9386,24 @@ static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
> * clock hierarchy. That would also allow us to do
> * clock bending finally.
> */
> + dev_priv->pch_ssc_use = 0;
> +
> if (spll_uses_pch_ssc(dev_priv)) {
> DRM_DEBUG_KMS("SPLL using PCH SSC\n");
> - pch_ssc_in_use = true;
> + dev_priv->pch_ssc_use |= BIT(DPLL_ID_SPLL);
> }
>
> if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL1)) {
> DRM_DEBUG_KMS("WRPLL1 using PCH SSC\n");
> - pch_ssc_in_use = true;
> + dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL1);
> }
>
> if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL2)) {
> DRM_DEBUG_KMS("WRPLL2 using PCH SSC\n");
> - pch_ssc_in_use = true;
> + dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL2);
> }
>
> - if (pch_ssc_in_use)
> + if (dev_priv->pch_ssc_use)
> return;
>
> if (has_fdi) {
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index ec10fa7d3c69..3ce0a023eee0 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -526,16 +526,31 @@ static void hsw_ddi_wrpll_disable(struct drm_i915_private *dev_priv,
> val = I915_READ(WRPLL_CTL(id));
> I915_WRITE(WRPLL_CTL(id), val & ~WRPLL_PLL_ENABLE);
> POSTING_READ(WRPLL_CTL(id));
> +
> + /*
> + * Try to set up the PCH reference clock once all DPLLs
> + * that depend on it have been shut down.
> + */
> + if (dev_priv->pch_ssc_use & BIT(id))
> + intel_init_pch_refclk(dev_priv);
> }
>
> static void hsw_ddi_spll_disable(struct drm_i915_private *dev_priv,
> struct intel_shared_dpll *pll)
> {
> + enum intel_dpll_id id = pll->info->id;
> u32 val;
>
> val = I915_READ(SPLL_CTL);
> I915_WRITE(SPLL_CTL, val & ~SPLL_PLL_ENABLE);
> POSTING_READ(SPLL_CTL);
> +
> + /*
> + * Try to set up the PCH reference clock once all DPLLs
> + * that depend on it have been shut down.
> + */
> + if (dev_priv->pch_ssc_use & BIT(id))
> + intel_init_pch_refclk(dev_priv);
> }
>
> static bool hsw_ddi_wrpll_get_hw_state(struct drm_i915_private *dev_priv,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 8882c0908c3b..5332825e0ce4 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1348,6 +1348,8 @@ struct drm_i915_private {
> } contexts;
> } gem;
>
> + u8 pch_ssc_use;
> +
> /* For i915gm/i945gm vblank irq workaround */
> u8 vblank_enabled;
>
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix PCH reference clock for FDI on HSW/BDW
@ 2019-10-23 12:44 ` Imre Deak
0 siblings, 0 replies; 10+ messages in thread
From: Imre Deak @ 2019-10-23 12:44 UTC (permalink / raw)
To: Ville Syrjala; +Cc: intel-gfx, stable, Andrija
On Tue, Oct 22, 2019 at 09:56:43PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> The change to skip the PCH reference initialization during fastboot
> did end up breaking FDI. To fix that let's try to do the PCH reference
> init whenever we're disabling a DPLL that was using said reference
> previously.
>
> Cc: stable@vger.kernel.org
> Tested-by: Andrija <akijo97@gmail.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112084
> Fixes: b16c7ed95caf ("drm/i915: Do not touch the PCH SSC reference if a PLL is using it")
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++-----
> drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 15 +++++++++++++++
> drivers/gpu/drm/i915/i915_drv.h | 2 ++
> 3 files changed, 23 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 236fdf122e47..da76f794a965 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -9359,7 +9359,6 @@ static bool wrpll_uses_pch_ssc(struct drm_i915_private *dev_priv,
> static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
> {
> struct intel_encoder *encoder;
> - bool pch_ssc_in_use = false;
> bool has_fdi = false;
>
> for_each_intel_encoder(&dev_priv->drm, encoder) {
> @@ -9387,22 +9386,24 @@ static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
> * clock hierarchy. That would also allow us to do
> * clock bending finally.
> */
> + dev_priv->pch_ssc_use = 0;
> +
> if (spll_uses_pch_ssc(dev_priv)) {
> DRM_DEBUG_KMS("SPLL using PCH SSC\n");
> - pch_ssc_in_use = true;
> + dev_priv->pch_ssc_use |= BIT(DPLL_ID_SPLL);
> }
>
> if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL1)) {
> DRM_DEBUG_KMS("WRPLL1 using PCH SSC\n");
> - pch_ssc_in_use = true;
> + dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL1);
> }
>
> if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL2)) {
> DRM_DEBUG_KMS("WRPLL2 using PCH SSC\n");
> - pch_ssc_in_use = true;
> + dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL2);
> }
>
> - if (pch_ssc_in_use)
> + if (dev_priv->pch_ssc_use)
> return;
>
> if (has_fdi) {
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> index ec10fa7d3c69..3ce0a023eee0 100644
> --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> @@ -526,16 +526,31 @@ static void hsw_ddi_wrpll_disable(struct drm_i915_private *dev_priv,
> val = I915_READ(WRPLL_CTL(id));
> I915_WRITE(WRPLL_CTL(id), val & ~WRPLL_PLL_ENABLE);
> POSTING_READ(WRPLL_CTL(id));
> +
> + /*
> + * Try to set up the PCH reference clock once all DPLLs
> + * that depend on it have been shut down.
> + */
> + if (dev_priv->pch_ssc_use & BIT(id))
> + intel_init_pch_refclk(dev_priv);
> }
>
> static void hsw_ddi_spll_disable(struct drm_i915_private *dev_priv,
> struct intel_shared_dpll *pll)
> {
> + enum intel_dpll_id id = pll->info->id;
> u32 val;
>
> val = I915_READ(SPLL_CTL);
> I915_WRITE(SPLL_CTL, val & ~SPLL_PLL_ENABLE);
> POSTING_READ(SPLL_CTL);
> +
> + /*
> + * Try to set up the PCH reference clock once all DPLLs
> + * that depend on it have been shut down.
> + */
> + if (dev_priv->pch_ssc_use & BIT(id))
> + intel_init_pch_refclk(dev_priv);
> }
>
> static bool hsw_ddi_wrpll_get_hw_state(struct drm_i915_private *dev_priv,
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 8882c0908c3b..5332825e0ce4 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1348,6 +1348,8 @@ struct drm_i915_private {
> } contexts;
> } gem;
>
> + u8 pch_ssc_use;
> +
> /* For i915gm/i945gm vblank irq workaround */
> u8 vblank_enabled;
>
> --
> 2.21.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2)
@ 2019-10-24 1:48 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-10-24 1:48 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2)
URL : https://patchwork.freedesktop.org/series/68411/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14953
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/index.html
Known issues
------------
Here are the changes found in Patchwork_14953 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_addfb_basic@addfb25-x-tiled-mismatch:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-icl-u3/igt@kms_addfb_basic@addfb25-x-tiled-mismatch.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-icl-u3/igt@kms_addfb_basic@addfb25-x-tiled-mismatch.html
#### Possible fixes ####
* igt@gem_sync@basic-store-all:
- {fi-tgl-u}: [INCOMPLETE][3] ([fdo#111880]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-tgl-u/igt@gem_sync@basic-store-all.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-tgl-u/igt@gem_sync@basic-store-all.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-skl-6600u: [FAIL][5] ([fdo#107707]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-skl-6600u/igt@i915_pm_rpm@basic-pci-d3-state.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-skl-6600u/igt@i915_pm_rpm@basic-pci-d3-state.html
* {igt@i915_selftest@live_gt_heartbeat}:
- {fi-icl-dsi}: [DMESG-FAIL][7] -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-icl-dsi/igt@i915_selftest@live_gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-icl-dsi/igt@i915_selftest@live_gt_heartbeat.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([fdo#111407]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@prime_vgem@basic-fence-wait-default:
- fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-icl-u3/igt@prime_vgem@basic-fence-wait-default.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-icl-u3/igt@prime_vgem@basic-fence-wait-default.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107707]: https://bugs.freedesktop.org/show_bug.cgi?id=107707
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
Participating hosts (52 -> 43)
------------------------------
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-bdw-samus fi-byt-clapper fi-skl-6700k2 fi-kbl-r
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7167 -> Patchwork_14953
CI-20190529: 20190529
CI_DRM_7167: a62b1c4e7739c6777d51e7b2d66406b935131451 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5236: 8153b95b53bdef26d2c3e318197d174e982b4265 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14953: ffe180767d438e9f8d91e5305fb83dc6dd671e54 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ffe180767d43 drm/i915: Fix PCH reference clock for FDI on HSW/BDW
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2)
@ 2019-10-24 1:48 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-10-24 1:48 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2)
URL : https://patchwork.freedesktop.org/series/68411/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7167 -> Patchwork_14953
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/index.html
Known issues
------------
Here are the changes found in Patchwork_14953 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_addfb_basic@addfb25-x-tiled-mismatch:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-icl-u3/igt@kms_addfb_basic@addfb25-x-tiled-mismatch.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-icl-u3/igt@kms_addfb_basic@addfb25-x-tiled-mismatch.html
#### Possible fixes ####
* igt@gem_sync@basic-store-all:
- {fi-tgl-u}: [INCOMPLETE][3] ([fdo#111880]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-tgl-u/igt@gem_sync@basic-store-all.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-tgl-u/igt@gem_sync@basic-store-all.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-skl-6600u: [FAIL][5] ([fdo#107707]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-skl-6600u/igt@i915_pm_rpm@basic-pci-d3-state.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-skl-6600u/igt@i915_pm_rpm@basic-pci-d3-state.html
* {igt@i915_selftest@live_gt_heartbeat}:
- {fi-icl-dsi}: [DMESG-FAIL][7] -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-icl-dsi/igt@i915_selftest@live_gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-icl-dsi/igt@i915_selftest@live_gt_heartbeat.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([fdo#111407]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@prime_vgem@basic-fence-wait-default:
- fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/fi-icl-u3/igt@prime_vgem@basic-fence-wait-default.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/fi-icl-u3/igt@prime_vgem@basic-fence-wait-default.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107707]: https://bugs.freedesktop.org/show_bug.cgi?id=107707
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
Participating hosts (52 -> 43)
------------------------------
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-bdw-samus fi-byt-clapper fi-skl-6700k2 fi-kbl-r
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7167 -> Patchwork_14953
CI-20190529: 20190529
CI_DRM_7167: a62b1c4e7739c6777d51e7b2d66406b935131451 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5236: 8153b95b53bdef26d2c3e318197d174e982b4265 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14953: ffe180767d438e9f8d91e5305fb83dc6dd671e54 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ffe180767d43 drm/i915: Fix PCH reference clock for FDI on HSW/BDW
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2)
@ 2019-10-24 23:35 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-10-24 23:35 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2)
URL : https://patchwork.freedesktop.org/series/68411/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7167_full -> Patchwork_14953_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14953_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14953_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14953_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_shared@q-promotion-bsd1:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-apl2/igt@gem_ctx_shared@q-promotion-bsd1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-apl1/igt@gem_ctx_shared@q-promotion-bsd1.html
* igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd:
- shard-skl: NOTRUN -> [FAIL][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl8/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
- shard-iclb: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb3/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_parallel@bcs0:
- {shard-tglb}: NOTRUN -> [INCOMPLETE][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb1/igt@gem_exec_parallel@bcs0.html
* igt@gem_exec_schedule@wide-bsd2:
- {shard-tglb}: [PASS][6] -> [FAIL][7] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-tglb6/igt@gem_exec_schedule@wide-bsd2.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb4/igt@gem_exec_schedule@wide-bsd2.html
Known issues
------------
Here are the changes found in Patchwork_14953_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#112080]) +9 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb4/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb7/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* igt@gem_ctx_isolation@vcs1-s3:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#109276] / [fdo#112080])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb4/igt@gem_ctx_isolation@vcs1-s3.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb6/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_ctx_shared@exec-single-timeline-bsd1:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#109276]) +14 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][14] -> [SKIP][15] ([fdo#111325]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb6/igt@gem_exec_async@concurrent-writes-bsd.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb4/igt@gem_exec_async@concurrent-writes-bsd.html
* igt@gem_exec_reloc@basic-write-read-active:
- shard-skl: [PASS][16] -> [DMESG-WARN][17] ([fdo#106107])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl7/igt@gem_exec_reloc@basic-write-read-active.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl7/igt@gem_exec_reloc@basic-write-read-active.html
* igt@gem_exec_schedule@wide-bsd2:
- shard-kbl: [PASS][18] -> [INCOMPLETE][19] ([fdo#103665])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl2/igt@gem_exec_schedule@wide-bsd2.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl3/igt@gem_exec_schedule@wide-bsd2.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [PASS][20] -> [FAIL][21] ([fdo#112037])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [PASS][22] -> [DMESG-WARN][23] ([fdo#111870]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb6/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][24] -> [DMESG-WARN][25] ([fdo#111870])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@i915_suspend@forcewake:
- shard-apl: [PASS][26] -> [DMESG-WARN][27] ([fdo#108566])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-apl2/igt@i915_suspend@forcewake.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-apl6/igt@i915_suspend@forcewake.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][28] -> [FAIL][29] ([fdo#105363])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [PASS][30] -> [FAIL][31] ([fdo#103167]) +9 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-skl: [PASS][32] -> [FAIL][33] ([fdo#103167]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- shard-skl: [PASS][34] -> [FAIL][35] ([fdo#103191])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl7/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: [PASS][36] -> [INCOMPLETE][37] ([fdo#104108])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][38] -> [FAIL][39] ([fdo#108145])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#109642] / [fdo#111068])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][42] -> [SKIP][43] ([fdo#109441]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][44] -> [DMESG-WARN][45] ([fdo#108566]) +5 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][46] ([fdo#108566]) -> [PASS][47] +7 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl1/igt@gem_ctx_isolation@rcs0-s3.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][48] ([fdo#109276] / [fdo#112080]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb6/igt@gem_ctx_isolation@vcs1-none.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][50] ([fdo#109661]) -> [PASS][51] +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb5/igt@gem_eio@unwedge-stress.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_reloc@basic-cpu-wc-active:
- shard-skl: [DMESG-WARN][52] ([fdo#106107]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl6/igt@gem_exec_reloc@basic-cpu-wc-active.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl5/igt@gem_exec_reloc@basic-cpu-wc-active.html
* igt@gem_exec_schedule@preempt-queue-contexts-render:
- shard-kbl: [FAIL][54] -> [PASS][55] +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl2/igt@gem_exec_schedule@preempt-queue-contexts-render.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl4/igt@gem_exec_schedule@preempt-queue-contexts-render.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][56] ([fdo#111325]) -> [PASS][57] +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb8/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-snb: [INCOMPLETE][58] ([fdo#105411]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb4/igt@gem_persistent_relocs@forked-thrash-inactive.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb4/igt@gem_persistent_relocs@forked-thrash-inactive.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][60] ([fdo#104108]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl6/igt@gem_softpin@noreloc-s3.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl5/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][62] ([fdo#111870]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [DMESG-WARN][64] ([fdo#111870]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@i915_hangman@error-state-basic:
- shard-kbl: [SKIP][66] ([fdo#109271]) -> [PASS][67] +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl2/igt@i915_hangman@error-state-basic.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl4/igt@i915_hangman@error-state-basic.html
* {igt@i915_pm_dc@dc6-dpms}:
- shard-iclb: [FAIL][68] ([fdo#110548]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [DMESG-WARN][70] ([fdo#105763] / [fdo#106538]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-glk2/igt@i915_pm_rpm@modeset-stress-extra-wait.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-skl: [INCOMPLETE][72] ([fdo#104108] / [fdo#107807]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl7/igt@i915_pm_rpm@system-suspend-execbuf.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl8/igt@i915_pm_rpm@system-suspend-execbuf.html
* {igt@i915_selftest@live_gt_heartbeat}:
- shard-skl: [DMESG-FAIL][74] -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl3/igt@i915_selftest@live_gt_heartbeat.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl8/igt@i915_selftest@live_gt_heartbeat.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [DMESG-FAIL][76] ([fdo#111991]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-hsw7/igt@i915_selftest@live_hangcheck.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-hsw8/igt@i915_selftest@live_hangcheck.html
- shard-iclb: [INCOMPLETE][78] ([fdo#107713] / [fdo#108569]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb3/igt@i915_selftest@live_hangcheck.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb7/igt@i915_selftest@live_hangcheck.html
* igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing:
- {shard-tglb}: [DMESG-WARN][80] ([fdo#111600]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-tglb6/igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb1/igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing.html
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: [FAIL][82] ([fdo#103355]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-hsw7/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
* igt@kms_flip@blocking-absolute-wf_vblank-interruptible:
- {shard-tglb}: [INCOMPLETE][84] -> [PASS][85] +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-tglb3/igt@kms_flip@blocking-absolute-wf_vblank-interruptible.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb2/igt@kms_flip@blocking-absolute-wf_vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][86] ([fdo#105363]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [FAIL][88] ([fdo#103167]) -> [PASS][89] +5 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- {shard-tglb}: [FAIL][90] ([fdo#103167]) -> [PASS][91] +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt:
- shard-snb: [SKIP][92] ([fdo#109271]) -> [PASS][93] +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [FAIL][94] ([fdo#103167] / [fdo#110378]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][96] ([fdo#108145] / [fdo#110403]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][98] ([fdo#108566]) -> [PASS][99] +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [SKIP][100] ([fdo#112080]) -> [PASS][101] +12 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb6/igt@perf_pmu@busy-no-semaphores-vcs1.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][102] ([fdo#109276]) -> [PASS][103] +14 similar issues
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2)
@ 2019-10-24 23:35 ` Patchwork
0 siblings, 0 replies; 10+ messages in thread
From: Patchwork @ 2019-10-24 23:35 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2)
URL : https://patchwork.freedesktop.org/series/68411/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7167_full -> Patchwork_14953_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14953_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14953_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14953_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_shared@q-promotion-bsd1:
- shard-apl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-apl2/igt@gem_ctx_shared@q-promotion-bsd1.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-apl1/igt@gem_ctx_shared@q-promotion-bsd1.html
* igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd:
- shard-skl: NOTRUN -> [FAIL][3] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl8/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
- shard-iclb: NOTRUN -> [FAIL][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb3/igt@gem_exec_schedule@preempt-queue-contexts-chain-bsd.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_exec_parallel@bcs0:
- {shard-tglb}: NOTRUN -> [INCOMPLETE][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb1/igt@gem_exec_parallel@bcs0.html
* igt@gem_exec_schedule@wide-bsd2:
- {shard-tglb}: [PASS][6] -> [FAIL][7] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-tglb6/igt@gem_exec_schedule@wide-bsd2.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb4/igt@gem_exec_schedule@wide-bsd2.html
Known issues
------------
Here are the changes found in Patchwork_14953_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#112080]) +9 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb4/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb7/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* igt@gem_ctx_isolation@vcs1-s3:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#109276] / [fdo#112080])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb4/igt@gem_ctx_isolation@vcs1-s3.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb6/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_ctx_shared@exec-single-timeline-bsd1:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#109276]) +14 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd1.html
* igt@gem_exec_async@concurrent-writes-bsd:
- shard-iclb: [PASS][14] -> [SKIP][15] ([fdo#111325]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb6/igt@gem_exec_async@concurrent-writes-bsd.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb4/igt@gem_exec_async@concurrent-writes-bsd.html
* igt@gem_exec_reloc@basic-write-read-active:
- shard-skl: [PASS][16] -> [DMESG-WARN][17] ([fdo#106107])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl7/igt@gem_exec_reloc@basic-write-read-active.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl7/igt@gem_exec_reloc@basic-write-read-active.html
* igt@gem_exec_schedule@wide-bsd2:
- shard-kbl: [PASS][18] -> [INCOMPLETE][19] ([fdo#103665])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl2/igt@gem_exec_schedule@wide-bsd2.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl3/igt@gem_exec_schedule@wide-bsd2.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [PASS][20] -> [FAIL][21] ([fdo#112037])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb6/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [PASS][22] -> [DMESG-WARN][23] ([fdo#111870]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb6/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][24] -> [DMESG-WARN][25] ([fdo#111870])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-hsw7/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@i915_suspend@forcewake:
- shard-apl: [PASS][26] -> [DMESG-WARN][27] ([fdo#108566])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-apl2/igt@i915_suspend@forcewake.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-apl6/igt@i915_suspend@forcewake.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][28] -> [FAIL][29] ([fdo#105363])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl8/igt@kms_flip@flip-vs-expired-vblank.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl3/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite:
- shard-iclb: [PASS][30] -> [FAIL][31] ([fdo#103167]) +9 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt:
- shard-skl: [PASS][32] -> [FAIL][33] ([fdo#103167]) +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl7/igt@kms_frontbuffer_tracking@psr-1p-primscrn-cur-indfb-draw-mmap-gtt.html
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- shard-skl: [PASS][34] -> [FAIL][35] ([fdo#103191])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl6/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl7/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-skl: [PASS][36] -> [INCOMPLETE][37] ([fdo#104108])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl9/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][38] -> [FAIL][39] ([fdo#108145])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl4/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl7/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][40] -> [SKIP][41] ([fdo#109642] / [fdo#111068])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb8/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [PASS][42] -> [SKIP][43] ([fdo#109441]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb8/igt@kms_psr@psr2_cursor_blt.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [PASS][44] -> [DMESG-WARN][45] ([fdo#108566]) +5 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][46] ([fdo#108566]) -> [PASS][47] +7 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl1/igt@gem_ctx_isolation@rcs0-s3.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][48] ([fdo#109276] / [fdo#112080]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb6/igt@gem_ctx_isolation@vcs1-none.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb1/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][50] ([fdo#109661]) -> [PASS][51] +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb5/igt@gem_eio@unwedge-stress.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_reloc@basic-cpu-wc-active:
- shard-skl: [DMESG-WARN][52] ([fdo#106107]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl6/igt@gem_exec_reloc@basic-cpu-wc-active.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl5/igt@gem_exec_reloc@basic-cpu-wc-active.html
* igt@gem_exec_schedule@preempt-queue-contexts-render:
- shard-kbl: [FAIL][54] -> [PASS][55] +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl2/igt@gem_exec_schedule@preempt-queue-contexts-render.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl4/igt@gem_exec_schedule@preempt-queue-contexts-render.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [SKIP][56] ([fdo#111325]) -> [PASS][57] +3 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb8/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-snb: [INCOMPLETE][58] ([fdo#105411]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb4/igt@gem_persistent_relocs@forked-thrash-inactive.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb4/igt@gem_persistent_relocs@forked-thrash-inactive.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][60] ([fdo#104108]) -> [PASS][61] +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl6/igt@gem_softpin@noreloc-s3.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl5/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-snb: [DMESG-WARN][62] ([fdo#111870]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [DMESG-WARN][64] ([fdo#111870]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@i915_hangman@error-state-basic:
- shard-kbl: [SKIP][66] ([fdo#109271]) -> [PASS][67] +2 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-kbl2/igt@i915_hangman@error-state-basic.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-kbl4/igt@i915_hangman@error-state-basic.html
* {igt@i915_pm_dc@dc6-dpms}:
- shard-iclb: [FAIL][68] ([fdo#110548]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb3/igt@i915_pm_dc@dc6-dpms.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb5/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@modeset-stress-extra-wait:
- shard-glk: [DMESG-WARN][70] ([fdo#105763] / [fdo#106538]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-glk8/igt@i915_pm_rpm@modeset-stress-extra-wait.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-glk2/igt@i915_pm_rpm@modeset-stress-extra-wait.html
* igt@i915_pm_rpm@system-suspend-execbuf:
- shard-skl: [INCOMPLETE][72] ([fdo#104108] / [fdo#107807]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl7/igt@i915_pm_rpm@system-suspend-execbuf.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl8/igt@i915_pm_rpm@system-suspend-execbuf.html
* {igt@i915_selftest@live_gt_heartbeat}:
- shard-skl: [DMESG-FAIL][74] -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl3/igt@i915_selftest@live_gt_heartbeat.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl8/igt@i915_selftest@live_gt_heartbeat.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [DMESG-FAIL][76] ([fdo#111991]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-hsw7/igt@i915_selftest@live_hangcheck.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-hsw8/igt@i915_selftest@live_hangcheck.html
- shard-iclb: [INCOMPLETE][78] ([fdo#107713] / [fdo#108569]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb3/igt@i915_selftest@live_hangcheck.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb7/igt@i915_selftest@live_hangcheck.html
* igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing:
- {shard-tglb}: [DMESG-WARN][80] ([fdo#111600]) -> [PASS][81]
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-tglb6/igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb1/igt@kms_atomic_transition@plane-all-transition-nonblocking-fencing.html
* igt@kms_cursor_legacy@cursor-vs-flip-legacy:
- shard-hsw: [FAIL][82] ([fdo#103355]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-hsw7/igt@kms_cursor_legacy@cursor-vs-flip-legacy.html
* igt@kms_flip@blocking-absolute-wf_vblank-interruptible:
- {shard-tglb}: [INCOMPLETE][84] -> [PASS][85] +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-tglb3/igt@kms_flip@blocking-absolute-wf_vblank-interruptible.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb2/igt@kms_flip@blocking-absolute-wf_vblank-interruptible.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-skl: [FAIL][86] ([fdo#105363]) -> [PASS][87]
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl7/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl9/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
- shard-iclb: [FAIL][88] ([fdo#103167]) -> [PASS][89] +5 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt:
- {shard-tglb}: [FAIL][90] ([fdo#103167]) -> [PASS][91] +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-plflip-blt.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt:
- shard-snb: [SKIP][92] ([fdo#109271]) -> [PASS][93] +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-snb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-snb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [FAIL][94] ([fdo#103167] / [fdo#110378]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][96] ([fdo#108145] / [fdo#110403]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-skl9/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-skl3/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [DMESG-WARN][98] ([fdo#108566]) -> [PASS][99] +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-apl6/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-apl2/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [SKIP][100] ([fdo#112080]) -> [PASS][101] +12 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7167/shard-iclb6/igt@perf_pmu@busy-no-semaphores-vcs1.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html
* igt@prime_busy@hang-bsd2:
- shard-iclb: [SKIP][102] ([fdo#109276]) -> [PASS][103] +14 similar issues
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14953/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix PCH reference clock for FDI on HSW/BDW
@ 2019-10-25 17:24 ` Ville Syrjälä
0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2019-10-25 17:24 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx, Andrija, stable
On Wed, Oct 23, 2019 at 03:44:50PM +0300, Imre Deak wrote:
> On Tue, Oct 22, 2019 at 09:56:43PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The change to skip the PCH reference initialization during fastboot
> > did end up breaking FDI. To fix that let's try to do the PCH reference
> > init whenever we're disabling a DPLL that was using said reference
> > previously.
> >
> > Cc: stable@vger.kernel.org
> > Tested-by: Andrija <akijo97@gmail.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112084
> > Fixes: b16c7ed95caf ("drm/i915: Do not touch the PCH SSC reference if a PLL is using it")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
CI had some bsd fails which are not relevant, so pushed to dinq.
Thanks for the review.
>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++-----
> > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 15 +++++++++++++++
> > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > 3 files changed, 23 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index 236fdf122e47..da76f794a965 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -9359,7 +9359,6 @@ static bool wrpll_uses_pch_ssc(struct drm_i915_private *dev_priv,
> > static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
> > {
> > struct intel_encoder *encoder;
> > - bool pch_ssc_in_use = false;
> > bool has_fdi = false;
> >
> > for_each_intel_encoder(&dev_priv->drm, encoder) {
> > @@ -9387,22 +9386,24 @@ static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
> > * clock hierarchy. That would also allow us to do
> > * clock bending finally.
> > */
> > + dev_priv->pch_ssc_use = 0;
> > +
> > if (spll_uses_pch_ssc(dev_priv)) {
> > DRM_DEBUG_KMS("SPLL using PCH SSC\n");
> > - pch_ssc_in_use = true;
> > + dev_priv->pch_ssc_use |= BIT(DPLL_ID_SPLL);
> > }
> >
> > if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL1)) {
> > DRM_DEBUG_KMS("WRPLL1 using PCH SSC\n");
> > - pch_ssc_in_use = true;
> > + dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL1);
> > }
> >
> > if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL2)) {
> > DRM_DEBUG_KMS("WRPLL2 using PCH SSC\n");
> > - pch_ssc_in_use = true;
> > + dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL2);
> > }
> >
> > - if (pch_ssc_in_use)
> > + if (dev_priv->pch_ssc_use)
> > return;
> >
> > if (has_fdi) {
> > diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > index ec10fa7d3c69..3ce0a023eee0 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > @@ -526,16 +526,31 @@ static void hsw_ddi_wrpll_disable(struct drm_i915_private *dev_priv,
> > val = I915_READ(WRPLL_CTL(id));
> > I915_WRITE(WRPLL_CTL(id), val & ~WRPLL_PLL_ENABLE);
> > POSTING_READ(WRPLL_CTL(id));
> > +
> > + /*
> > + * Try to set up the PCH reference clock once all DPLLs
> > + * that depend on it have been shut down.
> > + */
> > + if (dev_priv->pch_ssc_use & BIT(id))
> > + intel_init_pch_refclk(dev_priv);
> > }
> >
> > static void hsw_ddi_spll_disable(struct drm_i915_private *dev_priv,
> > struct intel_shared_dpll *pll)
> > {
> > + enum intel_dpll_id id = pll->info->id;
> > u32 val;
> >
> > val = I915_READ(SPLL_CTL);
> > I915_WRITE(SPLL_CTL, val & ~SPLL_PLL_ENABLE);
> > POSTING_READ(SPLL_CTL);
> > +
> > + /*
> > + * Try to set up the PCH reference clock once all DPLLs
> > + * that depend on it have been shut down.
> > + */
> > + if (dev_priv->pch_ssc_use & BIT(id))
> > + intel_init_pch_refclk(dev_priv);
> > }
> >
> > static bool hsw_ddi_wrpll_get_hw_state(struct drm_i915_private *dev_priv,
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index 8882c0908c3b..5332825e0ce4 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -1348,6 +1348,8 @@ struct drm_i915_private {
> > } contexts;
> > } gem;
> >
> > + u8 pch_ssc_use;
> > +
> > /* For i915gm/i945gm vblank irq workaround */
> > u8 vblank_enabled;
> >
> > --
> > 2.21.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Fix PCH reference clock for FDI on HSW/BDW
@ 2019-10-25 17:24 ` Ville Syrjälä
0 siblings, 0 replies; 10+ messages in thread
From: Ville Syrjälä @ 2019-10-25 17:24 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx, stable, Andrija
On Wed, Oct 23, 2019 at 03:44:50PM +0300, Imre Deak wrote:
> On Tue, Oct 22, 2019 at 09:56:43PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > The change to skip the PCH reference initialization during fastboot
> > did end up breaking FDI. To fix that let's try to do the PCH reference
> > init whenever we're disabling a DPLL that was using said reference
> > previously.
> >
> > Cc: stable@vger.kernel.org
> > Tested-by: Andrija <akijo97@gmail.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=112084
> > Fixes: b16c7ed95caf ("drm/i915: Do not touch the PCH SSC reference if a PLL is using it")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
CI had some bsd fails which are not relevant, so pushed to dinq.
Thanks for the review.
>
> > ---
> > drivers/gpu/drm/i915/display/intel_display.c | 11 ++++++-----
> > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 15 +++++++++++++++
> > drivers/gpu/drm/i915/i915_drv.h | 2 ++
> > 3 files changed, 23 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > index 236fdf122e47..da76f794a965 100644
> > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > @@ -9359,7 +9359,6 @@ static bool wrpll_uses_pch_ssc(struct drm_i915_private *dev_priv,
> > static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
> > {
> > struct intel_encoder *encoder;
> > - bool pch_ssc_in_use = false;
> > bool has_fdi = false;
> >
> > for_each_intel_encoder(&dev_priv->drm, encoder) {
> > @@ -9387,22 +9386,24 @@ static void lpt_init_pch_refclk(struct drm_i915_private *dev_priv)
> > * clock hierarchy. That would also allow us to do
> > * clock bending finally.
> > */
> > + dev_priv->pch_ssc_use = 0;
> > +
> > if (spll_uses_pch_ssc(dev_priv)) {
> > DRM_DEBUG_KMS("SPLL using PCH SSC\n");
> > - pch_ssc_in_use = true;
> > + dev_priv->pch_ssc_use |= BIT(DPLL_ID_SPLL);
> > }
> >
> > if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL1)) {
> > DRM_DEBUG_KMS("WRPLL1 using PCH SSC\n");
> > - pch_ssc_in_use = true;
> > + dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL1);
> > }
> >
> > if (wrpll_uses_pch_ssc(dev_priv, DPLL_ID_WRPLL2)) {
> > DRM_DEBUG_KMS("WRPLL2 using PCH SSC\n");
> > - pch_ssc_in_use = true;
> > + dev_priv->pch_ssc_use |= BIT(DPLL_ID_WRPLL2);
> > }
> >
> > - if (pch_ssc_in_use)
> > + if (dev_priv->pch_ssc_use)
> > return;
> >
> > if (has_fdi) {
> > diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > index ec10fa7d3c69..3ce0a023eee0 100644
> > --- a/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > +++ b/drivers/gpu/drm/i915/display/intel_dpll_mgr.c
> > @@ -526,16 +526,31 @@ static void hsw_ddi_wrpll_disable(struct drm_i915_private *dev_priv,
> > val = I915_READ(WRPLL_CTL(id));
> > I915_WRITE(WRPLL_CTL(id), val & ~WRPLL_PLL_ENABLE);
> > POSTING_READ(WRPLL_CTL(id));
> > +
> > + /*
> > + * Try to set up the PCH reference clock once all DPLLs
> > + * that depend on it have been shut down.
> > + */
> > + if (dev_priv->pch_ssc_use & BIT(id))
> > + intel_init_pch_refclk(dev_priv);
> > }
> >
> > static void hsw_ddi_spll_disable(struct drm_i915_private *dev_priv,
> > struct intel_shared_dpll *pll)
> > {
> > + enum intel_dpll_id id = pll->info->id;
> > u32 val;
> >
> > val = I915_READ(SPLL_CTL);
> > I915_WRITE(SPLL_CTL, val & ~SPLL_PLL_ENABLE);
> > POSTING_READ(SPLL_CTL);
> > +
> > + /*
> > + * Try to set up the PCH reference clock once all DPLLs
> > + * that depend on it have been shut down.
> > + */
> > + if (dev_priv->pch_ssc_use & BIT(id))
> > + intel_init_pch_refclk(dev_priv);
> > }
> >
> > static bool hsw_ddi_wrpll_get_hw_state(struct drm_i915_private *dev_priv,
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> > index 8882c0908c3b..5332825e0ce4 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -1348,6 +1348,8 @@ struct drm_i915_private {
> > } contexts;
> > } gem;
> >
> > + u8 pch_ssc_use;
> > +
> > /* For i915gm/i945gm vblank irq workaround */
> > u8 vblank_enabled;
> >
> > --
> > 2.21.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-10-25 17:24 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 18:56 [PATCH] drm/i915: Fix PCH reference clock for FDI on HSW/BDW Ville Syrjala
2019-10-23 1:17 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-23 12:44 ` [Intel-gfx] [PATCH] " Imre Deak
2019-10-23 12:44 ` Imre Deak
2019-10-25 17:24 ` Ville Syrjälä
2019-10-25 17:24 ` Ville Syrjälä
2019-10-24 1:48 ` ✓ Fi.CI.BAT: success for drm/i915: Fix PCH reference clock for FDI on HSW/BDW (rev2) Patchwork
2019-10-24 1:48 ` [Intel-gfx] " Patchwork
2019-10-24 23:35 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-10-24 23:35 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.