From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Max Gurtovoy <maxg@mellanox.com>,
Stephen Bates <sbates@raithlin.com>,
Logan Gunthorpe <logang@deltatee.com>
Subject: [PATCH 0/7] Remove data_len field from the nvmet_req struct
Date: Wed, 23 Oct 2019 10:35:38 -0600 [thread overview]
Message-ID: <20191023163545.4193-1-logang@deltatee.com> (raw)
Hi,
This patchset is a cleanup in preparation for the passthru patchset.
The aim is to remove the data_len field in the nvmet_req struct and
instead just check the length is appropriate inside the execute
handlers. This is more appropriate for passthru which may have
commands with unknown lengths (like Vendor Specific Commands).
It's also in improvement seeing it can often be confusing when
it's best to use the data_len field over the transfer_len field.
The first two patches in this series remove some questionable uses
of the data_len field in nvmt-tcp
Most of this patchset was extracted from a draft patch from
Christoph[1].
The series is based on v5.4-rc4 and a git branch is available here:
https://github.com/sbates130272/linux-p2pmem/branches nvmet_data_len
Logan
[1] https://lore.kernel.org/linux-block/20191010110425.GA28372@lst.de/
--
Logan Gunthorpe (7):
nvmet-tcp: Don't check data_len in nvmet_tcp_map_data()
nvmet-tcp: Don't set the request's data_len
nvmet: Introduce common execute function for get_log_page and identify
nvmet: Cleanup discovery execute handlers
nvmet: Introduce nvmet_dsm_len() helper
nvmet: Remove the data_len field from the nvmet_req struct
nvmet: Open code nvmet_req_execute()
drivers/nvme/target/admin-cmd.c | 128 +++++++++++++++++-------------
drivers/nvme/target/core.c | 12 +--
drivers/nvme/target/discovery.c | 62 +++++++--------
drivers/nvme/target/fabrics-cmd.c | 15 +++-
drivers/nvme/target/fc.c | 4 +-
drivers/nvme/target/io-cmd-bdev.c | 19 +++--
drivers/nvme/target/io-cmd-file.c | 20 +++--
drivers/nvme/target/loop.c | 2 +-
drivers/nvme/target/nvmet.h | 10 ++-
drivers/nvme/target/rdma.c | 4 +-
drivers/nvme/target/tcp.c | 14 ++--
11 files changed, 167 insertions(+), 123 deletions(-)
--
2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: Logan Gunthorpe <logang@deltatee.com>
To: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Cc: Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Stephen Bates <sbates@raithlin.com>,
Max Gurtovoy <maxg@mellanox.com>,
Logan Gunthorpe <logang@deltatee.com>,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH 0/7] Remove data_len field from the nvmet_req struct
Date: Wed, 23 Oct 2019 10:35:38 -0600 [thread overview]
Message-ID: <20191023163545.4193-1-logang@deltatee.com> (raw)
Hi,
This patchset is a cleanup in preparation for the passthru patchset.
The aim is to remove the data_len field in the nvmet_req struct and
instead just check the length is appropriate inside the execute
handlers. This is more appropriate for passthru which may have
commands with unknown lengths (like Vendor Specific Commands).
It's also in improvement seeing it can often be confusing when
it's best to use the data_len field over the transfer_len field.
The first two patches in this series remove some questionable uses
of the data_len field in nvmt-tcp
Most of this patchset was extracted from a draft patch from
Christoph[1].
The series is based on v5.4-rc4 and a git branch is available here:
https://github.com/sbates130272/linux-p2pmem/branches nvmet_data_len
Logan
[1] https://lore.kernel.org/linux-block/20191010110425.GA28372@lst.de/
--
Logan Gunthorpe (7):
nvmet-tcp: Don't check data_len in nvmet_tcp_map_data()
nvmet-tcp: Don't set the request's data_len
nvmet: Introduce common execute function for get_log_page and identify
nvmet: Cleanup discovery execute handlers
nvmet: Introduce nvmet_dsm_len() helper
nvmet: Remove the data_len field from the nvmet_req struct
nvmet: Open code nvmet_req_execute()
drivers/nvme/target/admin-cmd.c | 128 +++++++++++++++++-------------
drivers/nvme/target/core.c | 12 +--
drivers/nvme/target/discovery.c | 62 +++++++--------
drivers/nvme/target/fabrics-cmd.c | 15 +++-
drivers/nvme/target/fc.c | 4 +-
drivers/nvme/target/io-cmd-bdev.c | 19 +++--
drivers/nvme/target/io-cmd-file.c | 20 +++--
drivers/nvme/target/loop.c | 2 +-
drivers/nvme/target/nvmet.h | 10 ++-
drivers/nvme/target/rdma.c | 4 +-
drivers/nvme/target/tcp.c | 14 ++--
11 files changed, 167 insertions(+), 123 deletions(-)
--
2.20.1
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next reply other threads:[~2019-10-23 16:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 16:35 Logan Gunthorpe [this message]
2019-10-23 16:35 ` [PATCH 0/7] Remove data_len field from the nvmet_req struct Logan Gunthorpe
2019-10-23 16:35 ` [PATCH 1/7] nvmet-tcp: Don't check data_len in nvmet_tcp_map_data() Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-24 1:15 ` Christoph Hellwig
2019-10-24 1:15 ` Christoph Hellwig
2019-10-23 16:35 ` [PATCH 2/7] nvmet-tcp: Don't set the request's data_len Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-24 1:15 ` Christoph Hellwig
2019-10-24 1:15 ` Christoph Hellwig
2019-10-23 16:35 ` [PATCH 3/7] nvmet: Introduce common execute function for get_log_page and identify Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 20:31 ` Chaitanya Kulkarni
2019-10-23 20:31 ` Chaitanya Kulkarni
2019-10-24 1:17 ` Christoph Hellwig
2019-10-24 1:17 ` Christoph Hellwig
2019-10-24 17:18 ` Logan Gunthorpe
2019-10-24 17:18 ` Logan Gunthorpe
2019-10-24 22:01 ` Keith Busch
2019-10-24 22:01 ` Keith Busch
2019-10-24 22:40 ` Logan Gunthorpe
2019-10-24 22:40 ` Logan Gunthorpe
2019-10-23 16:35 ` [PATCH 4/7] nvmet: Cleanup discovery execute handlers Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 16:35 ` [PATCH 5/7] nvmet: Introduce nvmet_dsm_len() helper Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 20:31 ` Chaitanya Kulkarni
2019-10-23 20:31 ` Chaitanya Kulkarni
2019-10-23 16:35 ` [PATCH 6/7] nvmet: Remove the data_len field from the nvmet_req struct Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 16:35 ` [PATCH 7/7] nvmet: Open code nvmet_req_execute() Logan Gunthorpe
2019-10-23 16:35 ` Logan Gunthorpe
2019-10-23 20:34 ` Chaitanya Kulkarni
2019-10-23 20:34 ` Chaitanya Kulkarni
2019-10-25 0:20 ` [PATCH 0/7] Remove data_len field from the nvmet_req struct Keith Busch
2019-10-25 0:20 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023163545.4193-1-logang@deltatee.com \
--to=logang@deltatee.com \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.