Re: [PATCH v1 1/1] scsi: ufs: Add command logging infrastructure

From: kbuild test robot <lkp@intel.com>
To: Can Guo <cang@codeaurora.org>
Cc: kbuild-all@lists.01.org, asutoshd@codeaurora.org,
	nguyenb@codeaurora.org, rnayak@codeaurora.org,
	linux-scsi@vger.kernel.org, kernel-team@android.com,
	saravanak@google.com, salyzyn@google.com, cang@codeaurora.org,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	Pedro Sousa <pedrom.sousa@synopsys.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Evan Green <evgreen@chromium.org>, Janek Kotas <jank@cadence.com>,
	Stanley Chu <stanley.chu@mediatek.com>,
	Bean Huo <beanhuo@micron.com>,
	Tomas Winkler <tomas.winkler@intel.com>,
	Subhash Jadavani <subhashj@codeaurora.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/1] scsi: ufs: Add command logging infrastructure
Date: Wed, 23 Oct 2019 17:33:58 +0800	[thread overview]
Message-ID: <201910231712.llsn23Ol%lkp@intel.com> (raw)
In-Reply-To: <1571808560-3965-1-git-send-email-cang@codeaurora.org>

[-- Attachment #1: Type: text/plain, Size: 2634 bytes --]

Hi Can,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on scsi/for-next]
[cannot apply to v5.4-rc4 next-20191023]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Can-Guo/scsi-ufs-Add-command-logging-infrastructure/20191023-151035
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
config: x86_64-rhel (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from drivers/scsi/ufs/ufshcd.c:45:0:
>> drivers/scsi/ufs/ufshcd.h:426:10: error: 'UFS_ERR_REG_HIST_LENGTH' undeclared here (not in a function); did you mean 'UIC_ERR_REG_HIST_LENGTH'?
     u32 reg[UFS_ERR_REG_HIST_LENGTH];
             ^~~~~~~~~~~~~~~~~~~~~~~
             UIC_ERR_REG_HIST_LENGTH

vim +426 drivers/scsi/ufs/ufshcd.h

3a4bf06d1f6d7d Yaniv Gardi 2014-09-25  416  
7425e502f13960 Can Guo     2019-10-22  417  #define UIC_ERR_REG_HIST_LENGTH 20
ff8e20c6624921 Dolev Raviv 2016-12-22  418  /**
d3c615bf586f27 Stanley Chu 2019-07-10  419   * struct ufs_err_reg_hist - keeps history of errors
ff8e20c6624921 Dolev Raviv 2016-12-22  420   * @pos: index to indicate cyclic buffer position
ff8e20c6624921 Dolev Raviv 2016-12-22  421   * @reg: cyclic buffer for registers value
ff8e20c6624921 Dolev Raviv 2016-12-22  422   * @tstamp: cyclic buffer for time stamp
ff8e20c6624921 Dolev Raviv 2016-12-22  423   */
48d5b9732580bc Stanley Chu 2019-07-10  424  struct ufs_err_reg_hist {
ff8e20c6624921 Dolev Raviv 2016-12-22  425  	int pos;
48d5b9732580bc Stanley Chu 2019-07-10 @426  	u32 reg[UFS_ERR_REG_HIST_LENGTH];
48d5b9732580bc Stanley Chu 2019-07-10  427  	ktime_t tstamp[UFS_ERR_REG_HIST_LENGTH];
ff8e20c6624921 Dolev Raviv 2016-12-22  428  };
ff8e20c6624921 Dolev Raviv 2016-12-22  429  

:::::: The code at line 426 was first introduced by commit
:::::: 48d5b9732580bca18fed9ef20da8aa210c646755 scsi: ufs: Change names related to error history

:::::: TO: Stanley Chu <stanley.chu@mediatek.com>
:::::: CC: Martin K. Petersen <martin.petersen@oracle.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 43803 bytes --]