* [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-24 16:29 ` don.hiatt
0 siblings, 0 replies; 20+ messages in thread
From: don.hiatt @ 2019-10-24 16:29 UTC (permalink / raw)
To: intel-gfx
From: Don Hiatt <don.hiatt@intel.com>
Check to see if GuC submission is enabled before requesting the
EXIT_S_STATE action.
On some platforms (e.g. KBL) that do not support GuC submission, but
the user enabled the GuC communication (e.g for HuC authentication)
calling the GuC EXIT_S_STATE action results in lose of ability to
enter RC6. Guard against this by only requesting the GuC action on
platforms that support GuC submission.
I've verfied that intel_guc_resume() only gets called when driver
is loaded with: guc_enable={1,2,3}, all other cases (no args,
guc_enable={0,-1} the intel_guc_resume() is not called.
Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 37f7bcbf7dac..33318ed135c0 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
GUC_POWER_D0,
};
- return intel_guc_send(guc, action, ARRAY_SIZE(action));
+ if (guc->submission_supported)
+ return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+ return 0;
}
/**
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-24 16:29 ` don.hiatt
0 siblings, 0 replies; 20+ messages in thread
From: don.hiatt @ 2019-10-24 16:29 UTC (permalink / raw)
To: intel-gfx
From: Don Hiatt <don.hiatt@intel.com>
Check to see if GuC submission is enabled before requesting the
EXIT_S_STATE action.
On some platforms (e.g. KBL) that do not support GuC submission, but
the user enabled the GuC communication (e.g for HuC authentication)
calling the GuC EXIT_S_STATE action results in lose of ability to
enter RC6. Guard against this by only requesting the GuC action on
platforms that support GuC submission.
I've verfied that intel_guc_resume() only gets called when driver
is loaded with: guc_enable={1,2,3}, all other cases (no args,
guc_enable={0,-1} the intel_guc_resume() is not called.
Signed-off-by: Don Hiatt <don.hiatt@intel.com>
---
drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
index 37f7bcbf7dac..33318ed135c0 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
@@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
GUC_POWER_D0,
};
- return intel_guc_send(guc, action, ARRAY_SIZE(action));
+ if (guc->submission_supported)
+ return intel_guc_send(guc, action, ARRAY_SIZE(action));
+
+ return 0;
}
/**
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-24 18:27 ` Summers, Stuart
0 siblings, 0 replies; 20+ messages in thread
From: Summers, Stuart @ 2019-10-24 18:27 UTC (permalink / raw)
To: Hiatt, Don, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1804 bytes --]
On Thu, 2019-10-24 at 09:29 -0700, don.hiatt@intel.com wrote:
> From: Don Hiatt <don.hiatt@intel.com>
>
> Check to see if GuC submission is enabled before requesting the
> EXIT_S_STATE action.
>
> On some platforms (e.g. KBL) that do not support GuC submission, but
> the user enabled the GuC communication (e.g for HuC authentication)
> calling the GuC EXIT_S_STATE action results in lose of ability to
> enter RC6. Guard against this by only requesting the GuC action on
> platforms that support GuC submission.
>
> I've verfied that intel_guc_resume() only gets called when driver
> is loaded with: guc_enable={1,2,3}, all other cases (no args,
> guc_enable={0,-1} the intel_guc_resume() is not called.
>
> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 37f7bcbf7dac..33318ed135c0 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> GUC_POWER_D0,
> };
>
> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> + if (guc->submission_supported)
Hey Don,
I might be missing something here, but glancing over the code for
submission_supported, it looks like this relies on the availability of
the firmware for the intended platform. Looking at the GuC table for
KBL, I do see this present (using KBL per your commit above). So
wouldn't this return true here if enable_guc is set to 1 or 3?
Thanks,
Stuart
> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> +
> + return 0;
> }
>
> /**
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-24 18:27 ` Summers, Stuart
0 siblings, 0 replies; 20+ messages in thread
From: Summers, Stuart @ 2019-10-24 18:27 UTC (permalink / raw)
To: Hiatt, Don, intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 1804 bytes --]
On Thu, 2019-10-24 at 09:29 -0700, don.hiatt@intel.com wrote:
> From: Don Hiatt <don.hiatt@intel.com>
>
> Check to see if GuC submission is enabled before requesting the
> EXIT_S_STATE action.
>
> On some platforms (e.g. KBL) that do not support GuC submission, but
> the user enabled the GuC communication (e.g for HuC authentication)
> calling the GuC EXIT_S_STATE action results in lose of ability to
> enter RC6. Guard against this by only requesting the GuC action on
> platforms that support GuC submission.
>
> I've verfied that intel_guc_resume() only gets called when driver
> is loaded with: guc_enable={1,2,3}, all other cases (no args,
> guc_enable={0,-1} the intel_guc_resume() is not called.
>
> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 37f7bcbf7dac..33318ed135c0 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> GUC_POWER_D0,
> };
>
> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> + if (guc->submission_supported)
Hey Don,
I might be missing something here, but glancing over the code for
submission_supported, it looks like this relies on the availability of
the firmware for the intended platform. Looking at the GuC table for
KBL, I do see this present (using KBL per your commit above). So
wouldn't this return true here if enable_guc is set to 1 or 3?
Thanks,
Stuart
> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> +
> + return 0;
> }
>
> /**
[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-24 20:10 ` Hiatt, Don
0 siblings, 0 replies; 20+ messages in thread
From: Hiatt, Don @ 2019-10-24 20:10 UTC (permalink / raw)
To: Summers, Stuart, intel-gfx
> On Thu, 2019-10-24 at 09:29 -0700, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > Check to see if GuC submission is enabled before requesting the
> > EXIT_S_STATE action.
> >
> > On some platforms (e.g. KBL) that do not support GuC submission, but
> > the user enabled the GuC communication (e.g for HuC authentication)
> > calling the GuC EXIT_S_STATE action results in lose of ability to
> > enter RC6. Guard against this by only requesting the GuC action on
> > platforms that support GuC submission.
> >
> > I've verfied that intel_guc_resume() only gets called when driver
> > is loaded with: guc_enable={1,2,3}, all other cases (no args,
> > guc_enable={0,-1} the intel_guc_resume() is not called.
> >
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > index 37f7bcbf7dac..33318ed135c0 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> > GUC_POWER_D0,
> > };
> >
> > - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > + if (guc->submission_supported)
>
> Hey Don,
>
> I might be missing something here, but glancing over the code for
> submission_supported, it looks like this relies on the availability of
> the firmware for the intended platform. Looking at the GuC table for
> KBL, I do see this present (using KBL per your commit above). So
> wouldn't this return true here if enable_guc is set to 1 or 3?
>
> Thanks,
> Stuart
Hi Stuart,
KBL does not support GuC submission, just HuC authentication. I've instrumented
the code and verified that all guc->submission_supported is always false when guc_enable
is set for KBL.
Thanks,
don
>
> > + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > +
> > + return 0;
> > }
> >
> > /**
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-24 20:10 ` Hiatt, Don
0 siblings, 0 replies; 20+ messages in thread
From: Hiatt, Don @ 2019-10-24 20:10 UTC (permalink / raw)
To: Summers, Stuart, intel-gfx
> On Thu, 2019-10-24 at 09:29 -0700, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > Check to see if GuC submission is enabled before requesting the
> > EXIT_S_STATE action.
> >
> > On some platforms (e.g. KBL) that do not support GuC submission, but
> > the user enabled the GuC communication (e.g for HuC authentication)
> > calling the GuC EXIT_S_STATE action results in lose of ability to
> > enter RC6. Guard against this by only requesting the GuC action on
> > platforms that support GuC submission.
> >
> > I've verfied that intel_guc_resume() only gets called when driver
> > is loaded with: guc_enable={1,2,3}, all other cases (no args,
> > guc_enable={0,-1} the intel_guc_resume() is not called.
> >
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > index 37f7bcbf7dac..33318ed135c0 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> > GUC_POWER_D0,
> > };
> >
> > - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > + if (guc->submission_supported)
>
> Hey Don,
>
> I might be missing something here, but glancing over the code for
> submission_supported, it looks like this relies on the availability of
> the firmware for the intended platform. Looking at the GuC table for
> KBL, I do see this present (using KBL per your commit above). So
> wouldn't this return true here if enable_guc is set to 1 or 3?
>
> Thanks,
> Stuart
Hi Stuart,
KBL does not support GuC submission, just HuC authentication. I've instrumented
the code and verified that all guc->submission_supported is always false when guc_enable
is set for KBL.
Thanks,
don
>
> > + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > +
> > + return 0;
> > }
> >
> > /**
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-24 20:43 ` Patchwork
0 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-10-24 20:43 UTC (permalink / raw)
To: Hiatt, Don; +Cc: intel-gfx
== Series Details ==
Series: drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
URL : https://patchwork.freedesktop.org/series/68526/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7175 -> Patchwork_14971
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/index.html
Known issues
------------
Here are the changes found in Patchwork_14971 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][1] -> [DMESG-WARN][2] ([fdo#102614])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
* igt@prime_vgem@basic-wait-default:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
#### Possible fixes ####
* igt@gem_basic@create-close:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-icl-u3/igt@gem_basic@create-close.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-icl-u3/igt@gem_basic@create-close.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8109u: [DMESG-FAIL][7] ([fdo#112050 ]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html
* igt@kms_busy@basic-flip-a:
- {fi-tgl-u2}: [DMESG-WARN][9] ([fdo#111600]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-7500u: [WARN][11] ([fdo#109483]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][13] ([fdo#111407]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111831]: https://bugs.freedesktop.org/show_bug.cgi?id=111831
[fdo#112050 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112050
Participating hosts (51 -> 43)
------------------------------
Additional (1): fi-tgl-u
Missing (9): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7175 -> Patchwork_14971
CI-20190529: 20190529
CI_DRM_7175: 29ffd6b6aac24cdf361aa11a5a18e2ebc95b3180 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5237: 9a46404de7c42c8cc2d492176e956597ef28d7c4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14971: ec048a07dfe678ac7728c210ed859f9c08a19efc @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ec048a07dfe6 drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-24 20:43 ` Patchwork
0 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-10-24 20:43 UTC (permalink / raw)
To: Hiatt, Don; +Cc: intel-gfx
== Series Details ==
Series: drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
URL : https://patchwork.freedesktop.org/series/68526/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7175 -> Patchwork_14971
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/index.html
Known issues
------------
Here are the changes found in Patchwork_14971 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_frontbuffer_tracking@basic:
- fi-hsw-peppy: [PASS][1] -> [DMESG-WARN][2] ([fdo#102614])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
* igt@prime_vgem@basic-wait-default:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
#### Possible fixes ####
* igt@gem_basic@create-close:
- fi-icl-u3: [DMESG-WARN][5] ([fdo#107724]) -> [PASS][6] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-icl-u3/igt@gem_basic@create-close.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-icl-u3/igt@gem_basic@create-close.html
* igt@i915_selftest@live_gem_contexts:
- fi-cfl-8109u: [DMESG-FAIL][7] ([fdo#112050 ]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-cfl-8109u/igt@i915_selftest@live_gem_contexts.html
* igt@kms_busy@basic-flip-a:
- {fi-tgl-u2}: [DMESG-WARN][9] ([fdo#111600]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-tgl-u2/igt@kms_busy@basic-flip-a.html
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-7500u: [WARN][11] ([fdo#109483]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-kbl-7500u/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][13] ([fdo#111407]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109483]: https://bugs.freedesktop.org/show_bug.cgi?id=109483
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111600]: https://bugs.freedesktop.org/show_bug.cgi?id=111600
[fdo#111831]: https://bugs.freedesktop.org/show_bug.cgi?id=111831
[fdo#112050 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112050
Participating hosts (51 -> 43)
------------------------------
Additional (1): fi-tgl-u
Missing (9): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-pnv-d510 fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7175 -> Patchwork_14971
CI-20190529: 20190529
CI_DRM_7175: 29ffd6b6aac24cdf361aa11a5a18e2ebc95b3180 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5237: 9a46404de7c42c8cc2d492176e956597ef28d7c4 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14971: ec048a07dfe678ac7728c210ed859f9c08a19efc @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
ec048a07dfe6 drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-26 5:53 ` Patchwork
0 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-10-26 5:53 UTC (permalink / raw)
To: Hiatt, Don; +Cc: intel-gfx
== Series Details ==
Series: drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
URL : https://patchwork.freedesktop.org/series/68526/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7175_full -> Patchwork_14971_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14971_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14971_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14971_full:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- shard-kbl: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_14971_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][2] -> [SKIP][3] ([fdo#112080]) +12 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb1/igt@gem_busy@busy-vcs1.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@vcs1-dirty-switch:
- shard-iclb: [PASS][4] -> [SKIP][5] ([fdo#109276] / [fdo#112080])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb1/igt@gem_ctx_isolation@vcs1-dirty-switch.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@gem_ctx_isolation@vcs1-dirty-switch.html
* igt@gem_exec_reuse@contexts:
- shard-kbl: [PASS][6] -> [DMESG-WARN][7] ([fdo#105604] / [fdo#105763])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl2/igt@gem_exec_reuse@contexts.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@gem_exec_reuse@contexts.html
* igt@gem_exec_schedule@preempt-queue-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#111325]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-snb: [PASS][10] -> [DMESG-WARN][11] ([fdo#102365])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb7/igt@gem_exec_suspend@basic-s3.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb1/igt@gem_exec_suspend@basic-s3.html
- shard-skl: [PASS][12] -> [INCOMPLETE][13] ([fdo#104108])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl6/igt@gem_exec_suspend@basic-s3.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl7/igt@gem_exec_suspend@basic-s3.html
* igt@gem_linear_blits@normal:
- shard-apl: [PASS][14] -> [INCOMPLETE][15] ([fdo#103927])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl6/igt@gem_linear_blits@normal.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl1/igt@gem_linear_blits@normal.html
* igt@gem_mmap_gtt@hang:
- shard-snb: [PASS][16] -> [INCOMPLETE][17] ([fdo#105411])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb5/igt@gem_mmap_gtt@hang.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb7/igt@gem_mmap_gtt@hang.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-kbl: [PASS][18] -> [TIMEOUT][19] ([fdo#112068 ])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl7/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][20] -> [DMESG-WARN][21] ([fdo#111870])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [PASS][22] -> [DMESG-WARN][23] ([fdo#111870])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb1/igt@gem_userptr_blits@sync-unmap-after-close.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb4/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [PASS][24] -> [DMESG-FAIL][25] ([fdo#111991])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw1/igt@i915_selftest@live_hangcheck.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw1/igt@i915_selftest@live_hangcheck.html
* igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing:
- shard-hsw: [PASS][26] -> [INCOMPLETE][27] ([fdo#103540])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw1/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw4/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing.html
* igt@kms_color@pipe-c-ctm-max:
- shard-skl: [PASS][28] -> [FAIL][29] ([fdo#108147])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl5/igt@kms_color@pipe-c-ctm-max.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl6/igt@kms_color@pipe-c-ctm-max.html
* igt@kms_cursor_crc@pipe-a-cursor-64x21-random:
- shard-skl: [PASS][30] -> [FAIL][31] ([fdo#103232])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][32] -> [FAIL][33] ([fdo#105363])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl1/igt@kms_flip@flip-vs-expired-vblank.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][34] -> [DMESG-WARN][35] ([fdo#108566]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: [PASS][36] -> [FAIL][37] ([fdo#103167]) +4 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_lease@page_flip_implicit_plane:
- shard-iclb: [PASS][38] -> [INCOMPLETE][39] ([fdo#107713])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb5/igt@kms_lease@page_flip_implicit_plane.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb7/igt@kms_lease@page_flip_implicit_plane.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][40] -> [DMESG-WARN][41] ([fdo#108566]) +4 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][42] -> [FAIL][43] ([fdo#108145]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][44] -> [FAIL][45] ([fdo#108145] / [fdo#110403])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][46] -> [SKIP][47] ([fdo#109642] / [fdo#111068])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][48] -> [SKIP][49] ([fdo#109441]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_psr@psr2_basic.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb1/igt@kms_psr@psr2_basic.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#109276]) +12 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][52] ([fdo#108566]) -> [PASS][53] +6 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl4/igt@gem_ctx_isolation@rcs0-s3.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][54] ([fdo#109276] / [fdo#112080]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_ctx_switch@vcs1-heavy-queue:
- shard-iclb: [SKIP][56] ([fdo#112080]) -> [PASS][57] +8 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb8/igt@gem_ctx_switch@vcs1-heavy-queue.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy-queue.html
* igt@gem_eio@reset-stress:
- shard-snb: [FAIL][58] ([fdo#109661]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb4/igt@gem_eio@reset-stress.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb5/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][60] ([fdo#110854]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb3/igt@gem_exec_balancer@smoke.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@deep-render:
- shard-apl: [INCOMPLETE][62] ([fdo#103927]) -> [PASS][63] +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl6/igt@gem_exec_schedule@deep-render.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl1/igt@gem_exec_schedule@deep-render.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][64] ([fdo#109276]) -> [PASS][65] +15 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][66] ([fdo#111325]) -> [PASS][67] +5 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- {shard-tglb}: [TIMEOUT][68] ([fdo#112068 ]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][70] ([fdo#104108]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl4/igt@gem_softpin@noreloc-s3.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl8/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [DMESG-WARN][72] ([fdo#111870]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw7/igt@gem_userptr_blits@dmabuf-unsync.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw6/igt@gem_userptr_blits@dmabuf-unsync.html
- shard-snb: [DMESG-WARN][74] ([fdo#111870]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb7/igt@gem_userptr_blits@dmabuf-unsync.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb1/igt@gem_userptr_blits@dmabuf-unsync.html
* {igt@i915_pm_dc@dc6-psr}:
- shard-iclb: [FAIL][76] ([fdo#110548]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@universal-planes:
- shard-kbl: [DMESG-WARN][78] ([fdo#103313]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl2/igt@i915_pm_rpm@universal-planes.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@i915_pm_rpm@universal-planes.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [DMESG-WARN][80] ([fdo#106107]) -> [PASS][81] +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl3/igt@kms_color@pipe-a-ctm-0-5.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled:
- {shard-tglb}: [INCOMPLETE][82] ([fdo#111747]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb4/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb3/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [INCOMPLETE][84] ([fdo#109507]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl8/igt@kms_flip@flip-vs-suspend.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- {shard-tglb}: [FAIL][86] ([fdo#103167]) -> [PASS][87] +3 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- {shard-tglb}: [INCOMPLETE][88] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- {shard-tglb}: [INCOMPLETE][90] ([fdo#111884]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][92] ([fdo#103167]) -> [PASS][93] +7 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [FAIL][94] ([fdo#103167] / [fdo#110378]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][96] ([fdo#108145]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][98] ([fdo#108341]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb1/igt@kms_psr@no_drrs.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][100] ([fdo#109441]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_rotation_crc@primary-x-tiled-reflect-x-0:
- shard-iclb: [INCOMPLETE][102] ([fdo#107713] / [fdo#110026]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb7/igt@kms_rotation_crc@primary-x-tiled-reflect-x-0.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb7/igt@kms_rotation_crc@primary-x-tiled-reflect-x-0.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][104] ([fdo#99912]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl3/igt@kms_setmode@basic.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl2/igt@kms_setmode@basic.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][106] ([fdo#109276] / [fdo#112080]) -> [FAIL][107] ([fdo#111329])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb3/igt@gem_ctx_isolation@vcs1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-26 5:53 ` Patchwork
0 siblings, 0 replies; 20+ messages in thread
From: Patchwork @ 2019-10-26 5:53 UTC (permalink / raw)
To: Hiatt, Don; +Cc: intel-gfx
== Series Details ==
Series: drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
URL : https://patchwork.freedesktop.org/series/68526/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7175_full -> Patchwork_14971_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14971_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14971_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14971_full:
### IGT changes ###
#### Possible regressions ####
* igt@runner@aborted:
- shard-kbl: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@runner@aborted.html
Known issues
------------
Here are the changes found in Patchwork_14971_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [PASS][2] -> [SKIP][3] ([fdo#112080]) +12 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb1/igt@gem_busy@busy-vcs1.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@gem_busy@busy-vcs1.html
* igt@gem_ctx_isolation@vcs1-dirty-switch:
- shard-iclb: [PASS][4] -> [SKIP][5] ([fdo#109276] / [fdo#112080])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb1/igt@gem_ctx_isolation@vcs1-dirty-switch.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@gem_ctx_isolation@vcs1-dirty-switch.html
* igt@gem_exec_reuse@contexts:
- shard-kbl: [PASS][6] -> [DMESG-WARN][7] ([fdo#105604] / [fdo#105763])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl2/igt@gem_exec_reuse@contexts.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@gem_exec_reuse@contexts.html
* igt@gem_exec_schedule@preempt-queue-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#111325]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb5/igt@gem_exec_schedule@preempt-queue-bsd.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd.html
* igt@gem_exec_suspend@basic-s3:
- shard-snb: [PASS][10] -> [DMESG-WARN][11] ([fdo#102365])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb7/igt@gem_exec_suspend@basic-s3.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb1/igt@gem_exec_suspend@basic-s3.html
- shard-skl: [PASS][12] -> [INCOMPLETE][13] ([fdo#104108])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl6/igt@gem_exec_suspend@basic-s3.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl7/igt@gem_exec_suspend@basic-s3.html
* igt@gem_linear_blits@normal:
- shard-apl: [PASS][14] -> [INCOMPLETE][15] ([fdo#103927])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl6/igt@gem_linear_blits@normal.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl1/igt@gem_linear_blits@normal.html
* igt@gem_mmap_gtt@hang:
- shard-snb: [PASS][16] -> [INCOMPLETE][17] ([fdo#105411])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb5/igt@gem_mmap_gtt@hang.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb7/igt@gem_mmap_gtt@hang.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-kbl: [PASS][18] -> [TIMEOUT][19] ([fdo#112068 ])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl7/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][20] -> [DMESG-WARN][21] ([fdo#111870])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw8/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@sync-unmap-after-close:
- shard-snb: [PASS][22] -> [DMESG-WARN][23] ([fdo#111870])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb1/igt@gem_userptr_blits@sync-unmap-after-close.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb4/igt@gem_userptr_blits@sync-unmap-after-close.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [PASS][24] -> [DMESG-FAIL][25] ([fdo#111991])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw1/igt@i915_selftest@live_hangcheck.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw1/igt@i915_selftest@live_hangcheck.html
* igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing:
- shard-hsw: [PASS][26] -> [INCOMPLETE][27] ([fdo#103540])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw1/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw4/igt@kms_atomic_transition@2x-modeset-transitions-nonblocking-fencing.html
* igt@kms_color@pipe-c-ctm-max:
- shard-skl: [PASS][28] -> [FAIL][29] ([fdo#108147])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl5/igt@kms_color@pipe-c-ctm-max.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl6/igt@kms_color@pipe-c-ctm-max.html
* igt@kms_cursor_crc@pipe-a-cursor-64x21-random:
- shard-skl: [PASS][30] -> [FAIL][31] ([fdo#103232])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl6/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl8/igt@kms_cursor_crc@pipe-a-cursor-64x21-random.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-skl: [PASS][32] -> [FAIL][33] ([fdo#105363])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl1/igt@kms_flip@flip-vs-expired-vblank.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl7/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [PASS][34] -> [DMESG-WARN][35] ([fdo#108566]) +2 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl4/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt:
- shard-iclb: [PASS][36] -> [FAIL][37] ([fdo#103167]) +4 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_lease@page_flip_implicit_plane:
- shard-iclb: [PASS][38] -> [INCOMPLETE][39] ([fdo#107713])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb5/igt@kms_lease@page_flip_implicit_plane.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb7/igt@kms_lease@page_flip_implicit_plane.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][40] -> [DMESG-WARN][41] ([fdo#108566]) +4 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][42] -> [FAIL][43] ([fdo#108145]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl3/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl9/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [PASS][44] -> [FAIL][45] ([fdo#108145] / [fdo#110403])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr2_su@frontbuffer:
- shard-iclb: [PASS][46] -> [SKIP][47] ([fdo#109642] / [fdo#111068])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_psr2_su@frontbuffer.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@kms_psr2_su@frontbuffer.html
* igt@kms_psr@psr2_basic:
- shard-iclb: [PASS][48] -> [SKIP][49] ([fdo#109441]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_psr@psr2_basic.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb1/igt@kms_psr@psr2_basic.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][50] -> [SKIP][51] ([fdo#109276]) +12 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@prime_vgem@fence-wait-bsd2.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_isolation@rcs0-s3:
- shard-kbl: [DMESG-WARN][52] ([fdo#108566]) -> [PASS][53] +6 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl4/igt@gem_ctx_isolation@rcs0-s3.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl6/igt@gem_ctx_isolation@rcs0-s3.html
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [SKIP][54] ([fdo#109276] / [fdo#112080]) -> [PASS][55] +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_ctx_switch@vcs1-heavy-queue:
- shard-iclb: [SKIP][56] ([fdo#112080]) -> [PASS][57] +8 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb8/igt@gem_ctx_switch@vcs1-heavy-queue.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy-queue.html
* igt@gem_eio@reset-stress:
- shard-snb: [FAIL][58] ([fdo#109661]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb4/igt@gem_eio@reset-stress.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb5/igt@gem_eio@reset-stress.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][60] ([fdo#110854]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb3/igt@gem_exec_balancer@smoke.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb1/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@deep-render:
- shard-apl: [INCOMPLETE][62] ([fdo#103927]) -> [PASS][63] +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl6/igt@gem_exec_schedule@deep-render.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl1/igt@gem_exec_schedule@deep-render.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][64] ([fdo#109276]) -> [PASS][65] +15 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@preemptive-hang-bsd:
- shard-iclb: [SKIP][66] ([fdo#111325]) -> [PASS][67] +5 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb4/igt@gem_exec_schedule@preemptive-hang-bsd.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb5/igt@gem_exec_schedule@preemptive-hang-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- {shard-tglb}: [TIMEOUT][68] ([fdo#112068 ]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_softpin@noreloc-s3:
- shard-skl: [INCOMPLETE][70] ([fdo#104108]) -> [PASS][71]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl4/igt@gem_softpin@noreloc-s3.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl8/igt@gem_softpin@noreloc-s3.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [DMESG-WARN][72] ([fdo#111870]) -> [PASS][73]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-hsw7/igt@gem_userptr_blits@dmabuf-unsync.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-hsw6/igt@gem_userptr_blits@dmabuf-unsync.html
- shard-snb: [DMESG-WARN][74] ([fdo#111870]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-snb7/igt@gem_userptr_blits@dmabuf-unsync.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-snb1/igt@gem_userptr_blits@dmabuf-unsync.html
* {igt@i915_pm_dc@dc6-psr}:
- shard-iclb: [FAIL][76] ([fdo#110548]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb8/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rpm@universal-planes:
- shard-kbl: [DMESG-WARN][78] ([fdo#103313]) -> [PASS][79]
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-kbl2/igt@i915_pm_rpm@universal-planes.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-kbl3/igt@i915_pm_rpm@universal-planes.html
* igt@kms_color@pipe-a-ctm-0-5:
- shard-skl: [DMESG-WARN][80] ([fdo#106107]) -> [PASS][81] +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl3/igt@kms_color@pipe-a-ctm-0-5.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl9/igt@kms_color@pipe-a-ctm-0-5.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled:
- {shard-tglb}: [INCOMPLETE][82] ([fdo#111747]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb4/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb3/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-ytiled.html
* igt@kms_flip@flip-vs-suspend:
- shard-skl: [INCOMPLETE][84] ([fdo#109507]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl8/igt@kms_flip@flip-vs-suspend.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- {shard-tglb}: [FAIL][86] ([fdo#103167]) -> [PASS][87] +3 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb5/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- {shard-tglb}: [INCOMPLETE][88] ([fdo#111832] / [fdo#111850] / [fdo#111884]) -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-suspend.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt:
- {shard-tglb}: [INCOMPLETE][90] ([fdo#111884]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [FAIL][92] ([fdo#103167]) -> [PASS][93] +7 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
- shard-iclb: [FAIL][94] ([fdo#103167] / [fdo#110378]) -> [PASS][95]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][96] ([fdo#108145]) -> [PASS][97]
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-skl1/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-skl2/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][98] ([fdo#108341]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb1/igt@kms_psr@no_drrs.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb6/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_primary_page_flip:
- shard-iclb: [SKIP][100] ([fdo#109441]) -> [PASS][101]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb3/igt@kms_psr@psr2_primary_page_flip.html
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html
* igt@kms_rotation_crc@primary-x-tiled-reflect-x-0:
- shard-iclb: [INCOMPLETE][102] ([fdo#107713] / [fdo#110026]) -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb7/igt@kms_rotation_crc@primary-x-tiled-reflect-x-0.html
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-iclb7/igt@kms_rotation_crc@primary-x-tiled-reflect-x-0.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][104] ([fdo#99912]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-apl3/igt@kms_setmode@basic.html
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/shard-apl2/igt@kms_setmode@basic.html
#### Warnings ####
* igt@gem_ctx_isolation@vcs1-nonpriv:
- shard-iclb: [SKIP][106] ([fdo#109276] / [fdo#112080]) -> [FAIL][107] ([fdo#111329])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7175/shard-iclb3/igt@gem_ctx_isolation@vcs1
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14971/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 16:44 ` Daniele Ceraolo Spurio
0 siblings, 0 replies; 20+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-10-28 16:44 UTC (permalink / raw)
To: don.hiatt, intel-gfx
On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
> From: Don Hiatt <don.hiatt@intel.com>
>
> Check to see if GuC submission is enabled before requesting the
> EXIT_S_STATE action.
>
You're only skipping the resume, but does it make any sense to do the
suspend action if we're not going to call the resume one? Does guc do
anything in the suspend action that we still require? I thought it only
saved the submission status, which we don't care about if guc submission
is disabled.
Daniele
> On some platforms (e.g. KBL) that do not support GuC submission, but
> the user enabled the GuC communication (e.g for HuC authentication)
> calling the GuC EXIT_S_STATE action results in lose of ability to
> enter RC6. Guard against this by only requesting the GuC action on
> platforms that support GuC submission.
>
> I've verfied that intel_guc_resume() only gets called when driver
> is loaded with: guc_enable={1,2,3}, all other cases (no args,
> guc_enable={0,-1} the intel_guc_resume() is not called.
>
> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 37f7bcbf7dac..33318ed135c0 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> GUC_POWER_D0,
> };
>
> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> + if (guc->submission_supported)
> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> +
> + return 0;
> }
>
> /**
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 16:44 ` Daniele Ceraolo Spurio
0 siblings, 0 replies; 20+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-10-28 16:44 UTC (permalink / raw)
To: don.hiatt, intel-gfx
On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
> From: Don Hiatt <don.hiatt@intel.com>
>
> Check to see if GuC submission is enabled before requesting the
> EXIT_S_STATE action.
>
You're only skipping the resume, but does it make any sense to do the
suspend action if we're not going to call the resume one? Does guc do
anything in the suspend action that we still require? I thought it only
saved the submission status, which we don't care about if guc submission
is disabled.
Daniele
> On some platforms (e.g. KBL) that do not support GuC submission, but
> the user enabled the GuC communication (e.g for HuC authentication)
> calling the GuC EXIT_S_STATE action results in lose of ability to
> enter RC6. Guard against this by only requesting the GuC action on
> platforms that support GuC submission.
>
> I've verfied that intel_guc_resume() only gets called when driver
> is loaded with: guc_enable={1,2,3}, all other cases (no args,
> guc_enable={0,-1} the intel_guc_resume() is not called.
>
> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> index 37f7bcbf7dac..33318ed135c0 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> GUC_POWER_D0,
> };
>
> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> + if (guc->submission_supported)
> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> +
> + return 0;
> }
>
> /**
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 18:17 ` Hiatt, Don
0 siblings, 0 replies; 20+ messages in thread
From: Hiatt, Don @ 2019-10-28 18:17 UTC (permalink / raw)
To: Ceraolo Spurio, Daniele, intel-gfx
> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> Sent: Monday, October 28, 2019 9:44 AM
> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC
> submission but enabled
>
>
>
> On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > Check to see if GuC submission is enabled before requesting the
> > EXIT_S_STATE action.
> >
>
> You're only skipping the resume, but does it make any sense to do the
> suspend action if we're not going to call the resume one? Does guc do
> anything in the suspend action that we still require? I thought it only
> saved the submission status, which we don't care about if guc submission
> is disabled.
>
> Daniele
>
Hi Daniele,
I tried skipping the suspend all together but then the HuC gets timeouts
waiting for the GuC to acknowledge the authentication request which leads to a
wedged GPU. ☹
BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that
up.
Thanks,
don
> > On some platforms (e.g. KBL) that do not support GuC submission, but
> > the user enabled the GuC communication (e.g for HuC authentication)
> > calling the GuC EXIT_S_STATE action results in lose of ability to
> > enter RC6. Guard against this by only requesting the GuC action on
> > platforms that support GuC submission.
> >
> > I've verfied that intel_guc_resume() only gets called when driver
> > is loaded with: guc_enable={1,2,3}, all other cases (no args,
> > guc_enable={0,-1} the intel_guc_resume() is not called.
> >
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > index 37f7bcbf7dac..33318ed135c0 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> > GUC_POWER_D0,
> > };
> >
> > - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > + if (guc->submission_supported)
> > + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > +
> > + return 0;
> > }
> >
> > /**
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 18:17 ` Hiatt, Don
0 siblings, 0 replies; 20+ messages in thread
From: Hiatt, Don @ 2019-10-28 18:17 UTC (permalink / raw)
To: Ceraolo Spurio, Daniele, intel-gfx
> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> Sent: Monday, October 28, 2019 9:44 AM
> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC
> submission but enabled
>
>
>
> On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
> > From: Don Hiatt <don.hiatt@intel.com>
> >
> > Check to see if GuC submission is enabled before requesting the
> > EXIT_S_STATE action.
> >
>
> You're only skipping the resume, but does it make any sense to do the
> suspend action if we're not going to call the resume one? Does guc do
> anything in the suspend action that we still require? I thought it only
> saved the submission status, which we don't care about if guc submission
> is disabled.
>
> Daniele
>
Hi Daniele,
I tried skipping the suspend all together but then the HuC gets timeouts
waiting for the GuC to acknowledge the authentication request which leads to a
wedged GPU. ☹
BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that
up.
Thanks,
don
> > On some platforms (e.g. KBL) that do not support GuC submission, but
> > the user enabled the GuC communication (e.g for HuC authentication)
> > calling the GuC EXIT_S_STATE action results in lose of ability to
> > enter RC6. Guard against this by only requesting the GuC action on
> > platforms that support GuC submission.
> >
> > I've verfied that intel_guc_resume() only gets called when driver
> > is loaded with: guc_enable={1,2,3}, all other cases (no args,
> > guc_enable={0,-1} the intel_guc_resume() is not called.
> >
> > Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > index 37f7bcbf7dac..33318ed135c0 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> > GUC_POWER_D0,
> > };
> >
> > - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > + if (guc->submission_supported)
> > + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > +
> > + return 0;
> > }
> >
> > /**
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 18:30 ` Daniele Ceraolo Spurio
0 siblings, 0 replies; 20+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-10-28 18:30 UTC (permalink / raw)
To: Hiatt, Don, intel-gfx
On 10/28/19 11:17 AM, Hiatt, Don wrote:
>> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
>> Sent: Monday, October 28, 2019 9:44 AM
>> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
>> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC
>> submission but enabled
>>
>>
>>
>> On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
>>> From: Don Hiatt <don.hiatt@intel.com>
>>>
>>> Check to see if GuC submission is enabled before requesting the
>>> EXIT_S_STATE action.
>>>
>>
>> You're only skipping the resume, but does it make any sense to do the
>> suspend action if we're not going to call the resume one? Does guc do
>> anything in the suspend action that we still require? I thought it only
>> saved the submission status, which we don't care about if guc submission
>> is disabled.
>>
>> Daniele
>>
>
> Hi Daniele,
>
> I tried skipping the suspend all together but then the HuC gets timeouts
> waiting for the GuC to acknowledge the authentication request which leads to a
> wedged GPU. ☹
>
Do we know why? if we skip the suspend/resume H2G and reload the blobs
after resetting the HW it should look like a clean boot from the HW
perspective, so the fact that HuC auth times out feels weird and might
hide other issues. I asked one of the guc devs and he also thinks this
is not expected behavior. Can you dig a bit more?
Thanks,
Daniele
> BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that
> up.
>
> Thanks,
>
> don
>
>
>>> On some platforms (e.g. KBL) that do not support GuC submission, but
>>> the user enabled the GuC communication (e.g for HuC authentication)
>>> calling the GuC EXIT_S_STATE action results in lose of ability to
>>> enter RC6. Guard against this by only requesting the GuC action on
>>> platforms that support GuC submission.
>>>
>>> I've verfied that intel_guc_resume() only gets called when driver
>>> is loaded with: guc_enable={1,2,3}, all other cases (no args,
>>> guc_enable={0,-1} the intel_guc_resume() is not called.
>>>
>>> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>>> index 37f7bcbf7dac..33318ed135c0 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>>> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
>>> GUC_POWER_D0,
>>> };
>>>
>>> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
>>> + if (guc->submission_supported)
>>> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
>>> +
>>> + return 0;
>>> }
>>>
>>> /**
>>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 18:30 ` Daniele Ceraolo Spurio
0 siblings, 0 replies; 20+ messages in thread
From: Daniele Ceraolo Spurio @ 2019-10-28 18:30 UTC (permalink / raw)
To: Hiatt, Don, intel-gfx
On 10/28/19 11:17 AM, Hiatt, Don wrote:
>> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
>> Sent: Monday, October 28, 2019 9:44 AM
>> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
>> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC
>> submission but enabled
>>
>>
>>
>> On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
>>> From: Don Hiatt <don.hiatt@intel.com>
>>>
>>> Check to see if GuC submission is enabled before requesting the
>>> EXIT_S_STATE action.
>>>
>>
>> You're only skipping the resume, but does it make any sense to do the
>> suspend action if we're not going to call the resume one? Does guc do
>> anything in the suspend action that we still require? I thought it only
>> saved the submission status, which we don't care about if guc submission
>> is disabled.
>>
>> Daniele
>>
>
> Hi Daniele,
>
> I tried skipping the suspend all together but then the HuC gets timeouts
> waiting for the GuC to acknowledge the authentication request which leads to a
> wedged GPU. ☹
>
Do we know why? if we skip the suspend/resume H2G and reload the blobs
after resetting the HW it should look like a clean boot from the HW
perspective, so the fact that HuC auth times out feels weird and might
hide other issues. I asked one of the guc devs and he also thinks this
is not expected behavior. Can you dig a bit more?
Thanks,
Daniele
> BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that
> up.
>
> Thanks,
>
> don
>
>
>>> On some platforms (e.g. KBL) that do not support GuC submission, but
>>> the user enabled the GuC communication (e.g for HuC authentication)
>>> calling the GuC EXIT_S_STATE action results in lose of ability to
>>> enter RC6. Guard against this by only requesting the GuC action on
>>> platforms that support GuC submission.
>>>
>>> I've verfied that intel_guc_resume() only gets called when driver
>>> is loaded with: guc_enable={1,2,3}, all other cases (no args,
>>> guc_enable={0,-1} the intel_guc_resume() is not called.
>>>
>>> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
>>> ---
>>> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>>> index 37f7bcbf7dac..33318ed135c0 100644
>>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
>>> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
>>> GUC_POWER_D0,
>>> };
>>>
>>> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
>>> + if (guc->submission_supported)
>>> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
>>> +
>>> + return 0;
>>> }
>>>
>>> /**
>>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 20:04 ` Hiatt, Don
0 siblings, 0 replies; 20+ messages in thread
From: Hiatt, Don @ 2019-10-28 20:04 UTC (permalink / raw)
To: Ceraolo Spurio, Daniele, intel-gfx
> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> Sent: Monday, October 28, 2019 11:30 AM
> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC
> submission but enabled
>
>
>
> On 10/28/19 11:17 AM, Hiatt, Don wrote:
> >> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> >> Sent: Monday, October 28, 2019 9:44 AM
> >> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> >> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o
> GuC
> >> submission but enabled
> >>
> >>
> >>
> >> On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
> >>> From: Don Hiatt <don.hiatt@intel.com>
> >>>
> >>> Check to see if GuC submission is enabled before requesting the
> >>> EXIT_S_STATE action.
> >>>
> >>
> >> You're only skipping the resume, but does it make any sense to do the
> >> suspend action if we're not going to call the resume one? Does guc do
> >> anything in the suspend action that we still require? I thought it only
> >> saved the submission status, which we don't care about if guc submission
> >> is disabled.
> >>
> >> Daniele
> >>
> >
> > Hi Daniele,
> >
> > I tried skipping the suspend all together but then the HuC gets timeouts
> > waiting for the GuC to acknowledge the authentication request which leads to
> a
> > wedged GPU. ☹
> >
>
> Do we know why? if we skip the suspend/resume H2G and reload the blobs
> after resetting the HW it should look like a clean boot from the HW
> perspective, so the fact that HuC auth times out feels weird and might
> hide other issues. I asked one of the guc devs and he also thinks this
> is not expected behavior. Can you dig a bit more?
>
> Thanks,
> Daniele
>
No idea why but I'll do some digging and see what I find.
Thanks!
don
> > BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that
> > up.
> >
> > Thanks,
> >
> > don
> >
> >
> >>> On some platforms (e.g. KBL) that do not support GuC submission, but
> >>> the user enabled the GuC communication (e.g for HuC authentication)
> >>> calling the GuC EXIT_S_STATE action results in lose of ability to
> >>> enter RC6. Guard against this by only requesting the GuC action on
> >>> platforms that support GuC submission.
> >>>
> >>> I've verfied that intel_guc_resume() only gets called when driver
> >>> is loaded with: guc_enable={1,2,3}, all other cases (no args,
> >>> guc_enable={0,-1} the intel_guc_resume() is not called.
> >>>
> >>> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> >>> ---
> >>> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> >>> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> >> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> >>> index 37f7bcbf7dac..33318ed135c0 100644
> >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> >>> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> >>> GUC_POWER_D0,
> >>> };
> >>>
> >>> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> >>> + if (guc->submission_supported)
> >>> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> >>> +
> >>> + return 0;
> >>> }
> >>>
> >>> /**
> >>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 20:04 ` Hiatt, Don
0 siblings, 0 replies; 20+ messages in thread
From: Hiatt, Don @ 2019-10-28 20:04 UTC (permalink / raw)
To: Ceraolo Spurio, Daniele, intel-gfx
> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> Sent: Monday, October 28, 2019 11:30 AM
> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC
> submission but enabled
>
>
>
> On 10/28/19 11:17 AM, Hiatt, Don wrote:
> >> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> >> Sent: Monday, October 28, 2019 9:44 AM
> >> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> >> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o
> GuC
> >> submission but enabled
> >>
> >>
> >>
> >> On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
> >>> From: Don Hiatt <don.hiatt@intel.com>
> >>>
> >>> Check to see if GuC submission is enabled before requesting the
> >>> EXIT_S_STATE action.
> >>>
> >>
> >> You're only skipping the resume, but does it make any sense to do the
> >> suspend action if we're not going to call the resume one? Does guc do
> >> anything in the suspend action that we still require? I thought it only
> >> saved the submission status, which we don't care about if guc submission
> >> is disabled.
> >>
> >> Daniele
> >>
> >
> > Hi Daniele,
> >
> > I tried skipping the suspend all together but then the HuC gets timeouts
> > waiting for the GuC to acknowledge the authentication request which leads to
> a
> > wedged GPU. ☹
> >
>
> Do we know why? if we skip the suspend/resume H2G and reload the blobs
> after resetting the HW it should look like a clean boot from the HW
> perspective, so the fact that HuC auth times out feels weird and might
> hide other issues. I asked one of the guc devs and he also thinks this
> is not expected behavior. Can you dig a bit more?
>
> Thanks,
> Daniele
>
No idea why but I'll do some digging and see what I find.
Thanks!
don
> > BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that
> > up.
> >
> > Thanks,
> >
> > don
> >
> >
> >>> On some platforms (e.g. KBL) that do not support GuC submission, but
> >>> the user enabled the GuC communication (e.g for HuC authentication)
> >>> calling the GuC EXIT_S_STATE action results in lose of ability to
> >>> enter RC6. Guard against this by only requesting the GuC action on
> >>> platforms that support GuC submission.
> >>>
> >>> I've verfied that intel_guc_resume() only gets called when driver
> >>> is loaded with: guc_enable={1,2,3}, all other cases (no args,
> >>> guc_enable={0,-1} the intel_guc_resume() is not called.
> >>>
> >>> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> >>> ---
> >>> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> >>> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> >> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> >>> index 37f7bcbf7dac..33318ed135c0 100644
> >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> >>> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> >>> GUC_POWER_D0,
> >>> };
> >>>
> >>> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> >>> + if (guc->submission_supported)
> >>> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> >>> +
> >>> + return 0;
> >>> }
> >>>
> >>> /**
> >>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 21:25 ` Hiatt, Don
0 siblings, 0 replies; 20+ messages in thread
From: Hiatt, Don @ 2019-10-28 21:25 UTC (permalink / raw)
To: Hiatt, Don, Ceraolo Spurio, Daniele, intel-gfx
> > From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> > Sent: Monday, October 28, 2019 11:30 AM
> > To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o
> GuC
> > submission but enabled
> >
> >
> >
> > On 10/28/19 11:17 AM, Hiatt, Don wrote:
> > >> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> > >> Sent: Monday, October 28, 2019 9:44 AM
> > >> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> > >> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o
> > GuC
> > >> submission but enabled
> > >>
> > >>
> > >>
> > >> On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
> > >>> From: Don Hiatt <don.hiatt@intel.com>
> > >>>
> > >>> Check to see if GuC submission is enabled before requesting the
> > >>> EXIT_S_STATE action.
> > >>>
> > >>
> > >> You're only skipping the resume, but does it make any sense to do the
> > >> suspend action if we're not going to call the resume one? Does guc do
> > >> anything in the suspend action that we still require? I thought it only
> > >> saved the submission status, which we don't care about if guc submission
> > >> is disabled.
> > >>
> > >> Daniele
> > >>
> > >
> > > Hi Daniele,
> > >
> > > I tried skipping the suspend all together but then the HuC gets timeouts
> > > waiting for the GuC to acknowledge the authentication request which leads
> to
> > a
> > > wedged GPU. ☹
> > >
> >
> > Do we know why? if we skip the suspend/resume H2G and reload the blobs
> > after resetting the HW it should look like a clean boot from the HW
> > perspective, so the fact that HuC auth times out feels weird and might
> > hide other issues. I asked one of the guc devs and he also thinks this
> > is not expected behavior. Can you dig a bit more?
> >
> > Thanks,
> > Daniele
> >
>
> No idea why but I'll do some digging and see what I find.
>
> Thanks!
>
> don
>
Hi Daniele,
I was a little overzealous on my removal of suspend/resume. We still need to go
through the steps of enable/disable GuC communication on suspend/resume but
just not send the GuC action. My first attempt was not handling the GuC communication
properly so that is why I was seeing the HuC authentication timesouts.
I'm submitting new patch -- with the proper 'drm/i915' -- and will CC you.
Thanks!
don
> > > BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that
> > > up.
> > >
> > > Thanks,
> > >
> > > don
> > >
> > >
> > >>> On some platforms (e.g. KBL) that do not support GuC submission, but
> > >>> the user enabled the GuC communication (e.g for HuC authentication)
> > >>> calling the GuC EXIT_S_STATE action results in lose of ability to
> > >>> enter RC6. Guard against this by only requesting the GuC action on
> > >>> platforms that support GuC submission.
> > >>>
> > >>> I've verfied that intel_guc_resume() only gets called when driver
> > >>> is loaded with: guc_enable={1,2,3}, all other cases (no args,
> > >>> guc_enable={0,-1} the intel_guc_resume() is not called.
> > >>>
> > >>> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > >>> ---
> > >>> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> > >>> 1 file changed, 4 insertions(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > >> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > >>> index 37f7bcbf7dac..33318ed135c0 100644
> > >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > >>> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> > >>> GUC_POWER_D0,
> > >>> };
> > >>>
> > >>> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > >>> + if (guc->submission_supported)
> > >>> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > >>> +
> > >>> + return 0;
> > >>> }
> > >>>
> > >>> /**
> > >>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled
@ 2019-10-28 21:25 ` Hiatt, Don
0 siblings, 0 replies; 20+ messages in thread
From: Hiatt, Don @ 2019-10-28 21:25 UTC (permalink / raw)
To: Hiatt, Don, Ceraolo Spurio, Daniele, intel-gfx
> > From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> > Sent: Monday, October 28, 2019 11:30 AM
> > To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o
> GuC
> > submission but enabled
> >
> >
> >
> > On 10/28/19 11:17 AM, Hiatt, Don wrote:
> > >> From: Ceraolo Spurio, Daniele <daniele.ceraolospurio@intel.com>
> > >> Sent: Monday, October 28, 2019 9:44 AM
> > >> To: Hiatt, Don <don.hiatt@intel.com>; intel-gfx@lists.freedesktop.org
> > >> Subject: Re: [Intel-gfx] [PATCH] drm/i914/guc: Fix resume on platforms w/o
> > GuC
> > >> submission but enabled
> > >>
> > >>
> > >>
> > >> On 10/24/19 9:29 AM, don.hiatt@intel.com wrote:
> > >>> From: Don Hiatt <don.hiatt@intel.com>
> > >>>
> > >>> Check to see if GuC submission is enabled before requesting the
> > >>> EXIT_S_STATE action.
> > >>>
> > >>
> > >> You're only skipping the resume, but does it make any sense to do the
> > >> suspend action if we're not going to call the resume one? Does guc do
> > >> anything in the suspend action that we still require? I thought it only
> > >> saved the submission status, which we don't care about if guc submission
> > >> is disabled.
> > >>
> > >> Daniele
> > >>
> > >
> > > Hi Daniele,
> > >
> > > I tried skipping the suspend all together but then the HuC gets timeouts
> > > waiting for the GuC to acknowledge the authentication request which leads
> to
> > a
> > > wedged GPU. ☹
> > >
> >
> > Do we know why? if we skip the suspend/resume H2G and reload the blobs
> > after resetting the HW it should look like a clean boot from the HW
> > perspective, so the fact that HuC auth times out feels weird and might
> > hide other issues. I asked one of the guc devs and he also thinks this
> > is not expected behavior. Can you dig a bit more?
> >
> > Thanks,
> > Daniele
> >
>
> No idea why but I'll do some digging and see what I find.
>
> Thanks!
>
> don
>
Hi Daniele,
I was a little overzealous on my removal of suspend/resume. We still need to go
through the steps of enable/disable GuC communication on suspend/resume but
just not send the GuC action. My first attempt was not handling the GuC communication
properly so that is why I was seeing the HuC authentication timesouts.
I'm submitting new patch -- with the proper 'drm/i915' -- and will CC you.
Thanks!
don
> > > BTW, I made a typo in the patch, should be 'drm/i915' not '914', I'll fix that
> > > up.
> > >
> > > Thanks,
> > >
> > > don
> > >
> > >
> > >>> On some platforms (e.g. KBL) that do not support GuC submission, but
> > >>> the user enabled the GuC communication (e.g for HuC authentication)
> > >>> calling the GuC EXIT_S_STATE action results in lose of ability to
> > >>> enter RC6. Guard against this by only requesting the GuC action on
> > >>> platforms that support GuC submission.
> > >>>
> > >>> I've verfied that intel_guc_resume() only gets called when driver
> > >>> is loaded with: guc_enable={1,2,3}, all other cases (no args,
> > >>> guc_enable={0,-1} the intel_guc_resume() is not called.
> > >>>
> > >>> Signed-off-by: Don Hiatt <don.hiatt@intel.com>
> > >>> ---
> > >>> drivers/gpu/drm/i915/gt/uc/intel_guc.c | 5 ++++-
> > >>> 1 file changed, 4 insertions(+), 1 deletion(-)
> > >>>
> > >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > >> b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > >>> index 37f7bcbf7dac..33318ed135c0 100644
> > >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.c
> > >>> @@ -565,7 +565,10 @@ int intel_guc_resume(struct intel_guc *guc)
> > >>> GUC_POWER_D0,
> > >>> };
> > >>>
> > >>> - return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > >>> + if (guc->submission_supported)
> > >>> + return intel_guc_send(guc, action, ARRAY_SIZE(action));
> > >>> +
> > >>> + return 0;
> > >>> }
> > >>>
> > >>> /**
> > >>>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2019-10-28 21:25 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 16:29 [PATCH] drm/i914/guc: Fix resume on platforms w/o GuC submission but enabled don.hiatt
2019-10-24 16:29 ` [Intel-gfx] " don.hiatt
2019-10-24 18:27 ` Summers, Stuart
2019-10-24 18:27 ` [Intel-gfx] " Summers, Stuart
2019-10-24 20:10 ` Hiatt, Don
2019-10-24 20:10 ` [Intel-gfx] " Hiatt, Don
2019-10-24 20:43 ` ✓ Fi.CI.BAT: success for " Patchwork
2019-10-24 20:43 ` [Intel-gfx] " Patchwork
2019-10-26 5:53 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-10-26 5:53 ` [Intel-gfx] " Patchwork
2019-10-28 16:44 ` [PATCH] " Daniele Ceraolo Spurio
2019-10-28 16:44 ` [Intel-gfx] " Daniele Ceraolo Spurio
2019-10-28 18:17 ` Hiatt, Don
2019-10-28 18:17 ` [Intel-gfx] " Hiatt, Don
2019-10-28 18:30 ` Daniele Ceraolo Spurio
2019-10-28 18:30 ` [Intel-gfx] " Daniele Ceraolo Spurio
2019-10-28 20:04 ` Hiatt, Don
2019-10-28 20:04 ` [Intel-gfx] " Hiatt, Don
2019-10-28 21:25 ` Hiatt, Don
2019-10-28 21:25 ` [Intel-gfx] " Hiatt, Don
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.