* [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes
@ 2019-10-08 21:17 Matt Roper
2019-10-08 22:34 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Matt Roper @ 2019-10-08 21:17 UTC (permalink / raw)
To: intel-gfx
Gen11+ has more hardware planes than gen9 so we need to test additional
pipe interrupt register bits to recognize any GTT faults that happen on
these extra planes.
Bspec: 50335
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
drivers/gpu/drm/i915/i915_irq.c | 4 +++-
drivers/gpu/drm/i915/i915_reg.h | 8 ++++++++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index f2371b6083c6..5499450c1524 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2589,7 +2589,9 @@ static u32 gen8_de_port_aux_mask(struct drm_i915_private *dev_priv)
static u32 gen8_de_pipe_fault_mask(struct drm_i915_private *dev_priv)
{
- if (INTEL_GEN(dev_priv) >= 9)
+ if (INTEL_GEN(dev_priv) >= 11)
+ return GEN11_DE_PIPE_IRQ_FAULT_ERRORS;
+ else if (INTEL_GEN(dev_priv) >= 9)
return GEN9_DE_PIPE_IRQ_FAULT_ERRORS;
else
return GEN8_DE_PIPE_IRQ_FAULT_ERRORS;
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 6d67bd238cfe..24311fee7009 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -7373,6 +7373,9 @@ enum {
#define GEN8_PIPE_VSYNC (1 << 1)
#define GEN8_PIPE_VBLANK (1 << 0)
#define GEN9_PIPE_CURSOR_FAULT (1 << 11)
+#define GEN11_PIPE_PLANE7_FAULT (1 << 22)
+#define GEN11_PIPE_PLANE6_FAULT (1 << 21)
+#define GEN11_PIPE_PLANE5_FAULT (1 << 20)
#define GEN9_PIPE_PLANE4_FAULT (1 << 10)
#define GEN9_PIPE_PLANE3_FAULT (1 << 9)
#define GEN9_PIPE_PLANE2_FAULT (1 << 8)
@@ -7392,6 +7395,11 @@ enum {
GEN9_PIPE_PLANE3_FAULT | \
GEN9_PIPE_PLANE2_FAULT | \
GEN9_PIPE_PLANE1_FAULT)
+#define GEN11_DE_PIPE_IRQ_FAULT_ERRORS \
+ (GEN9_DE_PIPE_IRQ_FAULT_ERRORS | \
+ GEN11_PIPE_PLANE7_FAULT | \
+ GEN11_PIPE_PLANE6_FAULT | \
+ GEN11_PIPE_PLANE5_FAULT)
#define GEN8_DE_PORT_ISR _MMIO(0x44440)
#define GEN8_DE_PORT_IMR _MMIO(0x44444)
--
2.21.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: Catch GTT fault errors for gen11+ planes
2019-10-08 21:17 [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes Matt Roper
@ 2019-10-08 22:34 ` Patchwork
2019-10-08 23:36 ` Matt Roper
2019-10-09 0:28 ` ✓ Fi.CI.BAT: success for drm/i915: Catch GTT fault errors for gen11+ planes (rev2) Patchwork
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2019-10-08 22:34 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Catch GTT fault errors for gen11+ planes
URL : https://patchwork.freedesktop.org/series/67752/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7036 -> Patchwork_14710
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_14710 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_14710, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_14710:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live_coherency:
- fi-skl-lmem: [PASS][1] -> [TIMEOUT][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-skl-lmem/igt@i915_selftest@live_coherency.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-skl-lmem/igt@i915_selftest@live_coherency.html
Known issues
------------
Here are the changes found in Patchwork_14710 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-bxt-dsi: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
* igt@gem_exec_suspend@basic-s4-devices:
- fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-icl-u3/igt@gem_exec_suspend@basic-s4-devices.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-icl-u3/igt@gem_exec_suspend@basic-s4-devices.html
#### Possible fixes ####
* igt@gem_ctx_switch@rcs0:
- fi-cml-u2: [INCOMPLETE][7] ([fdo#110566]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-cml-u2/igt@gem_ctx_switch@rcs0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-cml-u2/igt@gem_ctx_switch@rcs0.html
* igt@gem_tiled_blits@basic:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-icl-u3/igt@gem_tiled_blits@basic.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-icl-u3/igt@gem_tiled_blits@basic.html
* igt@i915_module_load@reload:
- fi-blb-e6850: [INCOMPLETE][11] ([fdo#107718]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-blb-e6850/igt@i915_module_load@reload.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-blb-e6850/igt@i915_module_load@reload.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
Participating hosts (51 -> 43)
------------------------------
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-tgl-u fi-hsw-4200u fi-byt-squawks fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7036 -> Patchwork_14710
CI-20190529: 20190529
CI_DRM_7036: a1b9c6723faeec2ee044e28a8e7e8ffe5aa434a0 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5218: 869ed1ee0b71ce17f0a864512488f8b1a6cb8545 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14710: a199ddec9d887287b74eaac5e723b02169094353 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a199ddec9d88 drm/i915: Catch GTT fault errors for gen11+ planes
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915: Catch GTT fault errors for gen11+ planes
2019-10-08 22:34 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2019-10-08 23:36 ` Matt Roper
0 siblings, 0 replies; 9+ messages in thread
From: Matt Roper @ 2019-10-08 23:36 UTC (permalink / raw)
To: intel-gfx
On Tue, Oct 08, 2019 at 10:34:48PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Catch GTT fault errors for gen11+ planes
> URL : https://patchwork.freedesktop.org/series/67752/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_7036 -> Patchwork_14710
> ====================================================
>
> Summary
> -------
>
> **FAILURE**
>
> Serious unknown changes coming with Patchwork_14710 absolutely need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_14710, please notify your bug team to allow them
> to document this new failure mode, which will reduce false positives in CI.
>
> External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/index.html
>
> Possible new issues
> -------------------
>
> Here are the unknown changes that may have been introduced in Patchwork_14710:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
> * igt@i915_selftest@live_coherency:
> - fi-skl-lmem: [PASS][1] -> [TIMEOUT][2]
> [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-skl-lmem/igt@i915_selftest@live_coherency.html
> [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-skl-lmem/igt@i915_selftest@live_coherency.html
GEM_BUG_ON(gt->awake), not related to checking extra display interrupt
bits in this patch. Will request a re-test.
Matt
>
>
> Known issues
> ------------
>
> Here are the changes found in Patchwork_14710 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
> * igt@gem_ctx_create@basic-files:
> - fi-bxt-dsi: [PASS][3] -> [INCOMPLETE][4] ([fdo#103927])
> [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
> [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-bxt-dsi/igt@gem_ctx_create@basic-files.html
>
> * igt@gem_exec_suspend@basic-s4-devices:
> - fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724])
> [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-icl-u3/igt@gem_exec_suspend@basic-s4-devices.html
> [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-icl-u3/igt@gem_exec_suspend@basic-s4-devices.html
>
>
> #### Possible fixes ####
>
> * igt@gem_ctx_switch@rcs0:
> - fi-cml-u2: [INCOMPLETE][7] ([fdo#110566]) -> [PASS][8]
> [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-cml-u2/igt@gem_ctx_switch@rcs0.html
> [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-cml-u2/igt@gem_ctx_switch@rcs0.html
>
> * igt@gem_tiled_blits@basic:
> - fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10]
> [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-icl-u3/igt@gem_tiled_blits@basic.html
> [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-icl-u3/igt@gem_tiled_blits@basic.html
>
> * igt@i915_module_load@reload:
> - fi-blb-e6850: [INCOMPLETE][11] ([fdo#107718]) -> [PASS][12]
> [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7036/fi-blb-e6850/igt@i915_module_load@reload.html
> [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/fi-blb-e6850/igt@i915_module_load@reload.html
>
>
> {name}: This element is suppressed. This means it is ignored when computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
> [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
> [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
> [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
> [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
> [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
> [fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
>
>
> Participating hosts (51 -> 43)
> ------------------------------
>
> Missing (8): fi-kbl-soraka fi-ilk-m540 fi-tgl-u fi-hsw-4200u fi-byt-squawks fi-icl-y fi-byt-clapper fi-bdw-samus
>
>
> Build changes
> -------------
>
> * CI: CI-20190529 -> None
> * Linux: CI_DRM_7036 -> Patchwork_14710
>
> CI-20190529: 20190529
> CI_DRM_7036: a1b9c6723faeec2ee044e28a8e7e8ffe5aa434a0 @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_5218: 869ed1ee0b71ce17f0a864512488f8b1a6cb8545 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_14710: a199ddec9d887287b74eaac5e723b02169094353 @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Linux commits ==
>
> a199ddec9d88 drm/i915: Catch GTT fault errors for gen11+ planes
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14710/index.html
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Catch GTT fault errors for gen11+ planes (rev2)
2019-10-08 21:17 [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes Matt Roper
2019-10-08 22:34 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2019-10-09 0:28 ` Patchwork
2019-10-09 8:48 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-24 21:17 ` [Intel-gfx] " Souza, Jose
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-10-09 0:28 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Catch GTT fault errors for gen11+ planes (rev2)
URL : https://patchwork.freedesktop.org/series/67752/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7037 -> Patchwork_14713
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/index.html
Known issues
------------
Here are the changes found in Patchwork_14713 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@create-close:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/fi-icl-u3/igt@gem_basic@create-close.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/fi-icl-u3/igt@gem_basic@create-close.html
* igt@kms_chamelium@dp-edid-read:
- fi-icl-u2: [PASS][3] -> [DMESG-WARN][4] ([fdo#106107]) +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/fi-icl-u2/igt@kms_chamelium@dp-edid-read.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/fi-icl-u2/igt@kms_chamelium@dp-edid-read.html
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- {fi-tgl-u}: [INCOMPLETE][5] ([fdo#111593]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/fi-tgl-u/igt@gem_exec_gttfill@basic.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/fi-tgl-u/igt@gem_exec_gttfill@basic.html
* igt@gem_tiled_fence_blits@basic:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/fi-icl-u3/igt@gem_tiled_fence_blits@basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/fi-icl-u3/igt@gem_tiled_fence_blits@basic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593
Participating hosts (50 -> 45)
------------------------------
Additional (1): fi-icl-dsi
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7037 -> Patchwork_14713
CI-20190529: 20190529
CI_DRM_7037: 4ff590d66f456266150c2c42c194f62338569140 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5218: 869ed1ee0b71ce17f0a864512488f8b1a6cb8545 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14713: 5d5d181a8ee8f002ad223781446b91e8c5f727f6 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5d5d181a8ee8 drm/i915: Catch GTT fault errors for gen11+ planes
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Catch GTT fault errors for gen11+ planes (rev2)
2019-10-08 21:17 [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes Matt Roper
2019-10-08 22:34 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-09 0:28 ` ✓ Fi.CI.BAT: success for drm/i915: Catch GTT fault errors for gen11+ planes (rev2) Patchwork
@ 2019-10-09 8:48 ` Patchwork
2019-10-24 21:17 ` [Intel-gfx] " Souza, Jose
3 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-10-09 8:48 UTC (permalink / raw)
To: Matt Roper; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Catch GTT fault errors for gen11+ planes (rev2)
URL : https://patchwork.freedesktop.org/series/67752/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7037_full -> Patchwork_14713_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_14713_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_balancer@smoke:
- shard-iclb: [PASS][1] -> [SKIP][2] ([fdo#110854])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb1/igt@gem_exec_balancer@smoke.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb5/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_schedule@wide-bsd:
- shard-iclb: [PASS][3] -> [SKIP][4] ([fdo#111325]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb3/igt@gem_exec_schedule@wide-bsd.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb2/igt@gem_exec_schedule@wide-bsd.html
* igt@gem_fence_thrash@bo-write-verify-x:
- shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb5/igt@gem_fence_thrash@bo-write-verify-x.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb4/igt@gem_fence_thrash@bo-write-verify-x.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][7] -> [DMESG-WARN][8] ([fdo#111870]) +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [PASS][9] -> [DMESG-WARN][10] ([fdo#111870]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-snb4/igt@gem_userptr_blits@sync-unmap-cycles.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_selftest@live_hangcheck:
- shard-iclb: [PASS][11] -> [INCOMPLETE][12] ([fdo#107713] / [fdo#108569])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb4/igt@i915_selftest@live_hangcheck.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb6/igt@i915_selftest@live_hangcheck.html
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-apl: [PASS][13] -> [INCOMPLETE][14] ([fdo#103927])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-apl1/igt@kms_busy@extended-modeset-hang-newfb-render-a.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-apl3/igt@kms_busy@extended-modeset-hang-newfb-render-a.html
* igt@kms_flip@2x-flip-vs-expired-vblank:
- shard-glk: [PASS][15] -> [FAIL][16] ([fdo#105363])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-glk5/igt@kms_flip@2x-flip-vs-expired-vblank.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render:
- shard-iclb: [PASS][17] -> [FAIL][18] ([fdo#103167]) +4 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-render.html
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-iclb: [PASS][19] -> [SKIP][20] ([fdo#109441]) +1 similar issue
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb2/igt@kms_psr@psr2_primary_mmap_gtt.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb5/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][21] -> [FAIL][22] ([fdo#99912])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-kbl7/igt@kms_setmode@basic.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-kbl7/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][23] -> [DMESG-WARN][24] ([fdo#108566]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-apl8/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-apl4/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [PASS][25] -> [SKIP][26] ([fdo#109276]) +19 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb3/igt@prime_vgem@fence-wait-bsd2.html
#### Possible fixes ####
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [SKIP][27] ([fdo#110841]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_eio@suspend:
- shard-apl: [INCOMPLETE][29] ([fdo#103927]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-apl2/igt@gem_eio@suspend.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-apl7/igt@gem_eio@suspend.html
* igt@gem_exec_schedule@out-order-bsd1:
- shard-iclb: [SKIP][31] ([fdo#109276]) -> [PASS][32] +7 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb5/igt@gem_exec_schedule@out-order-bsd1.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb2/igt@gem_exec_schedule@out-order-bsd1.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [SKIP][33] ([fdo#111325]) -> [PASS][34] +2 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb1/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb5/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [DMESG-WARN][35] ([fdo#111870]) -> [PASS][36] +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-snb7/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@dmabuf-unsync:
- shard-hsw: [DMESG-WARN][37] ([fdo#111870]) -> [PASS][38] +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-hsw2/igt@gem_userptr_blits@dmabuf-unsync.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-hsw2/igt@gem_userptr_blits@dmabuf-unsync.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][39] ([fdo#108566]) -> [PASS][40] +6 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-apl7/igt@i915_suspend@sysfs-reader.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-apl8/igt@i915_suspend@sysfs-reader.html
* igt@kms_busy@extended-modeset-hang-newfb-render-a:
- shard-iclb: [INCOMPLETE][41] ([fdo#107713]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb7/igt@kms_busy@extended-modeset-hang-newfb-render-a.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb3/igt@kms_busy@extended-modeset-hang-newfb-render-a.html
* igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen:
- shard-skl: [FAIL][43] ([fdo#103232]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-skl5/igt@kms_cursor_crc@pipe-c-cursor-256x85-offscreen.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-cpu:
- {shard-tglb}: [INCOMPLETE][45] -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-cpu.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][47] ([fdo#103167]) -> [PASS][48] +4 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min:
- shard-skl: [FAIL][49] ([fdo#108145]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-skl5/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][51] ([fdo#108145] / [fdo#110403]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-skl8/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [SKIP][53] ([fdo#109441]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- {shard-tglb}: [INCOMPLETE][55] ([fdo#111832] / [fdo#111850]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-tglb2/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-tglb6/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@gem_mocs_settings@mocs-isolation-bsd2:
- shard-iclb: [FAIL][57] ([fdo#111330]) -> [SKIP][58] ([fdo#109276])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb1/igt@gem_mocs_settings@mocs-isolation-bsd2.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb3/igt@gem_mocs_settings@mocs-isolation-bsd2.html
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [SKIP][59] ([fdo#109276]) -> [FAIL][60] ([fdo#111330]) +1 similar issue
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-iclb6/igt@gem_mocs_settings@mocs-settings-bsd2.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-iclb1/igt@gem_mocs_settings@mocs-settings-bsd2.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-apl: [DMESG-WARN][61] ([fdo#108566]) -> [INCOMPLETE][62] ([fdo#103927])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7037/shard-apl6/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/shard-apl7/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#110854]: https://bugs.freedesktop.org/show_bug.cgi?id=110854
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7037 -> Patchwork_14713
CI-20190529: 20190529
CI_DRM_7037: 4ff590d66f456266150c2c42c194f62338569140 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5218: 869ed1ee0b71ce17f0a864512488f8b1a6cb8545 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_14713: 5d5d181a8ee8f002ad223781446b91e8c5f727f6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14713/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes
@ 2019-10-24 21:17 ` Souza, Jose
0 siblings, 0 replies; 9+ messages in thread
From: Souza, Jose @ 2019-10-24 21:17 UTC (permalink / raw)
To: Roper, Matthew D, intel-gfx
On Tue, 2019-10-08 at 14:17 -0700, Matt Roper wrote:
> Gen11+ has more hardware planes than gen9 so we need to test
> additional
> pipe interrupt register bits to recognize any GTT faults that happen
> on
> these extra planes.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Bspec: 50335
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 4 +++-
> drivers/gpu/drm/i915/i915_reg.h | 8 ++++++++
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c
> b/drivers/gpu/drm/i915/i915_irq.c
> index f2371b6083c6..5499450c1524 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2589,7 +2589,9 @@ static u32 gen8_de_port_aux_mask(struct
> drm_i915_private *dev_priv)
>
> static u32 gen8_de_pipe_fault_mask(struct drm_i915_private
> *dev_priv)
> {
> - if (INTEL_GEN(dev_priv) >= 9)
> + if (INTEL_GEN(dev_priv) >= 11)
> + return GEN11_DE_PIPE_IRQ_FAULT_ERRORS;
> + else if (INTEL_GEN(dev_priv) >= 9)
> return GEN9_DE_PIPE_IRQ_FAULT_ERRORS;
> else
> return GEN8_DE_PIPE_IRQ_FAULT_ERRORS;
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h
> index 6d67bd238cfe..24311fee7009 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -7373,6 +7373,9 @@ enum {
> #define GEN8_PIPE_VSYNC (1 << 1)
> #define GEN8_PIPE_VBLANK (1 << 0)
> #define GEN9_PIPE_CURSOR_FAULT (1 << 11)
> +#define GEN11_PIPE_PLANE7_FAULT (1 << 22)
> +#define GEN11_PIPE_PLANE6_FAULT (1 << 21)
> +#define GEN11_PIPE_PLANE5_FAULT (1 << 20)
> #define GEN9_PIPE_PLANE4_FAULT (1 << 10)
> #define GEN9_PIPE_PLANE3_FAULT (1 << 9)
> #define GEN9_PIPE_PLANE2_FAULT (1 << 8)
> @@ -7392,6 +7395,11 @@ enum {
> GEN9_PIPE_PLANE3_FAULT | \
> GEN9_PIPE_PLANE2_FAULT | \
> GEN9_PIPE_PLANE1_FAULT)
> +#define GEN11_DE_PIPE_IRQ_FAULT_ERRORS \
> + (GEN9_DE_PIPE_IRQ_FAULT_ERRORS | \
> + GEN11_PIPE_PLANE7_FAULT | \
> + GEN11_PIPE_PLANE6_FAULT | \
> + GEN11_PIPE_PLANE5_FAULT)
>
> #define GEN8_DE_PORT_ISR _MMIO(0x44440)
> #define GEN8_DE_PORT_IMR _MMIO(0x44444)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes
@ 2019-10-24 21:17 ` Souza, Jose
0 siblings, 0 replies; 9+ messages in thread
From: Souza, Jose @ 2019-10-24 21:17 UTC (permalink / raw)
To: Roper, Matthew D, intel-gfx
On Tue, 2019-10-08 at 14:17 -0700, Matt Roper wrote:
> Gen11+ has more hardware planes than gen9 so we need to test
> additional
> pipe interrupt register bits to recognize any GTT faults that happen
> on
> these extra planes.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Bspec: 50335
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 4 +++-
> drivers/gpu/drm/i915/i915_reg.h | 8 ++++++++
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c
> b/drivers/gpu/drm/i915/i915_irq.c
> index f2371b6083c6..5499450c1524 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2589,7 +2589,9 @@ static u32 gen8_de_port_aux_mask(struct
> drm_i915_private *dev_priv)
>
> static u32 gen8_de_pipe_fault_mask(struct drm_i915_private
> *dev_priv)
> {
> - if (INTEL_GEN(dev_priv) >= 9)
> + if (INTEL_GEN(dev_priv) >= 11)
> + return GEN11_DE_PIPE_IRQ_FAULT_ERRORS;
> + else if (INTEL_GEN(dev_priv) >= 9)
> return GEN9_DE_PIPE_IRQ_FAULT_ERRORS;
> else
> return GEN8_DE_PIPE_IRQ_FAULT_ERRORS;
> diff --git a/drivers/gpu/drm/i915/i915_reg.h
> b/drivers/gpu/drm/i915/i915_reg.h
> index 6d67bd238cfe..24311fee7009 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -7373,6 +7373,9 @@ enum {
> #define GEN8_PIPE_VSYNC (1 << 1)
> #define GEN8_PIPE_VBLANK (1 << 0)
> #define GEN9_PIPE_CURSOR_FAULT (1 << 11)
> +#define GEN11_PIPE_PLANE7_FAULT (1 << 22)
> +#define GEN11_PIPE_PLANE6_FAULT (1 << 21)
> +#define GEN11_PIPE_PLANE5_FAULT (1 << 20)
> #define GEN9_PIPE_PLANE4_FAULT (1 << 10)
> #define GEN9_PIPE_PLANE3_FAULT (1 << 9)
> #define GEN9_PIPE_PLANE2_FAULT (1 << 8)
> @@ -7392,6 +7395,11 @@ enum {
> GEN9_PIPE_PLANE3_FAULT | \
> GEN9_PIPE_PLANE2_FAULT | \
> GEN9_PIPE_PLANE1_FAULT)
> +#define GEN11_DE_PIPE_IRQ_FAULT_ERRORS \
> + (GEN9_DE_PIPE_IRQ_FAULT_ERRORS | \
> + GEN11_PIPE_PLANE7_FAULT | \
> + GEN11_PIPE_PLANE6_FAULT | \
> + GEN11_PIPE_PLANE5_FAULT)
>
> #define GEN8_DE_PORT_ISR _MMIO(0x44440)
> #define GEN8_DE_PORT_IMR _MMIO(0x44444)
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes
@ 2019-10-24 23:49 ` Matt Roper
0 siblings, 0 replies; 9+ messages in thread
From: Matt Roper @ 2019-10-24 23:49 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
On Thu, Oct 24, 2019 at 02:17:34PM -0700, Souza, Jose wrote:
> On Tue, 2019-10-08 at 14:17 -0700, Matt Roper wrote:
> > Gen11+ has more hardware planes than gen9 so we need to test
> > additional
> > pipe interrupt register bits to recognize any GTT faults that happen
> > on
> > these extra planes.
>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Applied to dinq, thanks for the review.
Matt
>
> >
> > Bspec: 50335
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_irq.c | 4 +++-
> > drivers/gpu/drm/i915/i915_reg.h | 8 ++++++++
> > 2 files changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_irq.c
> > b/drivers/gpu/drm/i915/i915_irq.c
> > index f2371b6083c6..5499450c1524 100644
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -2589,7 +2589,9 @@ static u32 gen8_de_port_aux_mask(struct
> > drm_i915_private *dev_priv)
> >
> > static u32 gen8_de_pipe_fault_mask(struct drm_i915_private
> > *dev_priv)
> > {
> > - if (INTEL_GEN(dev_priv) >= 9)
> > + if (INTEL_GEN(dev_priv) >= 11)
> > + return GEN11_DE_PIPE_IRQ_FAULT_ERRORS;
> > + else if (INTEL_GEN(dev_priv) >= 9)
> > return GEN9_DE_PIPE_IRQ_FAULT_ERRORS;
> > else
> > return GEN8_DE_PIPE_IRQ_FAULT_ERRORS;
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h
> > b/drivers/gpu/drm/i915/i915_reg.h
> > index 6d67bd238cfe..24311fee7009 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -7373,6 +7373,9 @@ enum {
> > #define GEN8_PIPE_VSYNC (1 << 1)
> > #define GEN8_PIPE_VBLANK (1 << 0)
> > #define GEN9_PIPE_CURSOR_FAULT (1 << 11)
> > +#define GEN11_PIPE_PLANE7_FAULT (1 << 22)
> > +#define GEN11_PIPE_PLANE6_FAULT (1 << 21)
> > +#define GEN11_PIPE_PLANE5_FAULT (1 << 20)
> > #define GEN9_PIPE_PLANE4_FAULT (1 << 10)
> > #define GEN9_PIPE_PLANE3_FAULT (1 << 9)
> > #define GEN9_PIPE_PLANE2_FAULT (1 << 8)
> > @@ -7392,6 +7395,11 @@ enum {
> > GEN9_PIPE_PLANE3_FAULT | \
> > GEN9_PIPE_PLANE2_FAULT | \
> > GEN9_PIPE_PLANE1_FAULT)
> > +#define GEN11_DE_PIPE_IRQ_FAULT_ERRORS \
> > + (GEN9_DE_PIPE_IRQ_FAULT_ERRORS | \
> > + GEN11_PIPE_PLANE7_FAULT | \
> > + GEN11_PIPE_PLANE6_FAULT | \
> > + GEN11_PIPE_PLANE5_FAULT)
> >
> > #define GEN8_DE_PORT_ISR _MMIO(0x44440)
> > #define GEN8_DE_PORT_IMR _MMIO(0x44444)
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes
@ 2019-10-24 23:49 ` Matt Roper
0 siblings, 0 replies; 9+ messages in thread
From: Matt Roper @ 2019-10-24 23:49 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
On Thu, Oct 24, 2019 at 02:17:34PM -0700, Souza, Jose wrote:
> On Tue, 2019-10-08 at 14:17 -0700, Matt Roper wrote:
> > Gen11+ has more hardware planes than gen9 so we need to test
> > additional
> > pipe interrupt register bits to recognize any GTT faults that happen
> > on
> > these extra planes.
>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
Applied to dinq, thanks for the review.
Matt
>
> >
> > Bspec: 50335
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_irq.c | 4 +++-
> > drivers/gpu/drm/i915/i915_reg.h | 8 ++++++++
> > 2 files changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_irq.c
> > b/drivers/gpu/drm/i915/i915_irq.c
> > index f2371b6083c6..5499450c1524 100644
> > --- a/drivers/gpu/drm/i915/i915_irq.c
> > +++ b/drivers/gpu/drm/i915/i915_irq.c
> > @@ -2589,7 +2589,9 @@ static u32 gen8_de_port_aux_mask(struct
> > drm_i915_private *dev_priv)
> >
> > static u32 gen8_de_pipe_fault_mask(struct drm_i915_private
> > *dev_priv)
> > {
> > - if (INTEL_GEN(dev_priv) >= 9)
> > + if (INTEL_GEN(dev_priv) >= 11)
> > + return GEN11_DE_PIPE_IRQ_FAULT_ERRORS;
> > + else if (INTEL_GEN(dev_priv) >= 9)
> > return GEN9_DE_PIPE_IRQ_FAULT_ERRORS;
> > else
> > return GEN8_DE_PIPE_IRQ_FAULT_ERRORS;
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h
> > b/drivers/gpu/drm/i915/i915_reg.h
> > index 6d67bd238cfe..24311fee7009 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -7373,6 +7373,9 @@ enum {
> > #define GEN8_PIPE_VSYNC (1 << 1)
> > #define GEN8_PIPE_VBLANK (1 << 0)
> > #define GEN9_PIPE_CURSOR_FAULT (1 << 11)
> > +#define GEN11_PIPE_PLANE7_FAULT (1 << 22)
> > +#define GEN11_PIPE_PLANE6_FAULT (1 << 21)
> > +#define GEN11_PIPE_PLANE5_FAULT (1 << 20)
> > #define GEN9_PIPE_PLANE4_FAULT (1 << 10)
> > #define GEN9_PIPE_PLANE3_FAULT (1 << 9)
> > #define GEN9_PIPE_PLANE2_FAULT (1 << 8)
> > @@ -7392,6 +7395,11 @@ enum {
> > GEN9_PIPE_PLANE3_FAULT | \
> > GEN9_PIPE_PLANE2_FAULT | \
> > GEN9_PIPE_PLANE1_FAULT)
> > +#define GEN11_DE_PIPE_IRQ_FAULT_ERRORS \
> > + (GEN9_DE_PIPE_IRQ_FAULT_ERRORS | \
> > + GEN11_PIPE_PLANE7_FAULT | \
> > + GEN11_PIPE_PLANE6_FAULT | \
> > + GEN11_PIPE_PLANE5_FAULT)
> >
> > #define GEN8_DE_PORT_ISR _MMIO(0x44440)
> > #define GEN8_DE_PORT_IMR _MMIO(0x44444)
--
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-10-24 23:48 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 21:17 [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes Matt Roper
2019-10-08 22:34 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-08 23:36 ` Matt Roper
2019-10-09 0:28 ` ✓ Fi.CI.BAT: success for drm/i915: Catch GTT fault errors for gen11+ planes (rev2) Patchwork
2019-10-09 8:48 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-24 21:17 ` [PATCH] drm/i915: Catch GTT fault errors for gen11+ planes Souza, Jose
2019-10-24 21:17 ` [Intel-gfx] " Souza, Jose
2019-10-24 23:49 ` Matt Roper
2019-10-24 23:49 ` [Intel-gfx] " Matt Roper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.