All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
	davem@davemloft.net, David Laight <david.laight@aculab.com>
Subject: Re: [PATCHv3 net-next 3/5] sctp: add SCTP_EXPOSE_POTENTIALLY_FAILED_STATE sockopt
Date: Fri, 25 Oct 2019 00:24:12 -0300	[thread overview]
Message-ID: <20191025032412.GD4326@localhost.localdomain> (raw)
In-Reply-To: <eedcaeabec9253902de381b75ffc00c007fcd2b6.1571033544.git.lucien.xin@gmail.com>

On Mon, Oct 14, 2019 at 02:14:46PM +0800, Xin Long wrote:
> This is a sockopt defined in section 7.3 of rfc7829: "Exposing
> the Potentially Failed Path State", by which users can change
> pf_expose per sock and asoc.
> 
> v1->v2:
>   - no change.
> v2->v3:
>   - return -EINVAL if params.assoc_value > SCTP_PF_EXPOSE_MAX.
>   - define SCTP_EXPOSE_PF_STATE SCTP_EXPOSE_POTENTIALLY_FAILED_STATE.

Hm, why again? Please add it to the changelog, as it's an exception on
the list below.

> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
>  include/uapi/linux/sctp.h |  2 ++
>  net/sctp/socket.c         | 79 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 81 insertions(+)
> 
> diff --git a/include/uapi/linux/sctp.h b/include/uapi/linux/sctp.h
> index d99b428..a190e4a 100644
> --- a/include/uapi/linux/sctp.h
> +++ b/include/uapi/linux/sctp.h
> @@ -137,6 +137,8 @@ typedef __s32 sctp_assoc_t;
>  #define SCTP_ASCONF_SUPPORTED	128
>  #define SCTP_AUTH_SUPPORTED	129
>  #define SCTP_ECN_SUPPORTED	130
> +#define SCTP_EXPOSE_POTENTIALLY_FAILED_STATE	131
> +#define SCTP_EXPOSE_PF_STATE	SCTP_EXPOSE_POTENTIALLY_FAILED_STATE
>  
>  /* PR-SCTP policies */
>  #define SCTP_PR_SCTP_NONE	0x0000

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
	davem@davemloft.net, David Laight <david.laight@aculab.com>
Subject: Re: [PATCHv3 net-next 3/5] sctp: add SCTP_EXPOSE_POTENTIALLY_FAILED_STATE sockopt
Date: Fri, 25 Oct 2019 03:24:12 +0000	[thread overview]
Message-ID: <20191025032412.GD4326@localhost.localdomain> (raw)
In-Reply-To: <eedcaeabec9253902de381b75ffc00c007fcd2b6.1571033544.git.lucien.xin@gmail.com>

On Mon, Oct 14, 2019 at 02:14:46PM +0800, Xin Long wrote:
> This is a sockopt defined in section 7.3 of rfc7829: "Exposing
> the Potentially Failed Path State", by which users can change
> pf_expose per sock and asoc.
> 
> v1->v2:
>   - no change.
> v2->v3:
>   - return -EINVAL if params.assoc_value > SCTP_PF_EXPOSE_MAX.
>   - define SCTP_EXPOSE_PF_STATE SCTP_EXPOSE_POTENTIALLY_FAILED_STATE.

Hm, why again? Please add it to the changelog, as it's an exception on
the list below.

> 
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
>  include/uapi/linux/sctp.h |  2 ++
>  net/sctp/socket.c         | 79 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 81 insertions(+)
> 
> diff --git a/include/uapi/linux/sctp.h b/include/uapi/linux/sctp.h
> index d99b428..a190e4a 100644
> --- a/include/uapi/linux/sctp.h
> +++ b/include/uapi/linux/sctp.h
> @@ -137,6 +137,8 @@ typedef __s32 sctp_assoc_t;
>  #define SCTP_ASCONF_SUPPORTED	128
>  #define SCTP_AUTH_SUPPORTED	129
>  #define SCTP_ECN_SUPPORTED	130
> +#define SCTP_EXPOSE_POTENTIALLY_FAILED_STATE	131
> +#define SCTP_EXPOSE_PF_STATE	SCTP_EXPOSE_POTENTIALLY_FAILED_STATE
>  
>  /* PR-SCTP policies */
>  #define SCTP_PR_SCTP_NONE	0x0000

  parent reply	other threads:[~2019-10-25  3:24 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14  6:14 [PATCHv3 net-next 0/5] sctp: update from rfc7829 Xin Long
2019-10-14  6:14 ` Xin Long
2019-10-14  6:14 ` [PATCHv3 net-next 1/5] sctp: add SCTP_ADDR_POTENTIALLY_FAILED notification Xin Long
2019-10-14  6:14   ` Xin Long
2019-10-14  6:14   ` [PATCHv3 net-next 2/5] sctp: add pf_expose per netns and sock and asoc Xin Long
2019-10-14  6:14     ` Xin Long
2019-10-14  6:14     ` [PATCHv3 net-next 3/5] sctp: add SCTP_EXPOSE_POTENTIALLY_FAILED_STATE sockopt Xin Long
2019-10-14  6:14       ` Xin Long
2019-10-14  6:14       ` [PATCHv3 net-next 4/5] sctp: add support for Primary Path Switchover Xin Long
2019-10-14  6:14         ` Xin Long
2019-10-14  6:14         ` [PATCHv3 net-next 5/5] sctp: add SCTP_PEER_ADDR_THLDS_V2 sockopt Xin Long
2019-10-14  6:14           ` Xin Long
2019-10-25  3:25         ` [PATCHv3 net-next 4/5] sctp: add support for Primary Path Switchover Marcelo Ricardo Leitner
2019-10-25  3:25           ` Marcelo Ricardo Leitner
2019-10-25  8:13           ` Xin Long
2019-10-25  8:13             ` Xin Long
2019-10-25  3:24       ` Marcelo Ricardo Leitner [this message]
2019-10-25  3:24         ` [PATCHv3 net-next 3/5] sctp: add SCTP_EXPOSE_POTENTIALLY_FAILED_STATE sockopt Marcelo Ricardo Leitner
2019-10-25  8:05         ` Xin Long
2019-10-25  8:05           ` Xin Long
2019-10-25  3:23     ` [PATCHv3 net-next 2/5] sctp: add pf_expose per netns and sock and asoc Marcelo Ricardo Leitner
2019-10-25  3:23       ` Marcelo Ricardo Leitner
2019-10-25  8:02       ` Xin Long
2019-10-25  8:02         ` Xin Long
2019-10-25  9:00       ` David Laight
2019-10-25  9:00         ` David Laight
2019-10-25 13:21         ` 'Marcelo Ricardo Leitner'
2019-10-25 13:21           ` 'Marcelo Ricardo Leitner'
2019-10-25 14:26           ` David Laight
2019-10-25 14:26             ` David Laight
2019-10-25 14:45             ` 'Marcelo Ricardo Leitner'
2019-10-25 14:45               ` 'Marcelo Ricardo Leitner'
2019-10-18 15:56   ` [PATCHv3 net-next 1/5] sctp: add SCTP_ADDR_POTENTIALLY_FAILED notification David Laight
2019-10-18 15:56     ` David Laight
2019-10-19  8:55     ` Xin Long
2019-10-19  8:55       ` Xin Long
2019-10-22 11:13       ` Xin Long
2019-10-22 11:13         ` Xin Long
2019-10-25  3:22       ` Marcelo Ricardo Leitner
2019-10-25  3:22         ` Marcelo Ricardo Leitner
2019-10-25  7:58         ` Xin Long
2019-10-25  7:58           ` Xin Long
2019-10-25  3:21   ` Marcelo Ricardo Leitner
2019-10-25  3:21     ` Marcelo Ricardo Leitner
2019-10-25  7:59     ` Xin Long
2019-10-25  7:59       ` Xin Long
2019-10-14 12:42 ` [PATCHv3 net-next 0/5] sctp: update from rfc7829 Neil Horman
2019-10-14 12:42   ` Neil Horman
2019-10-16  0:56 ` David Miller
2019-10-16  0:56   ` David Miller
2019-10-16 10:42   ` David Laight
2019-10-17  4:56     ` Xin Long
2019-10-17  4:56       ` Xin Long
2019-10-17  9:04       ` David Laight
2019-10-17  9:04         ` David Laight
2019-10-16 18:25 ` David Miller
2019-10-16 18:25   ` David Miller
2019-10-16 18:32   ` Marcelo Ricardo Leitner
2019-10-16 18:32     ` Marcelo Ricardo Leitner
2019-10-16 19:04     ` David Miller
2019-10-16 19:04       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025032412.GD4326@localhost.localdomain \
    --to=marcelo.leitner@gmail.com \
    --cc=davem@davemloft.net \
    --cc=david.laight@aculab.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.