* [RFC i-g-t 0/1] Per client engine busyness
@ 2019-10-25 14:24 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-10-25 14:24 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
intel_gpu_top counterpart for the equally named i915 series. For reference only
at this stage.
Tvrtko Ursulin (1):
intel-gpu-top: Support for client stats
tools/intel_gpu_top.c | 590 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 584 insertions(+), 6 deletions(-)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Intel-gfx] [RFC i-g-t 0/1] Per client engine busyness
@ 2019-10-25 14:24 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-10-25 14:24 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
intel_gpu_top counterpart for the equally named i915 series. For reference only
at this stage.
Tvrtko Ursulin (1):
intel-gpu-top: Support for client stats
tools/intel_gpu_top.c | 590 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 584 insertions(+), 6 deletions(-)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* [igt-dev] [RFC i-g-t 0/1] Per client engine busyness
@ 2019-10-25 14:24 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-10-25 14:24 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
intel_gpu_top counterpart for the equally named i915 series. For reference only
at this stage.
Tvrtko Ursulin (1):
intel-gpu-top: Support for client stats
tools/intel_gpu_top.c | 590 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 584 insertions(+), 6 deletions(-)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* [RFC i-g-t 1/1] intel-gpu-top: Support for client stats
@ 2019-10-25 14:24 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-10-25 14:24 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Adds support for per-client engine busyness stats i915 exports in sysfs
and produces output like the below:
==========================================================================
intel-gpu-top - 935/ 935 MHz; 0% RC6; 14.73 Watts; 1097 irqs/s
IMC reads: 1401 MiB/s
IMC writes: 4 MiB/s
ENGINE BUSY MI_SEMA MI_WAIT
Render/3D/0 63.73% |███████████████████ | 3% 0%
Blitter/0 9.53% |██▊ | 6% 0%
Video/0 39.32% |███████████▊ | 16% 0%
Video/1 15.62% |████▋ | 0% 0%
VideoEnhance/0 0.00% | | 0% 0%
PID NAME RCS BCS VCS VECS
4084 gem_wsim |█████▌ ||█ || || |
4086 gem_wsim |█▌ || ||███ || |
==========================================================================
Apart from the existing physical engine utilization it now also shows
utilization per client and per engine class.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tools/intel_gpu_top.c | 590 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 584 insertions(+), 6 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index cc8db7c539ed..50e9c153329a 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -659,8 +659,403 @@ static void pmu_sample(struct engines *engines)
}
}
+enum client_status {
+ FREE = 0, /* mbz */
+ ALIVE,
+ PROBE
+};
+
+struct clients;
+
+struct client {
+ struct clients *clients;
+
+ enum client_status status;
+ unsigned int id;
+ unsigned int pid;
+ char name[128];
+ unsigned int samples;
+ unsigned long total;
+ struct engines *engines;
+ unsigned long *val;
+ uint64_t *last;
+};
+
+struct engine_class {
+ unsigned int class;
+ const char *name;
+ unsigned int num_engines;
+};
+
+struct clients {
+ unsigned int num_classes;
+ struct engine_class *class;
+
+ unsigned int num_clients;
+ struct client *client;
+};
+
+#define for_each_client(clients, c, tmp) \
+ for ((tmp) = (clients)->num_clients, c = (clients)->client; \
+ (tmp > 0); (tmp)--, (c)++)
+
+#define SYSFS_ENABLE "/sys/class/drm/card0/clients/enable_stats"
+
+bool __stats_enabled;
+
+static int __set_stats(bool val)
+{
+ int fd, ret;
+
+ fd = open(SYSFS_ENABLE, O_WRONLY);
+ if (fd < 0)
+ return -errno;
+
+ ret = write(fd, val ? "1" : "0", 2);
+ if (ret < 0)
+ return -errno;
+ else if (ret < 2)
+ return 1;
+
+ close(fd);
+
+ return 0;
+}
+
+static void __restore_stats(void)
+{
+ int ret;
+
+ if (__stats_enabled)
+ return;
+
+ ret = __set_stats(false);
+ if (ret)
+ fprintf(stderr, "Failed to disable per-client stats! (%d)\n",
+ ret);
+}
+
+static void __restore_stats_signal(int sig)
+{
+ exit(0);
+}
+
+static int enable_stats(void)
+{
+ int fd, ret;
+
+ fd = open(SYSFS_ENABLE, O_RDONLY);
+ if (fd < 0)
+ return -errno;
+
+ close(fd);
+
+ __stats_enabled = filename_to_u64(SYSFS_ENABLE, 10);
+ if (__stats_enabled)
+ return 0;
+
+ ret = __set_stats(true);
+ if (!ret) {
+ if (atexit(__restore_stats))
+ fprintf(stderr, "Failed to register exit handler!");
+
+ if (signal(SIGINT, __restore_stats_signal))
+ fprintf(stderr, "Failed to register signal handler!");
+ } else {
+ fprintf(stderr, "Failed to enable per-client stats! (%d)\n",
+ ret);
+ }
+
+ return ret;
+}
+
+static struct clients *init_clients(void)
+{
+ struct clients *clients = malloc(sizeof(*clients));
+
+ if (enable_stats()) {
+ free(clients);
+ return NULL;
+ }
+
+ return memset(clients, 0, sizeof(*clients));
+}
+
+#define SYSFS_CLIENTS "/sys/class/drm/card0/clients"
+
+static uint64_t read_client_busy(unsigned int id, unsigned int class)
+{
+ char buf[256];
+ ssize_t ret;
+
+ ret = snprintf(buf, sizeof(buf),
+ SYSFS_CLIENTS "/%u/busy/%u",
+ id, class);
+ assert(ret > 0 && ret < sizeof(buf));
+ if (ret <= 0 || ret == sizeof(buf))
+ return 0;
+
+ return filename_to_u64(buf, 10);
+}
+
+static struct client *
+find_client(struct clients *clients, enum client_status status, unsigned int id)
+{
+ struct client *c;
+ int tmp;
+
+ for_each_client(clients, c, tmp) {
+ if ((status == FREE && c->status == FREE) ||
+ (status == c->status && c->id == id))
+ return c;
+ }
+
+ return NULL;
+}
+
+static void update_client(struct client *c, unsigned int pid, char *name)
+{
+ uint64_t val[c->clients->num_classes];
+ unsigned int i;
+
+ if (c->pid != pid)
+ c->pid = pid;
+
+ if (strncmp(c->name, name, sizeof(c->name)))
+ strncpy(c->name, name, sizeof(c->name));
+
+ for (i = 0; i < c->clients->num_classes; i++)
+ val[i] = read_client_busy(c->id, c->clients->class[i].class);
+
+ c->total = 0;
+
+ for (i = 0; i < c->clients->num_classes; i++) {
+ assert(val[i] >= c->last[i]);
+ c->val[i] = val[i] - c->last[i];
+ c->total += c->val[i];
+ c->last[i] = val[i];
+ }
+
+ c->samples++;
+ c->status = ALIVE;
+}
+
+static int class_cmp(const void *_a, const void *_b)
+{
+ const struct engine_class *a = _a;
+ const struct engine_class *b = _b;
+
+ return a->class - b->class;
+}
+
+static void scan_classes(struct clients *clients, unsigned int id)
+{
+ struct engine_class *classes;
+ unsigned int num, i;
+ struct dirent *dent;
+ char buf[256];
+ int ret;
+ DIR *d;
+
+ ret = snprintf(buf, sizeof(buf), SYSFS_CLIENTS "/%u/busy", id);
+ assert(ret > 0 && ret < sizeof(buf));
+ if (ret <= 0 || ret == sizeof(buf))
+ return;
+
+ d = opendir(buf);
+ if (!d)
+ return;
+
+restart:
+ rewinddir(d);
+
+ num = 0;
+ while ((dent = readdir(d)) != NULL) {
+ if (dent->d_type != DT_REG)
+ continue;
+
+ num++;
+ }
+
+ rewinddir(d);
+
+ classes = calloc(num, sizeof(*classes));
+ assert(classes);
+
+ i = 0;
+ while ((dent = readdir(d)) != NULL) {
+ if (i > num) {
+ // FIXME: free individual names
+ free(classes);
+ goto restart;
+ }
+
+ if (dent->d_type != DT_REG)
+ continue;
+
+ classes[i].class = atoi(dent->d_name);
+ classes[i].name = class_short_name(classes[i].class);
+ i++;
+ }
+
+ closedir(d);
+
+ qsort(classes, num, sizeof(*classes), class_cmp);
+
+ clients->num_classes = num;
+ clients->class = classes;
+}
+
+static void
+add_client(struct clients *clients, unsigned int id, unsigned int pid,
+ char *name)
+{
+ struct client *c;
+
+ assert(!find_client(clients, ALIVE, id));
+
+ c = find_client(clients, FREE, 0);
+ if (!c) {
+ unsigned int idx = clients->num_clients;
+
+ clients->num_clients += (clients->num_clients + 2) / 2;
+ clients->client = realloc(clients->client,
+ clients->num_clients * sizeof(*c));
+ assert(clients->client);
+
+ c = &clients->client[idx];
+ memset(c, 0, (clients->num_clients - idx) * sizeof(*c));
+ }
+
+ if (!clients->num_classes)
+ scan_classes(clients, id);
+
+ c->id = id;
+ c->clients = clients;
+ c->val = calloc(clients->num_classes, sizeof(c->val));
+ c->last = calloc(clients->num_classes, sizeof(c->last));
+ assert(c->val && c->last);
+
+ update_client(c, pid, name);
+}
+
+static void free_client(struct client *c)
+{
+ free(c->val);
+ free(c->last);
+ memset(c, 0, sizeof(*c));
+}
+
+static char *read_client_sysfs(unsigned int id, const char *field)
+{
+ char buf[256];
+ ssize_t ret;
+
+ ret = snprintf(buf, sizeof(buf), SYSFS_CLIENTS "/%u/%s", id, field);
+ assert(ret > 0 && ret < sizeof(buf));
+ if (ret <= 0 || ret == sizeof(buf))
+ return NULL;
+
+ ret = filename_to_buf(buf, buf, sizeof(buf));
+ assert(ret == 0);
+ if (ret)
+ return NULL;
+
+ return strdup(buf);
+}
+
+static void scan_clients(struct clients *clients)
+{
+ struct dirent *dent;
+ struct client *c;
+ char *pid, *name;
+ unsigned int id;
+ int tmp;
+ DIR *d;
+
+ if (!clients)
+ return;
+
+ for_each_client(clients, c, tmp) {
+ if (c->status == ALIVE)
+ c->status = PROBE;
+ }
+
+ d = opendir(SYSFS_CLIENTS);
+ if (!d)
+ return;
+
+ while ((dent = readdir(d)) != NULL) {
+ if (dent->d_type != DT_DIR)
+ continue;
+ if (!isdigit(dent->d_name[0]))
+ continue;
+
+ id = atoi(dent->d_name);
+
+ name = read_client_sysfs(id, "name");
+ assert(name);
+ if (!name)
+ continue;
+
+ pid = read_client_sysfs(id, "pid");
+ assert(pid);
+ if (!pid) {
+ free(name);
+ continue;
+ }
+
+ c = find_client(clients, PROBE, id);
+ if (c) {
+ update_client(c, atoi(pid), name);
+ continue;
+ }
+
+ add_client(clients, id, atoi(pid), name);
+
+ free(name);
+ free(pid);
+ }
+
+ closedir(d);
+
+ for_each_client(clients, c, tmp) {
+ if (c->status == PROBE)
+ free_client(c);
+ }
+}
+
+static int cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ long tot_a = a->total;
+ long tot_b = b->total;
+
+ tot_a *= a->status == ALIVE && a->samples > 1;
+ tot_b *= b->status == ALIVE && b->samples > 1;
+
+ tot_b -= tot_a;
+
+ if (!tot_b)
+ return (int)b->id - a->id;
+
+ while (tot_b > INT_MAX || tot_b < INT_MIN)
+ tot_b /= 2;
+
+ return tot_b;
+}
+
static const char *bars[] = { " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" };
+static void n_spaces(const unsigned int n)
+{
+ unsigned int i;
+
+ for (i = 0; i < n; i++)
+ putchar(' ');
+}
+
static void
print_percentage_bar(double percent, int max_len)
{
@@ -674,8 +1069,10 @@ print_percentage_bar(double percent, int max_len)
if (i)
printf("%s", bars[i]);
- for (i = 0; i < (max_len - 2 - (bar_len + 7) / 8); i++)
- putchar(' ');
+ bar_len = max_len - 2 - (bar_len + 7) / 8;
+ if (bar_len > max_len)
+ bar_len = max_len;
+ n_spaces(bar_len);
putchar('|');
}
@@ -775,6 +1172,18 @@ json_close_struct(void)
fflush(stdout);
}
+static void
+__json_add_member(const char *key, const char *val)
+{
+ assert(json_indent_level < ARRAY_SIZE(json_indent));
+
+ fprintf(out, "%s%s\"%s\": \"%s\"",
+ json_struct_members ? ",\n" : "",
+ json_indent[json_indent_level], key, val);
+
+ json_struct_members++;
+}
+
static unsigned int
json_add_member(const struct cnt_group *parent, struct cnt_item *item,
unsigned int headers)
@@ -1075,8 +1484,6 @@ print_header(struct engines *engines, double t,
memmove(&groups[0], &groups[1],
sizeof(groups) - sizeof(groups[0]));
- pops->open_struct(NULL);
-
*consumed = print_groups(groups);
if (output_mode == INTERACTIVE) {
@@ -1232,7 +1639,6 @@ print_engines_footer(struct engines *engines, double t,
int lines, int con_w, int con_h)
{
pops->close_struct();
- pops->close_struct();
if (output_mode == INTERACTIVE) {
if (lines++ < con_h)
@@ -1242,6 +1648,136 @@ print_engines_footer(struct engines *engines, double t,
return lines;
}
+static int
+print_clients_header(struct clients *clients, int lines,
+ int con_w, int con_h, unsigned int *class_w)
+{
+ int len;
+
+ if (output_mode == INTERACTIVE) {
+ if (lines++ >= con_h)
+ return lines;
+
+ printf("\033[7m");
+ len = printf("%5s%16s", "PID", "NAME");
+
+ if (lines++ >= con_h)
+ return lines;
+
+ if (clients->num_classes) {
+ unsigned int i;
+
+ *class_w = (con_w - len) / clients->num_classes;
+
+ for (i = 0; i < clients->num_classes; i++) {
+ unsigned int name_len =
+ strlen(clients->class[i].name);
+ unsigned int pad = (*class_w - name_len) / 2;
+
+ n_spaces(pad);
+ printf("%s", clients->class[i].name);
+ n_spaces(*class_w - pad - name_len);
+ len += pad + name_len +
+ (*class_w - pad - name_len);
+ }
+ }
+
+ n_spaces(con_w - len);
+ printf("\033[0m\n");
+ } else {
+ if (clients->num_classes)
+ pops->open_struct("clients");
+ }
+
+ return lines;
+}
+
+static void count_engines(struct clients *clients, struct engines *engines)
+{
+ unsigned int i;
+
+ for (i = 0; i < engines->num_engines; i++) {
+ struct engine *engine = engine_ptr(engines, i);
+
+ clients->class[engine->class].num_engines++;
+ }
+}
+
+static int
+print_client(struct client *c, struct engines *engines, double t, int lines,
+ int con_w, int con_h, unsigned int period_us,
+ unsigned int *class_w)
+{
+ struct clients *clients = c->clients;
+ unsigned int i;
+
+ if (output_mode == INTERACTIVE) {
+ printf("%5u%16s ", c->pid, c->name);
+
+ for (i = 0; i < clients->num_classes; i++) {
+ double pct;
+
+ if (!clients->class[i].num_engines)
+ count_engines(clients, engines);
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100 /
+ clients->class[i].num_engines;
+
+ print_percentage_bar(pct, *class_w);
+ }
+
+ putchar('\n');
+ } else if (output_mode == JSON) {
+ char buf[64];
+
+ snprintf(buf, sizeof(buf), "%u", c->id);
+ pops->open_struct(buf);
+
+ __json_add_member("name", c->name);
+
+ snprintf(buf, sizeof(buf), "%u", c->pid);
+ __json_add_member("pid", buf);
+
+ pops->open_struct("engine-classes");
+
+ for (i = 0; i < clients->num_classes; i++) {
+ double pct;
+
+ snprintf(buf, sizeof(buf), "%s",
+ clients->class[i].name);
+ pops->open_struct(buf);
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100;
+ snprintf(buf, sizeof(buf), "%f", pct);
+ __json_add_member("busy", buf);
+
+ __json_add_member("unit", "%");
+
+ pops->close_struct();
+ }
+
+ pops->close_struct();
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
+static int
+print_clients_footer(struct clients *clients, double t,
+ int lines, int con_w, int con_h)
+{
+ if (output_mode == INTERACTIVE) {
+ if (lines++ < con_h)
+ printf("\n");
+ } else {
+ if (clients->num_classes)
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
static bool stop_top;
static void sigint_handler(int sig)
@@ -1252,6 +1788,7 @@ static void sigint_handler(int sig)
int main(int argc, char **argv)
{
unsigned int period_us = DEFAULT_PERIOD_MS * 1000;
+ struct clients *clients = NULL;
int con_w = -1, con_h = -1;
char *output_path = NULL;
struct engines *engines;
@@ -1335,12 +1872,17 @@ int main(int argc, char **argv)
return 1;
}
+ clients = init_clients();
+
pmu_sample(engines);
+ scan_clients(clients);
while (!stop_top) {
bool consumed = false;
- int lines = 0;
+ int j, lines = 0;
+ unsigned int class_w;
struct winsize ws;
+ struct client *c;
double t;
/* Update terminal size. */
@@ -1354,10 +1896,18 @@ int main(int argc, char **argv)
pmu_sample(engines);
t = (double)(engines->ts.cur - engines->ts.prev) / 1e9;
+ scan_clients(clients);
+ if (clients) {
+ qsort(clients->client, clients->num_clients,
+ sizeof(*clients->client), cmp);
+ }
+
if (stop_top)
break;
while (!consumed) {
+ pops->open_struct(NULL);
+
lines = print_header(engines, t, lines, con_w, con_h,
&consumed);
@@ -1376,6 +1926,34 @@ int main(int argc, char **argv)
lines = print_engines_footer(engines, t, lines, con_w,
con_h);
+
+ if (clients) {
+ lines = print_clients_header(clients, lines,
+ con_w, con_h,
+ &class_w);
+
+ for_each_client(clients, c, j) {
+ if (lines++ > con_h)
+ break;
+
+ assert(c->status != PROBE);
+ if (c->status != ALIVE)
+ break;
+
+ if (c->samples < 2)
+ continue;
+
+ lines = print_client(c, engines, t,
+ lines, con_w,
+ con_h, period_us,
+ &class_w);
+ }
+
+ lines = print_clients_footer(clients, t, lines,
+ con_w, con_h);
+ }
+
+ pops->close_struct();
}
if (stop_top)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Intel-gfx] [RFC i-g-t 1/1] intel-gpu-top: Support for client stats
@ 2019-10-25 14:24 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-10-25 14:24 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Adds support for per-client engine busyness stats i915 exports in sysfs
and produces output like the below:
==========================================================================
intel-gpu-top - 935/ 935 MHz; 0% RC6; 14.73 Watts; 1097 irqs/s
IMC reads: 1401 MiB/s
IMC writes: 4 MiB/s
ENGINE BUSY MI_SEMA MI_WAIT
Render/3D/0 63.73% |███████████████████ | 3% 0%
Blitter/0 9.53% |██▊ | 6% 0%
Video/0 39.32% |███████████▊ | 16% 0%
Video/1 15.62% |████▋ | 0% 0%
VideoEnhance/0 0.00% | | 0% 0%
PID NAME RCS BCS VCS VECS
4084 gem_wsim |█████▌ ||█ || || |
4086 gem_wsim |█▌ || ||███ || |
==========================================================================
Apart from the existing physical engine utilization it now also shows
utilization per client and per engine class.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tools/intel_gpu_top.c | 590 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 584 insertions(+), 6 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index cc8db7c539ed..50e9c153329a 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -659,8 +659,403 @@ static void pmu_sample(struct engines *engines)
}
}
+enum client_status {
+ FREE = 0, /* mbz */
+ ALIVE,
+ PROBE
+};
+
+struct clients;
+
+struct client {
+ struct clients *clients;
+
+ enum client_status status;
+ unsigned int id;
+ unsigned int pid;
+ char name[128];
+ unsigned int samples;
+ unsigned long total;
+ struct engines *engines;
+ unsigned long *val;
+ uint64_t *last;
+};
+
+struct engine_class {
+ unsigned int class;
+ const char *name;
+ unsigned int num_engines;
+};
+
+struct clients {
+ unsigned int num_classes;
+ struct engine_class *class;
+
+ unsigned int num_clients;
+ struct client *client;
+};
+
+#define for_each_client(clients, c, tmp) \
+ for ((tmp) = (clients)->num_clients, c = (clients)->client; \
+ (tmp > 0); (tmp)--, (c)++)
+
+#define SYSFS_ENABLE "/sys/class/drm/card0/clients/enable_stats"
+
+bool __stats_enabled;
+
+static int __set_stats(bool val)
+{
+ int fd, ret;
+
+ fd = open(SYSFS_ENABLE, O_WRONLY);
+ if (fd < 0)
+ return -errno;
+
+ ret = write(fd, val ? "1" : "0", 2);
+ if (ret < 0)
+ return -errno;
+ else if (ret < 2)
+ return 1;
+
+ close(fd);
+
+ return 0;
+}
+
+static void __restore_stats(void)
+{
+ int ret;
+
+ if (__stats_enabled)
+ return;
+
+ ret = __set_stats(false);
+ if (ret)
+ fprintf(stderr, "Failed to disable per-client stats! (%d)\n",
+ ret);
+}
+
+static void __restore_stats_signal(int sig)
+{
+ exit(0);
+}
+
+static int enable_stats(void)
+{
+ int fd, ret;
+
+ fd = open(SYSFS_ENABLE, O_RDONLY);
+ if (fd < 0)
+ return -errno;
+
+ close(fd);
+
+ __stats_enabled = filename_to_u64(SYSFS_ENABLE, 10);
+ if (__stats_enabled)
+ return 0;
+
+ ret = __set_stats(true);
+ if (!ret) {
+ if (atexit(__restore_stats))
+ fprintf(stderr, "Failed to register exit handler!");
+
+ if (signal(SIGINT, __restore_stats_signal))
+ fprintf(stderr, "Failed to register signal handler!");
+ } else {
+ fprintf(stderr, "Failed to enable per-client stats! (%d)\n",
+ ret);
+ }
+
+ return ret;
+}
+
+static struct clients *init_clients(void)
+{
+ struct clients *clients = malloc(sizeof(*clients));
+
+ if (enable_stats()) {
+ free(clients);
+ return NULL;
+ }
+
+ return memset(clients, 0, sizeof(*clients));
+}
+
+#define SYSFS_CLIENTS "/sys/class/drm/card0/clients"
+
+static uint64_t read_client_busy(unsigned int id, unsigned int class)
+{
+ char buf[256];
+ ssize_t ret;
+
+ ret = snprintf(buf, sizeof(buf),
+ SYSFS_CLIENTS "/%u/busy/%u",
+ id, class);
+ assert(ret > 0 && ret < sizeof(buf));
+ if (ret <= 0 || ret == sizeof(buf))
+ return 0;
+
+ return filename_to_u64(buf, 10);
+}
+
+static struct client *
+find_client(struct clients *clients, enum client_status status, unsigned int id)
+{
+ struct client *c;
+ int tmp;
+
+ for_each_client(clients, c, tmp) {
+ if ((status == FREE && c->status == FREE) ||
+ (status == c->status && c->id == id))
+ return c;
+ }
+
+ return NULL;
+}
+
+static void update_client(struct client *c, unsigned int pid, char *name)
+{
+ uint64_t val[c->clients->num_classes];
+ unsigned int i;
+
+ if (c->pid != pid)
+ c->pid = pid;
+
+ if (strncmp(c->name, name, sizeof(c->name)))
+ strncpy(c->name, name, sizeof(c->name));
+
+ for (i = 0; i < c->clients->num_classes; i++)
+ val[i] = read_client_busy(c->id, c->clients->class[i].class);
+
+ c->total = 0;
+
+ for (i = 0; i < c->clients->num_classes; i++) {
+ assert(val[i] >= c->last[i]);
+ c->val[i] = val[i] - c->last[i];
+ c->total += c->val[i];
+ c->last[i] = val[i];
+ }
+
+ c->samples++;
+ c->status = ALIVE;
+}
+
+static int class_cmp(const void *_a, const void *_b)
+{
+ const struct engine_class *a = _a;
+ const struct engine_class *b = _b;
+
+ return a->class - b->class;
+}
+
+static void scan_classes(struct clients *clients, unsigned int id)
+{
+ struct engine_class *classes;
+ unsigned int num, i;
+ struct dirent *dent;
+ char buf[256];
+ int ret;
+ DIR *d;
+
+ ret = snprintf(buf, sizeof(buf), SYSFS_CLIENTS "/%u/busy", id);
+ assert(ret > 0 && ret < sizeof(buf));
+ if (ret <= 0 || ret == sizeof(buf))
+ return;
+
+ d = opendir(buf);
+ if (!d)
+ return;
+
+restart:
+ rewinddir(d);
+
+ num = 0;
+ while ((dent = readdir(d)) != NULL) {
+ if (dent->d_type != DT_REG)
+ continue;
+
+ num++;
+ }
+
+ rewinddir(d);
+
+ classes = calloc(num, sizeof(*classes));
+ assert(classes);
+
+ i = 0;
+ while ((dent = readdir(d)) != NULL) {
+ if (i > num) {
+ // FIXME: free individual names
+ free(classes);
+ goto restart;
+ }
+
+ if (dent->d_type != DT_REG)
+ continue;
+
+ classes[i].class = atoi(dent->d_name);
+ classes[i].name = class_short_name(classes[i].class);
+ i++;
+ }
+
+ closedir(d);
+
+ qsort(classes, num, sizeof(*classes), class_cmp);
+
+ clients->num_classes = num;
+ clients->class = classes;
+}
+
+static void
+add_client(struct clients *clients, unsigned int id, unsigned int pid,
+ char *name)
+{
+ struct client *c;
+
+ assert(!find_client(clients, ALIVE, id));
+
+ c = find_client(clients, FREE, 0);
+ if (!c) {
+ unsigned int idx = clients->num_clients;
+
+ clients->num_clients += (clients->num_clients + 2) / 2;
+ clients->client = realloc(clients->client,
+ clients->num_clients * sizeof(*c));
+ assert(clients->client);
+
+ c = &clients->client[idx];
+ memset(c, 0, (clients->num_clients - idx) * sizeof(*c));
+ }
+
+ if (!clients->num_classes)
+ scan_classes(clients, id);
+
+ c->id = id;
+ c->clients = clients;
+ c->val = calloc(clients->num_classes, sizeof(c->val));
+ c->last = calloc(clients->num_classes, sizeof(c->last));
+ assert(c->val && c->last);
+
+ update_client(c, pid, name);
+}
+
+static void free_client(struct client *c)
+{
+ free(c->val);
+ free(c->last);
+ memset(c, 0, sizeof(*c));
+}
+
+static char *read_client_sysfs(unsigned int id, const char *field)
+{
+ char buf[256];
+ ssize_t ret;
+
+ ret = snprintf(buf, sizeof(buf), SYSFS_CLIENTS "/%u/%s", id, field);
+ assert(ret > 0 && ret < sizeof(buf));
+ if (ret <= 0 || ret == sizeof(buf))
+ return NULL;
+
+ ret = filename_to_buf(buf, buf, sizeof(buf));
+ assert(ret == 0);
+ if (ret)
+ return NULL;
+
+ return strdup(buf);
+}
+
+static void scan_clients(struct clients *clients)
+{
+ struct dirent *dent;
+ struct client *c;
+ char *pid, *name;
+ unsigned int id;
+ int tmp;
+ DIR *d;
+
+ if (!clients)
+ return;
+
+ for_each_client(clients, c, tmp) {
+ if (c->status == ALIVE)
+ c->status = PROBE;
+ }
+
+ d = opendir(SYSFS_CLIENTS);
+ if (!d)
+ return;
+
+ while ((dent = readdir(d)) != NULL) {
+ if (dent->d_type != DT_DIR)
+ continue;
+ if (!isdigit(dent->d_name[0]))
+ continue;
+
+ id = atoi(dent->d_name);
+
+ name = read_client_sysfs(id, "name");
+ assert(name);
+ if (!name)
+ continue;
+
+ pid = read_client_sysfs(id, "pid");
+ assert(pid);
+ if (!pid) {
+ free(name);
+ continue;
+ }
+
+ c = find_client(clients, PROBE, id);
+ if (c) {
+ update_client(c, atoi(pid), name);
+ continue;
+ }
+
+ add_client(clients, id, atoi(pid), name);
+
+ free(name);
+ free(pid);
+ }
+
+ closedir(d);
+
+ for_each_client(clients, c, tmp) {
+ if (c->status == PROBE)
+ free_client(c);
+ }
+}
+
+static int cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ long tot_a = a->total;
+ long tot_b = b->total;
+
+ tot_a *= a->status == ALIVE && a->samples > 1;
+ tot_b *= b->status == ALIVE && b->samples > 1;
+
+ tot_b -= tot_a;
+
+ if (!tot_b)
+ return (int)b->id - a->id;
+
+ while (tot_b > INT_MAX || tot_b < INT_MIN)
+ tot_b /= 2;
+
+ return tot_b;
+}
+
static const char *bars[] = { " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" };
+static void n_spaces(const unsigned int n)
+{
+ unsigned int i;
+
+ for (i = 0; i < n; i++)
+ putchar(' ');
+}
+
static void
print_percentage_bar(double percent, int max_len)
{
@@ -674,8 +1069,10 @@ print_percentage_bar(double percent, int max_len)
if (i)
printf("%s", bars[i]);
- for (i = 0; i < (max_len - 2 - (bar_len + 7) / 8); i++)
- putchar(' ');
+ bar_len = max_len - 2 - (bar_len + 7) / 8;
+ if (bar_len > max_len)
+ bar_len = max_len;
+ n_spaces(bar_len);
putchar('|');
}
@@ -775,6 +1172,18 @@ json_close_struct(void)
fflush(stdout);
}
+static void
+__json_add_member(const char *key, const char *val)
+{
+ assert(json_indent_level < ARRAY_SIZE(json_indent));
+
+ fprintf(out, "%s%s\"%s\": \"%s\"",
+ json_struct_members ? ",\n" : "",
+ json_indent[json_indent_level], key, val);
+
+ json_struct_members++;
+}
+
static unsigned int
json_add_member(const struct cnt_group *parent, struct cnt_item *item,
unsigned int headers)
@@ -1075,8 +1484,6 @@ print_header(struct engines *engines, double t,
memmove(&groups[0], &groups[1],
sizeof(groups) - sizeof(groups[0]));
- pops->open_struct(NULL);
-
*consumed = print_groups(groups);
if (output_mode == INTERACTIVE) {
@@ -1232,7 +1639,6 @@ print_engines_footer(struct engines *engines, double t,
int lines, int con_w, int con_h)
{
pops->close_struct();
- pops->close_struct();
if (output_mode == INTERACTIVE) {
if (lines++ < con_h)
@@ -1242,6 +1648,136 @@ print_engines_footer(struct engines *engines, double t,
return lines;
}
+static int
+print_clients_header(struct clients *clients, int lines,
+ int con_w, int con_h, unsigned int *class_w)
+{
+ int len;
+
+ if (output_mode == INTERACTIVE) {
+ if (lines++ >= con_h)
+ return lines;
+
+ printf("\033[7m");
+ len = printf("%5s%16s", "PID", "NAME");
+
+ if (lines++ >= con_h)
+ return lines;
+
+ if (clients->num_classes) {
+ unsigned int i;
+
+ *class_w = (con_w - len) / clients->num_classes;
+
+ for (i = 0; i < clients->num_classes; i++) {
+ unsigned int name_len =
+ strlen(clients->class[i].name);
+ unsigned int pad = (*class_w - name_len) / 2;
+
+ n_spaces(pad);
+ printf("%s", clients->class[i].name);
+ n_spaces(*class_w - pad - name_len);
+ len += pad + name_len +
+ (*class_w - pad - name_len);
+ }
+ }
+
+ n_spaces(con_w - len);
+ printf("\033[0m\n");
+ } else {
+ if (clients->num_classes)
+ pops->open_struct("clients");
+ }
+
+ return lines;
+}
+
+static void count_engines(struct clients *clients, struct engines *engines)
+{
+ unsigned int i;
+
+ for (i = 0; i < engines->num_engines; i++) {
+ struct engine *engine = engine_ptr(engines, i);
+
+ clients->class[engine->class].num_engines++;
+ }
+}
+
+static int
+print_client(struct client *c, struct engines *engines, double t, int lines,
+ int con_w, int con_h, unsigned int period_us,
+ unsigned int *class_w)
+{
+ struct clients *clients = c->clients;
+ unsigned int i;
+
+ if (output_mode == INTERACTIVE) {
+ printf("%5u%16s ", c->pid, c->name);
+
+ for (i = 0; i < clients->num_classes; i++) {
+ double pct;
+
+ if (!clients->class[i].num_engines)
+ count_engines(clients, engines);
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100 /
+ clients->class[i].num_engines;
+
+ print_percentage_bar(pct, *class_w);
+ }
+
+ putchar('\n');
+ } else if (output_mode == JSON) {
+ char buf[64];
+
+ snprintf(buf, sizeof(buf), "%u", c->id);
+ pops->open_struct(buf);
+
+ __json_add_member("name", c->name);
+
+ snprintf(buf, sizeof(buf), "%u", c->pid);
+ __json_add_member("pid", buf);
+
+ pops->open_struct("engine-classes");
+
+ for (i = 0; i < clients->num_classes; i++) {
+ double pct;
+
+ snprintf(buf, sizeof(buf), "%s",
+ clients->class[i].name);
+ pops->open_struct(buf);
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100;
+ snprintf(buf, sizeof(buf), "%f", pct);
+ __json_add_member("busy", buf);
+
+ __json_add_member("unit", "%");
+
+ pops->close_struct();
+ }
+
+ pops->close_struct();
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
+static int
+print_clients_footer(struct clients *clients, double t,
+ int lines, int con_w, int con_h)
+{
+ if (output_mode == INTERACTIVE) {
+ if (lines++ < con_h)
+ printf("\n");
+ } else {
+ if (clients->num_classes)
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
static bool stop_top;
static void sigint_handler(int sig)
@@ -1252,6 +1788,7 @@ static void sigint_handler(int sig)
int main(int argc, char **argv)
{
unsigned int period_us = DEFAULT_PERIOD_MS * 1000;
+ struct clients *clients = NULL;
int con_w = -1, con_h = -1;
char *output_path = NULL;
struct engines *engines;
@@ -1335,12 +1872,17 @@ int main(int argc, char **argv)
return 1;
}
+ clients = init_clients();
+
pmu_sample(engines);
+ scan_clients(clients);
while (!stop_top) {
bool consumed = false;
- int lines = 0;
+ int j, lines = 0;
+ unsigned int class_w;
struct winsize ws;
+ struct client *c;
double t;
/* Update terminal size. */
@@ -1354,10 +1896,18 @@ int main(int argc, char **argv)
pmu_sample(engines);
t = (double)(engines->ts.cur - engines->ts.prev) / 1e9;
+ scan_clients(clients);
+ if (clients) {
+ qsort(clients->client, clients->num_clients,
+ sizeof(*clients->client), cmp);
+ }
+
if (stop_top)
break;
while (!consumed) {
+ pops->open_struct(NULL);
+
lines = print_header(engines, t, lines, con_w, con_h,
&consumed);
@@ -1376,6 +1926,34 @@ int main(int argc, char **argv)
lines = print_engines_footer(engines, t, lines, con_w,
con_h);
+
+ if (clients) {
+ lines = print_clients_header(clients, lines,
+ con_w, con_h,
+ &class_w);
+
+ for_each_client(clients, c, j) {
+ if (lines++ > con_h)
+ break;
+
+ assert(c->status != PROBE);
+ if (c->status != ALIVE)
+ break;
+
+ if (c->samples < 2)
+ continue;
+
+ lines = print_client(c, engines, t,
+ lines, con_w,
+ con_h, period_us,
+ &class_w);
+ }
+
+ lines = print_clients_footer(clients, t, lines,
+ con_w, con_h);
+ }
+
+ pops->close_struct();
}
if (stop_top)
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] [RFC i-g-t 1/1] intel-gpu-top: Support for client stats
@ 2019-10-25 14:24 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-10-25 14:24 UTC (permalink / raw)
To: igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Adds support for per-client engine busyness stats i915 exports in sysfs
and produces output like the below:
==========================================================================
intel-gpu-top - 935/ 935 MHz; 0% RC6; 14.73 Watts; 1097 irqs/s
IMC reads: 1401 MiB/s
IMC writes: 4 MiB/s
ENGINE BUSY MI_SEMA MI_WAIT
Render/3D/0 63.73% |███████████████████ | 3% 0%
Blitter/0 9.53% |██▊ | 6% 0%
Video/0 39.32% |███████████▊ | 16% 0%
Video/1 15.62% |████▋ | 0% 0%
VideoEnhance/0 0.00% | | 0% 0%
PID NAME RCS BCS VCS VECS
4084 gem_wsim |█████▌ ||█ || || |
4086 gem_wsim |█▌ || ||███ || |
==========================================================================
Apart from the existing physical engine utilization it now also shows
utilization per client and per engine class.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
tools/intel_gpu_top.c | 590 +++++++++++++++++++++++++++++++++++++++++-
1 file changed, 584 insertions(+), 6 deletions(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index cc8db7c539ed..50e9c153329a 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -659,8 +659,403 @@ static void pmu_sample(struct engines *engines)
}
}
+enum client_status {
+ FREE = 0, /* mbz */
+ ALIVE,
+ PROBE
+};
+
+struct clients;
+
+struct client {
+ struct clients *clients;
+
+ enum client_status status;
+ unsigned int id;
+ unsigned int pid;
+ char name[128];
+ unsigned int samples;
+ unsigned long total;
+ struct engines *engines;
+ unsigned long *val;
+ uint64_t *last;
+};
+
+struct engine_class {
+ unsigned int class;
+ const char *name;
+ unsigned int num_engines;
+};
+
+struct clients {
+ unsigned int num_classes;
+ struct engine_class *class;
+
+ unsigned int num_clients;
+ struct client *client;
+};
+
+#define for_each_client(clients, c, tmp) \
+ for ((tmp) = (clients)->num_clients, c = (clients)->client; \
+ (tmp > 0); (tmp)--, (c)++)
+
+#define SYSFS_ENABLE "/sys/class/drm/card0/clients/enable_stats"
+
+bool __stats_enabled;
+
+static int __set_stats(bool val)
+{
+ int fd, ret;
+
+ fd = open(SYSFS_ENABLE, O_WRONLY);
+ if (fd < 0)
+ return -errno;
+
+ ret = write(fd, val ? "1" : "0", 2);
+ if (ret < 0)
+ return -errno;
+ else if (ret < 2)
+ return 1;
+
+ close(fd);
+
+ return 0;
+}
+
+static void __restore_stats(void)
+{
+ int ret;
+
+ if (__stats_enabled)
+ return;
+
+ ret = __set_stats(false);
+ if (ret)
+ fprintf(stderr, "Failed to disable per-client stats! (%d)\n",
+ ret);
+}
+
+static void __restore_stats_signal(int sig)
+{
+ exit(0);
+}
+
+static int enable_stats(void)
+{
+ int fd, ret;
+
+ fd = open(SYSFS_ENABLE, O_RDONLY);
+ if (fd < 0)
+ return -errno;
+
+ close(fd);
+
+ __stats_enabled = filename_to_u64(SYSFS_ENABLE, 10);
+ if (__stats_enabled)
+ return 0;
+
+ ret = __set_stats(true);
+ if (!ret) {
+ if (atexit(__restore_stats))
+ fprintf(stderr, "Failed to register exit handler!");
+
+ if (signal(SIGINT, __restore_stats_signal))
+ fprintf(stderr, "Failed to register signal handler!");
+ } else {
+ fprintf(stderr, "Failed to enable per-client stats! (%d)\n",
+ ret);
+ }
+
+ return ret;
+}
+
+static struct clients *init_clients(void)
+{
+ struct clients *clients = malloc(sizeof(*clients));
+
+ if (enable_stats()) {
+ free(clients);
+ return NULL;
+ }
+
+ return memset(clients, 0, sizeof(*clients));
+}
+
+#define SYSFS_CLIENTS "/sys/class/drm/card0/clients"
+
+static uint64_t read_client_busy(unsigned int id, unsigned int class)
+{
+ char buf[256];
+ ssize_t ret;
+
+ ret = snprintf(buf, sizeof(buf),
+ SYSFS_CLIENTS "/%u/busy/%u",
+ id, class);
+ assert(ret > 0 && ret < sizeof(buf));
+ if (ret <= 0 || ret == sizeof(buf))
+ return 0;
+
+ return filename_to_u64(buf, 10);
+}
+
+static struct client *
+find_client(struct clients *clients, enum client_status status, unsigned int id)
+{
+ struct client *c;
+ int tmp;
+
+ for_each_client(clients, c, tmp) {
+ if ((status == FREE && c->status == FREE) ||
+ (status == c->status && c->id == id))
+ return c;
+ }
+
+ return NULL;
+}
+
+static void update_client(struct client *c, unsigned int pid, char *name)
+{
+ uint64_t val[c->clients->num_classes];
+ unsigned int i;
+
+ if (c->pid != pid)
+ c->pid = pid;
+
+ if (strncmp(c->name, name, sizeof(c->name)))
+ strncpy(c->name, name, sizeof(c->name));
+
+ for (i = 0; i < c->clients->num_classes; i++)
+ val[i] = read_client_busy(c->id, c->clients->class[i].class);
+
+ c->total = 0;
+
+ for (i = 0; i < c->clients->num_classes; i++) {
+ assert(val[i] >= c->last[i]);
+ c->val[i] = val[i] - c->last[i];
+ c->total += c->val[i];
+ c->last[i] = val[i];
+ }
+
+ c->samples++;
+ c->status = ALIVE;
+}
+
+static int class_cmp(const void *_a, const void *_b)
+{
+ const struct engine_class *a = _a;
+ const struct engine_class *b = _b;
+
+ return a->class - b->class;
+}
+
+static void scan_classes(struct clients *clients, unsigned int id)
+{
+ struct engine_class *classes;
+ unsigned int num, i;
+ struct dirent *dent;
+ char buf[256];
+ int ret;
+ DIR *d;
+
+ ret = snprintf(buf, sizeof(buf), SYSFS_CLIENTS "/%u/busy", id);
+ assert(ret > 0 && ret < sizeof(buf));
+ if (ret <= 0 || ret == sizeof(buf))
+ return;
+
+ d = opendir(buf);
+ if (!d)
+ return;
+
+restart:
+ rewinddir(d);
+
+ num = 0;
+ while ((dent = readdir(d)) != NULL) {
+ if (dent->d_type != DT_REG)
+ continue;
+
+ num++;
+ }
+
+ rewinddir(d);
+
+ classes = calloc(num, sizeof(*classes));
+ assert(classes);
+
+ i = 0;
+ while ((dent = readdir(d)) != NULL) {
+ if (i > num) {
+ // FIXME: free individual names
+ free(classes);
+ goto restart;
+ }
+
+ if (dent->d_type != DT_REG)
+ continue;
+
+ classes[i].class = atoi(dent->d_name);
+ classes[i].name = class_short_name(classes[i].class);
+ i++;
+ }
+
+ closedir(d);
+
+ qsort(classes, num, sizeof(*classes), class_cmp);
+
+ clients->num_classes = num;
+ clients->class = classes;
+}
+
+static void
+add_client(struct clients *clients, unsigned int id, unsigned int pid,
+ char *name)
+{
+ struct client *c;
+
+ assert(!find_client(clients, ALIVE, id));
+
+ c = find_client(clients, FREE, 0);
+ if (!c) {
+ unsigned int idx = clients->num_clients;
+
+ clients->num_clients += (clients->num_clients + 2) / 2;
+ clients->client = realloc(clients->client,
+ clients->num_clients * sizeof(*c));
+ assert(clients->client);
+
+ c = &clients->client[idx];
+ memset(c, 0, (clients->num_clients - idx) * sizeof(*c));
+ }
+
+ if (!clients->num_classes)
+ scan_classes(clients, id);
+
+ c->id = id;
+ c->clients = clients;
+ c->val = calloc(clients->num_classes, sizeof(c->val));
+ c->last = calloc(clients->num_classes, sizeof(c->last));
+ assert(c->val && c->last);
+
+ update_client(c, pid, name);
+}
+
+static void free_client(struct client *c)
+{
+ free(c->val);
+ free(c->last);
+ memset(c, 0, sizeof(*c));
+}
+
+static char *read_client_sysfs(unsigned int id, const char *field)
+{
+ char buf[256];
+ ssize_t ret;
+
+ ret = snprintf(buf, sizeof(buf), SYSFS_CLIENTS "/%u/%s", id, field);
+ assert(ret > 0 && ret < sizeof(buf));
+ if (ret <= 0 || ret == sizeof(buf))
+ return NULL;
+
+ ret = filename_to_buf(buf, buf, sizeof(buf));
+ assert(ret == 0);
+ if (ret)
+ return NULL;
+
+ return strdup(buf);
+}
+
+static void scan_clients(struct clients *clients)
+{
+ struct dirent *dent;
+ struct client *c;
+ char *pid, *name;
+ unsigned int id;
+ int tmp;
+ DIR *d;
+
+ if (!clients)
+ return;
+
+ for_each_client(clients, c, tmp) {
+ if (c->status == ALIVE)
+ c->status = PROBE;
+ }
+
+ d = opendir(SYSFS_CLIENTS);
+ if (!d)
+ return;
+
+ while ((dent = readdir(d)) != NULL) {
+ if (dent->d_type != DT_DIR)
+ continue;
+ if (!isdigit(dent->d_name[0]))
+ continue;
+
+ id = atoi(dent->d_name);
+
+ name = read_client_sysfs(id, "name");
+ assert(name);
+ if (!name)
+ continue;
+
+ pid = read_client_sysfs(id, "pid");
+ assert(pid);
+ if (!pid) {
+ free(name);
+ continue;
+ }
+
+ c = find_client(clients, PROBE, id);
+ if (c) {
+ update_client(c, atoi(pid), name);
+ continue;
+ }
+
+ add_client(clients, id, atoi(pid), name);
+
+ free(name);
+ free(pid);
+ }
+
+ closedir(d);
+
+ for_each_client(clients, c, tmp) {
+ if (c->status == PROBE)
+ free_client(c);
+ }
+}
+
+static int cmp(const void *_a, const void *_b)
+{
+ const struct client *a = _a;
+ const struct client *b = _b;
+ long tot_a = a->total;
+ long tot_b = b->total;
+
+ tot_a *= a->status == ALIVE && a->samples > 1;
+ tot_b *= b->status == ALIVE && b->samples > 1;
+
+ tot_b -= tot_a;
+
+ if (!tot_b)
+ return (int)b->id - a->id;
+
+ while (tot_b > INT_MAX || tot_b < INT_MIN)
+ tot_b /= 2;
+
+ return tot_b;
+}
+
static const char *bars[] = { " ", "▏", "▎", "▍", "▌", "▋", "▊", "▉", "█" };
+static void n_spaces(const unsigned int n)
+{
+ unsigned int i;
+
+ for (i = 0; i < n; i++)
+ putchar(' ');
+}
+
static void
print_percentage_bar(double percent, int max_len)
{
@@ -674,8 +1069,10 @@ print_percentage_bar(double percent, int max_len)
if (i)
printf("%s", bars[i]);
- for (i = 0; i < (max_len - 2 - (bar_len + 7) / 8); i++)
- putchar(' ');
+ bar_len = max_len - 2 - (bar_len + 7) / 8;
+ if (bar_len > max_len)
+ bar_len = max_len;
+ n_spaces(bar_len);
putchar('|');
}
@@ -775,6 +1172,18 @@ json_close_struct(void)
fflush(stdout);
}
+static void
+__json_add_member(const char *key, const char *val)
+{
+ assert(json_indent_level < ARRAY_SIZE(json_indent));
+
+ fprintf(out, "%s%s\"%s\": \"%s\"",
+ json_struct_members ? ",\n" : "",
+ json_indent[json_indent_level], key, val);
+
+ json_struct_members++;
+}
+
static unsigned int
json_add_member(const struct cnt_group *parent, struct cnt_item *item,
unsigned int headers)
@@ -1075,8 +1484,6 @@ print_header(struct engines *engines, double t,
memmove(&groups[0], &groups[1],
sizeof(groups) - sizeof(groups[0]));
- pops->open_struct(NULL);
-
*consumed = print_groups(groups);
if (output_mode == INTERACTIVE) {
@@ -1232,7 +1639,6 @@ print_engines_footer(struct engines *engines, double t,
int lines, int con_w, int con_h)
{
pops->close_struct();
- pops->close_struct();
if (output_mode == INTERACTIVE) {
if (lines++ < con_h)
@@ -1242,6 +1648,136 @@ print_engines_footer(struct engines *engines, double t,
return lines;
}
+static int
+print_clients_header(struct clients *clients, int lines,
+ int con_w, int con_h, unsigned int *class_w)
+{
+ int len;
+
+ if (output_mode == INTERACTIVE) {
+ if (lines++ >= con_h)
+ return lines;
+
+ printf("\033[7m");
+ len = printf("%5s%16s", "PID", "NAME");
+
+ if (lines++ >= con_h)
+ return lines;
+
+ if (clients->num_classes) {
+ unsigned int i;
+
+ *class_w = (con_w - len) / clients->num_classes;
+
+ for (i = 0; i < clients->num_classes; i++) {
+ unsigned int name_len =
+ strlen(clients->class[i].name);
+ unsigned int pad = (*class_w - name_len) / 2;
+
+ n_spaces(pad);
+ printf("%s", clients->class[i].name);
+ n_spaces(*class_w - pad - name_len);
+ len += pad + name_len +
+ (*class_w - pad - name_len);
+ }
+ }
+
+ n_spaces(con_w - len);
+ printf("\033[0m\n");
+ } else {
+ if (clients->num_classes)
+ pops->open_struct("clients");
+ }
+
+ return lines;
+}
+
+static void count_engines(struct clients *clients, struct engines *engines)
+{
+ unsigned int i;
+
+ for (i = 0; i < engines->num_engines; i++) {
+ struct engine *engine = engine_ptr(engines, i);
+
+ clients->class[engine->class].num_engines++;
+ }
+}
+
+static int
+print_client(struct client *c, struct engines *engines, double t, int lines,
+ int con_w, int con_h, unsigned int period_us,
+ unsigned int *class_w)
+{
+ struct clients *clients = c->clients;
+ unsigned int i;
+
+ if (output_mode == INTERACTIVE) {
+ printf("%5u%16s ", c->pid, c->name);
+
+ for (i = 0; i < clients->num_classes; i++) {
+ double pct;
+
+ if (!clients->class[i].num_engines)
+ count_engines(clients, engines);
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100 /
+ clients->class[i].num_engines;
+
+ print_percentage_bar(pct, *class_w);
+ }
+
+ putchar('\n');
+ } else if (output_mode == JSON) {
+ char buf[64];
+
+ snprintf(buf, sizeof(buf), "%u", c->id);
+ pops->open_struct(buf);
+
+ __json_add_member("name", c->name);
+
+ snprintf(buf, sizeof(buf), "%u", c->pid);
+ __json_add_member("pid", buf);
+
+ pops->open_struct("engine-classes");
+
+ for (i = 0; i < clients->num_classes; i++) {
+ double pct;
+
+ snprintf(buf, sizeof(buf), "%s",
+ clients->class[i].name);
+ pops->open_struct(buf);
+
+ pct = (double)c->val[i] / period_us / 1e3 * 100;
+ snprintf(buf, sizeof(buf), "%f", pct);
+ __json_add_member("busy", buf);
+
+ __json_add_member("unit", "%");
+
+ pops->close_struct();
+ }
+
+ pops->close_struct();
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
+static int
+print_clients_footer(struct clients *clients, double t,
+ int lines, int con_w, int con_h)
+{
+ if (output_mode == INTERACTIVE) {
+ if (lines++ < con_h)
+ printf("\n");
+ } else {
+ if (clients->num_classes)
+ pops->close_struct();
+ }
+
+ return lines;
+}
+
static bool stop_top;
static void sigint_handler(int sig)
@@ -1252,6 +1788,7 @@ static void sigint_handler(int sig)
int main(int argc, char **argv)
{
unsigned int period_us = DEFAULT_PERIOD_MS * 1000;
+ struct clients *clients = NULL;
int con_w = -1, con_h = -1;
char *output_path = NULL;
struct engines *engines;
@@ -1335,12 +1872,17 @@ int main(int argc, char **argv)
return 1;
}
+ clients = init_clients();
+
pmu_sample(engines);
+ scan_clients(clients);
while (!stop_top) {
bool consumed = false;
- int lines = 0;
+ int j, lines = 0;
+ unsigned int class_w;
struct winsize ws;
+ struct client *c;
double t;
/* Update terminal size. */
@@ -1354,10 +1896,18 @@ int main(int argc, char **argv)
pmu_sample(engines);
t = (double)(engines->ts.cur - engines->ts.prev) / 1e9;
+ scan_clients(clients);
+ if (clients) {
+ qsort(clients->client, clients->num_clients,
+ sizeof(*clients->client), cmp);
+ }
+
if (stop_top)
break;
while (!consumed) {
+ pops->open_struct(NULL);
+
lines = print_header(engines, t, lines, con_w, con_h,
&consumed);
@@ -1376,6 +1926,34 @@ int main(int argc, char **argv)
lines = print_engines_footer(engines, t, lines, con_w,
con_h);
+
+ if (clients) {
+ lines = print_clients_header(clients, lines,
+ con_w, con_h,
+ &class_w);
+
+ for_each_client(clients, c, j) {
+ if (lines++ > con_h)
+ break;
+
+ assert(c->status != PROBE);
+ if (c->status != ALIVE)
+ break;
+
+ if (c->samples < 2)
+ continue;
+
+ lines = print_client(c, engines, t,
+ lines, con_w,
+ con_h, period_us,
+ &class_w);
+ }
+
+ lines = print_clients_footer(clients, t, lines,
+ con_w, con_h);
+ }
+
+ pops->close_struct();
}
if (stop_top)
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [igt-dev] [RFC i-g-t 1/1] intel-gpu-top: Support for client stats
@ 2019-10-25 15:13 ` Chris Wilson
0 siblings, 0 replies; 14+ messages in thread
From: Chris Wilson @ 2019-10-25 15:13 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Quoting Tvrtko Ursulin (2019-10-25 15:24:10)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Adds support for per-client engine busyness stats i915 exports in sysfs
> and produces output like the below:
>
> ==========================================================================
> intel-gpu-top - 935/ 935 MHz; 0% RC6; 14.73 Watts; 1097 irqs/s
Could we get "gpu / pkg Watts" pretty please?
Are irq/s interesting with execlists? Originally the idea was to say how
many times clients were sleeping and being woken up. Now we interrupt
to wipe the gpu's nose when it sneezes.
>
> IMC reads: 1401 MiB/s
> IMC writes: 4 MiB/s
>
> ENGINE BUSY MI_SEMA MI_WAIT
> Render/3D/0 63.73% |███████████████████ | 3% 0%
> Blitter/0 9.53% |██▊ | 6% 0%
> Video/0 39.32% |███████████▊ | 16% 0%
> Video/1 15.62% |████▋ | 0% 0%
> VideoEnhance/0 0.00% | | 0% 0%
>
> PID NAME RCS BCS VCS VECS
> 4084 gem_wsim |█████▌ ||█ || || |
> 4086 gem_wsim |█▌ || ||███ || |
> ==========================================================================
>
> Apart from the existing physical engine utilization it now also shows
> utilization per client and per engine class.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> +#define SYSFS_CLIENTS "/sys/class/drm/card0/clients"
We need to somehow pull the right card.
Nothing shocking here. Where's the intel-gpu-overlay integration? ;)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [igt-dev] [RFC i-g-t 1/1] intel-gpu-top: Support for client stats
@ 2019-10-25 15:13 ` Chris Wilson
0 siblings, 0 replies; 14+ messages in thread
From: Chris Wilson @ 2019-10-25 15:13 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx
Quoting Tvrtko Ursulin (2019-10-25 15:24:10)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Adds support for per-client engine busyness stats i915 exports in sysfs
> and produces output like the below:
>
> ==========================================================================
> intel-gpu-top - 935/ 935 MHz; 0% RC6; 14.73 Watts; 1097 irqs/s
Could we get "gpu / pkg Watts" pretty please?
Are irq/s interesting with execlists? Originally the idea was to say how
many times clients were sleeping and being woken up. Now we interrupt
to wipe the gpu's nose when it sneezes.
>
> IMC reads: 1401 MiB/s
> IMC writes: 4 MiB/s
>
> ENGINE BUSY MI_SEMA MI_WAIT
> Render/3D/0 63.73% |███████████████████ | 3% 0%
> Blitter/0 9.53% |██▊ | 6% 0%
> Video/0 39.32% |███████████▊ | 16% 0%
> Video/1 15.62% |████▋ | 0% 0%
> VideoEnhance/0 0.00% | | 0% 0%
>
> PID NAME RCS BCS VCS VECS
> 4084 gem_wsim |█████▌ ||█ || || |
> 4086 gem_wsim |█▌ || ||███ || |
> ==========================================================================
>
> Apart from the existing physical engine utilization it now also shows
> utilization per client and per engine class.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> +#define SYSFS_CLIENTS "/sys/class/drm/card0/clients"
We need to somehow pull the right card.
Nothing shocking here. Where's the intel-gpu-overlay integration? ;)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [RFC i-g-t 1/1] intel-gpu-top: Support for client stats
@ 2019-10-25 15:13 ` Chris Wilson
0 siblings, 0 replies; 14+ messages in thread
From: Chris Wilson @ 2019-10-25 15:13 UTC (permalink / raw)
To: Tvrtko Ursulin, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
Quoting Tvrtko Ursulin (2019-10-25 15:24:10)
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Adds support for per-client engine busyness stats i915 exports in sysfs
> and produces output like the below:
>
> ==========================================================================
> intel-gpu-top - 935/ 935 MHz; 0% RC6; 14.73 Watts; 1097 irqs/s
Could we get "gpu / pkg Watts" pretty please?
Are irq/s interesting with execlists? Originally the idea was to say how
many times clients were sleeping and being woken up. Now we interrupt
to wipe the gpu's nose when it sneezes.
>
> IMC reads: 1401 MiB/s
> IMC writes: 4 MiB/s
>
> ENGINE BUSY MI_SEMA MI_WAIT
> Render/3D/0 63.73% |███████████████████ | 3% 0%
> Blitter/0 9.53% |██▊ | 6% 0%
> Video/0 39.32% |███████████▊ | 16% 0%
> Video/1 15.62% |████▋ | 0% 0%
> VideoEnhance/0 0.00% | | 0% 0%
>
> PID NAME RCS BCS VCS VECS
> 4084 gem_wsim |█████▌ ||█ || || |
> 4086 gem_wsim |█▌ || ||███ || |
> ==========================================================================
>
> Apart from the existing physical engine utilization it now also shows
> utilization per client and per engine class.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> +#define SYSFS_CLIENTS "/sys/class/drm/card0/clients"
We need to somehow pull the right card.
Nothing shocking here. Where's the intel-gpu-overlay integration? ;)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for Per client engine busyness
2019-10-25 14:24 ` [Intel-gfx] " Tvrtko Ursulin
` (2 preceding siblings ...)
(?)
@ 2019-10-25 15:26 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-10-25 15:26 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: Per client engine busyness
URL : https://patchwork.freedesktop.org/series/68572/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7186 -> IGTPW_3610
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/index.html
Known issues
------------
Here are the changes found in IGTPW_3610 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_switch@legacy-render:
- fi-bxt-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#103927] / [fdo#111381])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-bxt-dsi/igt@gem_ctx_switch@legacy-render.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/fi-bxt-dsi/igt@gem_ctx_switch@legacy-render.html
* igt@gem_exec_create@basic:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-icl-u3/igt@gem_exec_create@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/fi-icl-u3/igt@gem_exec_create@basic.html
* igt@i915_selftest@live_execlists:
- fi-icl-u3: [PASS][5] -> [INCOMPLETE][6] ([fdo#107713])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-icl-u3/igt@i915_selftest@live_execlists.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/fi-icl-u3/igt@i915_selftest@live_execlists.html
#### Possible fixes ####
* {igt@i915_selftest@live_gt_heartbeat}:
- fi-byt-n2820: [DMESG-FAIL][7] ([fdo#112096]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-byt-n2820/igt@i915_selftest@live_gt_heartbeat.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/fi-byt-n2820/igt@i915_selftest@live_gt_heartbeat.html
* igt@prime_vgem@basic-wait-default:
- fi-icl-u3: [DMESG-WARN][9] ([fdo#107724]) -> [PASS][10] +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/fi-icl-u3/igt@prime_vgem@basic-wait-default.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111381]: https://bugs.freedesktop.org/show_bug.cgi?id=111381
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096
Participating hosts (49 -> 41)
------------------------------
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-bsw-n3050 fi-byt-squawks fi-bsw-cyan fi-gdg-551 fi-icl-y fi-byt-clapper
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5241 -> IGTPW_3610
CI-20190529: 20190529
CI_DRM_7186: ce03ec86789ef8fc41a56176e5f2a9251182183c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3610: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/index.html
IGT_5241: 17b87c378fa155390b13a43f141371fd899d567b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [RFC i-g-t 1/1] intel-gpu-top: Support for client stats
@ 2019-10-25 15:38 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-10-25 15:38 UTC (permalink / raw)
To: Chris Wilson, igt-dev; +Cc: Intel-gfx
On 25/10/2019 16:13, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-10-25 15:24:10)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Adds support for per-client engine busyness stats i915 exports in sysfs
>> and produces output like the below:
>>
>> ==========================================================================
>> intel-gpu-top - 935/ 935 MHz; 0% RC6; 14.73 Watts; 1097 irqs/s
>
> Could we get "gpu / pkg Watts" pretty please?
Sure, next week or so.
> Are irq/s interesting with execlists? Originally the idea was to say how
> many times clients were sleeping and being woken up. Now we interrupt
> to wipe the gpu's nose when it sneezes.
>
>>
>> IMC reads: 1401 MiB/s
>> IMC writes: 4 MiB/s
>>
>> ENGINE BUSY MI_SEMA MI_WAIT
>> Render/3D/0 63.73% |███████████████████ | 3% 0%
>> Blitter/0 9.53% |██▊ | 6% 0%
>> Video/0 39.32% |███████████▊ | 16% 0%
>> Video/1 15.62% |████▋ | 0% 0%
>> VideoEnhance/0 0.00% | | 0% 0%
>>
>> PID NAME RCS BCS VCS VECS
>> 4084 gem_wsim |█████▌ ||█ || || |
>> 4086 gem_wsim |█▌ || ||███ || |
>> ==========================================================================
>>
>> Apart from the existing physical engine utilization it now also shows
>> utilization per client and per engine class.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>
>> +#define SYSFS_CLIENTS "/sys/class/drm/card0/clients"
>
> We need to somehow pull the right card.
Yeah, as I said RFC and reference only. :)
> Nothing shocking here. Where's the intel-gpu-overlay integration? ;)
Maybe intel-gpu-overlay should become an output plugin for intel_gpu_top. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Intel-gfx] [igt-dev] [RFC i-g-t 1/1] intel-gpu-top: Support for client stats
@ 2019-10-25 15:38 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-10-25 15:38 UTC (permalink / raw)
To: Chris Wilson, igt-dev; +Cc: Intel-gfx
On 25/10/2019 16:13, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-10-25 15:24:10)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Adds support for per-client engine busyness stats i915 exports in sysfs
>> and produces output like the below:
>>
>> ==========================================================================
>> intel-gpu-top - 935/ 935 MHz; 0% RC6; 14.73 Watts; 1097 irqs/s
>
> Could we get "gpu / pkg Watts" pretty please?
Sure, next week or so.
> Are irq/s interesting with execlists? Originally the idea was to say how
> many times clients were sleeping and being woken up. Now we interrupt
> to wipe the gpu's nose when it sneezes.
>
>>
>> IMC reads: 1401 MiB/s
>> IMC writes: 4 MiB/s
>>
>> ENGINE BUSY MI_SEMA MI_WAIT
>> Render/3D/0 63.73% |███████████████████ | 3% 0%
>> Blitter/0 9.53% |██▊ | 6% 0%
>> Video/0 39.32% |███████████▊ | 16% 0%
>> Video/1 15.62% |████▋ | 0% 0%
>> VideoEnhance/0 0.00% | | 0% 0%
>>
>> PID NAME RCS BCS VCS VECS
>> 4084 gem_wsim |█████▌ ||█ || || |
>> 4086 gem_wsim |█▌ || ||███ || |
>> ==========================================================================
>>
>> Apart from the existing physical engine utilization it now also shows
>> utilization per client and per engine class.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>
>> +#define SYSFS_CLIENTS "/sys/class/drm/card0/clients"
>
> We need to somehow pull the right card.
Yeah, as I said RFC and reference only. :)
> Nothing shocking here. Where's the intel-gpu-overlay integration? ;)
Maybe intel-gpu-overlay should become an output plugin for intel_gpu_top. :)
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [RFC i-g-t 1/1] intel-gpu-top: Support for client stats
@ 2019-10-25 15:38 ` Tvrtko Ursulin
0 siblings, 0 replies; 14+ messages in thread
From: Tvrtko Ursulin @ 2019-10-25 15:38 UTC (permalink / raw)
To: Chris Wilson, igt-dev; +Cc: Intel-gfx, Tvrtko Ursulin
On 25/10/2019 16:13, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-10-25 15:24:10)
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Adds support for per-client engine busyness stats i915 exports in sysfs
>> and produces output like the below:
>>
>> ==========================================================================
>> intel-gpu-top - 935/ 935 MHz; 0% RC6; 14.73 Watts; 1097 irqs/s
>
> Could we get "gpu / pkg Watts" pretty please?
Sure, next week or so.
> Are irq/s interesting with execlists? Originally the idea was to say how
> many times clients were sleeping and being woken up. Now we interrupt
> to wipe the gpu's nose when it sneezes.
>
>>
>> IMC reads: 1401 MiB/s
>> IMC writes: 4 MiB/s
>>
>> ENGINE BUSY MI_SEMA MI_WAIT
>> Render/3D/0 63.73% |███████████████████ | 3% 0%
>> Blitter/0 9.53% |██▊ | 6% 0%
>> Video/0 39.32% |███████████▊ | 16% 0%
>> Video/1 15.62% |████▋ | 0% 0%
>> VideoEnhance/0 0.00% | | 0% 0%
>>
>> PID NAME RCS BCS VCS VECS
>> 4084 gem_wsim |█████▌ ||█ || || |
>> 4086 gem_wsim |█▌ || ||███ || |
>> ==========================================================================
>>
>> Apart from the existing physical engine utilization it now also shows
>> utilization per client and per engine class.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> ---
>
>> +#define SYSFS_CLIENTS "/sys/class/drm/card0/clients"
>
> We need to somehow pull the right card.
Yeah, as I said RFC and reference only. :)
> Nothing shocking here. Where's the intel-gpu-overlay integration? ;)
Maybe intel-gpu-overlay should become an output plugin for intel_gpu_top. :)
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for Per client engine busyness
2019-10-25 14:24 ` [Intel-gfx] " Tvrtko Ursulin
` (3 preceding siblings ...)
(?)
@ 2019-10-27 5:50 ` Patchwork
-1 siblings, 0 replies; 14+ messages in thread
From: Patchwork @ 2019-10-27 5:50 UTC (permalink / raw)
To: Tvrtko Ursulin; +Cc: igt-dev
== Series Details ==
Series: Per client engine busyness
URL : https://patchwork.freedesktop.org/series/68572/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7186_full -> IGTPW_3610_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3610_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_ctx_exec@basic-nohangcheck}:
- {shard-tglb}: NOTRUN -> [FAIL][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-tglb7/igt@gem_ctx_exec@basic-nohangcheck.html
Known issues
------------
Here are the changes found in IGTPW_3610_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-s3:
- shard-iclb: [PASS][2] -> [SKIP][3] ([fdo#109276] / [fdo#112080]) +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb4/igt@gem_ctx_isolation@vcs1-s3.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb6/igt@gem_ctx_isolation@vcs1-s3.html
* igt@gem_ctx_switch@vcs1:
- shard-iclb: [PASS][4] -> [SKIP][5] ([fdo#112080]) +8 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb4/igt@gem_ctx_switch@vcs1.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb6/igt@gem_ctx_switch@vcs1.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#111325]) +4 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb7/igt@gem_exec_schedule@preempt-bsd.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb1/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_exec_schedule@promotion-bsd1:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#109276]) +16 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb4/igt@gem_exec_schedule@promotion-bsd1.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb8/igt@gem_exec_schedule@promotion-bsd1.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-hsw: [PASS][10] -> [DMESG-WARN][11] ([fdo#111870]) +1 similar issue
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-hsw5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-snb: [PASS][12] -> [DMESG-WARN][13] ([fdo#111870]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-snb2/igt@gem_userptr_blits@sync-unmap-cycles.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-snb1/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][14] -> [DMESG-WARN][15] ([fdo#108566]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-apl8/igt@gem_workarounds@suspend-resume.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-apl1/igt@gem_workarounds@suspend-resume.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +4 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-kbl3/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-kbl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [PASS][18] -> [INCOMPLETE][19] ([fdo#103540])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-hsw4/igt@kms_flip@flip-vs-suspend.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-hsw4/igt@kms_flip@flip-vs-suspend.html
* igt@kms_plane_lowres@pipe-a-tiling-x:
- shard-iclb: [PASS][20] -> [FAIL][21] ([fdo#103166]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb3/igt@kms_plane_lowres@pipe-a-tiling-x.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
* igt@kms_psr@psr2_primary_mmap_cpu:
- shard-iclb: [PASS][22] -> [SKIP][23] ([fdo#109441]) +4 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb1/igt@kms_psr@psr2_primary_mmap_cpu.html
* igt@kms_rotation_crc@primary-y-tiled-reflect-x-270:
- shard-iclb: [PASS][24] -> [INCOMPLETE][25] ([fdo#107713] / [fdo#110026] / [fdo#110040 ])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb5/igt@kms_rotation_crc@primary-y-tiled-reflect-x-270.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb7/igt@kms_rotation_crc@primary-y-tiled-reflect-x-270.html
#### Possible fixes ####
* igt@gem_busy@close-race:
- shard-apl: [DMESG-WARN][26] -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-apl8/igt@gem_busy@close-race.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-apl4/igt@gem_busy@close-race.html
* igt@gem_ctx_exec@basic-invalid-context-vcs1:
- shard-iclb: [SKIP][28] ([fdo#112080]) -> [PASS][29] +7 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb6/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb1/igt@gem_ctx_exec@basic-invalid-context-vcs1.html
* igt@gem_ctx_isolation@vcs1-dirty-create:
- shard-iclb: [SKIP][30] ([fdo#109276] / [fdo#112080]) -> [PASS][31] +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb6/igt@gem_ctx_isolation@vcs1-dirty-create.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb4/igt@gem_ctx_isolation@vcs1-dirty-create.html
* igt@gem_exec_schedule@preempt-queue-bsd1:
- shard-iclb: [SKIP][32] ([fdo#109276]) -> [PASS][33] +15 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd1.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb4/igt@gem_exec_schedule@preempt-queue-bsd1.html
* igt@gem_exec_schedule@reorder-wide-bsd:
- shard-iclb: [SKIP][34] ([fdo#111325]) -> [PASS][35] +5 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb4/igt@gem_exec_schedule@reorder-wide-bsd.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb7/igt@gem_exec_schedule@reorder-wide-bsd.html
* igt@gem_exec_schedule@smoketest-all:
- {shard-tglb}: [INCOMPLETE][36] ([fdo#111855]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-tglb6/igt@gem_exec_schedule@smoketest-all.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-tglb5/igt@gem_exec_schedule@smoketest-all.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-hsw: [TIMEOUT][38] ([fdo#112068 ]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-hsw5/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-hsw4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [DMESG-WARN][40] ([fdo#111870]) -> [PASS][41] +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [DMESG-WARN][42] ([fdo#111870]) -> [PASS][43] +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-hsw7/igt@gem_userptr_blits@sync-unmap-cycles.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-hsw8/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_pm_backlight@fade_with_suspend:
- {shard-tglb}: [INCOMPLETE][44] ([fdo#111832] / [fdo#111850]) -> [PASS][45] +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-tglb1/igt@i915_pm_backlight@fade_with_suspend.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-tglb8/igt@i915_pm_backlight@fade_with_suspend.html
* igt@i915_selftest@live_hangcheck:
- {shard-tglb}: [INCOMPLETE][46] ([fdo#111747]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-tglb2/igt@i915_selftest@live_hangcheck.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-tglb6/igt@i915_selftest@live_hangcheck.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-apl: [DMESG-WARN][48] ([fdo#108566]) -> [PASS][49] +3 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-apl4/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-apl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_edge_walk@pipe-d-64x64-bottom-edge:
- {shard-tglb}: [INCOMPLETE][50] -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-tglb7/igt@kms_cursor_edge_walk@pipe-d-64x64-bottom-edge.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-tglb6/igt@kms_cursor_edge_walk@pipe-d-64x64-bottom-edge.html
* igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw:
- shard-iclb: [FAIL][52] ([fdo#103167]) -> [PASS][53] +5 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-1p-pri-indfb-multidraw.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt:
- {shard-tglb}: [FAIL][54] ([fdo#103167]) -> [PASS][55] +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-tglb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-plflip-blt.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [DMESG-WARN][56] ([fdo#108566]) -> [PASS][57] +7 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-kbl2/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
- shard-apl: [INCOMPLETE][58] ([fdo#103927]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-apl8/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-apl4/igt@kms_plane@pixel-format-pipe-b-planes-source-clamping.html
* igt@kms_psr@no_drrs:
- shard-iclb: [FAIL][60] ([fdo#108341]) -> [PASS][61]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb1/igt@kms_psr@no_drrs.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb3/igt@kms_psr@no_drrs.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][62] ([fdo#109441]) -> [PASS][63] +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb7/igt@kms_psr@psr2_no_drrs.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
* igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
- {shard-tglb}: [INCOMPLETE][64] ([fdo#111850]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-tglb7/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-tglb2/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
#### Warnings ####
* igt@gem_mocs_settings@mocs-reset-bsd2:
- shard-iclb: [FAIL][66] ([fdo#111330]) -> [SKIP][67] ([fdo#109276]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb4/igt@gem_mocs_settings@mocs-reset-bsd2.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb3/igt@gem_mocs_settings@mocs-reset-bsd2.html
* igt@gem_mocs_settings@mocs-settings-bsd2:
- shard-iclb: [SKIP][68] ([fdo#109276]) -> [FAIL][69] ([fdo#111330]) +1 similar issue
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb3/igt@gem_mocs_settings@mocs-settings-bsd2.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb1/igt@gem_mocs_settings@mocs-settings-bsd2.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-iclb: [FAIL][70] ([fdo#112037]) -> [TIMEOUT][71] ([fdo#112068 ])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-iclb3/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-iclb7/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [INCOMPLETE][72] ([fdo#103665]) -> [DMESG-WARN][73] ([fdo#108566])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7186/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/shard-kbl2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 112000 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 112000
[fdo#102250]: https://bugs.freedesktop.org/show_bug.cgi?id=102250
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110026]: https://bugs.freedesktop.org/show_bug.cgi?id=110026
[fdo#110040 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110040
[fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
[fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111839 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111839
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111855]: https://bugs.freedesktop.org/show_bug.cgi?id=111855
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111884]: https://bugs.freedesktop.org/show_bug.cgi?id=111884
[fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
[fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-hsw-4770r
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5241 -> IGTPW_3610
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_7186: ce03ec86789ef8fc41a56176e5f2a9251182183c @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3610: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/index.html
IGT_5241: 17b87c378fa155390b13a43f141371fd899d567b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3610/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-10-27 5:50 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 14:24 [RFC i-g-t 0/1] Per client engine busyness Tvrtko Ursulin
2019-10-25 14:24 ` [igt-dev] " Tvrtko Ursulin
2019-10-25 14:24 ` [Intel-gfx] " Tvrtko Ursulin
2019-10-25 14:24 ` [RFC i-g-t 1/1] intel-gpu-top: Support for client stats Tvrtko Ursulin
2019-10-25 14:24 ` [igt-dev] " Tvrtko Ursulin
2019-10-25 14:24 ` [Intel-gfx] " Tvrtko Ursulin
2019-10-25 15:13 ` [igt-dev] " Chris Wilson
2019-10-25 15:13 ` Chris Wilson
2019-10-25 15:13 ` [Intel-gfx] " Chris Wilson
2019-10-25 15:38 ` Tvrtko Ursulin
2019-10-25 15:38 ` Tvrtko Ursulin
2019-10-25 15:38 ` [Intel-gfx] " Tvrtko Ursulin
2019-10-25 15:26 ` [igt-dev] ✓ Fi.CI.BAT: success for Per client engine busyness Patchwork
2019-10-27 5:50 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.