All of lore.kernel.org
 help / color / mirror / Atom feed
* [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly
@ 2019-10-25 15:48 Ian Jackson
  2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 2/5] make-flight: Drop arm64 with Linux before 4.10 Ian Jackson
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Ian Jackson @ 2019-10-25 15:48 UTC (permalink / raw)
  To: xen-devel; +Cc: Jürgen Groß, Ian Jackson

Now we have two lists of things not supported on ARM: one of branches
where that's inherent in the branch somehow, and one for those where
the kernel is simply too old.  The latter are going to differ between
armhf and arm64.

No functional change.
(Verified with standalone-generate-dump-flight-runvars.)

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 make-flight | 7 ++++++-
 mfi-common  | 4 ++++
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/make-flight b/make-flight
index 020ad5f1..f90fe77c 100755
--- a/make-flight
+++ b/make-flight
@@ -189,8 +189,13 @@ arch_branch_filter_callback () {
         linux-3.4) return 1;;
         linux-3.10) return 1;;
         linux-3.14) return 1;;
+        esac
+        ;;
+  esac
+  case "$arch" in
+  arm*)
+        case "$branch" in
         linux-mingo-tip-master) return 1;;
-        linux-*) ;;
         qemu-upstream-4.2-testing) return 1;;
         qemu-upstream-4.3-testing) return 1;;
         qemu-upstream-4.4-testing) return 1;;
diff --git a/mfi-common b/mfi-common
index 7c03ffd4..b40f057e 100644
--- a/mfi-common
+++ b/mfi-common
@@ -288,6 +288,10 @@ create_build_jobs () {
       "
       ;;
     arm64)
+      case "$branch" in
+      linux-3.*-testing) continue;;
+      linux-4.[0-4]-testing) continue;;
+      esac
       case "$xenbranch" in
       xen-3.*-testing) continue;;
       xen-4.[0-6]-testing) continue;;
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Xen-devel] [OSSTEST PATCH 2/5] make-flight: Drop arm64 with Linux before 4.10
  2019-10-25 15:48 [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly Ian Jackson
@ 2019-10-25 15:48 ` Ian Jackson
  2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 3/5] power_cycle_sleep: Change default sleep to 15s Ian Jackson
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2019-10-25 15:48 UTC (permalink / raw)
  To: xen-devel
  Cc: Jürgen Groß, Julien Grall, Stefano Stabellini, Ian Jackson

The driver for the laxtons' network cards is not in 4.4 (and that's
quite old).  Our ThunderX's may even require something more recent but
we will cross that bridge when we see it.

Effect is to drop the following jobs:
  linux-4.1  *arm64*
  linux-4.4  *arm64*
  linux-4.9  *arm64*
(Checked by eyeballing standalone-generate-dump-flight-runvars diff.)

CC: Julien Grall <julien.grall@arm.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Acked-by: Julien Grall <julien.grall@arm.com>
---
 make-flight | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/make-flight b/make-flight
index f90fe77c..be620c6d 100755
--- a/make-flight
+++ b/make-flight
@@ -183,7 +183,7 @@ job_create_test_filter_callback () {
 arch_branch_filter_callback () {
   local arch=$1
   case "$arch" in
-  arm*)
+  armhf)
         case "$branch" in
         linux-3.0) return 1;;
         linux-3.4) return 1;;
@@ -191,6 +191,12 @@ arch_branch_filter_callback () {
         linux-3.14) return 1;;
         esac
         ;;
+  arm64)
+        case "$branch" in
+        linux-3.*) return 1;;
+        linux-4.?) return 1;;
+        esac
+        ;;
   esac
   case "$arch" in
   arm*)
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Xen-devel] [OSSTEST PATCH 3/5] power_cycle_sleep: Change default sleep to 15s
  2019-10-25 15:48 [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly Ian Jackson
  2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 2/5] make-flight: Drop arm64 with Linux before 4.10 Ian Jackson
@ 2019-10-25 15:48 ` Ian Jackson
  2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 4/5] adhoc-revtuple-generator: Bisecting over 5000 commits Ian Jackson
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2019-10-25 15:48 UTC (permalink / raw)
  To: xen-devel; +Cc: Jürgen Groß, Ian Jackson

5s is so short that when a host fails to respond we aren't sure if it
was just very idle and ran off its PSU's internal energy storage for
that period.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest/TestSupport.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
index 6b0ee7a2..9c99ee17 100644
--- a/Osstest/TestSupport.pm
+++ b/Osstest/TestSupport.pm
@@ -1097,7 +1097,7 @@ sub power_reboot_attempts ($$$;$$) {
 
 sub power_cycle_sleep ($) {
     my ($ho) = @_;
-    my $to = get_host_property($ho, 'power-cycle-time', 5);
+    my $to = get_host_property($ho, 'power-cycle-time', 15);
     logm("power-cycle: waiting ${to}s");
     sleep($to);
 }
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Xen-devel] [OSSTEST PATCH 4/5] adhoc-revtuple-generator: Bisecting over 5000 commits
  2019-10-25 15:48 [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly Ian Jackson
  2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 2/5] make-flight: Drop arm64 with Linux before 4.10 Ian Jackson
  2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 3/5] power_cycle_sleep: Change default sleep to 15s Ian Jackson
@ 2019-10-25 15:48 ` Ian Jackson
  2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 5/5] other_revision_job_suffix: disregard recursive FreeBSD builds Ian Jackson
  2019-10-25 16:12 ` [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly Jürgen Groß
  4 siblings, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2019-10-25 15:48 UTC (permalink / raw)
  To: xen-devel; +Cc: Jürgen Groß, Ian Jackson

Rather than merely 1000.  Right now we have a troublesome FreeBSD
build problem which needs this!

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 adhoc-revtuple-generator | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/adhoc-revtuple-generator b/adhoc-revtuple-generator
index be3f3755..ac0f2463 100755
--- a/adhoc-revtuple-generator
+++ b/adhoc-revtuple-generator
@@ -553,7 +553,7 @@ sub main () {
     my @trees_continuous;
     foreach my $tree (@trees) {
         my $gen= tree_get_gen($tree);
-        my $count= 1000;
+        my $count= 5000;
         my $found= 0;
         my $top= undef;
         while ($count-- > 0) {
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Xen-devel] [OSSTEST PATCH 5/5] other_revision_job_suffix: disregard recursive FreeBSD builds
  2019-10-25 15:48 [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly Ian Jackson
                   ` (2 preceding siblings ...)
  2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 4/5] adhoc-revtuple-generator: Bisecting over 5000 commits Ian Jackson
@ 2019-10-25 15:48 ` Ian Jackson
  2019-10-25 16:12 ` [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly Jürgen Groß
  4 siblings, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2019-10-25 15:48 UTC (permalink / raw)
  To: xen-devel; +Cc: Jürgen Groß, Roger Pau Monné, Ian Jackson

We aren't actually interested in bisecting the FreeBSD
version (usually, the anointed version) which was used as the platform
for the failed builds.  We are thereby making the assumption that any
build failure (or indeed test failure) is the result in changes to the
recent FreeBSD being actually built or used, not the version being
used as a build host.

Achieve ignoring this by having other_revision_job_suffix return a new
magic new value DISCARD, which all callers must know means `skip
this one'.  There are three call sites:

In cs-bisection-step:flight_rmap, we skip those rows in the Perl
loop.  (We can't skip them conveniently in the SQL because we can't
refer to the column `othrev'; we'd have to duplicate the expression,
or have a subquery.  This doesn't seem likely to matter much.)

In cs-bisection-step:preparejob, we always compare the returned suffix
with a fixed value (which eventually came from the previous call).  So
DISCARD will never match.  No change is needed here.

In Osstest.pm:main_revision_job_cond, we compare the returned suffix
with ''.  Again, it will never match and no change is needed.

I have checked that now a cs-bisection-step run chooses a single
FreeBSD master commit to try to build.

CC: Roger Pau Monné <royger@FreeBSD.org>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 Osstest.pm        | 2 +-
 cs-bisection-step | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Osstest.pm b/Osstest.pm
index d6c1b709..27136bc9 100644
--- a/Osstest.pm
+++ b/Osstest.pm
@@ -380,7 +380,7 @@ sub other_revision_job_suffix ($$$) {
       (CASE
        WHEN ($jobfield) LIKE 'build-%-prev' THEN '${separator}prev'
        WHEN (($jobfield) LIKE 'build-%-freebsd' 
-             AND $refrunvar = 'freebsdbuildjob') THEN '${separator}recurse'
+             AND $refrunvar = 'freebsdbuildjob') THEN 'DISCARD'
        ELSE                                      ''
        END)
 END
diff --git a/cs-bisection-step b/cs-bisection-step
index 48208e46..16227234 100755
--- a/cs-bisection-step
+++ b/cs-bisection-step
@@ -254,6 +254,7 @@ END
     my $mixed=0;
     my (@ttreenames, @ttreeurls, @trevisions);
     while ($row= $sth->fetchrow_hashref()) {
+        next if $row->{othrev} eq 'DISCARD';
         $row->{longname} =~ m/^tree_/ or die "$row->{longname} ?";
         my $name= $'; #'
         print DEBUG " $flight.$row->{job} uval=$row->{uval}".
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly
  2019-10-25 15:48 [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly Ian Jackson
                   ` (3 preceding siblings ...)
  2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 5/5] other_revision_job_suffix: disregard recursive FreeBSD builds Ian Jackson
@ 2019-10-25 16:12 ` Jürgen Groß
  4 siblings, 0 replies; 6+ messages in thread
From: Jürgen Groß @ 2019-10-25 16:12 UTC (permalink / raw)
  To: Ian Jackson, xen-devel

On 25.10.19 17:48, Ian Jackson wrote:
> Now we have two lists of things not supported on ARM: one of branches
> where that's inherent in the branch somehow, and one for those where
> the kernel is simply too old.  The latter are going to differ between
> armhf and arm64.
> 
> No functional change.
> (Verified with standalone-generate-dump-flight-runvars.)
> 
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

For the complete series:

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-10-25 16:12 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 15:48 [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly Ian Jackson
2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 2/5] make-flight: Drop arm64 with Linux before 4.10 Ian Jackson
2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 3/5] power_cycle_sleep: Change default sleep to 15s Ian Jackson
2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 4/5] adhoc-revtuple-generator: Bisecting over 5000 commits Ian Jackson
2019-10-25 15:48 ` [Xen-devel] [OSSTEST PATCH 5/5] other_revision_job_suffix: disregard recursive FreeBSD builds Ian Jackson
2019-10-25 16:12 ` [Xen-devel] [OSSTEST PATCH 1/5] make-flight: Rework arch_branch_filter_callback slightly Jürgen Groß

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.