All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't test every plane on icl+
@ 2019-10-25 19:01 Ville Syrjala
  2019-10-25 19:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Ville Syrjala @ 2019-10-25 19:01 UTC (permalink / raw)
  To: igt-dev

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Only test one plane of each type (HDR, SDR UV, SDR Y) on icl+.
For the purposes of validating pixel formats this should be sufficient
as the programming of each plane of the same type is identical and
as such it's unlikely we'd have different bugs between them.

As before we'll leave the full test set available to be run at
the user's discretion via --extended.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 tests/kms_plane.c | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 86a3a6296d26..7672374f5152 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -757,6 +757,26 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
 	return result;
 }
 
+static bool skip_plane(data_t *data, igt_plane_t *plane)
+{
+	int index = plane->index;
+
+	if (data->extended)
+		return false;
+
+	if (!is_i915_device(data->drm_fd))
+		return false;
+
+	if (plane->type == DRM_PLANE_TYPE_CURSOR)
+		return false;
+
+	if (intel_gen(intel_get_drm_devid(data->drm_fd)) < 11)
+		return false;
+
+	/* test 1 HDR plane, 1 SDR UV plane, 1 SDR Y plane */
+	return index != 0 && index != 3 && index != 5;
+}
+
 static void
 test_pixel_formats(data_t *data, enum pipe pipe)
 {
@@ -794,8 +814,11 @@ test_pixel_formats(data_t *data, enum pipe pipe)
 	test_init(data, pipe);
 
 	result = true;
-	for_each_plane_on_pipe(&data->display, pipe, plane)
+	for_each_plane_on_pipe(&data->display, pipe, plane) {
+		if (skip_plane(data, plane))
+			continue;
 		result &= test_format_plane(data, pipe, output, plane);
+	}
 
 	test_fini(data);
 
-- 
2.21.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: Don't test every plane on icl+
  2019-10-25 19:01 [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't test every plane on icl+ Ville Syrjala
@ 2019-10-25 19:41 ` Patchwork
  2019-10-27 10:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2019-10-30 12:59 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
  2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-25 19:41 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: igt-dev

== Series Details ==

Series: tests/kms_plane: Don't test every plane on icl+
URL   : https://patchwork.freedesktop.org/series/68581/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7187 -> IGTPW_3616
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/index.html

Known issues
------------

  Here are the changes found in IGTPW_3616 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_create@basic-files:
    - fi-icl-u3:          [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-icl-u3/igt@gem_ctx_create@basic-files.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/fi-icl-u3/igt@gem_ctx_create@basic-files.html

  
#### Possible fixes ####

  * igt@gem_basic@bad-close:
    - fi-icl-u3:          [DMESG-WARN][3] ([fdo#107724]) -> [PASS][4]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-icl-u3/igt@gem_basic@bad-close.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/fi-icl-u3/igt@gem_basic@bad-close.html

  * {igt@i915_selftest@live_gt_heartbeat}:
    - fi-cml-u2:          [DMESG-FAIL][5] ([fdo#112096]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-cml-u2/igt@i915_selftest@live_gt_heartbeat.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/fi-cml-u2/igt@i915_selftest@live_gt_heartbeat.html

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       [FAIL][7] ([fdo#111407]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
  [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
  [fdo#112096]: https://bugs.freedesktop.org/show_bug.cgi?id=112096


Participating hosts (49 -> 43)
------------------------------

  Additional (1): fi-pnv-d510 
  Missing    (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5241 -> IGTPW_3616

  CI-20190529: 20190529
  CI_DRM_7187: 9df5aeba240a65ea80008020d3027484bc6055b3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3616: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/index.html
  IGT_5241: 17b87c378fa155390b13a43f141371fd899d567b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane: Don't test every plane on icl+
  2019-10-25 19:01 [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't test every plane on icl+ Ville Syrjala
  2019-10-25 19:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-10-27 10:33 ` Patchwork
  2019-10-30 12:59 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
  2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-27 10:33 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: igt-dev

== Series Details ==

Series: tests/kms_plane: Don't test every plane on icl+
URL   : https://patchwork.freedesktop.org/series/68581/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_7187_full -> IGTPW_3616_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_3616_full:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@gem_exec_schedule@preemptive-hang-bsd1:
    - {shard-tglb}:       NOTRUN -> [INCOMPLETE][1] +1 similar issue
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-tglb5/igt@gem_exec_schedule@preemptive-hang-bsd1.html

  * igt@kms_busy@basic-modeset-d:
    - {shard-tglb}:       [PASS][2] -> [INCOMPLETE][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb2/igt@kms_busy@basic-modeset-d.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-tglb6/igt@kms_busy@basic-modeset-d.html

  
Known issues
------------

  Here are the changes found in IGTPW_3616_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_ctx_shared@exec-single-timeline-bsd:
    - shard-iclb:         [PASS][4] -> [SKIP][5] ([fdo#110841])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb8/igt@gem_ctx_shared@exec-single-timeline-bsd.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb2/igt@gem_ctx_shared@exec-single-timeline-bsd.html

  * igt@gem_exec_schedule@reorder-wide-bsd:
    - shard-iclb:         [PASS][6] -> [SKIP][7] ([fdo#111325]) +7 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb8/igt@gem_exec_schedule@reorder-wide-bsd.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb1/igt@gem_exec_schedule@reorder-wide-bsd.html

  * igt@gem_userptr_blits@dmabuf-unsync:
    - shard-snb:          [PASS][8] -> [DMESG-WARN][9] ([fdo#111870])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-snb7/igt@gem_userptr_blits@dmabuf-unsync.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-snb5/igt@gem_userptr_blits@dmabuf-unsync.html

  * igt@i915_selftest@live_hangcheck:
    - shard-hsw:          [PASS][10] -> [DMESG-FAIL][11] ([fdo#111991])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-hsw5/igt@i915_selftest@live_hangcheck.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-hsw4/igt@i915_selftest@live_hangcheck.html

  * igt@i915_suspend@forcewake:
    - shard-kbl:          [PASS][12] -> [DMESG-WARN][13] ([fdo#108566]) +1 similar issue
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-kbl3/igt@i915_suspend@forcewake.html
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-kbl2/igt@i915_suspend@forcewake.html

  * igt@kms_color@pipe-b-ctm-0-75:
    - shard-hsw:          [PASS][14] -> [INCOMPLETE][15] ([fdo#103540])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-hsw5/igt@kms_color@pipe-b-ctm-0-75.html
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-hsw7/igt@kms_color@pipe-b-ctm-0-75.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-apl:          [PASS][16] -> [DMESG-WARN][17] ([fdo#108566]) +5 similar issues
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
    - shard-iclb:         [PASS][18] -> [FAIL][19] ([fdo#103167]) +9 similar issues
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html

  * igt@kms_psr@no_drrs:
    - shard-iclb:         [PASS][20] -> [FAIL][21] ([fdo#108341])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb2/igt@kms_psr@no_drrs.html
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb1/igt@kms_psr@no_drrs.html

  * igt@kms_psr@psr2_cursor_plane_move:
    - shard-iclb:         [PASS][22] -> [SKIP][23] ([fdo#109441]) +1 similar issue
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb2/igt@kms_psr@psr2_cursor_plane_move.html
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb5/igt@kms_psr@psr2_cursor_plane_move.html

  * igt@perf_pmu@busy-vcs1:
    - shard-iclb:         [PASS][24] -> [SKIP][25] ([fdo#112080]) +9 similar issues
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb4/igt@perf_pmu@busy-vcs1.html
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb7/igt@perf_pmu@busy-vcs1.html

  * igt@prime_busy@hang-bsd2:
    - shard-iclb:         [PASS][26] -> [SKIP][27] ([fdo#109276]) +15 similar issues
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb1/igt@prime_busy@hang-bsd2.html
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb8/igt@prime_busy@hang-bsd2.html

  
#### Possible fixes ####

  * igt@drm_import_export@flink:
    - {shard-tglb}:       [INCOMPLETE][28] -> [PASS][29] +1 similar issue
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb3/igt@drm_import_export@flink.html
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-tglb5/igt@drm_import_export@flink.html

  * igt@gem_busy@busy-vcs1:
    - shard-iclb:         [SKIP][30] ([fdo#112080]) -> [PASS][31] +9 similar issues
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@gem_busy@busy-vcs1.html
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb4/igt@gem_busy@busy-vcs1.html

  * igt@gem_ctx_isolation@vcs1-none:
    - shard-iclb:         [SKIP][32] ([fdo#109276] / [fdo#112080]) -> [PASS][33] +1 similar issue
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@gem_ctx_isolation@vcs1-none.html
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb4/igt@gem_ctx_isolation@vcs1-none.html

  * igt@gem_ctx_shared@q-smoketest-blt:
    - {shard-tglb}:       [INCOMPLETE][34] ([fdo#111735]) -> [PASS][35]
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb6/igt@gem_ctx_shared@q-smoketest-blt.html
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-tglb2/igt@gem_ctx_shared@q-smoketest-blt.html

  * igt@gem_exec_blt@dumb-buf-max:
    - shard-apl:          [INCOMPLETE][36] ([fdo#103927]) -> [PASS][37] +1 similar issue
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-apl4/igt@gem_exec_blt@dumb-buf-max.html
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-apl3/igt@gem_exec_blt@dumb-buf-max.html

  * igt@gem_exec_schedule@independent-bsd2:
    - shard-iclb:         [SKIP][38] ([fdo#109276]) -> [PASS][39] +16 similar issues
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@gem_exec_schedule@independent-bsd2.html
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb2/igt@gem_exec_schedule@independent-bsd2.html

  * igt@gem_exec_schedule@preemptive-hang-bsd:
    - shard-iclb:         [SKIP][40] ([fdo#111325]) -> [PASS][41] +3 similar issues
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb1/igt@gem_exec_schedule@preemptive-hang-bsd.html
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb6/igt@gem_exec_schedule@preemptive-hang-bsd.html

  * igt@gem_persistent_relocs@forked-interruptible-thrash-inactive:
    - shard-hsw:          [FAIL][42] ([fdo#112037]) -> [PASS][43]
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-hsw8/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-hsw5/igt@gem_persistent_relocs@forked-interruptible-thrash-inactive.html

  * igt@gem_userptr_blits@dmabuf-sync:
    - shard-snb:          [DMESG-WARN][44] ([fdo#111870]) -> [PASS][45] +1 similar issue
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-snb2/igt@gem_userptr_blits@dmabuf-sync.html
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-snb4/igt@gem_userptr_blits@dmabuf-sync.html

  * igt@gem_userptr_blits@sync-unmap-after-close:
    - shard-hsw:          [DMESG-WARN][46] ([fdo#111870]) -> [PASS][47] +3 similar issues
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-hsw2/igt@gem_userptr_blits@sync-unmap-after-close.html
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-hsw7/igt@gem_userptr_blits@sync-unmap-after-close.html

  * igt@gem_workarounds@suspend-resume-context:
    - shard-apl:          [DMESG-WARN][48] ([fdo#108566]) -> [PASS][49] +4 similar issues
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-apl4/igt@gem_workarounds@suspend-resume-context.html
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-apl7/igt@gem_workarounds@suspend-resume-context.html

  * igt@i915_selftest@live_hangcheck:
    - {shard-tglb}:       [INCOMPLETE][50] ([fdo#111747]) -> [PASS][51]
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb1/igt@i915_selftest@live_hangcheck.html
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-tglb5/igt@i915_selftest@live_hangcheck.html

  * igt@kms_cursor_crc@pipe-a-cursor-suspend:
    - shard-kbl:          [INCOMPLETE][52] ([fdo#103665]) -> [PASS][53]
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
    - shard-iclb:         [INCOMPLETE][54] ([fdo#107713]) -> [PASS][55]
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb2/igt@kms_cursor_crc@pipe-a-cursor-suspend.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-snb:          [INCOMPLETE][56] ([fdo#105411]) -> [PASS][57] +1 similar issue
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-snb1/igt@kms_flip@flip-vs-suspend.html
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-snb5/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt:
    - {shard-tglb}:       [FAIL][58] ([fdo#103167]) -> [PASS][59] +2 similar issues
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-pgflip-blt.html

  * igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
    - shard-iclb:         [FAIL][60] ([fdo#103167]) -> [PASS][61] +7 similar issues
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb6/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary.html

  * igt@kms_frontbuffer_tracking@fbc-suspend:
    - shard-kbl:          [DMESG-WARN][62] ([fdo#108566]) -> [PASS][63] +3 similar issues
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-suspend.html

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-rte:
    - shard-iclb:         [FAIL][64] ([fdo#103167] / [fdo#110378]) -> [PASS][65]
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb1/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-rte.html

  * igt@kms_psr2_su@frontbuffer:
    - shard-iclb:         [SKIP][66] ([fdo#109642] / [fdo#111068]) -> [PASS][67]
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@kms_psr2_su@frontbuffer.html
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb2/igt@kms_psr2_su@frontbuffer.html

  * igt@kms_psr@psr2_dpms:
    - shard-iclb:         [SKIP][68] ([fdo#109441]) -> [PASS][69]
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb7/igt@kms_psr@psr2_dpms.html
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb2/igt@kms_psr@psr2_dpms.html

  * igt@kms_psr@suspend:
    - {shard-tglb}:       [INCOMPLETE][70] ([fdo#111832] / [fdo#111850]) -> [PASS][71] +2 similar issues
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb4/igt@kms_psr@suspend.html
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-tglb4/igt@kms_psr@suspend.html

  * igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend:
    - {shard-tglb}:       [INCOMPLETE][72] ([fdo#111850]) -> [PASS][73]
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-tglb8/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-tglb4/igt@kms_vblank@pipe-b-ts-continuation-dpms-suspend.html

  
#### Warnings ####

  * igt@gem_ctx_isolation@vcs1-nonpriv:
    - shard-iclb:         [FAIL][74] ([fdo#111329]) -> [SKIP][75] ([fdo#109276] / [fdo#112080])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb4/igt@gem_ctx_isolation@vcs1-nonpriv.html
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb8/igt@gem_ctx_isolation@vcs1-nonpriv.html

  * igt@gem_mocs_settings@mocs-settings-bsd2:
    - shard-iclb:         [SKIP][76] ([fdo#109276]) -> [FAIL][77] ([fdo#111330])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-iclb6/igt@gem_mocs_settings@mocs-settings-bsd2.html
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-iclb1/igt@gem_mocs_settings@mocs-settings-bsd2.html

  * igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
    - shard-snb:          [DMESG-WARN][78] ([fdo#111870]) -> [DMESG-WARN][79] ([fdo#110789] / [fdo#111870])
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7187/shard-snb5/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/shard-snb4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo# 111852 ]: https://bugs.freedesktop.org/show_bug.cgi?id= 111852 
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
  [fdo#108341]: https://bugs.freedesktop.org/show_bug.cgi?id=108341
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
  [fdo#110378]: https://bugs.freedesktop.org/show_bug.cgi?id=110378
  [fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
  [fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
  [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
  [fdo#111325]: https://bugs.freedesktop.org/show_bug.cgi?id=111325
  [fdo#111329]: https://bugs.freedesktop.org/show_bug.cgi?id=111329
  [fdo#111330]: https://bugs.freedesktop.org/show_bug.cgi?id=111330
  [fdo#111646]: https://bugs.freedesktop.org/show_bug.cgi?id=111646
  [fdo#111671]: https://bugs.freedesktop.org/show_bug.cgi?id=111671
  [fdo#111703]: https://bugs.freedesktop.org/show_bug.cgi?id=111703
  [fdo#111735]: https://bugs.freedesktop.org/show_bug.cgi?id=111735
  [fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
  [fdo#111780 ]: https://bugs.freedesktop.org/show_bug.cgi?id=111780 
  [fdo#111781]: https://bugs.freedesktop.org/show_bug.cgi?id=111781
  [fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
  [fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
  [fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
  [fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991
  [fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
  [fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080


Participating hosts (11 -> 8)
------------------------------

  Missing    (3): pig-skl-6260u pig-glk-j5005 pig-hsw-4770r 


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_5241 -> IGTPW_3616
  * Piglit: piglit_4509 -> None

  CI-20190529: 20190529
  CI_DRM_7187: 9df5aeba240a65ea80008020d3027484bc6055b3 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_3616: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/index.html
  IGT_5241: 17b87c378fa155390b13a43f141371fd899d567b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3616/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't test every plane on icl+
  2019-10-25 19:01 [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't test every plane on icl+ Ville Syrjala
  2019-10-25 19:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2019-10-27 10:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-10-30 12:59 ` Petri Latvala
  2019-10-30 13:34   ` Ville Syrjälä
  2 siblings, 1 reply; 6+ messages in thread
From: Petri Latvala @ 2019-10-30 12:59 UTC (permalink / raw)
  To: Ville Syrjala; +Cc: igt-dev

On Fri, Oct 25, 2019 at 10:01:34PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Only test one plane of each type (HDR, SDR UV, SDR Y) on icl+.
> For the purposes of validating pixel formats this should be sufficient
> as the programming of each plane of the same type is identical and
> as such it's unlikely we'd have different bugs between them.
> 
> As before we'll leave the full test set available to be run at
> the user's discretion via --extended.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  tests/kms_plane.c | 25 ++++++++++++++++++++++++-
>  1 file changed, 24 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 86a3a6296d26..7672374f5152 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -757,6 +757,26 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
>  	return result;
>  }
>  
> +static bool skip_plane(data_t *data, igt_plane_t *plane)
> +{
> +	int index = plane->index;
> +
> +	if (data->extended)
> +		return false;
> +
> +	if (!is_i915_device(data->drm_fd))
> +		return false;
> +
> +	if (plane->type == DRM_PLANE_TYPE_CURSOR)
> +		return false;
> +
> +	if (intel_gen(intel_get_drm_devid(data->drm_fd)) < 11)
> +		return false;
> +
> +	/* test 1 HDR plane, 1 SDR UV plane, 1 SDR Y plane */
> +	return index != 0 && index != 3 && index != 5;


Magic numbers, but we can maybe let that slide. Where can one check
that these indices are the plane types stated?


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't test every plane on icl+
  2019-10-30 12:59 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
@ 2019-10-30 13:34   ` Ville Syrjälä
  2019-10-31  8:40     ` Petri Latvala
  0 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2019-10-30 13:34 UTC (permalink / raw)
  To: Petri Latvala; +Cc: igt-dev

On Wed, Oct 30, 2019 at 02:59:28PM +0200, Petri Latvala wrote:
> On Fri, Oct 25, 2019 at 10:01:34PM +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Only test one plane of each type (HDR, SDR UV, SDR Y) on icl+.
> > For the purposes of validating pixel formats this should be sufficient
> > as the programming of each plane of the same type is identical and
> > as such it's unlikely we'd have different bugs between them.
> > 
> > As before we'll leave the full test set available to be run at
> > the user's discretion via --extended.
> > 
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  tests/kms_plane.c | 25 ++++++++++++++++++++++++-
> >  1 file changed, 24 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> > index 86a3a6296d26..7672374f5152 100644
> > --- a/tests/kms_plane.c
> > +++ b/tests/kms_plane.c
> > @@ -757,6 +757,26 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
> >  	return result;
> >  }
> >  
> > +static bool skip_plane(data_t *data, igt_plane_t *plane)
> > +{
> > +	int index = plane->index;
> > +
> > +	if (data->extended)
> > +		return false;
> > +
> > +	if (!is_i915_device(data->drm_fd))
> > +		return false;
> > +
> > +	if (plane->type == DRM_PLANE_TYPE_CURSOR)
> > +		return false;
> > +
> > +	if (intel_gen(intel_get_drm_devid(data->drm_fd)) < 11)
> > +		return false;
> > +
> > +	/* test 1 HDR plane, 1 SDR UV plane, 1 SDR Y plane */
> > +	return index != 0 && index != 3 && index != 5;
> 
> 
> Magic numbers, but we can maybe let that slide. Where can one check
> that these indices are the plane types stated?

Kernel land plane->id:
icl_is_hdr_plane() vs. icl_is_nv12_y_plane(), vs. neither +
the plane uapi registration order matches the plane->id order.

0,1,2 HDR planes
3,4 SDR UV planes
5,6 SDR Y planes

I guess I should put that full list in the comment actually.

The SDR UV planes are going away at some point, but the index
3 check will then catch one of the the SDR Y planes. So should
be future proof for some time.

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't test every plane on icl+
  2019-10-30 13:34   ` Ville Syrjälä
@ 2019-10-31  8:40     ` Petri Latvala
  0 siblings, 0 replies; 6+ messages in thread
From: Petri Latvala @ 2019-10-31  8:40 UTC (permalink / raw)
  To: Ville Syrjälä; +Cc: igt-dev

On Wed, Oct 30, 2019 at 03:34:27PM +0200, Ville Syrjälä wrote:
> On Wed, Oct 30, 2019 at 02:59:28PM +0200, Petri Latvala wrote:
> > On Fri, Oct 25, 2019 at 10:01:34PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > 
> > > Only test one plane of each type (HDR, SDR UV, SDR Y) on icl+.
> > > For the purposes of validating pixel formats this should be sufficient
> > > as the programming of each plane of the same type is identical and
> > > as such it's unlikely we'd have different bugs between them.
> > > 
> > > As before we'll leave the full test set available to be run at
> > > the user's discretion via --extended.
> > > 
> > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > ---
> > >  tests/kms_plane.c | 25 ++++++++++++++++++++++++-
> > >  1 file changed, 24 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> > > index 86a3a6296d26..7672374f5152 100644
> > > --- a/tests/kms_plane.c
> > > +++ b/tests/kms_plane.c
> > > @@ -757,6 +757,26 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
> > >  	return result;
> > >  }
> > >  
> > > +static bool skip_plane(data_t *data, igt_plane_t *plane)
> > > +{
> > > +	int index = plane->index;
> > > +
> > > +	if (data->extended)
> > > +		return false;
> > > +
> > > +	if (!is_i915_device(data->drm_fd))
> > > +		return false;
> > > +
> > > +	if (plane->type == DRM_PLANE_TYPE_CURSOR)
> > > +		return false;
> > > +
> > > +	if (intel_gen(intel_get_drm_devid(data->drm_fd)) < 11)
> > > +		return false;
> > > +
> > > +	/* test 1 HDR plane, 1 SDR UV plane, 1 SDR Y plane */
> > > +	return index != 0 && index != 3 && index != 5;
> > 
> > 
> > Magic numbers, but we can maybe let that slide. Where can one check
> > that these indices are the plane types stated?
> 
> Kernel land plane->id:
> icl_is_hdr_plane() vs. icl_is_nv12_y_plane(), vs. neither +
> the plane uapi registration order matches the plane->id order.
> 
> 0,1,2 HDR planes
> 3,4 SDR UV planes
> 5,6 SDR Y planes
> 
> I guess I should put that full list in the comment actually.

Yes please.

> 
> The SDR UV planes are going away at some point, but the index
> 3 check will then catch one of the the SDR Y planes. So should
> be future proof for some time.


Sounds good. With the enhanced comment,

Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-10-31  8:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 19:01 [igt-dev] [PATCH i-g-t] tests/kms_plane: Don't test every plane on icl+ Ville Syrjala
2019-10-25 19:41 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-10-27 10:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-10-30 12:59 ` [igt-dev] [PATCH i-g-t] " Petri Latvala
2019-10-30 13:34   ` Ville Syrjälä
2019-10-31  8:40     ` Petri Latvala

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.