* Re: [PATCH] input: touchscreen: Add NULL pointer check before dereference
[not found] <20190901182309.GA5574@ahmlpt0706>
@ 2019-10-24 18:08 ` Saiyam Doshi
2019-10-25 21:17 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Saiyam Doshi @ 2019-10-24 18:08 UTC (permalink / raw)
To: robh, linux-input
On Sun, Sep 01, 2019 at 11:53:09PM +0530, Saiyam Doshi wrote:
> In sx8654_probe function, if call to device_get_match_data()
> return NULL, it dereferences driver_data from 'id'.
>
> To avoid NULL pointer dereference, add check to make sure
> 'id' is not NULL.
Any review / update on this?
-Saiyam
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] input: touchscreen: Add NULL pointer check before dereference
2019-10-24 18:08 ` [PATCH] input: touchscreen: Add NULL pointer check before dereference Saiyam Doshi
@ 2019-10-25 21:17 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2019-10-25 21:17 UTC (permalink / raw)
To: Saiyam Doshi; +Cc: robh, linux-input
Hi Saiyam,
On Thu, Oct 24, 2019 at 11:38:22PM +0530, Saiyam Doshi wrote:
> On Sun, Sep 01, 2019 at 11:53:09PM +0530, Saiyam Doshi wrote:
> > In sx8654_probe function, if call to device_get_match_data()
> > return NULL, it dereferences driver_data from 'id'.
> >
> > To avoid NULL pointer dereference, add check to make sure
> > 'id' is not NULL.
>
> Any review / update on this?
Can you please explain under what circumstances we can get NULL from
device_get_match_data() in this driver?
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-25 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190901182309.GA5574@ahmlpt0706>
2019-10-24 18:08 ` [PATCH] input: touchscreen: Add NULL pointer check before dereference Saiyam Doshi
2019-10-25 21:17 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.