All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH] staging: gasket: Fix line ending with a '('
@ 2019-10-25 23:39 ` Cristiane Naves
  0 siblings, 0 replies; 7+ messages in thread
From: Cristiane Naves @ 2019-10-25 23:39 UTC (permalink / raw)
  To: outreachy-kernel
  Cc: outreachy-kernel, Rob Springer, Todd Poynor, Ben Chan,
	Greg Kroah-Hartman, devel, linux-kernel

Fix line ending with a '('

Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
---
 drivers/staging/gasket/gasket_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
index 240f9bb..d1b3e9a 100644
--- a/drivers/staging/gasket/gasket_ioctl.c
+++ b/drivers/staging/gasket/gasket_ioctl.c
@@ -34,8 +34,8 @@ static int gasket_set_event_fd(struct gasket_dev *gasket_dev,
 
 	trace_gasket_ioctl_eventfd_data(die.interrupt, die.event_fd);
 
-	return gasket_interrupt_set_eventfd(
-		gasket_dev->interrupt_data, die.interrupt, die.event_fd);
+	return gasket_interrupt_set_eventfd(gasket_dev->interrupt_data,
+					    die.interrupt, die.event_fd);
 }
 
 /* Read the size of the page table. */
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [RESEND PATCH] staging: gasket: Fix line ending with a '('
@ 2019-10-25 23:39 ` Cristiane Naves
  0 siblings, 0 replies; 7+ messages in thread
From: Cristiane Naves @ 2019-10-25 23:39 UTC (permalink / raw)
  To: outreachy-kernel
  Cc: devel, Greg Kroah-Hartman, linux-kernel, outreachy-kernel,
	Rob Springer, Todd Poynor

Fix line ending with a '('

Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
---
 drivers/staging/gasket/gasket_ioctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
index 240f9bb..d1b3e9a 100644
--- a/drivers/staging/gasket/gasket_ioctl.c
+++ b/drivers/staging/gasket/gasket_ioctl.c
@@ -34,8 +34,8 @@ static int gasket_set_event_fd(struct gasket_dev *gasket_dev,
 
 	trace_gasket_ioctl_eventfd_data(die.interrupt, die.event_fd);
 
-	return gasket_interrupt_set_eventfd(
-		gasket_dev->interrupt_data, die.interrupt, die.event_fd);
+	return gasket_interrupt_set_eventfd(gasket_dev->interrupt_data,
+					    die.interrupt, die.event_fd);
 }
 
 /* Read the size of the page table. */
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix line ending with a '('
  2019-10-25 23:39 ` Cristiane Naves
@ 2019-10-26  4:40   ` Julia Lawall
  -1 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2019-10-26  4:40 UTC (permalink / raw)
  To: Cristiane Naves
  Cc: outreachy-kernel, Rob Springer, Todd Poynor, Ben Chan,
	Greg Kroah-Hartman, devel, linux-kernel



On Fri, 25 Oct 2019, Cristiane Naves wrote:

> Fix line ending with a '('
>
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
>  drivers/staging/gasket/gasket_ioctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
> index 240f9bb..d1b3e9a 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -34,8 +34,8 @@ static int gasket_set_event_fd(struct gasket_dev *gasket_dev,
>
>  	trace_gasket_ioctl_eventfd_data(die.interrupt, die.event_fd);
>
> -	return gasket_interrupt_set_eventfd(
> -		gasket_dev->interrupt_data, die.interrupt, die.event_fd);
> +	return gasket_interrupt_set_eventfd(gasket_dev->interrupt_data,
> +					    die.interrupt, die.event_fd);
>  }
>
>  /* Read the size of the page table. */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025233909.GA1599%40cristiane-Inspiron-5420.
>


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [Outreachy kernel] [RESEND PATCH] staging: gasket: Fix line ending with a '('
@ 2019-10-26  4:40   ` Julia Lawall
  0 siblings, 0 replies; 7+ messages in thread
From: Julia Lawall @ 2019-10-26  4:40 UTC (permalink / raw)
  To: Cristiane Naves
  Cc: devel, Greg Kroah-Hartman, linux-kernel, outreachy-kernel,
	Rob Springer, Todd Poynor



On Fri, 25 Oct 2019, Cristiane Naves wrote:

> Fix line ending with a '('
>
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
>  drivers/staging/gasket/gasket_ioctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/gasket/gasket_ioctl.c b/drivers/staging/gasket/gasket_ioctl.c
> index 240f9bb..d1b3e9a 100644
> --- a/drivers/staging/gasket/gasket_ioctl.c
> +++ b/drivers/staging/gasket/gasket_ioctl.c
> @@ -34,8 +34,8 @@ static int gasket_set_event_fd(struct gasket_dev *gasket_dev,
>
>  	trace_gasket_ioctl_eventfd_data(die.interrupt, die.event_fd);
>
> -	return gasket_interrupt_set_eventfd(
> -		gasket_dev->interrupt_data, die.interrupt, die.event_fd);
> +	return gasket_interrupt_set_eventfd(gasket_dev->interrupt_data,
> +					    die.interrupt, die.event_fd);
>  }
>
>  /* Read the size of the page table. */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191025233909.GA1599%40cristiane-Inspiron-5420.
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] staging: gasket: Fix line ending with a '('
  2019-10-25 23:39 ` Cristiane Naves
@ 2019-10-26 18:02   ` Greg Kroah-Hartman
  -1 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-10-26 18:02 UTC (permalink / raw)
  To: Cristiane Naves
  Cc: outreachy-kernel, devel, linux-kernel, Rob Springer, Todd Poynor

On Fri, Oct 25, 2019 at 08:39:09PM -0300, Cristiane Naves wrote:
> Fix line ending with a '('
> 
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
>  drivers/staging/gasket/gasket_ioctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why is this a "RESEND"?  Did nothing change in it?

Always version your patches, as the documentation suggests, and list
below the --- line what changed from the previous version.

Please fix up and resend it as a v3 (this is v2, right?)

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] staging: gasket: Fix line ending with a '('
@ 2019-10-26 18:02   ` Greg Kroah-Hartman
  0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2019-10-26 18:02 UTC (permalink / raw)
  To: Cristiane Naves
  Cc: devel, outreachy-kernel, Todd Poynor, Rob Springer, linux-kernel

On Fri, Oct 25, 2019 at 08:39:09PM -0300, Cristiane Naves wrote:
> Fix line ending with a '('
> 
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
>  drivers/staging/gasket/gasket_ioctl.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Why is this a "RESEND"?  Did nothing change in it?

Always version your patches, as the documentation suggests, and list
below the --- line what changed from the previous version.

Please fix up and resend it as a v3 (this is v2, right?)

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [RESEND PATCH] staging: gasket: Fix line ending with a '('
  2019-10-26 18:02   ` Greg Kroah-Hartman
  (?)
@ 2019-10-26 18:32   ` Cristiane Naves
  -1 siblings, 0 replies; 7+ messages in thread
From: Cristiane Naves @ 2019-10-26 18:32 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: outreachy-kernel

On Sat, Oct 26, 2019 at 08:02:25PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Oct 25, 2019 at 08:39:09PM -0300, Cristiane Naves wrote:
> > Fix line ending with a '('
> > 
> > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > ---
> >  drivers/staging/gasket/gasket_ioctl.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Why is this a "RESEND"?  Did nothing change in it?
> 
> Always version your patches, as the documentation suggests, and list
> below the --- line what changed from the previous version.
> 
> Please fix up and resend it as a v3 (this is v2, right?)
> 
> thanks,
> 
> greg k-h

The only thing that changed was that was conflicting between the
author and signed-off-by, so I fixed it. I will send v3 explaining this
change and joining the two patches 'Fix lines ending with (' because
they are similar.

Thanks for the feedback!




^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-10-26 18:32 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 23:39 [RESEND PATCH] staging: gasket: Fix line ending with a '(' Cristiane Naves
2019-10-25 23:39 ` Cristiane Naves
2019-10-26  4:40 ` [Outreachy kernel] " Julia Lawall
2019-10-26  4:40   ` Julia Lawall
2019-10-26 18:02 ` Greg Kroah-Hartman
2019-10-26 18:02   ` Greg Kroah-Hartman
2019-10-26 18:32   ` Cristiane Naves

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.