* [PATCH] staging: mt7621-dma: Remove unnecessary line continuations
@ 2019-10-28 5:12 Frank A. Cancio Bello
2019-10-28 6:27 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Frank A. Cancio Bello @ 2019-10-28 5:12 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, saiprakash.ranjan, joel, Matthias Brugger
checkpatch message:
"WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations"
Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
---
drivers/staging/mt7621-dma/mtk-hsdma.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
index 03c8937f80b0..94c2c708dc92 100644
--- a/drivers/staging/mt7621-dma/mtk-hsdma.c
+++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
@@ -208,8 +208,8 @@ static void mtk_hsdma_reset_chan(struct mtk_hsdam_engine *hsdma,
static void hsdma_dump_reg(struct mtk_hsdam_engine *hsdma)
{
- dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, " \
- "tctx %08x, tdtx: %08x, rbase %08x, " \
+ dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, "
+ "tctx %08x, tdtx: %08x, rbase %08x, "
"rcnt %08x, rctx %08x, rdtx %08x\n",
mtk_hsdma_read(hsdma, HSDMA_REG_TX_BASE),
mtk_hsdma_read(hsdma, HSDMA_REG_TX_CNT),
@@ -220,7 +220,7 @@ static void hsdma_dump_reg(struct mtk_hsdam_engine *hsdma)
mtk_hsdma_read(hsdma, HSDMA_REG_RX_CRX),
mtk_hsdma_read(hsdma, HSDMA_REG_RX_DRX));
- dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, " \
+ dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, "
"intr_stat %08x, intr_mask %08x\n",
mtk_hsdma_read(hsdma, HSDMA_REG_INFO),
mtk_hsdma_read(hsdma, HSDMA_REG_GLO_CFG),
@@ -243,9 +243,9 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
tx_desc = &chan->tx_ring[i];
rx_desc = &chan->rx_ring[i];
- dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, " \
+ dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, "
"tx addr1: %08x, rx addr0 %08x, flags %08x\n",
- i, tx_desc->addr0, tx_desc->flags, \
+ i, tx_desc->addr0, tx_desc->flags,
tx_desc->addr1, rx_desc->addr0, rx_desc->flags);
}
}
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: mt7621-dma: Remove unnecessary line continuations
2019-10-28 5:12 [PATCH] staging: mt7621-dma: Remove unnecessary line continuations Frank A. Cancio Bello
@ 2019-10-28 6:27 ` Julia Lawall
2019-10-28 7:00 ` Frank A. Cancio Bello
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2019-10-28 6:27 UTC (permalink / raw)
To: Frank A. Cancio Bello
Cc: gregkh, outreachy-kernel, saiprakash.ranjan, joel, Matthias Brugger
On Mon, 28 Oct 2019, Frank A. Cancio Bello wrote:
> checkpatch message:
> "WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations"
>
> Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> ---
> drivers/staging/mt7621-dma/mtk-hsdma.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> index 03c8937f80b0..94c2c708dc92 100644
> --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> @@ -208,8 +208,8 @@ static void mtk_hsdma_reset_chan(struct mtk_hsdam_engine *hsdma,
>
> static void hsdma_dump_reg(struct mtk_hsdam_engine *hsdma)
> {
> - dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, " \
> - "tctx %08x, tdtx: %08x, rbase %08x, " \
> + dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, "
> + "tctx %08x, tdtx: %08x, rbase %08x, "
> "rcnt %08x, rctx %08x, rdtx %08x\n",
String should not be cut over multiple lines, even if it results in
exceeding 80 characters. This makes it easier to grep for messages in the
code. You could fix both problems at once, since they affect the same
code in each case.
julia
> mtk_hsdma_read(hsdma, HSDMA_REG_TX_BASE),
> mtk_hsdma_read(hsdma, HSDMA_REG_TX_CNT),
> @@ -220,7 +220,7 @@ static void hsdma_dump_reg(struct mtk_hsdam_engine *hsdma)
> mtk_hsdma_read(hsdma, HSDMA_REG_RX_CRX),
> mtk_hsdma_read(hsdma, HSDMA_REG_RX_DRX));
>
> - dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, " \
> + dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, "
> "intr_stat %08x, intr_mask %08x\n",
> mtk_hsdma_read(hsdma, HSDMA_REG_INFO),
> mtk_hsdma_read(hsdma, HSDMA_REG_GLO_CFG),
> @@ -243,9 +243,9 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
> tx_desc = &chan->tx_ring[i];
> rx_desc = &chan->rx_ring[i];
>
> - dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, " \
> + dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, "
> "tx addr1: %08x, rx addr0 %08x, flags %08x\n",
> - i, tx_desc->addr0, tx_desc->flags, \
> + i, tx_desc->addr0, tx_desc->flags,
> tx_desc->addr1, rx_desc->addr0, rx_desc->flags);
> }
> }
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191028051237.3row7xnbr6pgn4bp%40linux-kernel-dev.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: mt7621-dma: Remove unnecessary line continuations
2019-10-28 6:27 ` [Outreachy kernel] " Julia Lawall
@ 2019-10-28 7:00 ` Frank A. Cancio Bello
0 siblings, 0 replies; 3+ messages in thread
From: Frank A. Cancio Bello @ 2019-10-28 7:00 UTC (permalink / raw)
To: Julia Lawall
Cc: gregkh, outreachy-kernel, saiprakash.ranjan, joel, Matthias Brugger
On Mon, Oct 28, 2019 at 07:27:36AM +0100, Julia Lawall wrote:
>
>
> On Mon, 28 Oct 2019, Frank A. Cancio Bello wrote:
>
> > checkpatch message:
> > "WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations"
> >
> > Signed-off-by: Frank A. Cancio Bello <frank@generalsoftwareinc.com>
> > ---
> > drivers/staging/mt7621-dma/mtk-hsdma.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/staging/mt7621-dma/mtk-hsdma.c b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > index 03c8937f80b0..94c2c708dc92 100644
> > --- a/drivers/staging/mt7621-dma/mtk-hsdma.c
> > +++ b/drivers/staging/mt7621-dma/mtk-hsdma.c
> > @@ -208,8 +208,8 @@ static void mtk_hsdma_reset_chan(struct mtk_hsdam_engine *hsdma,
> >
> > static void hsdma_dump_reg(struct mtk_hsdam_engine *hsdma)
> > {
> > - dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, " \
> > - "tctx %08x, tdtx: %08x, rbase %08x, " \
> > + dev_dbg(hsdma->ddev.dev, "tbase %08x, tcnt %08x, "
> > + "tctx %08x, tdtx: %08x, rbase %08x, "
> > "rcnt %08x, rctx %08x, rdtx %08x\n",
>
> String should not be cut over multiple lines, even if it results in
> exceeding 80 characters. This makes it easier to grep for messages in the
> code. You could fix both problems at once, since they affect the same
> code in each case.
>
> julia
>
Thank you Julia for the suggestion. I already sent a new version of the patch.
frank a.
> > mtk_hsdma_read(hsdma, HSDMA_REG_TX_BASE),
> > mtk_hsdma_read(hsdma, HSDMA_REG_TX_CNT),
> > @@ -220,7 +220,7 @@ static void hsdma_dump_reg(struct mtk_hsdam_engine *hsdma)
> > mtk_hsdma_read(hsdma, HSDMA_REG_RX_CRX),
> > mtk_hsdma_read(hsdma, HSDMA_REG_RX_DRX));
> >
> > - dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, " \
> > + dev_dbg(hsdma->ddev.dev, "info %08x, glo %08x, delay %08x, "
> > "intr_stat %08x, intr_mask %08x\n",
> > mtk_hsdma_read(hsdma, HSDMA_REG_INFO),
> > mtk_hsdma_read(hsdma, HSDMA_REG_GLO_CFG),
> > @@ -243,9 +243,9 @@ static void hsdma_dump_desc(struct mtk_hsdam_engine *hsdma,
> > tx_desc = &chan->tx_ring[i];
> > rx_desc = &chan->rx_ring[i];
> >
> > - dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, " \
> > + dev_dbg(hsdma->ddev.dev, "%d tx addr0: %08x, flags %08x, "
> > "tx addr1: %08x, rx addr0 %08x, flags %08x\n",
> > - i, tx_desc->addr0, tx_desc->flags, \
> > + i, tx_desc->addr0, tx_desc->flags,
> > tx_desc->addr1, rx_desc->addr0, rx_desc->flags);
> > }
> > }
> > --
> > 2.17.1
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191028051237.3row7xnbr6pgn4bp%40linux-kernel-dev.
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-28 7:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 5:12 [PATCH] staging: mt7621-dma: Remove unnecessary line continuations Frank A. Cancio Bello
2019-10-28 6:27 ` [Outreachy kernel] " Julia Lawall
2019-10-28 7:00 ` Frank A. Cancio Bello
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.