All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] ima-evm-utils: Add as new package, version 1.2.1
@ 2019-10-28  5:40 Petr Vorel
  2019-10-28  7:35 ` Yann E. MORIN
  0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2019-10-28  5:40 UTC (permalink / raw)
  To: buildroot

+ add myself as a maintainer.

Adding build and install hooks to run make in src subdirectory
(root directory asciidoc and xsltproc for manpage).

Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
---
Changes v1->v2:
* Add dependency comment
* Split make commands

Kind regards,
Petr

 DEVELOPERS                               |  1 +
 package/Config.in                        |  1 +
 package/ima-evm-utils/Config.in          | 15 +++++++++++
 package/ima-evm-utils/ima-evm-utils.hash |  3 +++
 package/ima-evm-utils/ima-evm-utils.mk   | 34 ++++++++++++++++++++++++
 5 files changed, 54 insertions(+)
 create mode 100644 package/ima-evm-utils/Config.in
 create mode 100644 package/ima-evm-utils/ima-evm-utils.hash
 create mode 100644 package/ima-evm-utils/ima-evm-utils.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index f41ac5f096..caf3ea26d4 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1891,6 +1891,7 @@ N:	Petr Kulhavy <brain@jikos.cz>
 F:	package/linuxptp/
 
 N:	Petr Vorel <petr.vorel@gmail.com>
+F:	package/ima-evm-utils/
 F:	package/iproute2/
 F:	package/iputils/
 F:	package/linux-backports/
diff --git a/package/Config.in b/package/Config.in
index a1ac5069aa..a5147ee7fa 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -2169,6 +2169,7 @@ endmenu
 
 menu "Security"
 	source "package/checkpolicy/Config.in"
+	source "package/ima-evm-utils/Config.in"
 	source "package/optee-benchmark/Config.in"
 	source "package/optee-client/Config.in"
 	source "package/optee-examples/Config.in"
diff --git a/package/ima-evm-utils/Config.in b/package/ima-evm-utils/Config.in
new file mode 100644
index 0000000000..10dea5243b
--- /dev/null
+++ b/package/ima-evm-utils/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_IMA_EVM_UTILS
+	bool "ima-evm-utils"
+	depends on BR2_USE_MMU # keyutils dependency: fork()
+	depends on !BR2_STATIC_LIBS # keyutils dependency: dlopen
+	select BR2_PACKAGE_OPENSSL
+	select BR2_PACKAGE_KEYUTILS
+	help
+	  Linux Integrity Measurement Architecture (IMA)
+	  Extended Verification Module (EVM) tools.
+
+	  https://sourceforge.net/p/linux-ima/wiki/Home/
+
+comment "ima-evm-utils needs dynamic library support"
+	depends on BR2_USE_MMU
+	depends on BR2_STATIC_LIBS
diff --git a/package/ima-evm-utils/ima-evm-utils.hash b/package/ima-evm-utils/ima-evm-utils.hash
new file mode 100644
index 0000000000..24be627d20
--- /dev/null
+++ b/package/ima-evm-utils/ima-evm-utils.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256 ad8471b58c4df29abd51c80d74b1501cfe3289b60d32d1b318618a8fd26c0c0a  ima-evm-utils-1.2.1.tar.gz
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/ima-evm-utils/ima-evm-utils.mk b/package/ima-evm-utils/ima-evm-utils.mk
new file mode 100644
index 0000000000..97de449d0d
--- /dev/null
+++ b/package/ima-evm-utils/ima-evm-utils.mk
@@ -0,0 +1,34 @@
+################################################################################
+#
+# ima-evm-utils
+#
+################################################################################
+
+IMA_EVM_UTILS_VERSION = 1.2.1
+IMA_EVM_UTILS_SITE = http://downloads.sourceforge.net/project/linux-ima/ima-evm-utils
+IMA_EVM_UTILS_LICENSE = GPL-2.0
+IMA_EVM_UTILS_LICENSE_FILES = COPYING
+IMA_EVM_UTILS_DEPENDENCIES = host-pkgconf keyutils openssl
+
+# configure is missing but gpm seems not compatible with our autoreconf
+# mechanism so we have to do it manually instead of using IMA_EVM_UTILS_AUTORECONF = YES
+define IMA_EVM_UTILS_RUN_AUTOGEN
+	cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
+endef
+IMA_EVM_UTILS_PRE_CONFIGURE_HOOKS += IMA_EVM_UTILS_RUN_AUTOGEN
+
+# build just sources in src subdirectory as root directory requires asciidoc
+# and xsltproc for manpage
+define IMA_EVM_UTILS_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(IMA_EVM_UTILS_MAKE_ENV) $(MAKE) -C $(@D)/src all
+endef
+define IMA_EVM_UTILS_INSTALL_STAGING_CMDS
+	$(TARGET_MAKE_ENV) $(IMA_EVM_UTILS_MAKE_ENV) $(MAKE) \
+		DESTDIR="$(STAGING_DIR)" -C $(@D)/src install
+endef
+define IMA_EVM_UTILS_INSTALL_TARGET_CMDS
+	$(TARGET_MAKE_ENV) $(IMA_EVM_UTILS_MAKE_ENV) $(MAKE) \
+		DESTDIR="$(TARGET_DIR)" -C $(@D)/src install
+endef
+
+$(eval $(autotools-package))
-- 
2.23.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2 1/1] ima-evm-utils: Add as new package, version 1.2.1
  2019-10-28  5:40 [Buildroot] [PATCH v2 1/1] ima-evm-utils: Add as new package, version 1.2.1 Petr Vorel
@ 2019-10-28  7:35 ` Yann E. MORIN
  2019-10-29  0:24   ` Petr Vorel
  0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2019-10-28  7:35 UTC (permalink / raw)
  To: buildroot

Petr, All,

On 2019-10-28 06:40 +0100, Petr Vorel spake thusly:
> + add myself as a maintainer.
> 
> Adding build and install hooks to run make in src subdirectory
> (root directory asciidoc and xsltproc for manpage).
> 
> Signed-off-by: Petr Vorel <petr.vorel@gmail.com>
> ---
[--SNIP--]
> diff --git a/package/ima-evm-utils/ima-evm-utils.mk b/package/ima-evm-utils/ima-evm-utils.mk
> new file mode 100644
> index 0000000000..97de449d0d
> --- /dev/null
> +++ b/package/ima-evm-utils/ima-evm-utils.mk
> @@ -0,0 +1,34 @@
> +################################################################################
> +#
> +# ima-evm-utils
> +#
> +################################################################################
> +
> +IMA_EVM_UTILS_VERSION = 1.2.1
> +IMA_EVM_UTILS_SITE = http://downloads.sourceforge.net/project/linux-ima/ima-evm-utils
> +IMA_EVM_UTILS_LICENSE = GPL-2.0
> +IMA_EVM_UTILS_LICENSE_FILES = COPYING
> +IMA_EVM_UTILS_DEPENDENCIES = host-pkgconf keyutils openssl
> +
> +# configure is missing but gpm seems not compatible with our autoreconf
> +# mechanism so we have to do it manually instead of using IMA_EVM_UTILS_AUTORECONF = YES
> +define IMA_EVM_UTILS_RUN_AUTOGEN
> +	cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
> +endef
> +IMA_EVM_UTILS_PRE_CONFIGURE_HOOKS += IMA_EVM_UTILS_RUN_AUTOGEN

Looking at the code, it looks like their autoregen.sh is just creating
the missing m4/ sub-directory.

Have you tried:

    define IMA_EVM_UTILS_M4
        mkdir -p $(@D)/m4
    endef
    IMA_EVM_UTILS_POST_EXTRACT_HOOKS += IMA_EVM_UTILS_M4
    IMA_EVM_UTILS_AUTORECONF = YES

> +# build just sources in src subdirectory as root directory requires asciidoc
> +# and xsltproc for manpage
> +define IMA_EVM_UTILS_BUILD_CMDS
> +	$(TARGET_MAKE_ENV) $(IMA_EVM_UTILS_MAKE_ENV) $(MAKE) -C $(@D)/src all
> +endef

Have you tried:

    IMA_EVM_UTILS_SUBDIR = src

Regards,
Yann E. MORIN.

> +define IMA_EVM_UTILS_INSTALL_STAGING_CMDS
> +	$(TARGET_MAKE_ENV) $(IMA_EVM_UTILS_MAKE_ENV) $(MAKE) \
> +		DESTDIR="$(STAGING_DIR)" -C $(@D)/src install
> +endef
> +define IMA_EVM_UTILS_INSTALL_TARGET_CMDS
> +	$(TARGET_MAKE_ENV) $(IMA_EVM_UTILS_MAKE_ENV) $(MAKE) \
> +		DESTDIR="$(TARGET_DIR)" -C $(@D)/src install
> +endef
> +
> +$(eval $(autotools-package))
> -- 
> 2.23.0
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

^ permalink raw reply	[flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v2 1/1] ima-evm-utils: Add as new package, version 1.2.1
  2019-10-28  7:35 ` Yann E. MORIN
@ 2019-10-29  0:24   ` Petr Vorel
  0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2019-10-29  0:24 UTC (permalink / raw)
  To: buildroot

Hi all,

> [--SNIP--]
> > diff --git a/package/ima-evm-utils/ima-evm-utils.mk b/package/ima-evm-utils/ima-evm-utils.mk
> > new file mode 100644
> > index 0000000000..97de449d0d
> > --- /dev/null
> > +++ b/package/ima-evm-utils/ima-evm-utils.mk
> > @@ -0,0 +1,34 @@
> > +################################################################################
> > +#
> > +# ima-evm-utils
> > +#
> > +################################################################################
> > +
> > +IMA_EVM_UTILS_VERSION = 1.2.1
> > +IMA_EVM_UTILS_SITE = http://downloads.sourceforge.net/project/linux-ima/ima-evm-utils
> > +IMA_EVM_UTILS_LICENSE = GPL-2.0
> > +IMA_EVM_UTILS_LICENSE_FILES = COPYING
> > +IMA_EVM_UTILS_DEPENDENCIES = host-pkgconf keyutils openssl
> > +
> > +# configure is missing but gpm seems not compatible with our autoreconf
gpm is obviously copy paste error.
I'm going to send v3, which won't need this section anyway.
> > +# mechanism so we have to do it manually instead of using IMA_EVM_UTILS_AUTORECONF = YES
> > +define IMA_EVM_UTILS_RUN_AUTOGEN
> > +	cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
> > +endef
> > +IMA_EVM_UTILS_PRE_CONFIGURE_HOOKS += IMA_EVM_UTILS_RUN_AUTOGEN

> Looking at the code, it looks like their autoregen.sh is just creating
> the missing m4/ sub-directory.

> Have you tried:

>     define IMA_EVM_UTILS_M4
>         mkdir -p $(@D)/m4
>     endef
>     IMA_EVM_UTILS_POST_EXTRACT_HOOKS += IMA_EVM_UTILS_M4
>     IMA_EVM_UTILS_AUTORECONF = YES
In the end IMA_EVM_UTILS_AUTORECONF = YES is enough, it's the only change.
I also got previously this error:
autoreconf: 'configure.ac' or 'configure.in' is required
But I somehow managed to fixed it.

> > +# build just sources in src subdirectory as root directory requires asciidoc
> > +# and xsltproc for manpage
> > +define IMA_EVM_UTILS_BUILD_CMDS
> > +	$(TARGET_MAKE_ENV) $(IMA_EVM_UTILS_MAKE_ENV) $(MAKE) -C $(@D)/src all
> > +endef

> Have you tried:

>     IMA_EVM_UTILS_SUBDIR = src
This would produce
/bin/bash: ./configure: No such file or directory

So, whole diff for v3 will be:

-# configure is missing but gpm seems not compatible with our autoreconf
-# mechanism so we have to do it manually instead of using IMA_EVM_UTILS_AUTORECONF = YES
-define IMA_EVM_UTILS_RUN_AUTOGEN
-	cd $(@D) && PATH=$(BR_PATH) ./autogen.sh
-endef
-IMA_EVM_UTILS_PRE_CONFIGURE_HOOKS += IMA_EVM_UTILS_RUN_AUTOGEN
+IMA_EVM_UTILS_AUTORECONF = YES

> Regards,
> Yann E. MORIN.

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-29  0:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28  5:40 [Buildroot] [PATCH v2 1/1] ima-evm-utils: Add as new package, version 1.2.1 Petr Vorel
2019-10-28  7:35 ` Yann E. MORIN
2019-10-29  0:24   ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.