[PATCH v3 0/2] Cleanup in rtl8712

[PATCH v3 0/2] Cleanup in rtl8712

[Cristiane Naves]

Cleanup in rtl8712

Changes in v2:
 - Arranging conflict between author name and signed-off-by.
 - Remove unnecessary parentheses.
 - Change the driver name to rtl8712

Changes in v3:
 - Change alignment of eth_type
 - Change alignment of SN_EQUAL
 - Remove commit of unneeded parentheses.

Cristiane Naves (2):
  staging: rtl8712: Fix Alignment of open parenthesis
  staging: rtl8712: Remove lines before a close brace

 drivers/staging/rtl8712/rtl8712_recv.c | 38 ++++++++++++++++------------------
 1 file changed, 18 insertions(+), 20 deletions(-)

-- 
2.7.4

[PATCH v3 0/2] Cleanup in rtl8712

[Cristiane Naves]

Cleanup in rtl8712

Changes in v2:
 - Arranging conflict between author name and signed-off-by.
 - Remove unnecessary parentheses.
 - Change the driver name to rtl8712

Changes in v3:
 - Change alignment of eth_type
 - Change alignment of SN_EQUAL
 - Remove commit of unneeded parentheses.

Cristiane Naves (2):
  staging: rtl8712: Fix Alignment of open parenthesis
  staging: rtl8712: Remove lines before a close brace

 drivers/staging/rtl8712/rtl8712_recv.c | 38 ++++++++++++++++------------------
 1 file changed, 18 insertions(+), 20 deletions(-)

-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Cristiane Naves]

Fix alignment should match open parenthesis. Issue found by checkpatch.

Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
---
 drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
index af12c16..304d031 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
 		precvbuf->ref_cnt = 0;
 		precvbuf->adapter = padapter;
 		list_add_tail(&precvbuf->list,
-				 &(precvpriv->free_recv_buf_queue.queue));
+			      (&precvpriv->free_recv_buf_queue.queue));
 		precvbuf++;
 	}
 	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
 	tasklet_init(&precvpriv->recv_tasklet,
-	     (void(*)(unsigned long))recv_tasklet,
-	     (unsigned long)padapter);
+		     (void(*)(unsigned long))recv_tasklet,
+		     (unsigned long)padapter);
 	skb_queue_head_init(&precvpriv->rx_skb_queue);
 
 	skb_queue_head_init(&precvpriv->free_recv_skb_queue);
@@ -140,7 +140,7 @@ void r8712_free_recvframe(union recv_frame *precvframe,
 }
 
 static void update_recvframe_attrib_from_recvstat(struct rx_pkt_attrib *pattrib,
-					   struct recv_stat *prxstat)
+						  struct recv_stat *prxstat)
 {
 	u16 drvinfo_sz;
 
@@ -177,7 +177,7 @@ static void update_recvframe_attrib_from_recvstat(struct rx_pkt_attrib *pattrib,
 
 /*perform defrag*/
 static union recv_frame *recvframe_defrag(struct _adapter *adapter,
-				   struct  __queue *defrag_q)
+					  struct  __queue *defrag_q)
 {
 	struct list_head *plist, *phead;
 	u8 wlanhdr_offset;
@@ -379,26 +379,26 @@ static void amsdu_to_msdu(struct _adapter *padapter, union recv_frame *prframe)
 		/* convert hdr + possible LLC headers into Ethernet header */
 		eth_type = (sub_skb->data[6] << 8) | sub_skb->data[7];
 		if (sub_skb->len >= 8 &&
-		   ((!memcmp(sub_skb->data, rfc1042_header, SNAP_SIZE) &&
-		   eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
-		   !memcmp(sub_skb->data, bridge_tunnel_header, SNAP_SIZE))) {
+		    ((!memcmp(sub_skb->data, rfc1042_header, SNAP_SIZE) &&
+		      eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
+		     !memcmp(sub_skb->data, bridge_tunnel_header, SNAP_SIZE))) {
 			/* remove RFC1042 or Bridge-Tunnel encapsulation and
 			 * replace EtherType
 			 */
 			skb_pull(sub_skb, SNAP_SIZE);
 			memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->src,
-				ETH_ALEN);
+			       ETH_ALEN);
 			memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->dst,
-				ETH_ALEN);
+			       ETH_ALEN);
 		} else {
 			__be16 len;
 			/* Leave Ethernet header part of hdr and full payload */
 			len = htons(sub_skb->len);
 			memcpy(skb_push(sub_skb, 2), &len, 2);
 			memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->src,
-				ETH_ALEN);
+			       ETH_ALEN);
 			memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->dst,
-				ETH_ALEN);
+			       ETH_ALEN);
 		}
 		/* Indicate the packets to upper layer */
 		if (sub_skb) {
@@ -472,7 +472,7 @@ static int check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl,
 }
 
 static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl,
-			      union recv_frame *prframe)
+				     union recv_frame *prframe)
 {
 	struct list_head *phead, *plist;
 	union recv_frame *pnextrframe;
@@ -499,8 +499,8 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl,
 }
 
 int r8712_recv_indicatepkts_in_order(struct _adapter *padapter,
-			       struct recv_reorder_ctrl *preorder_ctrl,
-			       int bforced)
+				     struct recv_reorder_ctrl *preorder_ctrl,
+				     int bforced)
 {
 	struct list_head *phead, *plist;
 	union recv_frame *prframe;
@@ -530,7 +530,7 @@ int r8712_recv_indicatepkts_in_order(struct _adapter *padapter,
 			plist = plist->next;
 			list_del_init(&(prframe->u.hdr.list));
 			if (SN_EQUAL(preorder_ctrl->indicate_seq,
-			    pattrib->seq_num))
+				     pattrib->seq_num))
 				preorder_ctrl->indicate_seq =
 				  (preorder_ctrl->indicate_seq + 1) % 4096;
 			/*indicate this recv_frame*/
@@ -555,7 +555,7 @@ int r8712_recv_indicatepkts_in_order(struct _adapter *padapter,
 }
 
 static int recv_indicatepkt_reorder(struct _adapter *padapter,
-			     union recv_frame *prframe)
+				    union recv_frame *prframe)
 {
 	unsigned long irql;
 	struct rx_pkt_attrib *pattrib = &prframe->u.hdr.attrib;
@@ -624,7 +624,7 @@ void r8712_reordering_ctrl_timeout_handler(void *pcontext)
 }
 
 static int r8712_process_recv_indicatepkts(struct _adapter *padapter,
-			      union recv_frame *prframe)
+					   union recv_frame *prframe)
 {
 	int retval = _SUCCESS;
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
-- 
2.7.4

[PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Cristiane Naves]

Fix alignment should match open parenthesis. Issue found by checkpatch.

Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
---
 drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
index af12c16..304d031 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
 		precvbuf->ref_cnt = 0;
 		precvbuf->adapter = padapter;
 		list_add_tail(&precvbuf->list,
-				 &(precvpriv->free_recv_buf_queue.queue));
+			      (&precvpriv->free_recv_buf_queue.queue));
 		precvbuf++;
 	}
 	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
 	tasklet_init(&precvpriv->recv_tasklet,
-	     (void(*)(unsigned long))recv_tasklet,
-	     (unsigned long)padapter);
+		     (void(*)(unsigned long))recv_tasklet,
+		     (unsigned long)padapter);
 	skb_queue_head_init(&precvpriv->rx_skb_queue);
 
 	skb_queue_head_init(&precvpriv->free_recv_skb_queue);
@@ -140,7 +140,7 @@ void r8712_free_recvframe(union recv_frame *precvframe,
 }
 
 static void update_recvframe_attrib_from_recvstat(struct rx_pkt_attrib *pattrib,
-					   struct recv_stat *prxstat)
+						  struct recv_stat *prxstat)
 {
 	u16 drvinfo_sz;
 
@@ -177,7 +177,7 @@ static void update_recvframe_attrib_from_recvstat(struct rx_pkt_attrib *pattrib,
 
 /*perform defrag*/
 static union recv_frame *recvframe_defrag(struct _adapter *adapter,
-				   struct  __queue *defrag_q)
+					  struct  __queue *defrag_q)
 {
 	struct list_head *plist, *phead;
 	u8 wlanhdr_offset;
@@ -379,26 +379,26 @@ static void amsdu_to_msdu(struct _adapter *padapter, union recv_frame *prframe)
 		/* convert hdr + possible LLC headers into Ethernet header */
 		eth_type = (sub_skb->data[6] << 8) | sub_skb->data[7];
 		if (sub_skb->len >= 8 &&
-		   ((!memcmp(sub_skb->data, rfc1042_header, SNAP_SIZE) &&
-		   eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
-		   !memcmp(sub_skb->data, bridge_tunnel_header, SNAP_SIZE))) {
+		    ((!memcmp(sub_skb->data, rfc1042_header, SNAP_SIZE) &&
+		      eth_type != ETH_P_AARP && eth_type != ETH_P_IPX) ||
+		     !memcmp(sub_skb->data, bridge_tunnel_header, SNAP_SIZE))) {
 			/* remove RFC1042 or Bridge-Tunnel encapsulation and
 			 * replace EtherType
 			 */
 			skb_pull(sub_skb, SNAP_SIZE);
 			memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->src,
-				ETH_ALEN);
+			       ETH_ALEN);
 			memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->dst,
-				ETH_ALEN);
+			       ETH_ALEN);
 		} else {
 			__be16 len;
 			/* Leave Ethernet header part of hdr and full payload */
 			len = htons(sub_skb->len);
 			memcpy(skb_push(sub_skb, 2), &len, 2);
 			memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->src,
-				ETH_ALEN);
+			       ETH_ALEN);
 			memcpy(skb_push(sub_skb, ETH_ALEN), pattrib->dst,
-				ETH_ALEN);
+			       ETH_ALEN);
 		}
 		/* Indicate the packets to upper layer */
 		if (sub_skb) {
@@ -472,7 +472,7 @@ static int check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl,
 }
 
 static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl,
-			      union recv_frame *prframe)
+				     union recv_frame *prframe)
 {
 	struct list_head *phead, *plist;
 	union recv_frame *pnextrframe;
@@ -499,8 +499,8 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl,
 }
 
 int r8712_recv_indicatepkts_in_order(struct _adapter *padapter,
-			       struct recv_reorder_ctrl *preorder_ctrl,
-			       int bforced)
+				     struct recv_reorder_ctrl *preorder_ctrl,
+				     int bforced)
 {
 	struct list_head *phead, *plist;
 	union recv_frame *prframe;
@@ -530,7 +530,7 @@ int r8712_recv_indicatepkts_in_order(struct _adapter *padapter,
 			plist = plist->next;
 			list_del_init(&(prframe->u.hdr.list));
 			if (SN_EQUAL(preorder_ctrl->indicate_seq,
-			    pattrib->seq_num))
+				     pattrib->seq_num))
 				preorder_ctrl->indicate_seq =
 				  (preorder_ctrl->indicate_seq + 1) % 4096;
 			/*indicate this recv_frame*/
@@ -555,7 +555,7 @@ int r8712_recv_indicatepkts_in_order(struct _adapter *padapter,
 }
 
 static int recv_indicatepkt_reorder(struct _adapter *padapter,
-			     union recv_frame *prframe)
+				    union recv_frame *prframe)
 {
 	unsigned long irql;
 	struct rx_pkt_attrib *pattrib = &prframe->u.hdr.attrib;
@@ -624,7 +624,7 @@ void r8712_reordering_ctrl_timeout_handler(void *pcontext)
 }
 
 static int r8712_process_recv_indicatepkts(struct _adapter *padapter,
-			      union recv_frame *prframe)
+					   union recv_frame *prframe)
 {
 	int retval = _SUCCESS;
 	struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH v3 2/2] staging: rtl8712: Remove lines before a close brace

[Cristiane Naves]

Fix Blank lines aren't necessary before a close brace '}'. Issue found
by checkpatch.

Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
---
 drivers/staging/rtl8712/rtl8712_recv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
index 304d031..1e3e49f 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -289,7 +289,6 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter,
 			r8712_free_recvframe(precv_frame, pfree_recv_queue);
 			prtnframe = NULL;
 		}
-
 	}
 	if ((ismfrag == 0) && (fragnum != 0)) {
 		/* the last fragment frame
@@ -438,7 +437,6 @@ void r8712_rxcmd_event_hdl(struct _adapter *padapter, void *prxcmdbuf)
 		r8712_event_handle(padapter, (__le32 *)poffset);
 		poffset += (cmd_len + 8);/*8 bytes alignment*/
 	} while (le32_to_cpu(voffset) & BIT(31));
-
 }
 
 static int check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl,
-- 
2.7.4

[PATCH v3 2/2] staging: rtl8712: Remove lines before a close brace

[Cristiane Naves]

Fix Blank lines aren't necessary before a close brace '}'. Issue found
by checkpatch.

Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
---
 drivers/staging/rtl8712/rtl8712_recv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
index 304d031..1e3e49f 100644
--- a/drivers/staging/rtl8712/rtl8712_recv.c
+++ b/drivers/staging/rtl8712/rtl8712_recv.c
@@ -289,7 +289,6 @@ union recv_frame *r8712_recvframe_chk_defrag(struct _adapter *padapter,
 			r8712_free_recvframe(precv_frame, pfree_recv_queue);
 			prtnframe = NULL;
 		}
-
 	}
 	if ((ismfrag == 0) && (fragnum != 0)) {
 		/* the last fragment frame
@@ -438,7 +437,6 @@ void r8712_rxcmd_event_hdl(struct _adapter *padapter, void *prxcmdbuf)
 		r8712_event_handle(padapter, (__le32 *)poffset);
 		poffset += (cmd_len + 8);/*8 bytes alignment*/
 	} while (le32_to_cpu(voffset) & BIT(31));
-
 }
 
 static int check_indicate_seq(struct recv_reorder_ctrl *preorder_ctrl,
-- 
2.7.4

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Dan Carpenter]

On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> Fix alignment should match open parenthesis. Issue found by checkpatch.
> 
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
>  1 file changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> index af12c16..304d031 100644
> --- a/drivers/staging/rtl8712/rtl8712_recv.c
> +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
>  		precvbuf->ref_cnt = 0;
>  		precvbuf->adapter = padapter;
>  		list_add_tail(&precvbuf->list,
> -				 &(precvpriv->free_recv_buf_queue.queue));
> +			      (&precvpriv->free_recv_buf_queue.queue));

You did this correctly in v2.

-				 &(precvpriv->free_recv_buf_queue.queue));
+			      &precvpriv->free_recv_buf_queue.queue);

>  		precvbuf++;
>  	}
>  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
>  	tasklet_init(&precvpriv->recv_tasklet,

regards,
dan carpenter

Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Dan Carpenter]

On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> Fix alignment should match open parenthesis. Issue found by checkpatch.
> 
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
>  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
>  1 file changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> index af12c16..304d031 100644
> --- a/drivers/staging/rtl8712/rtl8712_recv.c
> +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
>  		precvbuf->ref_cnt = 0;
>  		precvbuf->adapter = padapter;
>  		list_add_tail(&precvbuf->list,
> -				 &(precvpriv->free_recv_buf_queue.queue));
> +			      (&precvpriv->free_recv_buf_queue.queue));

You did this correctly in v2.

-				 &(precvpriv->free_recv_buf_queue.queue));
+			      &precvpriv->free_recv_buf_queue.queue);

>  		precvbuf++;
>  	}
>  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
>  	tasklet_init(&precvpriv->recv_tasklet,

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Cristiane Naves]

On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > 
> > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > ---
> >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> >  1 file changed, 18 insertions(+), 18 deletions(-)
> > 
> > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > index af12c16..304d031 100644
> > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> >  		precvbuf->ref_cnt = 0;
> >  		precvbuf->adapter = padapter;
> >  		list_add_tail(&precvbuf->list,
> > -				 &(precvpriv->free_recv_buf_queue.queue));
> > +			      (&precvpriv->free_recv_buf_queue.queue));
> 
> You did this correctly in v2.
> 
> -				 &(precvpriv->free_recv_buf_queue.queue));
> +			      &precvpriv->free_recv_buf_queue.queue);
> 
> >  		precvbuf++;
> >  	}
> >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> >  	tasklet_init(&precvpriv->recv_tasklet,
> 
> regards,
> dan carpenter
>
I wondered if it was better to use parentheses or not. Is it necessary
to send a new v5 version containing this change or it's possible to get it from
v2?
Thanks for your help!

Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Dan Carpenter]

On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > 
> > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > ---
> > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > 
> > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > index af12c16..304d031 100644
> > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > >  		precvbuf->ref_cnt = 0;
> > >  		precvbuf->adapter = padapter;
> > >  		list_add_tail(&precvbuf->list,
> > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > 
> > You did this correctly in v2.
> > 
> > -				 &(precvpriv->free_recv_buf_queue.queue));
> > +			      &precvpriv->free_recv_buf_queue.queue);
> > 
> > >  		precvbuf++;
> > >  	}
> > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > >  	tasklet_init(&precvpriv->recv_tasklet,
> > 
> > regards,
> > dan carpenter
> >
> I wondered if it was better to use parentheses or not. Is it necessary
> to send a new v5 version containing this change or it's possible to get it from
> v2?

Greg said that patch 2/2 of v4 didn't apply.  To me that suggests that
maybe he applied patch 1/2 and sent you an email?  If not then redo it.

If you don't change the parenthese Greg will apply it.  If you do then
maybe he will and maybe he won't.  The rules say don't do that but we
let people bend the rules slightly.  But why add that element of doubt?

I have a script which removes white space changes so if you change the
parentheses I have to check the patch by hand so that's annoying.  But I
might not comment on it when I'm reviewing the patch.

My advice is to remove the parenthese in a separate patch.

It's not possible to get the patch from v2.  Once a patch is gone then
it's gone forever.

regards,
dan carpenter

Re: [Outreachy kernel] Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Greg KH]

On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > 
> > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > ---
> > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > 
> > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > index af12c16..304d031 100644
> > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > >  		precvbuf->ref_cnt = 0;
> > >  		precvbuf->adapter = padapter;
> > >  		list_add_tail(&precvbuf->list,
> > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > 
> > You did this correctly in v2.
> > 
> > -				 &(precvpriv->free_recv_buf_queue.queue));
> > +			      &precvpriv->free_recv_buf_queue.queue);
> > 
> > >  		precvbuf++;
> > >  	}
> > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > >  	tasklet_init(&precvpriv->recv_tasklet,
> > 
> > regards,
> > dan carpenter
> >
> I wondered if it was better to use parentheses or not. Is it necessary
> to send a new v5 version containing this change or it's possible to get it from
> v2?

Send a follow-on patch to fix this up please as your other one is in my
tree now I think.

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Greg KH]

On Tue, Oct 29, 2019 at 09:05:54AM +0100, Greg KH wrote:
> On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> > On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > > 
> > > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > > ---
> > > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > > 
> > > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > index af12c16..304d031 100644
> > > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > > >  		precvbuf->ref_cnt = 0;
> > > >  		precvbuf->adapter = padapter;
> > > >  		list_add_tail(&precvbuf->list,
> > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > > 
> > > You did this correctly in v2.
> > > 
> > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > +			      &precvpriv->free_recv_buf_queue.queue);
> > > 
> > > >  		precvbuf++;
> > > >  	}
> > > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > > >  	tasklet_init(&precvpriv->recv_tasklet,
> > > 
> > > regards,
> > > dan carpenter
> > >
> > I wondered if it was better to use parentheses or not. Is it necessary
> > to send a new v5 version containing this change or it's possible to get it from
> > v2?
> 
> Send a follow-on patch to fix this up please as your other one is in my
> tree now I think.

Or maybe it isn't in my tree, I have no idea, I can't remember.  YOu
know if it is applied or not as you will get an email when it happens.

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Cristiane Naves]

On Tue, Oct 29, 2019 at 09:15:01AM +0100, Greg KH wrote:
> On Tue, Oct 29, 2019 at 09:05:54AM +0100, Greg KH wrote:
> > On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> > > On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > > > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > > > 
> > > > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > > > ---
> > > > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > > > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > > > 
> > > > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > index af12c16..304d031 100644
> > > > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > > > >  		precvbuf->ref_cnt = 0;
> > > > >  		precvbuf->adapter = padapter;
> > > > >  		list_add_tail(&precvbuf->list,
> > > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > > > 
> > > > You did this correctly in v2.
> > > > 
> > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > +			      &precvpriv->free_recv_buf_queue.queue);
> > > > 
> > > > >  		precvbuf++;
> > > > >  	}
> > > > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > > > >  	tasklet_init(&precvpriv->recv_tasklet,
> > > > 
> > > > regards,
> > > > dan carpenter
> > > >
> > > I wondered if it was better to use parentheses or not. Is it necessary
> > > to send a new v5 version containing this change or it's possible to get it from
> > > v2?
> > 
> > Send a follow-on patch to fix this up please as your other one is in my
> > tree now I think.
> 
> Or maybe it isn't in my tree, I have no idea, I can't remember.  YOu
> know if it is applied or not as you will get an email when it happens.
> 
> thanks,
> 
> greg k-h

I received an email with the subject patch "staging: rtl8712: Remove
lines before a close brace" added to staging-next on October 27th. Is
this the confirmation email when a patch is accepted or is there any
other email?

thanks,

Cristiane Naves

Re: [Outreachy kernel] Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Julia Lawall]

On Tue, 29 Oct 2019, Cristiane Naves wrote:

> On Tue, Oct 29, 2019 at 09:15:01AM +0100, Greg KH wrote:
> > On Tue, Oct 29, 2019 at 09:05:54AM +0100, Greg KH wrote:
> > > On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> > > > On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > > > > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > > > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > > > >
> > > > > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > > > > ---
> > > > > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > > > > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > > > >
> > > > > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > index af12c16..304d031 100644
> > > > > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > > > > >  		precvbuf->ref_cnt = 0;
> > > > > >  		precvbuf->adapter = padapter;
> > > > > >  		list_add_tail(&precvbuf->list,
> > > > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > > > >
> > > > > You did this correctly in v2.
> > > > >
> > > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > > +			      &precvpriv->free_recv_buf_queue.queue);
> > > > >
> > > > > >  		precvbuf++;
> > > > > >  	}
> > > > > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > > > > >  	tasklet_init(&precvpriv->recv_tasklet,
> > > > >
> > > > > regards,
> > > > > dan carpenter
> > > > >
> > > > I wondered if it was better to use parentheses or not. Is it necessary
> > > > to send a new v5 version containing this change or it's possible to get it from
> > > > v2?
> > >
> > > Send a follow-on patch to fix this up please as your other one is in my
> > > tree now I think.
> >
> > Or maybe it isn't in my tree, I have no idea, I can't remember.  YOu
> > know if it is applied or not as you will get an email when it happens.
> >
> > thanks,
> >
> > greg k-h
>
> I received an email with the subject patch "staging: rtl8712: Remove
> lines before a close brace" added to staging-next on October 27th. Is
> this the confirmation email when a patch is accepted or is there any
> other email?

No, that means it's good.

julia

>
> thanks,
>
> Cristiane Naves
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191029202157.GA2188%40cristiane-Inspiron-5420.
>

Re: [Outreachy kernel] Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Cristiane Naves]

On Tue, Oct 29, 2019 at 09:59:31PM +0100, Julia Lawall wrote:
> 
> 
> On Tue, 29 Oct 2019, Cristiane Naves wrote:
> 
> > On Tue, Oct 29, 2019 at 09:15:01AM +0100, Greg KH wrote:
> > > On Tue, Oct 29, 2019 at 09:05:54AM +0100, Greg KH wrote:
> > > > On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> > > > > On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > > > > > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > > > > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > > > > >
> > > > > > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > > > > > ---
> > > > > > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > > > > > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > > > > >
> > > > > > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > > index af12c16..304d031 100644
> > > > > > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > > > > > >  		precvbuf->ref_cnt = 0;
> > > > > > >  		precvbuf->adapter = padapter;
> > > > > > >  		list_add_tail(&precvbuf->list,
> > > > > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > > > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > > > > >
> > > > > > You did this correctly in v2.
> > > > > >
> > > > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > > > +			      &precvpriv->free_recv_buf_queue.queue);
> > > > > >
> > > > > > >  		precvbuf++;
> > > > > > >  	}
> > > > > > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > > > > > >  	tasklet_init(&precvpriv->recv_tasklet,
> > > > > >
> > > > > > regards,
> > > > > > dan carpenter
> > > > > >
> > > > > I wondered if it was better to use parentheses or not. Is it necessary
> > > > > to send a new v5 version containing this change or it's possible to get it from
> > > > > v2?
> > > >
> > > > Send a follow-on patch to fix this up please as your other one is in my
> > > > tree now I think.
> > >
> > > Or maybe it isn't in my tree, I have no idea, I can't remember.  YOu
> > > know if it is applied or not as you will get an email when it happens.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > I received an email with the subject patch "staging: rtl8712: Remove
> > lines before a close brace" added to staging-next on October 27th. Is
> > this the confirmation email when a patch is accepted or is there any
> > other email?
> 
> No, that means it's good.
> 
> julia
>
So when do I know if a patch has been accepted or not? Is When An
Acked-By Is Placed?
> >
> > thanks,
> >
> > Cristiane Naves
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191029202157.GA2188%40cristiane-Inspiron-5420.
> >

Re: [Outreachy kernel] Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Dan Carpenter]

On Tue, Oct 29, 2019 at 05:21:57PM -0300, Cristiane Naves wrote:
> On Tue, Oct 29, 2019 at 09:15:01AM +0100, Greg KH wrote:
> > On Tue, Oct 29, 2019 at 09:05:54AM +0100, Greg KH wrote:
> > > On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> > > > On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > > > > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > > > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > > > > 
> > > > > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > > > > ---
> > > > > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > > > > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > > > > 
> > > > > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > index af12c16..304d031 100644
> > > > > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > > > > >  		precvbuf->ref_cnt = 0;
> > > > > >  		precvbuf->adapter = padapter;
> > > > > >  		list_add_tail(&precvbuf->list,
> > > > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > > > > 
> > > > > You did this correctly in v2.
> > > > > 
> > > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > > +			      &precvpriv->free_recv_buf_queue.queue);
> > > > > 
> > > > > >  		precvbuf++;
> > > > > >  	}
> > > > > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > > > > >  	tasklet_init(&precvpriv->recv_tasklet,
> > > > > 
> > > > > regards,
> > > > > dan carpenter
> > > > >
> > > > I wondered if it was better to use parentheses or not. Is it necessary
> > > > to send a new v5 version containing this change or it's possible to get it from
> > > > v2?
> > > 
> > > Send a follow-on patch to fix this up please as your other one is in my
> > > tree now I think.
> > 
> > Or maybe it isn't in my tree, I have no idea, I can't remember.  YOu
> > know if it is applied or not as you will get an email when it happens.
> > 
> > thanks,
> > 
> > greg k-h
> 
> I received an email with the subject patch "staging: rtl8712: Remove
> lines before a close brace" added to staging-next on October 27th. Is
> this the confirmation email when a patch is accepted or is there any
> other email?

Yep.  That means the patch is in Greg's tree.  It won't hit Linus's tree
until the next merge window.

regards,
dan carpenter

Re: [Outreachy kernel] Re: [PATCH v3 1/2] staging: rtl8712: Fix Alignment of open parenthesis

[Julia Lawall]

On Tue, 29 Oct 2019, Cristiane Naves wrote:

> On Tue, Oct 29, 2019 at 09:59:31PM +0100, Julia Lawall wrote:
> >
> >
> > On Tue, 29 Oct 2019, Cristiane Naves wrote:
> >
> > > On Tue, Oct 29, 2019 at 09:15:01AM +0100, Greg KH wrote:
> > > > On Tue, Oct 29, 2019 at 09:05:54AM +0100, Greg KH wrote:
> > > > > On Mon, Oct 28, 2019 at 06:21:37PM -0300, Cristiane Naves wrote:
> > > > > > On Mon, Oct 28, 2019 at 10:02:59PM +0300, Dan Carpenter wrote:
> > > > > > > On Mon, Oct 28, 2019 at 12:15:52PM -0300, Cristiane Naves wrote:
> > > > > > > > Fix alignment should match open parenthesis. Issue found by checkpatch.
> > > > > > > >
> > > > > > > > Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> > > > > > > > ---
> > > > > > > >  drivers/staging/rtl8712/rtl8712_recv.c | 36 +++++++++++++++++-----------------
> > > > > > > >  1 file changed, 18 insertions(+), 18 deletions(-)
> > > > > > > >
> > > > > > > > diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > > > index af12c16..304d031 100644
> > > > > > > > --- a/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > > > +++ b/drivers/staging/rtl8712/rtl8712_recv.c
> > > > > > > > @@ -61,13 +61,13 @@ void r8712_init_recv_priv(struct recv_priv *precvpriv,
> > > > > > > >  		precvbuf->ref_cnt = 0;
> > > > > > > >  		precvbuf->adapter = padapter;
> > > > > > > >  		list_add_tail(&precvbuf->list,
> > > > > > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > > > > > +			      (&precvpriv->free_recv_buf_queue.queue));
> > > > > > >
> > > > > > > You did this correctly in v2.
> > > > > > >
> > > > > > > -				 &(precvpriv->free_recv_buf_queue.queue));
> > > > > > > +			      &precvpriv->free_recv_buf_queue.queue);
> > > > > > >
> > > > > > > >  		precvbuf++;
> > > > > > > >  	}
> > > > > > > >  	precvpriv->free_recv_buf_queue_cnt = NR_RECVBUFF;
> > > > > > > >  	tasklet_init(&precvpriv->recv_tasklet,
> > > > > > >
> > > > > > > regards,
> > > > > > > dan carpenter
> > > > > > >
> > > > > > I wondered if it was better to use parentheses or not. Is it necessary
> > > > > > to send a new v5 version containing this change or it's possible to get it from
> > > > > > v2?
> > > > >
> > > > > Send a follow-on patch to fix this up please as your other one is in my
> > > > > tree now I think.
> > > >
> > > > Or maybe it isn't in my tree, I have no idea, I can't remember.  YOu
> > > > know if it is applied or not as you will get an email when it happens.
> > > >
> > > > thanks,
> > > >
> > > > greg k-h
> > >
> > > I received an email with the subject patch "staging: rtl8712: Remove
> > > lines before a close brace" added to staging-next on October 27th. Is
> > > this the confirmation email when a patch is accepted or is there any
> > > other email?
> >
> > No, that means it's good.
> >
> > julia
> >
> So when do I know if a patch has been accepted or not? Is When An
> Acked-By Is Placed?

No, when you get the mail from Greg.

julia

> > >
> > > thanks,
> > >
> > > Cristiane Naves
> > >
> > > --
> > > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191029202157.GA2188%40cristiane-Inspiron-5420.
> > >
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191029210642.GA14913%40cristiane-Inspiron-5420.
>