All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] lib/color_encoding: Fix up support for XYUV format.
@ 2019-10-28 21:24 ` Bob Paauwe
  0 siblings, 0 replies; 6+ messages in thread
From: Bob Paauwe @ 2019-10-28 21:24 UTC (permalink / raw)
  To: intel-gfx

Add XYUV8888 to the list of DRM Formats to test.

Also fix the byte order for the format.

Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
---
 lib/igt_color_encoding.c | 1 +
 lib/igt_fb.c             | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/igt_color_encoding.c b/lib/igt_color_encoding.c
index 7de6d5ab..a7bd2b22 100644
--- a/lib/igt_color_encoding.c
+++ b/lib/igt_color_encoding.c
@@ -160,6 +160,7 @@ static const struct color_encoding_format {
 	{ DRM_FORMAT_XVYU2101010, 1023.f, 64.f, 940.f, 64.f, 512.f, 960.f },
 	{ DRM_FORMAT_XVYU12_16161616, 65520.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
 	{ DRM_FORMAT_XVYU16161616, 65535.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
+	{ DRM_FORMAT_XYUV8888, 255.f, 16.f, 235.f, 16.f, 128.f, 240.f },
 };
 
 static const struct color_encoding_format *lookup_fourcc(uint32_t fourcc)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 4adca967..fe5fa74b 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2423,9 +2423,9 @@ static void get_yuv_parameters(struct igt_fb *fb, struct yuv_parameters *params)
 		break;
 
 	case DRM_FORMAT_XYUV8888:
-		params->y_offset = fb->offsets[0] + 1;
-		params->u_offset = fb->offsets[0] + 2;
-		params->v_offset = fb->offsets[0] + 3;
+		params->y_offset = fb->offsets[0] + 2;
+		params->u_offset = fb->offsets[0] + 1;
+		params->v_offset = fb->offsets[0] + 0;
 		break;
 	}
 }
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Intel-gfx] [PATCH] lib/color_encoding: Fix up support for XYUV format.
@ 2019-10-28 21:24 ` Bob Paauwe
  0 siblings, 0 replies; 6+ messages in thread
From: Bob Paauwe @ 2019-10-28 21:24 UTC (permalink / raw)
  To: intel-gfx

Add XYUV8888 to the list of DRM Formats to test.

Also fix the byte order for the format.

Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
---
 lib/igt_color_encoding.c | 1 +
 lib/igt_fb.c             | 6 +++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/lib/igt_color_encoding.c b/lib/igt_color_encoding.c
index 7de6d5ab..a7bd2b22 100644
--- a/lib/igt_color_encoding.c
+++ b/lib/igt_color_encoding.c
@@ -160,6 +160,7 @@ static const struct color_encoding_format {
 	{ DRM_FORMAT_XVYU2101010, 1023.f, 64.f, 940.f, 64.f, 512.f, 960.f },
 	{ DRM_FORMAT_XVYU12_16161616, 65520.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
 	{ DRM_FORMAT_XVYU16161616, 65535.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
+	{ DRM_FORMAT_XYUV8888, 255.f, 16.f, 235.f, 16.f, 128.f, 240.f },
 };
 
 static const struct color_encoding_format *lookup_fourcc(uint32_t fourcc)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 4adca967..fe5fa74b 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -2423,9 +2423,9 @@ static void get_yuv_parameters(struct igt_fb *fb, struct yuv_parameters *params)
 		break;
 
 	case DRM_FORMAT_XYUV8888:
-		params->y_offset = fb->offsets[0] + 1;
-		params->u_offset = fb->offsets[0] + 2;
-		params->v_offset = fb->offsets[0] + 3;
+		params->y_offset = fb->offsets[0] + 2;
+		params->u_offset = fb->offsets[0] + 1;
+		params->v_offset = fb->offsets[0] + 0;
 		break;
 	}
 }
-- 
2.21.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* ✗ Fi.CI.BUILD: failure for lib/color_encoding: Fix up support for XYUV format.
@ 2019-10-29  0:25   ` Patchwork
  0 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-29  0:25 UTC (permalink / raw)
  To: Bob Paauwe; +Cc: intel-gfx

== Series Details ==

Series: lib/color_encoding: Fix up support for XYUV format.
URL   : https://patchwork.freedesktop.org/series/68684/
State : failure

== Summary ==

Applying: lib/color_encoding: Fix up support for XYUV format.
error: sha1 information is lacking or useless (lib/igt_color_encoding.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 lib/color_encoding: Fix up support for XYUV format.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Intel-gfx] ✗ Fi.CI.BUILD: failure for lib/color_encoding: Fix up support for XYUV format.
@ 2019-10-29  0:25   ` Patchwork
  0 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-10-29  0:25 UTC (permalink / raw)
  To: Bob Paauwe; +Cc: intel-gfx

== Series Details ==

Series: lib/color_encoding: Fix up support for XYUV format.
URL   : https://patchwork.freedesktop.org/series/68684/
State : failure

== Summary ==

Applying: lib/color_encoding: Fix up support for XYUV format.
error: sha1 information is lacking or useless (lib/igt_color_encoding.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Patch failed at 0001 lib/color_encoding: Fix up support for XYUV format.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] lib/color_encoding: Fix up support for XYUV format.
@ 2019-10-30 19:20   ` Matt Roper
  0 siblings, 0 replies; 6+ messages in thread
From: Matt Roper @ 2019-10-30 19:20 UTC (permalink / raw)
  To: Bob Paauwe; +Cc: intel-gfx

On Mon, Oct 28, 2019 at 02:24:59PM -0700, Bob Paauwe wrote:
> Add XYUV8888 to the list of DRM Formats to test.
> 
> Also fix the byte order for the format.
> 
> Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>

Looks like CI got confused by this.  You'll want to

Cc: igt-dev@lists.freedesktop.org

and also set your subjectPrefix to "PATCH i-g-t" so that CI recognizes
it as an igt patch and not a kernel patch.


Matt

> ---
>  lib/igt_color_encoding.c | 1 +
>  lib/igt_fb.c             | 6 +++---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_color_encoding.c b/lib/igt_color_encoding.c
> index 7de6d5ab..a7bd2b22 100644
> --- a/lib/igt_color_encoding.c
> +++ b/lib/igt_color_encoding.c
> @@ -160,6 +160,7 @@ static const struct color_encoding_format {
>  	{ DRM_FORMAT_XVYU2101010, 1023.f, 64.f, 940.f, 64.f, 512.f, 960.f },
>  	{ DRM_FORMAT_XVYU12_16161616, 65520.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
>  	{ DRM_FORMAT_XVYU16161616, 65535.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
> +	{ DRM_FORMAT_XYUV8888, 255.f, 16.f, 235.f, 16.f, 128.f, 240.f },
>  };
>  
>  static const struct color_encoding_format *lookup_fourcc(uint32_t fourcc)
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 4adca967..fe5fa74b 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -2423,9 +2423,9 @@ static void get_yuv_parameters(struct igt_fb *fb, struct yuv_parameters *params)
>  		break;
>  
>  	case DRM_FORMAT_XYUV8888:
> -		params->y_offset = fb->offsets[0] + 1;
> -		params->u_offset = fb->offsets[0] + 2;
> -		params->v_offset = fb->offsets[0] + 3;
> +		params->y_offset = fb->offsets[0] + 2;
> +		params->u_offset = fb->offsets[0] + 1;
> +		params->v_offset = fb->offsets[0] + 0;
>  		break;
>  	}
>  }
> -- 
> 2.21.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Intel-gfx] [PATCH] lib/color_encoding: Fix up support for XYUV format.
@ 2019-10-30 19:20   ` Matt Roper
  0 siblings, 0 replies; 6+ messages in thread
From: Matt Roper @ 2019-10-30 19:20 UTC (permalink / raw)
  To: Bob Paauwe; +Cc: intel-gfx

On Mon, Oct 28, 2019 at 02:24:59PM -0700, Bob Paauwe wrote:
> Add XYUV8888 to the list of DRM Formats to test.
> 
> Also fix the byte order for the format.
> 
> Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>

Looks like CI got confused by this.  You'll want to

Cc: igt-dev@lists.freedesktop.org

and also set your subjectPrefix to "PATCH i-g-t" so that CI recognizes
it as an igt patch and not a kernel patch.


Matt

> ---
>  lib/igt_color_encoding.c | 1 +
>  lib/igt_fb.c             | 6 +++---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/lib/igt_color_encoding.c b/lib/igt_color_encoding.c
> index 7de6d5ab..a7bd2b22 100644
> --- a/lib/igt_color_encoding.c
> +++ b/lib/igt_color_encoding.c
> @@ -160,6 +160,7 @@ static const struct color_encoding_format {
>  	{ DRM_FORMAT_XVYU2101010, 1023.f, 64.f, 940.f, 64.f, 512.f, 960.f },
>  	{ DRM_FORMAT_XVYU12_16161616, 65520.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
>  	{ DRM_FORMAT_XVYU16161616, 65535.f, 4096.f, 60160.f, 4096.f, 32768.f, 61440.f },
> +	{ DRM_FORMAT_XYUV8888, 255.f, 16.f, 235.f, 16.f, 128.f, 240.f },
>  };
>  
>  static const struct color_encoding_format *lookup_fourcc(uint32_t fourcc)
> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
> index 4adca967..fe5fa74b 100644
> --- a/lib/igt_fb.c
> +++ b/lib/igt_fb.c
> @@ -2423,9 +2423,9 @@ static void get_yuv_parameters(struct igt_fb *fb, struct yuv_parameters *params)
>  		break;
>  
>  	case DRM_FORMAT_XYUV8888:
> -		params->y_offset = fb->offsets[0] + 1;
> -		params->u_offset = fb->offsets[0] + 2;
> -		params->v_offset = fb->offsets[0] + 3;
> +		params->y_offset = fb->offsets[0] + 2;
> +		params->u_offset = fb->offsets[0] + 1;
> +		params->v_offset = fb->offsets[0] + 0;
>  		break;
>  	}
>  }
> -- 
> 2.21.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-10-30 19:19 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 21:24 [PATCH] lib/color_encoding: Fix up support for XYUV format Bob Paauwe
2019-10-28 21:24 ` [Intel-gfx] " Bob Paauwe
2019-10-29  0:25 ` ✗ Fi.CI.BUILD: failure for " Patchwork
2019-10-29  0:25   ` [Intel-gfx] " Patchwork
2019-10-30 19:20 ` [PATCH] " Matt Roper
2019-10-30 19:20   ` [Intel-gfx] " Matt Roper

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.