All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH -next] net: dsa: LAN9303: select REGMAP when LAN9303 enable
@ 2019-10-26  2:21 ` Mao Wenan
  0 siblings, 0 replies; 4+ messages in thread
From: Mao Wenan @ 2019-10-26  2:21 UTC (permalink / raw)
  To: andrew, vivien.didelot, f.fainelli, davem, jbe, robh
  Cc: netdev, linux-kernel, kernel-janitors, Mao Wenan

When NET_DSA_SMSC_LAN9303=y and NET_DSA_SMSC_LAN9303_MDIO=y,
below errors can be seen:
drivers/net/dsa/lan9303_mdio.c:87:23: error: REGMAP_ENDIAN_LITTLE
undeclared here (not in a function)
  .reg_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/net/dsa/lan9303_mdio.c:93:3: error: const struct regmap_config
has no member named reg_read
  .reg_read = lan9303_mdio_read,

It should select REGMAP in config NET_DSA_SMSC_LAN9303.

Fixes: dc7005831523 ("net: dsa: LAN9303: add MDIO managed mode support")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 drivers/net/dsa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index f6232ce..685e12b 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -77,6 +77,7 @@ config NET_DSA_REALTEK_SMI
 config NET_DSA_SMSC_LAN9303
 	tristate
 	select NET_DSA_TAG_LAN9303
+	select REGMAP
 	---help---
 	  This enables support for the SMSC/Microchip LAN9303 3 port ethernet
 	  switch chips.
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH -next] net: dsa: LAN9303: select REGMAP when LAN9303 enable
@ 2019-10-26  2:21 ` Mao Wenan
  0 siblings, 0 replies; 4+ messages in thread
From: Mao Wenan @ 2019-10-26  2:21 UTC (permalink / raw)
  To: andrew, vivien.didelot, f.fainelli, davem, jbe, robh
  Cc: netdev, linux-kernel, kernel-janitors, Mao Wenan

When NET_DSA_SMSC_LAN9303=y and NET_DSA_SMSC_LAN9303_MDIO=y,
below errors can be seen:
drivers/net/dsa/lan9303_mdio.c:87:23: error: REGMAP_ENDIAN_LITTLE
undeclared here (not in a function)
  .reg_format_endian = REGMAP_ENDIAN_LITTLE,
drivers/net/dsa/lan9303_mdio.c:93:3: error: const struct regmap_config
has no member named reg_read
  .reg_read = lan9303_mdio_read,

It should select REGMAP in config NET_DSA_SMSC_LAN9303.

Fixes: dc7005831523 ("net: dsa: LAN9303: add MDIO managed mode support")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
---
 drivers/net/dsa/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/dsa/Kconfig b/drivers/net/dsa/Kconfig
index f6232ce..685e12b 100644
--- a/drivers/net/dsa/Kconfig
+++ b/drivers/net/dsa/Kconfig
@@ -77,6 +77,7 @@ config NET_DSA_REALTEK_SMI
 config NET_DSA_SMSC_LAN9303
 	tristate
 	select NET_DSA_TAG_LAN9303
+	select REGMAP
 	---help---
 	  This enables support for the SMSC/Microchip LAN9303 3 port ethernet
 	  switch chips.
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] net: dsa: LAN9303: select REGMAP when LAN9303 enable
  2019-10-26  2:21 ` Mao Wenan
@ 2019-10-29 23:18   ` David Miller
  -1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-10-29 23:18 UTC (permalink / raw)
  To: maowenan
  Cc: andrew, vivien.didelot, f.fainelli, jbe, robh, netdev,
	linux-kernel, kernel-janitors

From: Mao Wenan <maowenan@huawei.com>
Date: Sat, 26 Oct 2019 10:21:39 +0800

> When NET_DSA_SMSC_LAN9303=y and NET_DSA_SMSC_LAN9303_MDIO=y,
> below errors can be seen:
> drivers/net/dsa/lan9303_mdio.c:87:23: error: REGMAP_ENDIAN_LITTLE
> undeclared here (not in a function)
>   .reg_format_endian = REGMAP_ENDIAN_LITTLE,
> drivers/net/dsa/lan9303_mdio.c:93:3: error: const struct regmap_config
> has no member named reg_read
>   .reg_read = lan9303_mdio_read,
> 
> It should select REGMAP in config NET_DSA_SMSC_LAN9303.
> 
> Fixes: dc7005831523 ("net: dsa: LAN9303: add MDIO managed mode support")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH -next] net: dsa: LAN9303: select REGMAP when LAN9303 enable
@ 2019-10-29 23:18   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-10-29 23:18 UTC (permalink / raw)
  To: maowenan
  Cc: andrew, vivien.didelot, f.fainelli, jbe, robh, netdev,
	linux-kernel, kernel-janitors

From: Mao Wenan <maowenan@huawei.com>
Date: Sat, 26 Oct 2019 10:21:39 +0800

> When NET_DSA_SMSC_LAN9303=y and NET_DSA_SMSC_LAN9303_MDIO=y,
> below errors can be seen:
> drivers/net/dsa/lan9303_mdio.c:87:23: error: REGMAP_ENDIAN_LITTLE
> undeclared here (not in a function)
>   .reg_format_endian = REGMAP_ENDIAN_LITTLE,
> drivers/net/dsa/lan9303_mdio.c:93:3: error: const struct regmap_config
> has no member named reg_read
>   .reg_read = lan9303_mdio_read,
> 
> It should select REGMAP in config NET_DSA_SMSC_LAN9303.
> 
> Fixes: dc7005831523 ("net: dsa: LAN9303: add MDIO managed mode support")
> Signed-off-by: Mao Wenan <maowenan@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-10-29 23:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-26  2:21 [PATCH -next] net: dsa: LAN9303: select REGMAP when LAN9303 enable Mao Wenan
2019-10-26  2:21 ` Mao Wenan
2019-10-29 23:18 ` David Miller
2019-10-29 23:18   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.