* [PATCH net-next 1/1] net/smc: remove unneeded include for smc.h
@ 2019-10-29 11:43 Ursula Braun
2019-10-30 1:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ursula Braun @ 2019-10-29 11:43 UTC (permalink / raw)
To: davem
Cc: netdev, linux-s390, gor, heiko.carstens, raspl, kgraul, ubraun,
jakub.kicinski
The only smc-related reference in net/sock.h is struct smc_hashinfo.
But just its address is refered to. Thus there is no need for the
include of net/smc.h. Remove it.
Suggested-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
---
include/net/sock.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/net/sock.h b/include/net/sock.h
index 380312cc67a9..09c26a5ecbff 100644
--- a/include/net/sock.h
+++ b/include/net/sock.h
@@ -66,7 +66,6 @@
#include <net/checksum.h>
#include <net/tcp_states.h>
#include <linux/net_tstamp.h>
-#include <net/smc.h>
#include <net/l3mdev.h>
/*
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next 1/1] net/smc: remove unneeded include for smc.h
2019-10-29 11:43 [PATCH net-next 1/1] net/smc: remove unneeded include for smc.h Ursula Braun
@ 2019-10-30 1:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-10-30 1:11 UTC (permalink / raw)
To: ubraun
Cc: netdev, linux-s390, gor, heiko.carstens, raspl, kgraul, jakub.kicinski
From: Ursula Braun <ubraun@linux.ibm.com>
Date: Tue, 29 Oct 2019 12:43:46 +0100
> The only smc-related reference in net/sock.h is struct smc_hashinfo.
> But just its address is refered to. Thus there is no need for the
> include of net/smc.h. Remove it.
>
> Suggested-by: Jakub Kicinski <jakub.kicinski@netronome.com>
> Reviewed by: Karsten Graul <kgraul@linux.ibm.com>
> Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-30 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 11:43 [PATCH net-next 1/1] net/smc: remove unneeded include for smc.h Ursula Braun
2019-10-30 1:11 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.