* [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
@ 2019-10-29 7:43 ` jianzh
0 siblings, 0 replies; 6+ messages in thread
From: jianzh-5C7GfCeVMHo @ 2019-10-29 7:43 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Deng, Emily, Zhao, Jiange, Liu, Monk, Chang, HaiJun
From: Jiange Zhao <Jiange.Zhao@amd.com>
In the old way, when doing IH hw_init, PSP, nv_common
and GMC hw.status would be reset to false, even though
their hw_init have been done. In the next step, fw_loading,
PSP would do hw_init again.
In the new way, only reset hw.status to false for the target
IP in the list. In this way, PSP will only do hw_init once.
Signed-off-by: Jiange Zhao <Jiange.Zhao@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4eee40b9d0b0..ad6d2452fed9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2352,11 +2352,11 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
for (j = 0; j < adev->num_ip_blocks; j++) {
block = &adev->ip_blocks[j];
- block->status.hw = false;
if (block->version->type != ip_order[i] ||
!block->status.valid)
continue;
+ block->status.hw = false;
r = block->version->funcs->hw_init(adev);
DRM_INFO("RE-INIT-early: %s %s\n", block->version->funcs->name, r?"failed":"succeeded");
if (r)
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
@ 2019-10-29 7:43 ` jianzh
0 siblings, 0 replies; 6+ messages in thread
From: jianzh @ 2019-10-29 7:43 UTC (permalink / raw)
To: amd-gfx; +Cc: Deng, Emily, Zhao, Jiange, Liu, Monk, Chang, HaiJun
From: Jiange Zhao <Jiange.Zhao@amd.com>
In the old way, when doing IH hw_init, PSP, nv_common
and GMC hw.status would be reset to false, even though
their hw_init have been done. In the next step, fw_loading,
PSP would do hw_init again.
In the new way, only reset hw.status to false for the target
IP in the list. In this way, PSP will only do hw_init once.
Signed-off-by: Jiange Zhao <Jiange.Zhao@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4eee40b9d0b0..ad6d2452fed9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2352,11 +2352,11 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
for (j = 0; j < adev->num_ip_blocks; j++) {
block = &adev->ip_blocks[j];
- block->status.hw = false;
if (block->version->type != ip_order[i] ||
!block->status.valid)
continue;
+ block->status.hw = false;
r = block->version->funcs->hw_init(adev);
DRM_INFO("RE-INIT-early: %s %s\n", block->version->funcs->name, r?"failed":"succeeded");
if (r)
--
2.20.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
@ 2019-10-30 2:26 ` Zhao, Jiange
0 siblings, 0 replies; 6+ messages in thread
From: Zhao, Jiange @ 2019-10-30 2:26 UTC (permalink / raw)
To: Zhao, Jiange, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Deng, Emily, Liu, Monk, Chang, HaiJun
[-- Attachment #1.1: Type: text/plain, Size: 2270 bytes --]
Ping.
@Deng, Emily<mailto:Emily.Deng-5C7GfCeVMHo@public.gmane.org> @Liu, Monk<mailto:Monk.Liu-5C7GfCeVMHo@public.gmane.org>, can you help review this patch?
Thanks!
Jiange
________________________________
From: Zhao, Jiange <jianzh-5C7GfCeVMHo@public.gmane.org>
Sent: Tuesday, October 29, 2019 3:43 PM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Cc: Deng, Emily <Emily.Deng-5C7GfCeVMHo@public.gmane.org>; Liu, Monk <Monk.Liu-5C7GfCeVMHo@public.gmane.org>; Chang, HaiJun <HaiJun.Chang-5C7GfCeVMHo@public.gmane.org>; Zhao, Jiange <Jiange.Zhao-5C7GfCeVMHo@public.gmane.org>
Subject: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
From: Jiange Zhao <Jiange.Zhao-5C7GfCeVMHo@public.gmane.org>
In the old way, when doing IH hw_init, PSP, nv_common
and GMC hw.status would be reset to false, even though
their hw_init have been done. In the next step, fw_loading,
PSP would do hw_init again.
In the new way, only reset hw.status to false for the target
IP in the list. In this way, PSP will only do hw_init once.
Signed-off-by: Jiange Zhao <Jiange.Zhao-5C7GfCeVMHo@public.gmane.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4eee40b9d0b0..ad6d2452fed9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2352,11 +2352,11 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
for (j = 0; j < adev->num_ip_blocks; j++) {
block = &adev->ip_blocks[j];
- block->status.hw = false;
if (block->version->type != ip_order[i] ||
!block->status.valid)
continue;
+ block->status.hw = false;
r = block->version->funcs->hw_init(adev);
DRM_INFO("RE-INIT-early: %s %s\n", block->version->funcs->name, r?"failed":"succeeded");
if (r)
--
2.20.1
[-- Attachment #1.2: Type: text/html, Size: 5253 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
@ 2019-10-30 2:26 ` Zhao, Jiange
0 siblings, 0 replies; 6+ messages in thread
From: Zhao, Jiange @ 2019-10-30 2:26 UTC (permalink / raw)
To: Zhao, Jiange, amd-gfx; +Cc: Deng, Emily, Liu, Monk, Chang, HaiJun
[-- Attachment #1.1: Type: text/plain, Size: 2025 bytes --]
Ping.
@Deng, Emily<mailto:Emily.Deng@amd.com> @Liu, Monk<mailto:Monk.Liu@amd.com>, can you help review this patch?
Thanks!
Jiange
________________________________
From: Zhao, Jiange <jianzh@amd.com>
Sent: Tuesday, October 29, 2019 3:43 PM
To: amd-gfx@lists.freedesktop.org <amd-gfx@lists.freedesktop.org>
Cc: Deng, Emily <Emily.Deng@amd.com>; Liu, Monk <Monk.Liu@amd.com>; Chang, HaiJun <HaiJun.Chang@amd.com>; Zhao, Jiange <Jiange.Zhao@amd.com>
Subject: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
From: Jiange Zhao <Jiange.Zhao@amd.com>
In the old way, when doing IH hw_init, PSP, nv_common
and GMC hw.status would be reset to false, even though
their hw_init have been done. In the next step, fw_loading,
PSP would do hw_init again.
In the new way, only reset hw.status to false for the target
IP in the list. In this way, PSP will only do hw_init once.
Signed-off-by: Jiange Zhao <Jiange.Zhao@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4eee40b9d0b0..ad6d2452fed9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2352,11 +2352,11 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
for (j = 0; j < adev->num_ip_blocks; j++) {
block = &adev->ip_blocks[j];
- block->status.hw = false;
if (block->version->type != ip_order[i] ||
!block->status.valid)
continue;
+ block->status.hw = false;
r = block->version->funcs->hw_init(adev);
DRM_INFO("RE-INIT-early: %s %s\n", block->version->funcs->name, r?"failed":"succeeded");
if (r)
--
2.20.1
[-- Attachment #1.2: Type: text/html, Size: 5029 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
@ 2019-10-30 3:38 ` Liu, Monk
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Monk @ 2019-10-30 3:38 UTC (permalink / raw)
To: Zhao, Jiange, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Cc: Deng, Emily, Chang, HaiJun
[-- Attachment #1.1.1: Type: text/plain, Size: 3431 bytes --]
Hi Jiange
You need to send the patch to amd-gfx for review if it intend to go drm-next branch
For gibraltar branch your patch is -1 by CI
_____________________________________
Monk Liu|GPU Virtualization Team |AMD
[sig-cloud-gpu]
From: Zhao, Jiange <Jiange.Zhao-5C7GfCeVMHo@public.gmane.org>
Sent: Wednesday, October 30, 2019 10:26 AM
To: Zhao, Jiange <Jiange.Zhao-5C7GfCeVMHo@public.gmane.org>; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Cc: Deng, Emily <Emily.Deng-5C7GfCeVMHo@public.gmane.org>; Liu, Monk <Monk.Liu-5C7GfCeVMHo@public.gmane.org>; Chang, HaiJun <HaiJun.Chang-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
Ping.
@Deng, Emily<mailto:Emily.Deng-5C7GfCeVMHo@public.gmane.org> @Liu, Monk<mailto:Monk.Liu-5C7GfCeVMHo@public.gmane.org>, can you help review this patch?
Thanks!
Jiange
________________________________
From: Zhao, Jiange <jianzh-5C7GfCeVMHo@public.gmane.org<mailto:jianzh-5C7GfCeVMHo@public.gmane.org>>
Sent: Tuesday, October 29, 2019 3:43 PM
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> <amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>>
Cc: Deng, Emily <Emily.Deng-5C7GfCeVMHo@public.gmane.org<mailto:Emily.Deng-5C7GfCeVMHo@public.gmane.org>>; Liu, Monk <Monk.Liu-5C7GfCeVMHo@public.gmane.org<mailto:Monk.Liu-5C7GfCeVMHo@public.gmane.org>>; Chang, HaiJun <HaiJun.Chang@amd.com<mailto:HaiJun.Chang-5C7GfCeVMHo@public.gmane.org>>; Zhao, Jiange <Jiange.Zhao-5C7GfCeVMHo@public.gmane.org<mailto:Jiange.Zhao-5C7GfCeVMHo@public.gmane.org>>
Subject: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
From: Jiange Zhao <Jiange.Zhao-5C7GfCeVMHo@public.gmane.org<mailto:Jiange.Zhao-5C7GfCeVMHo@public.gmane.org>>
In the old way, when doing IH hw_init, PSP, nv_common
and GMC hw.status would be reset to false, even though
their hw_init have been done. In the next step, fw_loading,
PSP would do hw_init again.
In the new way, only reset hw.status to false for the target
IP in the list. In this way, PSP will only do hw_init once.
Signed-off-by: Jiange Zhao <Jiange.Zhao-5C7GfCeVMHo@public.gmane.org<mailto:Jiange.Zhao-5C7GfCeVMHo@public.gmane.org>>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4eee40b9d0b0..ad6d2452fed9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2352,11 +2352,11 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
for (j = 0; j < adev->num_ip_blocks; j++) {
block = &adev->ip_blocks[j];
- block->status.hw = false;
if (block->version->type != ip_order[i] ||
!block->status.valid)
continue;
+ block->status.hw = false;
r = block->version->funcs->hw_init(adev);
DRM_INFO("RE-INIT-early: %s %s\n", block->version->funcs->name, r?"failed":"succeeded");
if (r)
--
2.20.1
[-- Attachment #1.1.2: Type: text/html, Size: 9351 bytes --]
[-- Attachment #1.2: image001.png --]
[-- Type: image/png, Size: 12243 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
@ 2019-10-30 3:38 ` Liu, Monk
0 siblings, 0 replies; 6+ messages in thread
From: Liu, Monk @ 2019-10-30 3:38 UTC (permalink / raw)
To: Zhao, Jiange, amd-gfx; +Cc: Deng, Emily, Chang, HaiJun
[-- Attachment #1.1.1: Type: text/plain, Size: 2871 bytes --]
Hi Jiange
You need to send the patch to amd-gfx for review if it intend to go drm-next branch
For gibraltar branch your patch is -1 by CI
_____________________________________
Monk Liu|GPU Virtualization Team |AMD
[sig-cloud-gpu]
From: Zhao, Jiange <Jiange.Zhao@amd.com>
Sent: Wednesday, October 30, 2019 10:26 AM
To: Zhao, Jiange <Jiange.Zhao@amd.com>; amd-gfx@lists.freedesktop.org
Cc: Deng, Emily <Emily.Deng@amd.com>; Liu, Monk <Monk.Liu@amd.com>; Chang, HaiJun <HaiJun.Chang@amd.com>
Subject: Re: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
Ping.
@Deng, Emily<mailto:Emily.Deng@amd.com> @Liu, Monk<mailto:Monk.Liu@amd.com>, can you help review this patch?
Thanks!
Jiange
________________________________
From: Zhao, Jiange <jianzh@amd.com<mailto:jianzh@amd.com>>
Sent: Tuesday, October 29, 2019 3:43 PM
To: amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org> <amd-gfx@lists.freedesktop.org<mailto:amd-gfx@lists.freedesktop.org>>
Cc: Deng, Emily <Emily.Deng@amd.com<mailto:Emily.Deng@amd.com>>; Liu, Monk <Monk.Liu@amd.com<mailto:Monk.Liu@amd.com>>; Chang, HaiJun <HaiJun.Chang@amd.com<mailto:HaiJun.Chang@amd.com>>; Zhao, Jiange <Jiange.Zhao@amd.com<mailto:Jiange.Zhao@amd.com>>
Subject: [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP
From: Jiange Zhao <Jiange.Zhao@amd.com<mailto:Jiange.Zhao@amd.com>>
In the old way, when doing IH hw_init, PSP, nv_common
and GMC hw.status would be reset to false, even though
their hw_init have been done. In the next step, fw_loading,
PSP would do hw_init again.
In the new way, only reset hw.status to false for the target
IP in the list. In this way, PSP will only do hw_init once.
Signed-off-by: Jiange Zhao <Jiange.Zhao@amd.com<mailto:Jiange.Zhao@amd.com>>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 4eee40b9d0b0..ad6d2452fed9 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -2352,11 +2352,11 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
for (j = 0; j < adev->num_ip_blocks; j++) {
block = &adev->ip_blocks[j];
- block->status.hw = false;
if (block->version->type != ip_order[i] ||
!block->status.valid)
continue;
+ block->status.hw = false;
r = block->version->funcs->hw_init(adev);
DRM_INFO("RE-INIT-early: %s %s\n", block->version->funcs->name, r?"failed":"succeeded");
if (r)
--
2.20.1
[-- Attachment #1.1.2: Type: text/html, Size: 8864 bytes --]
[-- Attachment #1.2: image001.png --]
[-- Type: image/png, Size: 12243 bytes --]
[-- Attachment #2: Type: text/plain, Size: 153 bytes --]
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-30 3:38 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 7:43 [PATCH] drm/amdgpu/SRIOV: Only reset hw.status for target IP jianzh-5C7GfCeVMHo
2019-10-29 7:43 ` jianzh
[not found] ` <20191029074248.11942-1-jianzh-5C7GfCeVMHo@public.gmane.org>
2019-10-30 2:26 ` Zhao, Jiange
2019-10-30 2:26 ` Zhao, Jiange
[not found] ` <MN2PR12MB3056C5DBA2AD474DB9A005C7E1600-rweVpJHSKTp9X0xwABXpTwdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-10-30 3:38 ` Liu, Monk
2019-10-30 3:38 ` Liu, Monk
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.