From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] stacktrace: don't skip first entry on noncurrent tasks
Date: Tue, 29 Oct 2019 08:35:26 -0500 [thread overview]
Message-ID: <20191029133526.tqzo4axnuyozaqzc@treble> (raw)
In-Reply-To: <20191029071944.17123-1-jslaby@suse.cz>
On Tue, Oct 29, 2019 at 08:19:44AM +0100, Jiri Slaby wrote:
> When doing cat /proc/<PID>/stack, the output is missing the first entry.
> When the current code walks the stack starting in stack_trace_save_tsk,
> it skips all scheduler functions (that's OK) plus one more function. But
> this one function should be skipped only for the 'current' task as it is
> stack_trace_save_tsk proper.
>
> The original code (before the common infrastructure) skipped one
> function only for the 'current' task -- see save_stack_trace_tsk before
> 3599fe12a125. So do so also in the new infrastructure now.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Fixes: 214d8ca6ee85 ("stacktrace: Provide common infrastructure")
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Josh Poimboeuf <jpoimboe@redhat.com>
> ---
>
> Notes:
> [v2] add the same for the !CONFIG_ARCH_STACKWALK case
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
next prev parent reply other threads:[~2019-10-29 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 6:52 [PATCH] stacktrace: don't skip first entry on noncurrent tasks Jiri Slaby
2019-10-25 14:21 ` Josh Poimboeuf
2019-10-29 7:19 ` [PATCH v2] " Jiri Slaby
2019-10-29 13:35 ` Josh Poimboeuf [this message]
2019-10-30 6:09 ` Jiri Slaby
2019-10-30 7:25 ` [PATCH v3] " Jiri Slaby
2019-11-04 20:24 ` [tip: core/urgent] stacktrace: Don't " tip-bot2 for Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029133526.tqzo4axnuyozaqzc@treble \
--to=jpoimboe@redhat.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.