All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jslaby@suse.cz>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf <jpoimboe@redhat.com>
Subject: Re: [PATCH v2] stacktrace: don't skip first entry on noncurrent tasks
Date: Wed, 30 Oct 2019 07:09:23 +0100	[thread overview]
Message-ID: <cc008627-edc0-bb82-db0e-5e02129cbd04@suse.cz> (raw)
In-Reply-To: <20191029071944.17123-1-jslaby@suse.cz>

On 29. 10. 19, 8:19, Jiri Slaby wrote:
> --- a/kernel/stacktrace.c
> +++ b/kernel/stacktrace.c
> @@ -298,7 +299,8 @@ unsigned int stack_trace_save_tsk(struct task_struct *task,

Argh, "task" here and:

>  	struct stack_trace trace = {
>  		.entries	= store,
>  		.max_entries	= size,
> -		.skip		= skipnr + 1,
> +		/* skip this function if they are tracing us */
> +		.skip	= skipnr + !!(current == tsk),

"tsk" here. Scratch this one.

thanks,
-- 
js
suse labs

  parent reply	other threads:[~2019-10-30  6:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25  6:52 [PATCH] stacktrace: don't skip first entry on noncurrent tasks Jiri Slaby
2019-10-25 14:21 ` Josh Poimboeuf
2019-10-29  7:19   ` [PATCH v2] " Jiri Slaby
2019-10-29 13:35     ` Josh Poimboeuf
2019-10-30  6:09     ` Jiri Slaby [this message]
2019-10-30  7:25     ` [PATCH v3] " Jiri Slaby
2019-11-04 20:24       ` [tip: core/urgent] stacktrace: Don't " tip-bot2 for Jiri Slaby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc008627-edc0-bb82-db0e-5e02129cbd04@suse.cz \
    --to=jslaby@suse.cz \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.