* [PATCH BlueZ] a2dp: Remove experimental flag for remote MediaEndpoint
@ 2019-10-18 10:53 Luiz Augusto von Dentz
2019-10-19 12:03 ` Luiz Augusto von Dentz
0 siblings, 1 reply; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2019-10-18 10:53 UTC (permalink / raw)
To: linux-bluetooth
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
This makes the MediaEndpoint and stable API for remote endpoints which
aligns with RegisterApplication API which is already stable.
---
profiles/audio/a2dp.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
index f98ec8505..e8262cdfe 100644
--- a/profiles/audio/a2dp.c
+++ b/profiles/audio/a2dp.c
@@ -1761,7 +1761,7 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg,
}
static const GDBusMethodTable sep_methods[] = {
- { GDBUS_EXPERIMENTAL_ASYNC_METHOD("SetConfiguration",
+ { GDBUS_ASYNC_METHOD("SetConfiguration",
GDBUS_ARGS({ "endpoint", "o" },
{ "properties", "a{sv}" } ),
NULL, set_configuration) },
@@ -1837,14 +1837,10 @@ static gboolean get_device(const GDBusPropertyTable *property,
}
static const GDBusPropertyTable sep_properties[] = {
- { "UUID", "s", get_uuid, NULL, NULL,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
- { "Codec", "y", get_codec, NULL, NULL,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
- { "Capabilities", "ay", get_capabilities, NULL, NULL,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
- { "Device", "o", get_device, NULL, NULL,
- G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
+ { "UUID", "s", get_uuid, NULL, NULL },
+ { "Codec", "y", get_codec, NULL, NULL },
+ { "Capabilities", "ay", get_capabilities, NULL, NULL },
+ { "Device", "o", get_device, NULL, NULL },
{ }
};
@@ -1862,9 +1858,6 @@ static void register_remote_sep(void *data, void *user_data)
sep->chan = chan;
sep->sep = rsep;
- if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL))
- goto done;
-
if (asprintf(&sep->path, "%s/sep%d",
device_get_path(chan->device),
avdtp_get_seid(rsep)) < 0) {
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH BlueZ] a2dp: Remove experimental flag for remote MediaEndpoint
2019-10-18 10:53 [PATCH BlueZ] a2dp: Remove experimental flag for remote MediaEndpoint Luiz Augusto von Dentz
@ 2019-10-19 12:03 ` Luiz Augusto von Dentz
2019-10-29 20:32 ` Pasi Kärkkäinen
0 siblings, 1 reply; 3+ messages in thread
From: Luiz Augusto von Dentz @ 2019-10-19 12:03 UTC (permalink / raw)
To: linux-bluetooth
Hi,
On Fri, Oct 18, 2019 at 1:53 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
>
> This makes the MediaEndpoint and stable API for remote endpoints which
> aligns with RegisterApplication API which is already stable.
> ---
> profiles/audio/a2dp.c | 17 +++++------------
> 1 file changed, 5 insertions(+), 12 deletions(-)
>
> diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
> index f98ec8505..e8262cdfe 100644
> --- a/profiles/audio/a2dp.c
> +++ b/profiles/audio/a2dp.c
> @@ -1761,7 +1761,7 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg,
> }
>
> static const GDBusMethodTable sep_methods[] = {
> - { GDBUS_EXPERIMENTAL_ASYNC_METHOD("SetConfiguration",
> + { GDBUS_ASYNC_METHOD("SetConfiguration",
> GDBUS_ARGS({ "endpoint", "o" },
> { "properties", "a{sv}" } ),
> NULL, set_configuration) },
> @@ -1837,14 +1837,10 @@ static gboolean get_device(const GDBusPropertyTable *property,
> }
>
> static const GDBusPropertyTable sep_properties[] = {
> - { "UUID", "s", get_uuid, NULL, NULL,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> - { "Codec", "y", get_codec, NULL, NULL,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> - { "Capabilities", "ay", get_capabilities, NULL, NULL,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> - { "Device", "o", get_device, NULL, NULL,
> - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> + { "UUID", "s", get_uuid, NULL, NULL },
> + { "Codec", "y", get_codec, NULL, NULL },
> + { "Capabilities", "ay", get_capabilities, NULL, NULL },
> + { "Device", "o", get_device, NULL, NULL },
> { }
> };
>
> @@ -1862,9 +1858,6 @@ static void register_remote_sep(void *data, void *user_data)
> sep->chan = chan;
> sep->sep = rsep;
>
> - if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL))
> - goto done;
> -
> if (asprintf(&sep->path, "%s/sep%d",
> device_get_path(chan->device),
> avdtp_get_seid(rsep)) < 0) {
> --
> 2.21.0
>
Pushed.
--
Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH BlueZ] a2dp: Remove experimental flag for remote MediaEndpoint
2019-10-19 12:03 ` Luiz Augusto von Dentz
@ 2019-10-29 20:32 ` Pasi Kärkkäinen
0 siblings, 0 replies; 3+ messages in thread
From: Pasi Kärkkäinen @ 2019-10-29 20:32 UTC (permalink / raw)
To: Luiz Augusto von Dentz; +Cc: linux-bluetooth, Pali Rohár
Hi Luiz,
Now that A2DP codec switching related APIs are declared stable in bluez git,
I'd like to request bluez 5.52 release soon.
This is because feature freeze for PulseAudio 14.0 is scheduled for 2019-12-13,
so It'd be nice to have a bluez release before that.. Also to try to avoid
distros shipping bluez 5.51, where MediaEndpoint API isn't stable yet..
Thanks a lot,
-- Pasi
On Sat, Oct 19, 2019 at 03:03:19PM +0300, Luiz Augusto von Dentz wrote:
> Hi,
>
> On Fri, Oct 18, 2019 at 1:53 PM Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
> >
> > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> >
> > This makes the MediaEndpoint and stable API for remote endpoints which
> > aligns with RegisterApplication API which is already stable.
> > ---
> > profiles/audio/a2dp.c | 17 +++++------------
> > 1 file changed, 5 insertions(+), 12 deletions(-)
> >
> > diff --git a/profiles/audio/a2dp.c b/profiles/audio/a2dp.c
> > index f98ec8505..e8262cdfe 100644
> > --- a/profiles/audio/a2dp.c
> > +++ b/profiles/audio/a2dp.c
> > @@ -1761,7 +1761,7 @@ static DBusMessage *set_configuration(DBusConnection *conn, DBusMessage *msg,
> > }
> >
> > static const GDBusMethodTable sep_methods[] = {
> > - { GDBUS_EXPERIMENTAL_ASYNC_METHOD("SetConfiguration",
> > + { GDBUS_ASYNC_METHOD("SetConfiguration",
> > GDBUS_ARGS({ "endpoint", "o" },
> > { "properties", "a{sv}" } ),
> > NULL, set_configuration) },
> > @@ -1837,14 +1837,10 @@ static gboolean get_device(const GDBusPropertyTable *property,
> > }
> >
> > static const GDBusPropertyTable sep_properties[] = {
> > - { "UUID", "s", get_uuid, NULL, NULL,
> > - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> > - { "Codec", "y", get_codec, NULL, NULL,
> > - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> > - { "Capabilities", "ay", get_capabilities, NULL, NULL,
> > - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> > - { "Device", "o", get_device, NULL, NULL,
> > - G_DBUS_PROPERTY_FLAG_EXPERIMENTAL },
> > + { "UUID", "s", get_uuid, NULL, NULL },
> > + { "Codec", "y", get_codec, NULL, NULL },
> > + { "Capabilities", "ay", get_capabilities, NULL, NULL },
> > + { "Device", "o", get_device, NULL, NULL },
> > { }
> > };
> >
> > @@ -1862,9 +1858,6 @@ static void register_remote_sep(void *data, void *user_data)
> > sep->chan = chan;
> > sep->sep = rsep;
> >
> > - if (!(g_dbus_get_flags() & G_DBUS_FLAG_ENABLE_EXPERIMENTAL))
> > - goto done;
> > -
> > if (asprintf(&sep->path, "%s/sep%d",
> > device_get_path(chan->device),
> > avdtp_get_seid(rsep)) < 0) {
> > --
> > 2.21.0
> >
>
> Pushed.
>
> --
> Luiz Augusto von Dentz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-29 20:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-18 10:53 [PATCH BlueZ] a2dp: Remove experimental flag for remote MediaEndpoint Luiz Augusto von Dentz
2019-10-19 12:03 ` Luiz Augusto von Dentz
2019-10-29 20:32 ` Pasi Kärkkäinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.