[sashal-linux-stable:queue-4.4 13/22] fs/nfs/write.c:730:19: warning: passing argument 1 of 'atomic_long_dec' from incompatible pointer type

[sashal-linux-stable:queue-4.4 13/22] fs/nfs/write.c:730:19: warning: passing argument 1 of 'atomic_long_dec' from incompatible pointer type

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 3474 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/sashal/linux-stable.git queue-4.4
head:   0fbef7e83238132a00cc89a1b22226c3c7b4b134
commit: e8dd29e1a7f4d861fd16ab4e1b2df10b3a38dda1 [13/22] nfs: Fix nfsi->nrequests count error on nfs_inode_remove_request
config: i386-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        git checkout e8dd29e1a7f4d861fd16ab4e1b2df10b3a38dda1
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/nfs/write.c: In function 'nfs_inode_remove_request':
>> fs/nfs/write.c:730:19: warning: passing argument 1 of 'atomic_long_dec' from incompatible pointer type [-Wincompatible-pointer-types]
      atomic_long_dec(&nfsi->nrequests);
                      ^
   In file included from include/linux/atomic.h:562:0,
                    from include/linux/jump_label.h:118,
                    from include/linux/static_key.h:1,
                    from arch/x86/include/asm/nospec-branch.h:6,
                    from arch/x86/include/asm/irqflags.h:8,
                    from include/linux/irqflags.h:15,
                    from arch/x86/include/asm/processor.h:31,
                    from arch/x86/include/asm/cpufeature.h:4,
                    from arch/x86/include/asm/thread_info.h:52,
                    from include/linux/thread_info.h:54,
                    from arch/x86/include/asm/preempt.h:6,
                    from include/linux/preempt.h:59,
                    from include/linux/spinlock.h:50,
                    from include/linux/mmzone.h:7,
                    from include/linux/gfp.h:5,
                    from include/linux/slab.h:14,
                    from fs/nfs/write.c:10:
   include/asm-generic/atomic-long.h:108:20: note: expected 'atomic_long_t * {aka struct <anonymous> *}' but argument is of type 'long unsigned int *'
    static inline void atomic_long_dec(atomic_long_t *l)
                       ^~~~~~~~~~~~~~~

vim +/atomic_long_dec +730 fs/nfs/write.c

   699	
   700	/*
   701	 * Remove a write request from an inode
   702	 */
   703	static void nfs_inode_remove_request(struct nfs_page *req)
   704	{
   705		struct inode *inode = d_inode(req->wb_context->dentry);
   706		struct nfs_inode *nfsi = NFS_I(inode);
   707		struct nfs_page *head;
   708	
   709		if (nfs_page_group_sync_on_bit(req, PG_REMOVE)) {
   710			head = req->wb_head;
   711	
   712			spin_lock(&inode->i_lock);
   713			if (likely(!PageSwapCache(head->wb_page))) {
   714				set_page_private(head->wb_page, 0);
   715				ClearPagePrivate(head->wb_page);
   716				smp_mb__after_atomic();
   717				wake_up_page(head->wb_page, PG_private);
   718				clear_bit(PG_MAPPED, &head->wb_flags);
   719			}
   720			nfsi->nrequests--;
   721			spin_unlock(&inode->i_lock);
   722		} else {
   723			spin_lock(&inode->i_lock);
   724			nfsi->nrequests--;
   725			spin_unlock(&inode->i_lock);
   726		}
   727	
   728		if (test_and_clear_bit(PG_INODE_REF, &req->wb_flags)) {
   729			nfs_release_request(req);
 > 730			atomic_long_dec(&nfsi->nrequests);
   731		}
   732	}
   733	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 23933 bytes --]