* [PATCH 0/2] staging: sm750fb: Fixing codestyle error
@ 2019-10-29 23:22 ` Gabriela Bittencourt
0 siblings, 0 replies; 12+ messages in thread
From: Gabriela Bittencourt @ 2019-10-29 23:22 UTC (permalink / raw)
To: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel, lkcamp, trivial
Cc: Gabriela Bittencourt
Fixing typo and usage of spaces/tabs in file sm750_accel.c
Gabriela Bittencourt (2):
staging: sm750fb: Fix typo in comment
staging: sm750fb: Replace multiple spaces with tabs when it suits
drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 0/2] staging: sm750fb: Fixing codestyle error
@ 2019-10-29 23:22 ` Gabriela Bittencourt
0 siblings, 0 replies; 12+ messages in thread
From: Gabriela Bittencourt @ 2019-10-29 23:22 UTC (permalink / raw)
To: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel, lkcamp, trivial
Cc: Gabriela Bittencourt
Fixing typo and usage of spaces/tabs in file sm750_accel.c
Gabriela Bittencourt (2):
staging: sm750fb: Fix typo in comment
staging: sm750fb: Replace multiple spaces with tabs when it suits
drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 1/2] staging: sm750fb: Fix typo in comment
2019-10-29 23:22 ` Gabriela Bittencourt
(?)
@ 2019-10-29 23:22 ` Gabriela Bittencourt
-1 siblings, 0 replies; 12+ messages in thread
From: Gabriela Bittencourt @ 2019-10-29 23:22 UTC (permalink / raw)
To: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel, lkcamp, trivial
Cc: Gabriela Bittencourt
Fixing typo in word 'and'.
Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 645813a87490..5925d7c7d464 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -224,7 +224,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
/*
* Note:
- * DE_FOREGROUND are DE_BACKGROUND are don't care.
+ * DE_FOREGROUND and DE_BACKGROUND are don't care.
* DE_COLOR_COMPARE and DE_COLOR_COMPARE_MAKS
* are set by set deSetTransparency().
*/
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] staging: sm750fb: Fix typo in comment
@ 2019-10-29 23:22 ` Gabriela Bittencourt
0 siblings, 0 replies; 12+ messages in thread
From: Gabriela Bittencourt @ 2019-10-29 23:22 UTC (permalink / raw)
To: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel, lkcamp, trivial
Cc: Gabriela Bittencourt
Fixing typo in word 'and'.
Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 645813a87490..5925d7c7d464 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -224,7 +224,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
/*
* Note:
- * DE_FOREGROUND are DE_BACKGROUND are don't care.
+ * DE_FOREGROUND and DE_BACKGROUND are don't care.
* DE_COLOR_COMPARE and DE_COLOR_COMPARE_MAKS
* are set by set deSetTransparency().
*/
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 1/2] staging: sm750fb: Fix typo in comment
@ 2019-10-29 23:22 ` Gabriela Bittencourt
0 siblings, 0 replies; 12+ messages in thread
From: Gabriela Bittencourt @ 2019-10-29 23:22 UTC (permalink / raw)
To: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel, lkcamp, trivial
Cc: Gabriela Bittencourt
Fixing typo in word 'and'.
Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 645813a87490..5925d7c7d464 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -224,7 +224,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
/*
* Note:
- * DE_FOREGROUND are DE_BACKGROUND are don't care.
+ * DE_FOREGROUND and DE_BACKGROUND are don't care.
* DE_COLOR_COMPARE and DE_COLOR_COMPARE_MAKS
* are set by set deSetTransparency().
*/
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: sm750fb: Fix typo in comment
2019-10-29 23:22 ` Gabriela Bittencourt
(?)
@ 2019-10-30 5:27 ` Julia Lawall
-1 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2019-10-30 5:27 UTC (permalink / raw)
To: Gabriela Bittencourt
Cc: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel, lkcamp, trivial
On Tue, 29 Oct 2019, Gabriela Bittencourt wrote:
> Fixing typo in word 'and'.
>
> Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 645813a87490..5925d7c7d464 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -224,7 +224,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
>
> /*
> * Note:
> - * DE_FOREGROUND are DE_BACKGROUND are don't care.
> + * DE_FOREGROUND and DE_BACKGROUND are don't care.
> * DE_COLOR_COMPARE and DE_COLOR_COMPARE_MAKS
> * are set by set deSetTransparency().
> */
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191029232207.4113-2-gabrielabittencourt00%40gmail.com.
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: sm750fb: Fix typo in comment
@ 2019-10-30 5:27 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2019-10-30 5:27 UTC (permalink / raw)
To: Gabriela Bittencourt
Cc: devel, linux-fbdev, trivial, teddy.wang, gregkh, linux-kernel,
outreachy-kernel, lkcamp, sudipm.mukherjee
On Tue, 29 Oct 2019, Gabriela Bittencourt wrote:
> Fixing typo in word 'and'.
>
> Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 645813a87490..5925d7c7d464 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -224,7 +224,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
>
> /*
> * Note:
> - * DE_FOREGROUND are DE_BACKGROUND are don't care.
> + * DE_FOREGROUND and DE_BACKGROUND are don't care.
> * DE_COLOR_COMPARE and DE_COLOR_COMPARE_MAKS
> * are set by set deSetTransparency().
> */
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191029232207.4113-2-gabrielabittencourt00%40gmail.com.
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Outreachy kernel] [PATCH 1/2] staging: sm750fb: Fix typo in comment
@ 2019-10-30 5:27 ` Julia Lawall
0 siblings, 0 replies; 12+ messages in thread
From: Julia Lawall @ 2019-10-30 5:27 UTC (permalink / raw)
To: Gabriela Bittencourt
Cc: devel, linux-fbdev, trivial, teddy.wang, gregkh, linux-kernel,
outreachy-kernel, lkcamp, sudipm.mukherjee
On Tue, 29 Oct 2019, Gabriela Bittencourt wrote:
> Fixing typo in word 'and'.
>
> Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index 645813a87490..5925d7c7d464 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -224,7 +224,7 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
>
> /*
> * Note:
> - * DE_FOREGROUND are DE_BACKGROUND are don't care.
> + * DE_FOREGROUND and DE_BACKGROUND are don't care.
> * DE_COLOR_COMPARE and DE_COLOR_COMPARE_MAKS
> * are set by set deSetTransparency().
> */
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20191029232207.4113-2-gabrielabittencourt00%40gmail.com.
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH 2/2] staging: sm750fb: Replace multiple spaces with tabs when it suits
2019-10-29 23:22 ` Gabriela Bittencourt
(?)
@ 2019-10-29 23:22 ` Gabriela Bittencourt
-1 siblings, 0 replies; 12+ messages in thread
From: Gabriela Bittencourt @ 2019-10-29 23:22 UTC (permalink / raw)
To: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel, lkcamp, trivial
Cc: Gabriela Bittencourt
Replace multiple spaces before some comments with one tab. Aligning the
comment with the function below it.
Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 5925d7c7d464..8faa601c700b 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -243,21 +243,21 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
*/
write_dpr(accel, DE_WINDOW_DESTINATION_BASE, dBase); /* dpr44 */
- /*
- * Program pitch (distance between the 1st points of two adjacent lines).
- * Note that input pitch is BYTE value, but the 2D Pitch register uses
- * pixel values. Need Byte to pixel conversion.
- */
+ /*
+ * Program pitch (distance between the 1st points of two adjacent lines).
+ * Note that input pitch is BYTE value, but the 2D Pitch register uses
+ * pixel values. Need Byte to pixel conversion.
+ */
write_dpr(accel, DE_PITCH,
((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) &
DE_PITCH_DESTINATION_MASK) |
(sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */
- /*
- * Screen Window width in Pixels.
- * 2D engine uses this value to calculate the linear address in frame buffer
- * for a given point.
- */
+ /*
+ * Screen Window width in Pixels.
+ * 2D engine uses this value to calculate the linear address in frame buffer
+ * for a given point.
+ */
write_dpr(accel, DE_WINDOW_WIDTH,
((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) &
DE_WINDOW_WIDTH_DST_MASK) |
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] staging: sm750fb: Replace multiple spaces with tabs when it suits
@ 2019-10-29 23:22 ` Gabriela Bittencourt
0 siblings, 0 replies; 12+ messages in thread
From: Gabriela Bittencourt @ 2019-10-29 23:22 UTC (permalink / raw)
To: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel, lkcamp, trivial
Cc: Gabriela Bittencourt
Replace multiple spaces before some comments with one tab. Aligning the
comment with the function below it.
Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 5925d7c7d464..8faa601c700b 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -243,21 +243,21 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
*/
write_dpr(accel, DE_WINDOW_DESTINATION_BASE, dBase); /* dpr44 */
- /*
- * Program pitch (distance between the 1st points of two adjacent lines).
- * Note that input pitch is BYTE value, but the 2D Pitch register uses
- * pixel values. Need Byte to pixel conversion.
- */
+ /*
+ * Program pitch (distance between the 1st points of two adjacent lines).
+ * Note that input pitch is BYTE value, but the 2D Pitch register uses
+ * pixel values. Need Byte to pixel conversion.
+ */
write_dpr(accel, DE_PITCH,
((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) &
DE_PITCH_DESTINATION_MASK) |
(sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */
- /*
- * Screen Window width in Pixels.
- * 2D engine uses this value to calculate the linear address in frame buffer
- * for a given point.
- */
+ /*
+ * Screen Window width in Pixels.
+ * 2D engine uses this value to calculate the linear address in frame buffer
+ * for a given point.
+ */
write_dpr(accel, DE_WINDOW_WIDTH,
((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) &
DE_WINDOW_WIDTH_DST_MASK) |
--
2.20.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] staging: sm750fb: Replace multiple spaces with tabs when it suits
@ 2019-10-29 23:22 ` Gabriela Bittencourt
0 siblings, 0 replies; 12+ messages in thread
From: Gabriela Bittencourt @ 2019-10-29 23:22 UTC (permalink / raw)
To: outreachy-kernel, sudipm.mukherjee, teddy.wang, gregkh,
linux-fbdev, devel, linux-kernel, lkcamp, trivial
Cc: Gabriela Bittencourt
Replace multiple spaces before some comments with one tab. Aligning the
comment with the function below it.
Signed-off-by: Gabriela Bittencourt <gabrielabittencourt00@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 5925d7c7d464..8faa601c700b 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -243,21 +243,21 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
*/
write_dpr(accel, DE_WINDOW_DESTINATION_BASE, dBase); /* dpr44 */
- /*
- * Program pitch (distance between the 1st points of two adjacent lines).
- * Note that input pitch is BYTE value, but the 2D Pitch register uses
- * pixel values. Need Byte to pixel conversion.
- */
+ /*
+ * Program pitch (distance between the 1st points of two adjacent lines).
+ * Note that input pitch is BYTE value, but the 2D Pitch register uses
+ * pixel values. Need Byte to pixel conversion.
+ */
write_dpr(accel, DE_PITCH,
((dPitch / Bpp << DE_PITCH_DESTINATION_SHIFT) &
DE_PITCH_DESTINATION_MASK) |
(sPitch / Bpp & DE_PITCH_SOURCE_MASK)); /* dpr10 */
- /*
- * Screen Window width in Pixels.
- * 2D engine uses this value to calculate the linear address in frame buffer
- * for a given point.
- */
+ /*
+ * Screen Window width in Pixels.
+ * 2D engine uses this value to calculate the linear address in frame buffer
+ * for a given point.
+ */
write_dpr(accel, DE_WINDOW_WIDTH,
((dPitch / Bpp << DE_WINDOW_WIDTH_DST_SHIFT) &
DE_WINDOW_WIDTH_DST_MASK) |
--
2.20.1
^ permalink raw reply related [flat|nested] 12+ messages in thread