All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] knownnetworks: Check result of setting getter
@ 2019-10-29 23:31 Tim Kourt
  2019-10-30 19:39 ` Denis Kenzior
  0 siblings, 1 reply; 2+ messages in thread
From: Tim Kourt @ 2019-10-29 23:31 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 946 bytes --]

Set the value of 'is_hidden' if necessary.
---
 src/knownnetworks.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/knownnetworks.c b/src/knownnetworks.c
index e5cbc01b..d8d6947d 100644
--- a/src/knownnetworks.c
+++ b/src/knownnetworks.c
@@ -338,7 +338,7 @@ void known_network_update(struct network_info *network,
 					struct l_settings *settings,
 					uint64_t connected_time)
 {
-	bool is_hidden = false;
+	bool is_hidden;
 	bool is_autoconnectable;
 
 	if (network->connected_time != connected_time) {
@@ -354,7 +354,8 @@ void known_network_update(struct network_info *network,
 
 	network->connected_time = connected_time;
 
-	l_settings_get_bool(settings, "Settings", "Hidden", &is_hidden);
+	if (!l_settings_get_bool(settings, "Settings", "Hidden", &is_hidden))
+		is_hidden = false;
 
 	if (network->is_hidden != is_hidden) {
 		if (network->is_hidden && !is_hidden)
-- 
2.13.6

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] knownnetworks: Check result of setting getter
  2019-10-29 23:31 [PATCH] knownnetworks: Check result of setting getter Tim Kourt
@ 2019-10-30 19:39 ` Denis Kenzior
  0 siblings, 0 replies; 2+ messages in thread
From: Denis Kenzior @ 2019-10-30 19:39 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Hi Tim,

On 10/29/19 6:31 PM, Tim Kourt wrote:
> Set the value of 'is_hidden' if necessary.
> ---
>   src/knownnetworks.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
> 

Applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-30 19:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-29 23:31 [PATCH] knownnetworks: Check result of setting getter Tim Kourt
2019-10-30 19:39 ` Denis Kenzior

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.