All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iommu/virtio: Remove unused variable
@ 2019-10-25 16:13 ` Cristiane Naves
  0 siblings, 0 replies; 5+ messages in thread
From: Cristiane Naves @ 2019-10-25 16:13 UTC (permalink / raw)
  To: outreachy-kernel
  Cc: Jean-Philippe Brucker, Julia Lawall, Greg KH, virtualization,
	outreachy-kernel, iommu

Remove the variable of return. Issue found by
coccicheck(scripts/coccinelle/misc/returnvar.cocci)

Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
---
 drivers/iommu/virtio-iommu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c
index 3ea9d76..d8f29c8 100644
--- a/drivers/iommu/virtio-iommu.c
+++ b/drivers/iommu/virtio-iommu.c
@@ -153,7 +153,6 @@ static off_t viommu_get_write_desc_offset(struct viommu_dev *viommu,
  */
 static int __viommu_sync_req(struct viommu_dev *viommu)
 {
-	int ret = 0;
 	unsigned int len;
 	size_t write_len;
 	struct viommu_request *req;
@@ -182,7 +181,7 @@ static int __viommu_sync_req(struct viommu_dev *viommu)
 		kfree(req);
 	}
 
-	return ret;
+	return 0;
 }
 
 static int viommu_sync_req(struct viommu_dev *viommu)
-- 
2.7.4

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH] iommu/virtio: Remove unused variable
@ 2019-10-25 16:13 ` Cristiane Naves
  0 siblings, 0 replies; 5+ messages in thread
From: Cristiane Naves @ 2019-10-25 16:13 UTC (permalink / raw)
  To: outreachy-kernel
  Cc: outreachy-kernel, Jean-Philippe Brucker, Joerg Roedel,
	virtualization, iommu, Greg KH, Julia Lawall

Remove the variable of return. Issue found by
coccicheck(scripts/coccinelle/misc/returnvar.cocci)

Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
---
 drivers/iommu/virtio-iommu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/iommu/virtio-iommu.c b/drivers/iommu/virtio-iommu.c
index 3ea9d76..d8f29c8 100644
--- a/drivers/iommu/virtio-iommu.c
+++ b/drivers/iommu/virtio-iommu.c
@@ -153,7 +153,6 @@ static off_t viommu_get_write_desc_offset(struct viommu_dev *viommu,
  */
 static int __viommu_sync_req(struct viommu_dev *viommu)
 {
-	int ret = 0;
 	unsigned int len;
 	size_t write_len;
 	struct viommu_request *req;
@@ -182,7 +181,7 @@ static int __viommu_sync_req(struct viommu_dev *viommu)
 		kfree(req);
 	}
 
-	return ret;
+	return 0;
 }
 
 static int viommu_sync_req(struct viommu_dev *viommu)
-- 
2.7.4



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iommu/virtio: Remove unused variable
  2019-10-25 16:13 ` Cristiane Naves
@ 2019-10-30  9:43   ` Joerg Roedel
  -1 siblings, 0 replies; 5+ messages in thread
From: Joerg Roedel @ 2019-10-30  9:43 UTC (permalink / raw)
  To: Cristiane Naves
  Cc: Jean-Philippe Brucker, Julia Lawall, Greg KH, virtualization,
	outreachy-kernel, iommu

On Fri, Oct 25, 2019 at 01:13:40PM -0300, Cristiane Naves wrote:
> Remove the variable of return. Issue found by
> coccicheck(scripts/coccinelle/misc/returnvar.cocci)
> 
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
>  drivers/iommu/virtio-iommu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied for v5.5, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iommu/virtio: Remove unused variable
  2019-10-25 16:13 ` Cristiane Naves
  (?)
@ 2019-10-30  9:43 ` Joerg Roedel
  -1 siblings, 0 replies; 5+ messages in thread
From: Joerg Roedel @ 2019-10-30  9:43 UTC (permalink / raw)
  To: Cristiane Naves
  Cc: Jean-Philippe Brucker, Julia Lawall, Greg KH, virtualization,
	outreachy-kernel, iommu

On Fri, Oct 25, 2019 at 01:13:40PM -0300, Cristiane Naves wrote:
> Remove the variable of return. Issue found by
> coccicheck(scripts/coccinelle/misc/returnvar.cocci)
> 
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
>  drivers/iommu/virtio-iommu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied for v5.5, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] iommu/virtio: Remove unused variable
@ 2019-10-30  9:43   ` Joerg Roedel
  0 siblings, 0 replies; 5+ messages in thread
From: Joerg Roedel @ 2019-10-30  9:43 UTC (permalink / raw)
  To: Cristiane Naves
  Cc: outreachy-kernel, Jean-Philippe Brucker, virtualization, iommu,
	Greg KH, Julia Lawall

On Fri, Oct 25, 2019 at 01:13:40PM -0300, Cristiane Naves wrote:
> Remove the variable of return. Issue found by
> coccicheck(scripts/coccinelle/misc/returnvar.cocci)
> 
> Signed-off-by: Cristiane Naves <cristianenavescardoso09@gmail.com>
> ---
>  drivers/iommu/virtio-iommu.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Applied for v5.5, thanks.


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-11-06 19:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-25 16:13 [PATCH] iommu/virtio: Remove unused variable Cristiane Naves
2019-10-25 16:13 ` Cristiane Naves
2019-10-30  9:43 ` Joerg Roedel
2019-10-30  9:43 ` Joerg Roedel
2019-10-30  9:43   ` Joerg Roedel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.