From: Lianbo Jiang <lijiang@redhat.com> To: linux-kernel@vger.kernel.org Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, x86@kernel.org, bhe@redhat.com, dyoung@redhat.com, jgross@suse.com, dhowells@redhat.com, Thomas.Lendacky@amd.com, ebiederm@xmission.com, vgoyal@redhat.com, d.hatayama@fujitsu.com, horms@verge.net.au, kexec@lists.infradead.org Subject: [PATCH 0/2 RESEND v8] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active Date: Thu, 31 Oct 2019 11:35:15 +0800 [thread overview] Message-ID: <20191031033517.11282-1-lijiang@redhat.com> (raw) In purgatory(), the main things are as below: [1] verify sha256 hashes for various segments. Lets keep these codes, and do not touch the logic. [2] copy the first 640k content to a backup region. Lets safely remove it and clean all code related to backup region. This patch series will remove the backup region, because the current handling of copying the first 640k runs into problems when SME is active(https://bugzilla.kernel.org/show_bug.cgi?id=204793). The low 1M region will always be reserved when the crashkernel kernel command line option is specified. And this way makes it unnecessary to do anything with the low 1M region, because the memory allocated later won't fall into the low 1M area. This series includes two patches: [1] x86/kdump: always reserve the low 1M when the crashkernel option is specified The low 1M region will always be reserved when the crashkernel kernel command line option is specified, which ensures that the memory allocated later won't fall into the low 1M area. [2] x86/kdump: clean up all the code related to the backup region Remove the backup region and clean up. Changes since v1: [1] Add extra checking condition: when the crashkernel option is specified, reserve the low 640k area. Changes since v2: [1] Reserve the low 1M region when the crashkernel option is only specified.(Suggested by Eric) [2] Remove the unused crash_copy_backup_region() [3] Remove the backup region and clean up [4] Split them into three patches Changes since v3: [1] Improve the first patch's log [2] Improve the third patch based on Eric's suggestions Changes since v4: [1] Correct some typos, and also improve the first patch's log [2] Add a new function kexec_reserve_low_1MiB() in kernel/kexec_core.c and which is called by reserve_real_mode(). (Suggested by Boris) Changes since v5: [1] Call the cmdline_find_option() instead of strstr() to check the crashkernel option. (Suggested by Hatayama) [2] Add a weak function kexec_reserve_low_1MiB() in kernel/kexec_core.c, and implement the kexec_reserve_low_1MiB() in arch/x86/kernel/ machine_kexec_64.c so that it does not cause the compile error on non-x86 kernel, and also ensures that it can work well on x86 kernel. Changes since v6: [1] Move the kexec_reserve_low_1MiB() to arch/x86/kernel/crash.c and also move its declaration function to arch/x86/include/asm/crash.h (Suggested by Dave Young) [2] Adjust the corresponding header files. Changes since v7: [1] Change the function name from kexec_reserve_low_1MiB() to crash_reserve_low_1M(). [2] Fix some warnings reported by kduild. Lianbo Jiang (2): x86/kdump: always reserve the low 1M when the crashkernel option is specified x86/kdump: clean up all the code related to the backup region arch/x86/include/asm/crash.h | 8 +++ arch/x86/include/asm/kexec.h | 10 --- arch/x86/include/asm/purgatory.h | 10 --- arch/x86/kernel/crash.c | 102 ++++++++--------------------- arch/x86/kernel/machine_kexec_64.c | 47 ------------- arch/x86/purgatory/purgatory.c | 19 ------ arch/x86/realmode/init.c | 2 + 7 files changed, 36 insertions(+), 162 deletions(-) -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Lianbo Jiang <lijiang@redhat.com> To: linux-kernel@vger.kernel.org Cc: jgross@suse.com, Thomas.Lendacky@amd.com, bhe@redhat.com, horms@verge.net.au, x86@kernel.org, kexec@lists.infradead.org, dhowells@redhat.com, mingo@redhat.com, bp@alien8.de, ebiederm@xmission.com, hpa@zytor.com, tglx@linutronix.de, dyoung@redhat.com, d.hatayama@fujitsu.com, vgoyal@redhat.com Subject: [PATCH 0/2 RESEND v8] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active Date: Thu, 31 Oct 2019 11:35:15 +0800 [thread overview] Message-ID: <20191031033517.11282-1-lijiang@redhat.com> (raw) In purgatory(), the main things are as below: [1] verify sha256 hashes for various segments. Lets keep these codes, and do not touch the logic. [2] copy the first 640k content to a backup region. Lets safely remove it and clean all code related to backup region. This patch series will remove the backup region, because the current handling of copying the first 640k runs into problems when SME is active(https://bugzilla.kernel.org/show_bug.cgi?id=204793). The low 1M region will always be reserved when the crashkernel kernel command line option is specified. And this way makes it unnecessary to do anything with the low 1M region, because the memory allocated later won't fall into the low 1M area. This series includes two patches: [1] x86/kdump: always reserve the low 1M when the crashkernel option is specified The low 1M region will always be reserved when the crashkernel kernel command line option is specified, which ensures that the memory allocated later won't fall into the low 1M area. [2] x86/kdump: clean up all the code related to the backup region Remove the backup region and clean up. Changes since v1: [1] Add extra checking condition: when the crashkernel option is specified, reserve the low 640k area. Changes since v2: [1] Reserve the low 1M region when the crashkernel option is only specified.(Suggested by Eric) [2] Remove the unused crash_copy_backup_region() [3] Remove the backup region and clean up [4] Split them into three patches Changes since v3: [1] Improve the first patch's log [2] Improve the third patch based on Eric's suggestions Changes since v4: [1] Correct some typos, and also improve the first patch's log [2] Add a new function kexec_reserve_low_1MiB() in kernel/kexec_core.c and which is called by reserve_real_mode(). (Suggested by Boris) Changes since v5: [1] Call the cmdline_find_option() instead of strstr() to check the crashkernel option. (Suggested by Hatayama) [2] Add a weak function kexec_reserve_low_1MiB() in kernel/kexec_core.c, and implement the kexec_reserve_low_1MiB() in arch/x86/kernel/ machine_kexec_64.c so that it does not cause the compile error on non-x86 kernel, and also ensures that it can work well on x86 kernel. Changes since v6: [1] Move the kexec_reserve_low_1MiB() to arch/x86/kernel/crash.c and also move its declaration function to arch/x86/include/asm/crash.h (Suggested by Dave Young) [2] Adjust the corresponding header files. Changes since v7: [1] Change the function name from kexec_reserve_low_1MiB() to crash_reserve_low_1M(). [2] Fix some warnings reported by kduild. Lianbo Jiang (2): x86/kdump: always reserve the low 1M when the crashkernel option is specified x86/kdump: clean up all the code related to the backup region arch/x86/include/asm/crash.h | 8 +++ arch/x86/include/asm/kexec.h | 10 --- arch/x86/include/asm/purgatory.h | 10 --- arch/x86/kernel/crash.c | 102 ++++++++--------------------- arch/x86/kernel/machine_kexec_64.c | 47 ------------- arch/x86/purgatory/purgatory.c | 19 ------ arch/x86/realmode/init.c | 2 + 7 files changed, 36 insertions(+), 162 deletions(-) -- 2.17.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2019-10-31 3:35 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-31 3:35 Lianbo Jiang [this message] 2019-10-31 3:35 ` [PATCH 0/2 RESEND v8] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active Lianbo Jiang 2019-10-31 3:35 ` [PATCH 1/2 RESEND v8] x86/kdump: always reserve the low 1M when the crashkernel option is specified Lianbo Jiang 2019-10-31 3:35 ` Lianbo Jiang 2019-10-31 7:13 ` Borislav Petkov 2019-10-31 7:13 ` Borislav Petkov 2019-10-31 9:40 ` lijiang 2019-10-31 9:40 ` lijiang 2019-10-31 10:47 ` Borislav Petkov 2019-10-31 10:47 ` Borislav Petkov 2019-11-01 7:12 ` lijiang 2019-11-01 7:12 ` lijiang 2019-10-31 3:35 ` [PATCH 2/2 RESEND v8] x86/kdump: clean up all the code related to the backup region Lianbo Jiang 2019-10-31 3:35 ` Lianbo Jiang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191031033517.11282-1-lijiang@redhat.com \ --to=lijiang@redhat.com \ --cc=Thomas.Lendacky@amd.com \ --cc=bhe@redhat.com \ --cc=bp@alien8.de \ --cc=d.hatayama@fujitsu.com \ --cc=dhowells@redhat.com \ --cc=dyoung@redhat.com \ --cc=ebiederm@xmission.com \ --cc=horms@verge.net.au \ --cc=hpa@zytor.com \ --cc=jgross@suse.com \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=tglx@linutronix.de \ --cc=vgoyal@redhat.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.