* [PATCH] mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
@ 2019-10-30 8:08 zhong jiang
2019-10-30 16:22 ` Jakub Kicinski
2019-10-31 8:10 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: zhong jiang @ 2019-10-30 8:08 UTC (permalink / raw)
To: kvalo; +Cc: kubakici, davem, matthias.bgg, linux-wireless, netdev, zhongjiang
It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
operation rather than DEFINE_SIMPLE_ATTRIBUTE.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
drivers/net/wireless/mediatek/mt7601u/debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/mediatek/mt7601u/debugfs.c b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
index 5e54983..300242b 100644
--- a/drivers/net/wireless/mediatek/mt7601u/debugfs.c
+++ b/drivers/net/wireless/mediatek/mt7601u/debugfs.c
@@ -27,7 +27,7 @@
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(fops_regval, mt76_reg_get, mt76_reg_set, "0x%08llx\n");
+DEFINE_DEBUGFS_ATTRIBUTE(fops_regval, mt76_reg_get, mt76_reg_set, "0x%08llx\n");
static int
mt7601u_ampdu_stat_read(struct seq_file *file, void *data)
--
1.7.12.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
2019-10-30 8:08 [PATCH] mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops zhong jiang
@ 2019-10-30 16:22 ` Jakub Kicinski
2019-10-31 8:10 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2019-10-30 16:22 UTC (permalink / raw)
To: zhong jiang; +Cc: kvalo, davem, matthias.bgg, linux-wireless, netdev
On Wed, 30 Oct 2019 16:08:44 +0800, zhong jiang wrote:
> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
> operation rather than DEFINE_SIMPLE_ATTRIBUTE.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
Acked-by: Jakub Kicinski <kubakici@wp.pl>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
2019-10-30 8:08 [PATCH] mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops zhong jiang
2019-10-30 16:22 ` Jakub Kicinski
@ 2019-10-31 8:10 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2019-10-31 8:10 UTC (permalink / raw)
To: zhong jiang
Cc: kubakici, davem, matthias.bgg, linux-wireless, netdev, zhongjiang
zhong jiang <zhongjiang@huawei.com> wrote:
> It is more clear to use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs file
> operation rather than DEFINE_SIMPLE_ATTRIBUTE.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> Acked-by: Jakub Kicinski <kubakici@wp.pl>
Patch applied to wireless-drivers-next.git, thanks.
086ddf860650 mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops
--
https://patchwork.kernel.org/patch/11219173/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-31 8:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 8:08 [PATCH] mt7601u: use DEFINE_DEBUGFS_ATTRIBUTE to define debugfs fops zhong jiang
2019-10-30 16:22 ` Jakub Kicinski
2019-10-31 8:10 ` Kalle Valo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.