All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: "Tu, ShawnX" <shawnx.tu@intel.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"Yeh, Andy" <andy.yeh@intel.com>
Subject: Re: [PATCH v3] hi556: Add support for Hi-556 sensor
Date: Thu, 31 Oct 2019 13:08:36 +0200	[thread overview]
Message-ID: <20191031110836.GJ10211@paasikivi.fi.intel.com> (raw)
In-Reply-To: <55E713954908ED4DB5E8817B2B5C2CDF01123803@PGSMSX107.gar.corp.intel.com>

Hi Shawn,

On Thu, Oct 31, 2019 at 09:53:56AM +0000, Tu, ShawnX wrote:
> Hi Sakari,
> 
> The patch v3 modified & fixed Kconfig conflict issue base latest codebase.

Please avoid top posting.

The Kconfig chunk appears to be the same as in v2.

> 
> Thanks,
> Shawn
> -----Original Message-----
> From: Sakari Ailus [mailto:sakari.ailus@linux.intel.com] 
> Sent: Thursday, October 31, 2019 5:36 PM
> To: Tu, ShawnX <shawnx.tu@intel.com>
> Cc: linux-media@vger.kernel.org; Yeh, Andy <andy.yeh@intel.com>
> Subject: Re: [PATCH v3] hi556: Add support for Hi-556 sensor
> 
> Hi Shawn,
> 
> On Thu, Oct 31, 2019 at 05:18:55PM +0800, Shawnx Tu wrote:
> > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig 
> > index 7eee181..eab4b78 100644
> > --- a/drivers/media/i2c/Kconfig
> > +++ b/drivers/media/i2c/Kconfig
> > @@ -566,6 +566,19 @@ config VIDEO_APTINA_PLL  config VIDEO_SMIAPP_PLL
> >  	tristate
> >  
> > +config VIDEO_HI556
> > +	tristate "Hynix Hi-556 sensor support"
> > +	depends on I2C && VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> > +	depends on MEDIA_CAMERA_SUPPORT
> > +	depends on MEDIA_CONTROLLER
> > +	select V4L2_FWNODE
> > +	help
> > +	  This is a Video4Linux2 sensor driver for the Hynix
> > +	  Hi-556 camera.
> > +
> > +	To compile this driver as a module, choose M here: the
> > +	module will be called hi556.
> > +
> 
> Can you fix the Kconfig issue kbuild bot found?
> 
> --
> Sakari Ailus

-- 
Sakari Ailus

      reply	other threads:[~2019-10-31 11:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-31  9:18 [PATCH v3] hi556: Add support for Hi-556 sensor Shawnx Tu
2019-10-31  9:35 ` Sakari Ailus
2019-10-31  9:53   ` Tu, ShawnX
2019-10-31 11:08     ` Sakari Ailus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191031110836.GJ10211@paasikivi.fi.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=andy.yeh@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=shawnx.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.