From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@lst.de>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
LKML <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org,
Linux PM <linux-pm@vger.kernel.org>,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v2] nvme: Add hardware monitoring support
Date: Thu, 31 Oct 2019 10:54:25 -0700 [thread overview]
Message-ID: <20191031175425.GA25602@roeck-us.net> (raw)
In-Reply-To: <20191031134549.GB4763@lst.de>
On Thu, Oct 31, 2019 at 02:45:49PM +0100, Christoph Hellwig wrote:
> On Wed, Oct 30, 2019 at 07:20:37PM -0700, Guenter Roeck wrote:
> >> The nvme_init_identify() can be called multiple time in nvme ctrl's
> >> lifetime (e.g 'nvme reset /dev/nvme*' or suspend/resume paths), so
> >> should we need to prevent nvme_hwmon_init() from registering hwmon
> >> device more than twice?
> >>
> >> In the nvme thermal zone patchset[1], thernal zone is registered in
> >> nvme_init_identify and unregistered in nvme_stop_ctrl().
> >>
> >
> > Doesn't that mean that the initialization should happen in nvme_start_ctrl()
> > and not here ?
>
> I think calling it from nvme_init_identify is fine, it just needs to
> be in the "if (!ctrl->identified)" section of that function.
Excellent, I'll do that. Thanks a lot for the hint!
Guenter
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: Christoph Hellwig <hch@lst.de>
Cc: Sagi Grimberg <sagi@grimberg.me>,
Linux PM <linux-pm@vger.kernel.org>,
Akinobu Mita <akinobu.mita@gmail.com>,
linux-nvme@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@fb.com>,
Keith Busch <kbusch@kernel.org>, Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v2] nvme: Add hardware monitoring support
Date: Thu, 31 Oct 2019 10:54:25 -0700 [thread overview]
Message-ID: <20191031175425.GA25602@roeck-us.net> (raw)
In-Reply-To: <20191031134549.GB4763@lst.de>
On Thu, Oct 31, 2019 at 02:45:49PM +0100, Christoph Hellwig wrote:
> On Wed, Oct 30, 2019 at 07:20:37PM -0700, Guenter Roeck wrote:
> >> The nvme_init_identify() can be called multiple time in nvme ctrl's
> >> lifetime (e.g 'nvme reset /dev/nvme*' or suspend/resume paths), so
> >> should we need to prevent nvme_hwmon_init() from registering hwmon
> >> device more than twice?
> >>
> >> In the nvme thermal zone patchset[1], thernal zone is registered in
> >> nvme_init_identify and unregistered in nvme_stop_ctrl().
> >>
> >
> > Doesn't that mean that the initialization should happen in nvme_start_ctrl()
> > and not here ?
>
> I think calling it from nvme_init_identify is fine, it just needs to
> be in the "if (!ctrl->identified)" section of that function.
Excellent, I'll do that. Thanks a lot for the hint!
Guenter
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-10-31 17:54 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 22:32 [PATCH v2] nvme: Add hardware monitoring support Guenter Roeck
2019-10-29 22:32 ` Guenter Roeck
2019-10-30 0:53 ` Keith Busch
2019-10-30 0:53 ` Keith Busch
2019-11-06 21:29 ` Pavel Machek
2019-11-06 21:29 ` Pavel Machek
2019-11-06 22:30 ` Guenter Roeck
2019-11-06 22:30 ` Guenter Roeck
2019-11-06 23:58 ` Chris Healy
2019-11-06 23:58 ` Chris Healy
2019-10-30 11:16 ` Akinobu Mita
2019-10-30 11:16 ` Akinobu Mita
2019-10-30 14:05 ` Christoph Hellwig
2019-10-30 14:05 ` Christoph Hellwig
2019-10-31 2:54 ` Guenter Roeck
2019-10-31 2:54 ` Guenter Roeck
2019-10-31 13:46 ` Christoph Hellwig
2019-10-31 13:46 ` Christoph Hellwig
2019-10-31 13:46 ` Akinobu Mita
2019-10-31 13:46 ` Akinobu Mita
2019-10-31 2:20 ` Guenter Roeck
2019-10-31 2:20 ` Guenter Roeck
2019-10-31 13:44 ` Akinobu Mita
2019-10-31 13:44 ` Akinobu Mita
2019-10-31 13:45 ` Christoph Hellwig
2019-10-31 13:45 ` Christoph Hellwig
2019-10-31 17:54 ` Guenter Roeck [this message]
2019-10-31 17:54 ` Guenter Roeck
2019-10-30 14:12 ` Christoph Hellwig
2019-10-30 14:12 ` Christoph Hellwig
2019-10-30 23:40 ` Chris Healy
2019-10-30 23:40 ` Chris Healy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031175425.GA25602@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akinobu.mita@gmail.com \
--cc=axboe@fb.com \
--cc=cphealy@gmail.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.