From: <Ludovic.Desroches@microchip.com> To: <Codrin.Ciubotariu@microchip.com> Cc: <linux-arm-kernel@lists.infradead.org>, <linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>, <linus.walleij@linaro.org>, <Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <robh+dt@kernel.org>, <Claudiu.Beznea@microchip.com> Subject: Re: [PATCH v2] pinctrl: at91: Enable slewrate by default on SAM9X60 Date: Fri, 1 Nov 2019 14:26:09 +0000 [thread overview] Message-ID: <20191101142602.voj2jeexvvgwgr23@M43218.corp.atmel.com> (raw) In-Reply-To: <20191101092031.24896-1-codrin.ciubotariu@microchip.com> On Fri, Nov 01, 2019 at 11:20:31AM +0200, Codrin Ciubotariu wrote: > On SAM9X60, slewrate should be enabled on pins with a switching frequency > below 50Mhz. Since most of our pins do not exceed this value, we enable > slewrate by default. Pins with a switching value that exceeds 50Mhz will > have to explicitly disable slewrate. > > This patch changes the ABI. However, the slewrate macros are only used > by SAM9X60 and, at this moment, there are no device-tree files available > for this platform. > > Suggested-by: Ludovic Desroches <ludovic.desroches@microchip.com> > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> Thanks > --- > > Changes in v2: > - updated commit message to reflect the ABI change > > drivers/pinctrl/pinctrl-at91.c | 4 ++-- > include/dt-bindings/pinctrl/at91.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > index 117075b5798f..c135149e84e9 100644 > --- a/drivers/pinctrl/pinctrl-at91.c > +++ b/drivers/pinctrl/pinctrl-at91.c > @@ -85,8 +85,8 @@ enum drive_strength_bit { > DRIVE_STRENGTH_SHIFT) > > enum slewrate_bit { > - SLEWRATE_BIT_DIS, > SLEWRATE_BIT_ENA, > + SLEWRATE_BIT_DIS, > }; > > #define SLEWRATE_BIT_MSK(name) (SLEWRATE_BIT_##name << SLEWRATE_SHIFT) > @@ -669,7 +669,7 @@ static void at91_mux_sam9x60_set_slewrate(void __iomem *pio, unsigned pin, > { > unsigned int tmp; > > - if (setting < SLEWRATE_BIT_DIS || setting > SLEWRATE_BIT_ENA) > + if (setting < SLEWRATE_BIT_ENA || setting > SLEWRATE_BIT_DIS) > return; > > tmp = readl_relaxed(pio + SAM9X60_PIO_SLEWR); > diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h > index 3831f91fb3ba..e8e117306b1b 100644 > --- a/include/dt-bindings/pinctrl/at91.h > +++ b/include/dt-bindings/pinctrl/at91.h > @@ -27,8 +27,8 @@ > #define AT91_PINCTRL_DRIVE_STRENGTH_MED (0x2 << 5) > #define AT91_PINCTRL_DRIVE_STRENGTH_HI (0x3 << 5) > > -#define AT91_PINCTRL_SLEWRATE_DIS (0x0 << 9) > -#define AT91_PINCTRL_SLEWRATE_ENA (0x1 << 9) > +#define AT91_PINCTRL_SLEWRATE_ENA (0x0 << 9) > +#define AT91_PINCTRL_SLEWRATE_DIS (0x1 << 9) > > #define AT91_PIOA 0 > #define AT91_PIOB 1 > -- > 2.20.1 >
WARNING: multiple messages have this Message-ID (diff)
From: <Ludovic.Desroches@microchip.com> To: <Codrin.Ciubotariu@microchip.com> Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] pinctrl: at91: Enable slewrate by default on SAM9X60 Date: Fri, 1 Nov 2019 14:26:09 +0000 [thread overview] Message-ID: <20191101142602.voj2jeexvvgwgr23@M43218.corp.atmel.com> (raw) In-Reply-To: <20191101092031.24896-1-codrin.ciubotariu@microchip.com> On Fri, Nov 01, 2019 at 11:20:31AM +0200, Codrin Ciubotariu wrote: > On SAM9X60, slewrate should be enabled on pins with a switching frequency > below 50Mhz. Since most of our pins do not exceed this value, we enable > slewrate by default. Pins with a switching value that exceeds 50Mhz will > have to explicitly disable slewrate. > > This patch changes the ABI. However, the slewrate macros are only used > by SAM9X60 and, at this moment, there are no device-tree files available > for this platform. > > Suggested-by: Ludovic Desroches <ludovic.desroches@microchip.com> > Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com> Thanks > --- > > Changes in v2: > - updated commit message to reflect the ABI change > > drivers/pinctrl/pinctrl-at91.c | 4 ++-- > include/dt-bindings/pinctrl/at91.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drivers/pinctrl/pinctrl-at91.c > index 117075b5798f..c135149e84e9 100644 > --- a/drivers/pinctrl/pinctrl-at91.c > +++ b/drivers/pinctrl/pinctrl-at91.c > @@ -85,8 +85,8 @@ enum drive_strength_bit { > DRIVE_STRENGTH_SHIFT) > > enum slewrate_bit { > - SLEWRATE_BIT_DIS, > SLEWRATE_BIT_ENA, > + SLEWRATE_BIT_DIS, > }; > > #define SLEWRATE_BIT_MSK(name) (SLEWRATE_BIT_##name << SLEWRATE_SHIFT) > @@ -669,7 +669,7 @@ static void at91_mux_sam9x60_set_slewrate(void __iomem *pio, unsigned pin, > { > unsigned int tmp; > > - if (setting < SLEWRATE_BIT_DIS || setting > SLEWRATE_BIT_ENA) > + if (setting < SLEWRATE_BIT_ENA || setting > SLEWRATE_BIT_DIS) > return; > > tmp = readl_relaxed(pio + SAM9X60_PIO_SLEWR); > diff --git a/include/dt-bindings/pinctrl/at91.h b/include/dt-bindings/pinctrl/at91.h > index 3831f91fb3ba..e8e117306b1b 100644 > --- a/include/dt-bindings/pinctrl/at91.h > +++ b/include/dt-bindings/pinctrl/at91.h > @@ -27,8 +27,8 @@ > #define AT91_PINCTRL_DRIVE_STRENGTH_MED (0x2 << 5) > #define AT91_PINCTRL_DRIVE_STRENGTH_HI (0x3 << 5) > > -#define AT91_PINCTRL_SLEWRATE_DIS (0x0 << 9) > -#define AT91_PINCTRL_SLEWRATE_ENA (0x1 << 9) > +#define AT91_PINCTRL_SLEWRATE_ENA (0x0 << 9) > +#define AT91_PINCTRL_SLEWRATE_DIS (0x1 << 9) > > #define AT91_PIOA 0 > #define AT91_PIOB 1 > -- > 2.20.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-11-01 14:26 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-01 9:20 [PATCH v2] pinctrl: at91: Enable slewrate by default on SAM9X60 Codrin Ciubotariu 2019-11-01 9:20 ` Codrin Ciubotariu 2019-11-01 14:26 ` Ludovic.Desroches [this message] 2019-11-01 14:26 ` Ludovic.Desroches 2019-11-01 22:26 ` Claudiu.Beznea 2019-11-01 22:26 ` Claudiu.Beznea 2019-11-03 22:35 ` Linus Walleij 2019-11-03 22:35 ` Linus Walleij
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191101142602.voj2jeexvvgwgr23@M43218.corp.atmel.com \ --to=ludovic.desroches@microchip.com \ --cc=Claudiu.Beznea@microchip.com \ --cc=Codrin.Ciubotariu@microchip.com \ --cc=Nicolas.Ferre@microchip.com \ --cc=alexandre.belloni@bootlin.com \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.