* [PATCH] gpu: ipu-v3: prg: add missed clk_disable_unprepare in remove
@ 2019-11-01 14:38 ` Chuhong Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-01 14:38 UTC (permalink / raw)
Cc: Philipp Zabel, dri-devel, linux-kernel, Chuhong Yuan
The driver forgets to disable and unprepare clks when remove.
Add the calls to clk_disable_unprepare to fix the problem.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/gpu/ipu-v3/ipu-prg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
index 196797c1b4b3..6ae6d634c983 100644
--- a/drivers/gpu/ipu-v3/ipu-prg.c
+++ b/drivers/gpu/ipu-v3/ipu-prg.c
@@ -430,6 +430,8 @@ static int ipu_prg_remove(struct platform_device *pdev)
list_del(&prg->list);
mutex_unlock(&ipu_prg_list_mutex);
+ clk_disable_unprepare(prg->clk_axi);
+ clk_disable_unprepare(prg->clk_ipg);
return 0;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] gpu: ipu-v3: prg: add missed clk_disable_unprepare in remove
@ 2019-11-01 14:38 ` Chuhong Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-01 14:38 UTC (permalink / raw)
Cc: Philipp Zabel, dri-devel, linux-kernel, Chuhong Yuan
The driver forgets to disable and unprepare clks when remove.
Add the calls to clk_disable_unprepare to fix the problem.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/gpu/ipu-v3/ipu-prg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
index 196797c1b4b3..6ae6d634c983 100644
--- a/drivers/gpu/ipu-v3/ipu-prg.c
+++ b/drivers/gpu/ipu-v3/ipu-prg.c
@@ -430,6 +430,8 @@ static int ipu_prg_remove(struct platform_device *pdev)
list_del(&prg->list);
mutex_unlock(&ipu_prg_list_mutex);
+ clk_disable_unprepare(prg->clk_axi);
+ clk_disable_unprepare(prg->clk_ipg);
return 0;
}
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] gpu: ipu-v3: prg: add missed clk_disable_unprepare in remove
@ 2019-11-01 14:38 ` Chuhong Yuan
0 siblings, 0 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-11-01 14:38 UTC (permalink / raw)
Cc: Chuhong Yuan, dri-devel, linux-kernel
The driver forgets to disable and unprepare clks when remove.
Add the calls to clk_disable_unprepare to fix the problem.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/gpu/ipu-v3/ipu-prg.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/ipu-v3/ipu-prg.c b/drivers/gpu/ipu-v3/ipu-prg.c
index 196797c1b4b3..6ae6d634c983 100644
--- a/drivers/gpu/ipu-v3/ipu-prg.c
+++ b/drivers/gpu/ipu-v3/ipu-prg.c
@@ -430,6 +430,8 @@ static int ipu_prg_remove(struct platform_device *pdev)
list_del(&prg->list);
mutex_unlock(&ipu_prg_list_mutex);
+ clk_disable_unprepare(prg->clk_axi);
+ clk_disable_unprepare(prg->clk_ipg);
return 0;
}
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-01 22:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-01 14:38 [PATCH] gpu: ipu-v3: prg: add missed clk_disable_unprepare in remove Chuhong Yuan
2019-11-01 14:38 ` Chuhong Yuan
2019-11-01 14:38 ` Chuhong Yuan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.