* [PATCH] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 18:18 ` Chris Wilson
0 siblings, 0 replies; 21+ messages in thread
From: Chris Wilson @ 2019-11-01 18:18 UTC (permalink / raw)
To: intel-gfx
Avoid
drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
simply by inverting the predicate and reversing the ternary.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 6e35b9255882..acd65da50651 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -2441,12 +2441,12 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
_MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
/*
- * If the user didn't require OA reports, instruct the
- * hardware not to emit ctx switch reports.
+ * If the user didn't require OA reports, instruct
+ * the hardware not to emit ctx switch reports.
*/
- !(stream->sample_flags & SAMPLE_OA_REPORT) ?
- _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
- _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
+ (stream->sample_flags & SAMPLE_OA_REPORT) ?
+ _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
+ _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
(GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
--
2.24.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 18:18 ` Chris Wilson
0 siblings, 0 replies; 21+ messages in thread
From: Chris Wilson @ 2019-11-01 18:18 UTC (permalink / raw)
To: intel-gfx
Avoid
drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
simply by inverting the predicate and reversing the ternary.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index 6e35b9255882..acd65da50651 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -2441,12 +2441,12 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
_MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
/*
- * If the user didn't require OA reports, instruct the
- * hardware not to emit ctx switch reports.
+ * If the user didn't require OA reports, instruct
+ * the hardware not to emit ctx switch reports.
*/
- !(stream->sample_flags & SAMPLE_OA_REPORT) ?
- _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
- _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
+ (stream->sample_flags & SAMPLE_OA_REPORT) ?
+ _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
+ _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
(GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
--
2.24.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 18:23 ` Lionel Landwerlin
0 siblings, 0 replies; 21+ messages in thread
From: Lionel Landwerlin @ 2019-11-01 18:23 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 01/11/2019 20:18, Chris Wilson wrote:
> Avoid
>
> drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
>
> simply by inverting the predicate and reversing the ternary.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Thanks a lot,
-Lionel
> ---
> drivers/gpu/drm/i915/i915_perf.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 6e35b9255882..acd65da50651 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -2441,12 +2441,12 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
> _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
> GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
> /*
> - * If the user didn't require OA reports, instruct the
> - * hardware not to emit ctx switch reports.
> + * If the user didn't require OA reports, instruct
> + * the hardware not to emit ctx switch reports.
> */
> - !(stream->sample_flags & SAMPLE_OA_REPORT) ?
> - _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
> - _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
> + (stream->sample_flags & SAMPLE_OA_REPORT) ?
> + _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
> + _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
>
> intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
> (GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 18:23 ` Lionel Landwerlin
0 siblings, 0 replies; 21+ messages in thread
From: Lionel Landwerlin @ 2019-11-01 18:23 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 01/11/2019 20:18, Chris Wilson wrote:
> Avoid
>
> drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
>
> simply by inverting the predicate and reversing the ternary.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Thanks a lot,
-Lionel
> ---
> drivers/gpu/drm/i915/i915_perf.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
> index 6e35b9255882..acd65da50651 100644
> --- a/drivers/gpu/drm/i915/i915_perf.c
> +++ b/drivers/gpu/drm/i915/i915_perf.c
> @@ -2441,12 +2441,12 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
> _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
> GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
> /*
> - * If the user didn't require OA reports, instruct the
> - * hardware not to emit ctx switch reports.
> + * If the user didn't require OA reports, instruct
> + * the hardware not to emit ctx switch reports.
> */
> - !(stream->sample_flags & SAMPLE_OA_REPORT) ?
> - _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
> - _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
> + (stream->sample_flags & SAMPLE_OA_REPORT) ?
> + _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
> + _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
>
> intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
> (GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 19:12 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 21+ messages in thread
From: Umesh Nerlige Ramappa @ 2019-11-01 19:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Nov 01, 2019 at 06:18:20PM +0000, Chris Wilson wrote:
>Avoid
>
>drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
>
>simply by inverting the predicate and reversing the ternary.
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>---
> drivers/gpu/drm/i915/i915_perf.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>index 6e35b9255882..acd65da50651 100644
>--- a/drivers/gpu/drm/i915/i915_perf.c
>+++ b/drivers/gpu/drm/i915/i915_perf.c
>@@ -2441,12 +2441,12 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
> _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
> GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
> /*
>- * If the user didn't require OA reports, instruct the
>- * hardware not to emit ctx switch reports.
>+ * If the user didn't require OA reports, instruct
>+ * the hardware not to emit ctx switch reports.
> */
>- !(stream->sample_flags & SAMPLE_OA_REPORT) ?
>- _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
>- _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
>+ (stream->sample_flags & SAMPLE_OA_REPORT) ?
>+ _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
>+ _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
oops, missed that one.
I thought sparse flagged it because of missing braces ("|" precedes "?:"
).
Maybe expecting another brace around the ternary - more like this?
+ ((stream->sample_flags & SAMPLE_OA_REPORT) ?
+ _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
+ _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS)));
Thanks,
Umesh
>
> intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
> (GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
>--
>2.24.0.rc2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 19:12 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 21+ messages in thread
From: Umesh Nerlige Ramappa @ 2019-11-01 19:12 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Nov 01, 2019 at 06:18:20PM +0000, Chris Wilson wrote:
>Avoid
>
>drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
>
>simply by inverting the predicate and reversing the ternary.
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>---
> drivers/gpu/drm/i915/i915_perf.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>index 6e35b9255882..acd65da50651 100644
>--- a/drivers/gpu/drm/i915/i915_perf.c
>+++ b/drivers/gpu/drm/i915/i915_perf.c
>@@ -2441,12 +2441,12 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
> _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
> GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
> /*
>- * If the user didn't require OA reports, instruct the
>- * hardware not to emit ctx switch reports.
>+ * If the user didn't require OA reports, instruct
>+ * the hardware not to emit ctx switch reports.
> */
>- !(stream->sample_flags & SAMPLE_OA_REPORT) ?
>- _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
>- _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
>+ (stream->sample_flags & SAMPLE_OA_REPORT) ?
>+ _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
>+ _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
oops, missed that one.
I thought sparse flagged it because of missing braces ("|" precedes "?:"
).
Maybe expecting another brace around the ternary - more like this?
+ ((stream->sample_flags & SAMPLE_OA_REPORT) ?
+ _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
+ _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS)));
Thanks,
Umesh
>
> intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
> (GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
>--
>2.24.0.rc2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 19:21 ` Chris Wilson
0 siblings, 0 replies; 21+ messages in thread
From: Chris Wilson @ 2019-11-01 19:21 UTC (permalink / raw)
To: intel-gfx
Avoid
drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
simply by inverting the predicate and reversing the ternary.
v2: More the long lines into their own function so there is no confusion
on operator precedence.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index a8c2318d3d5e..1fd6bac8a4fe 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -2428,6 +2428,13 @@ static int gen8_enable_metric_set(struct i915_perf_stream *stream)
return emit_oa_config(stream, oa_config, oa_context(stream));
}
+static u32 report_ctx_switches(const struct i915_perf_stream *stream)
+{
+ return _MASKED_FIELD(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS,
+ (stream->sample_flags & SAMPLE_OA_REPORT) ?
+ 0 : GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS);
+}
+
static int gen12_enable_metric_set(struct i915_perf_stream *stream)
{
struct intel_uncore *uncore = stream->uncore;
@@ -2441,12 +2448,10 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
_MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
/*
- * If the user didn't require OA reports, instruct the
- * hardware not to emit ctx switch reports.
+ * If the user didn't require OA reports, instruct
+ * the hardware not to emit ctx switch reports.
*/
- !(stream->sample_flags & SAMPLE_OA_REPORT) ?
- _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
- _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
+ report_ctx_switches(stream));
intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
(GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
--
2.24.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH v2] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 19:21 ` Chris Wilson
0 siblings, 0 replies; 21+ messages in thread
From: Chris Wilson @ 2019-11-01 19:21 UTC (permalink / raw)
To: intel-gfx
Avoid
drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
simply by inverting the predicate and reversing the ternary.
v2: More the long lines into their own function so there is no confusion
on operator precedence.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
---
drivers/gpu/drm/i915/i915_perf.c | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
index a8c2318d3d5e..1fd6bac8a4fe 100644
--- a/drivers/gpu/drm/i915/i915_perf.c
+++ b/drivers/gpu/drm/i915/i915_perf.c
@@ -2428,6 +2428,13 @@ static int gen8_enable_metric_set(struct i915_perf_stream *stream)
return emit_oa_config(stream, oa_config, oa_context(stream));
}
+static u32 report_ctx_switches(const struct i915_perf_stream *stream)
+{
+ return _MASKED_FIELD(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS,
+ (stream->sample_flags & SAMPLE_OA_REPORT) ?
+ 0 : GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS);
+}
+
static int gen12_enable_metric_set(struct i915_perf_stream *stream)
{
struct intel_uncore *uncore = stream->uncore;
@@ -2441,12 +2448,10 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
_MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
/*
- * If the user didn't require OA reports, instruct the
- * hardware not to emit ctx switch reports.
+ * If the user didn't require OA reports, instruct
+ * the hardware not to emit ctx switch reports.
*/
- !(stream->sample_flags & SAMPLE_OA_REPORT) ?
- _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
- _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
+ report_ctx_switches(stream));
intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
(GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
--
2.24.0.rc2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v2] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 19:31 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 21+ messages in thread
From: Umesh Nerlige Ramappa @ 2019-11-01 19:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Nov 01, 2019 at 07:21:16PM +0000, Chris Wilson wrote:
>Avoid
>
>drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
>
>simply by inverting the predicate and reversing the ternary.
>
>v2: More the long lines into their own function so there is no confusion
>on operator precedence.
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Thanks,
Umesh
>---
> drivers/gpu/drm/i915/i915_perf.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>index a8c2318d3d5e..1fd6bac8a4fe 100644
>--- a/drivers/gpu/drm/i915/i915_perf.c
>+++ b/drivers/gpu/drm/i915/i915_perf.c
>@@ -2428,6 +2428,13 @@ static int gen8_enable_metric_set(struct i915_perf_stream *stream)
> return emit_oa_config(stream, oa_config, oa_context(stream));
> }
>
>+static u32 report_ctx_switches(const struct i915_perf_stream *stream)
>+{
>+ return _MASKED_FIELD(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS,
>+ (stream->sample_flags & SAMPLE_OA_REPORT) ?
>+ 0 : GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS);
>+}
>+
> static int gen12_enable_metric_set(struct i915_perf_stream *stream)
> {
> struct intel_uncore *uncore = stream->uncore;
>@@ -2441,12 +2448,10 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
> _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
> GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
> /*
>- * If the user didn't require OA reports, instruct the
>- * hardware not to emit ctx switch reports.
>+ * If the user didn't require OA reports, instruct
>+ * the hardware not to emit ctx switch reports.
> */
>- !(stream->sample_flags & SAMPLE_OA_REPORT) ?
>- _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
>- _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
>+ report_ctx_switches(stream));
>
> intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
> (GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
>--
>2.24.0.rc2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH v2] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-11-01 19:31 ` Umesh Nerlige Ramappa
0 siblings, 0 replies; 21+ messages in thread
From: Umesh Nerlige Ramappa @ 2019-11-01 19:31 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Nov 01, 2019 at 07:21:16PM +0000, Chris Wilson wrote:
>Avoid
>
>drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
>
>simply by inverting the predicate and reversing the ternary.
>
>v2: More the long lines into their own function so there is no confusion
>on operator precedence.
>
>Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
>Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Thanks,
Umesh
>---
> drivers/gpu/drm/i915/i915_perf.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c
>index a8c2318d3d5e..1fd6bac8a4fe 100644
>--- a/drivers/gpu/drm/i915/i915_perf.c
>+++ b/drivers/gpu/drm/i915/i915_perf.c
>@@ -2428,6 +2428,13 @@ static int gen8_enable_metric_set(struct i915_perf_stream *stream)
> return emit_oa_config(stream, oa_config, oa_context(stream));
> }
>
>+static u32 report_ctx_switches(const struct i915_perf_stream *stream)
>+{
>+ return _MASKED_FIELD(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS,
>+ (stream->sample_flags & SAMPLE_OA_REPORT) ?
>+ 0 : GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS);
>+}
>+
> static int gen12_enable_metric_set(struct i915_perf_stream *stream)
> {
> struct intel_uncore *uncore = stream->uncore;
>@@ -2441,12 +2448,10 @@ static int gen12_enable_metric_set(struct i915_perf_stream *stream)
> _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CLK_RATIO_REPORTS |
> GEN12_OAG_OA_DEBUG_INCLUDE_CLK_RATIO) |
> /*
>- * If the user didn't require OA reports, instruct the
>- * hardware not to emit ctx switch reports.
>+ * If the user didn't require OA reports, instruct
>+ * the hardware not to emit ctx switch reports.
> */
>- !(stream->sample_flags & SAMPLE_OA_REPORT) ?
>- _MASKED_BIT_ENABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS) :
>- _MASKED_BIT_DISABLE(GEN12_OAG_OA_DEBUG_DISABLE_CTX_SWITCH_REPORTS));
>+ report_ctx_switches(stream));
>
> intel_uncore_write(uncore, GEN12_OAG_OAGLBCTXCTRL, periodic ?
> (GEN12_OAG_OAGLBCTXCTRL_COUNTER_RESUME |
>--
>2.24.0.rc2
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
@ 2019-11-01 19:36 ` Patchwork
0 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-11-01 19:36 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
URL : https://patchwork.freedesktop.org/series/68883/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
740c721e020f drm/i915/perf: Reverse a ternary to make sparse happy
-:4: WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it
#4:
Subject: [PATCH] drm/i915/perf: Reverse a ternary to make sparse happy
total: 0 errors, 1 warnings, 0 checks, 28 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
@ 2019-11-01 19:36 ` Patchwork
0 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-11-01 19:36 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
URL : https://patchwork.freedesktop.org/series/68883/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
740c721e020f drm/i915/perf: Reverse a ternary to make sparse happy
-:4: WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it
#4:
Subject: [PATCH] drm/i915/perf: Reverse a ternary to make sparse happy
total: 0 errors, 1 warnings, 0 checks, 28 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* ✗ Fi.CI.SPARSE: warning for drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
@ 2019-11-01 19:37 ` Patchwork
0 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-11-01 19:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
URL : https://patchwork.freedesktop.org/series/68883/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915/perf: Reverse a ternary to make sparse happy
-O:drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
@ 2019-11-01 19:37 ` Patchwork
0 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-11-01 19:37 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
URL : https://patchwork.freedesktop.org/series/68883/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.6.0
Commit: drm/i915/perf: Reverse a ternary to make sparse happy
-O:drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
@ 2019-11-01 20:11 ` Patchwork
0 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-11-01 20:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
URL : https://patchwork.freedesktop.org/series/68883/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7242 -> Patchwork_15113
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/index.html
Known issues
------------
Here are the changes found in Patchwork_15113 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@basic:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724] / [fdo#112052 ])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-u3/igt@gem_flink_basic@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-icl-u3/igt@gem_flink_basic@basic.html
* igt@i915_selftest@live_blt:
- fi-bsw-n3050: [PASS][3] -> [DMESG-FAIL][4] ([fdo#112176])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-bsw-n3050/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-bsw-n3050/igt@i915_selftest@live_blt.html
#### Possible fixes ####
* igt@gem_ctx_switch@rcs0:
- {fi-icl-y}: [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-y/igt@gem_ctx_switch@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-icl-y/igt@gem_ctx_switch@rcs0.html
* igt@gem_sync@basic-many-each:
- {fi-tgl-u}: [INCOMPLETE][7] ([fdo#111880] / [fdo#111998]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-tgl-u/igt@gem_sync@basic-many-each.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-tgl-u/igt@gem_sync@basic-many-each.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([fdo#111407]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@prime_vgem@basic-fence-flip:
- fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
[fdo#111998]: https://bugs.freedesktop.org/show_bug.cgi?id=111998
[fdo#112052 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112052
[fdo#112176]: https://bugs.freedesktop.org/show_bug.cgi?id=112176
Participating hosts (51 -> 44)
------------------------------
Additional (1): fi-skl-6600u
Missing (8): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-gdg-551 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7242 -> Patchwork_15113
CI-20190529: 20190529
CI_DRM_7242: 6cc1e34e4202cb6cfd4994e37414a34939eae4a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5258: c8a88b614ac057b01809a17b9e87a197195b44ad @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15113: 740c721e020fc22a40c80b2e0b1152d963cdc6ca @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
740c721e020f drm/i915/perf: Reverse a ternary to make sparse happy
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
@ 2019-11-01 20:11 ` Patchwork
0 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-11-01 20:11 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
URL : https://patchwork.freedesktop.org/series/68883/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_7242 -> Patchwork_15113
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/index.html
Known issues
------------
Here are the changes found in Patchwork_15113 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_flink_basic@basic:
- fi-icl-u3: [PASS][1] -> [DMESG-WARN][2] ([fdo#107724] / [fdo#112052 ])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-u3/igt@gem_flink_basic@basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-icl-u3/igt@gem_flink_basic@basic.html
* igt@i915_selftest@live_blt:
- fi-bsw-n3050: [PASS][3] -> [DMESG-FAIL][4] ([fdo#112176])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-bsw-n3050/igt@i915_selftest@live_blt.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-bsw-n3050/igt@i915_selftest@live_blt.html
#### Possible fixes ####
* igt@gem_ctx_switch@rcs0:
- {fi-icl-y}: [INCOMPLETE][5] ([fdo#107713]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-y/igt@gem_ctx_switch@rcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-icl-y/igt@gem_ctx_switch@rcs0.html
* igt@gem_sync@basic-many-each:
- {fi-tgl-u}: [INCOMPLETE][7] ([fdo#111880] / [fdo#111998]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-tgl-u/igt@gem_sync@basic-many-each.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-tgl-u/igt@gem_sync@basic-many-each.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([fdo#111407]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@prime_vgem@basic-fence-flip:
- fi-icl-u3: [DMESG-WARN][11] ([fdo#107724]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/fi-icl-u3/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#111880]: https://bugs.freedesktop.org/show_bug.cgi?id=111880
[fdo#111998]: https://bugs.freedesktop.org/show_bug.cgi?id=111998
[fdo#112052 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112052
[fdo#112176]: https://bugs.freedesktop.org/show_bug.cgi?id=112176
Participating hosts (51 -> 44)
------------------------------
Additional (1): fi-skl-6600u
Missing (8): fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-gdg-551 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* Linux: CI_DRM_7242 -> Patchwork_15113
CI-20190529: 20190529
CI_DRM_7242: 6cc1e34e4202cb6cfd4994e37414a34939eae4a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5258: c8a88b614ac057b01809a17b9e87a197195b44ad @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_15113: 740c721e020fc22a40c80b2e0b1152d963cdc6ca @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
740c721e020f drm/i915/perf: Reverse a ternary to make sparse happy
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* ✗ Fi.CI.IGT: failure for drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
@ 2019-11-03 7:35 ` Patchwork
0 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-11-03 7:35 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
URL : https://patchwork.freedesktop.org/series/68883/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7242_full -> Patchwork_15113_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15113_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15113_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15113_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb7/igt@gem_eio@in-flight-contexts-10ms.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb6/igt@gem_eio@in-flight-contexts-10ms.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_ctx_persistence@processes}:
- shard-apl: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl6/igt@gem_ctx_persistence@processes.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl7/igt@gem_ctx_persistence@processes.html
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- {shard-tglb}: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb8/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html
Known issues
------------
Here are the changes found in Patchwork_15113_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276] / [fdo#112080]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@gem_ctx_isolation@vcs1-none.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#110841])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#112146]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@gem_exec_schedule@in-order-bsd.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb2/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#109276]) +18 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb5/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-snb: [PASS][14] -> [TIMEOUT][15] ([fdo#112068 ])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb7/igt@gem_persistent_relocs@forked-thrash-inactive.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb5/igt@gem_persistent_relocs@forked-thrash-inactive.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][16] -> [DMESG-WARN][17] ([fdo#111870])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [PASS][18] -> [DMESG-FAIL][19] ([fdo#111991])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw2/igt@i915_selftest@live_hangcheck.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw1/igt@i915_selftest@live_hangcheck.html
* igt@i915_selftest@mock_requests:
- shard-glk: [PASS][20] -> [INCOMPLETE][21] ([fdo#103359] / [k.org#198133])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-glk2/igt@i915_selftest@mock_requests.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-glk9/igt@i915_selftest@mock_requests.html
* igt@kms_color@pipe-b-legacy-gamma:
- shard-kbl: [PASS][22] -> [FAIL][23] ([fdo#104782])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl4/igt@kms_color@pipe-b-legacy-gamma.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-kbl7/igt@kms_color@pipe-b-legacy-gamma.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][24] -> [FAIL][25] ([fdo#103167]) +6 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][26] -> [DMESG-WARN][27] ([fdo#108566]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][28] -> [SKIP][29] ([fdo#109441]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][30] -> [SKIP][31] ([fdo#112080]) +11 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb6/igt@perf_pmu@busy-no-semaphores-vcs1.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- {shard-tglb}: [INCOMPLETE][32] ([fdo#111832]) -> [PASS][33] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb2/igt@gem_ctx_isolation@bcs0-s3.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb8/igt@gem_ctx_isolation@bcs0-s3.html
* {igt@gem_ctx_persistence@vcs1-cleanup}:
- shard-iclb: [SKIP][34] ([fdo#109276] / [fdo#112080]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@gem_ctx_persistence@vcs1-cleanup.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@gem_ctx_persistence@vcs1-cleanup.html
* {igt@gem_ctx_persistence@vecs0-mixed-process}:
- {shard-tglb}: [FAIL][36] -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb3/igt@gem_ctx_persistence@vecs0-mixed-process.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb5/igt@gem_ctx_persistence@vecs0-mixed-process.html
* igt@gem_ctx_switch@queue-light:
- {shard-tglb}: [INCOMPLETE][38] ([fdo#111672]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb6/igt@gem_ctx_switch@queue-light.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb1/igt@gem_ctx_switch@queue-light.html
* igt@gem_eio@in-flight-suspend:
- {shard-tglb}: [INCOMPLETE][40] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb2/igt@gem_eio@in-flight-suspend.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb8/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][42] ([fdo#109661]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb5/igt@gem_eio@unwedge-stress.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][44] ([fdo#112080]) -> [PASS][45] +11 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@gem_exec_parallel@vcs1-fds.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preempt-queue-bsd:
- shard-iclb: [SKIP][46] ([fdo#112146]) -> [PASS][47] +8 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [TIMEOUT][48] ([fdo#112068 ]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb3/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-snb: [FAIL][50] ([fdo#112037]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [DMESG-WARN][52] ([fdo#111870]) -> [PASS][53] +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [DMESG-WARN][54] ([fdo#111870]) -> [PASS][55] +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_selftest@mock_requests:
- shard-skl: [INCOMPLETE][56] -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl8/igt@i915_selftest@mock_requests.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl6/igt@i915_selftest@mock_requests.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- {shard-tglb}: [INCOMPLETE][58] ([fdo#111832] / [fdo#111850]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb1/igt@i915_suspend@fence-restore-tiled2untiled.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb5/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][60] ([fdo#108566]) -> [PASS][61] +6 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl6/igt@i915_suspend@sysfs-reader.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl2/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding:
- shard-skl: [FAIL][62] ([fdo#103232]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][64] ([fdo#105767]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
- shard-skl: [FAIL][66] ([fdo#103184] / [fdo#103232]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl10/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html
* igt@kms_flip@flip-vs-dpms-off-vs-modeset:
- shard-apl: [INCOMPLETE][68] ([fdo#103927]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl2/igt@kms_flip@flip-vs-dpms-off-vs-modeset.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl1/igt@kms_flip@flip-vs-dpms-off-vs-modeset.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [FAIL][70] ([fdo#103167]) -> [PASS][71] +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
- {shard-tglb}: [FAIL][72] ([fdo#103167]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-FAIL][74] ([fdo#103375] / [fdo#108566]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][76] ([fdo#108145] / [fdo#110403]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][78] ([fdo#108145]) -> [PASS][79] +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][80] ([fdo#109441]) -> [PASS][81] +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_cpu.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][82] ([fdo#99912]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl2/igt@kms_setmode@basic.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl6/igt@kms_setmode@basic.html
- shard-hsw: [FAIL][84] ([fdo#99912]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw1/igt@kms_setmode@basic.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw1/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][86] ([fdo#108566]) -> [PASS][87] +5 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][88] ([fdo#109276]) -> [PASS][89] +14 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@prime_vgem@fence-wait-bsd2.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
* igt@tools_test@tools_test:
- shard-apl: [SKIP][90] ([fdo#109271]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl4/igt@tools_test@tools_test.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl3/igt@tools_test@tools_test.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111672]: https://bugs.freedesktop.org/show_bug.cgi?id=111672
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991
[fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
[fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112081]: https://bugs.freedesktop.org/show_bug.cgi?id=112081
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
@ 2019-11-03 7:35 ` Patchwork
0 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2019-11-03 7:35 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/perf: Reverse a ternary to make sparse happy (rev2)
URL : https://patchwork.freedesktop.org/series/68883/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_7242_full -> Patchwork_15113_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_15113_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_15113_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_15113_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_eio@in-flight-contexts-10ms:
- shard-snb: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb7/igt@gem_eio@in-flight-contexts-10ms.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb6/igt@gem_eio@in-flight-contexts-10ms.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@gem_ctx_persistence@processes}:
- shard-apl: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl6/igt@gem_ctx_persistence@processes.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl7/igt@gem_ctx_persistence@processes.html
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- {shard-tglb}: NOTRUN -> [FAIL][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb8/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html
Known issues
------------
Here are the changes found in Patchwork_15113_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-none:
- shard-iclb: [PASS][6] -> [SKIP][7] ([fdo#109276] / [fdo#112080]) +3 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@gem_ctx_isolation@vcs1-none.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb8/igt@gem_ctx_isolation@vcs1-none.html
* igt@gem_ctx_shared@exec-single-timeline-bsd:
- shard-iclb: [PASS][8] -> [SKIP][9] ([fdo#110841])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb7/igt@gem_ctx_shared@exec-single-timeline-bsd.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@gem_ctx_shared@exec-single-timeline-bsd.html
* igt@gem_exec_schedule@in-order-bsd:
- shard-iclb: [PASS][10] -> [SKIP][11] ([fdo#112146]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@gem_exec_schedule@in-order-bsd.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb2/igt@gem_exec_schedule@in-order-bsd.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][12] -> [SKIP][13] ([fdo#109276]) +18 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb5/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_persistent_relocs@forked-thrash-inactive:
- shard-snb: [PASS][14] -> [TIMEOUT][15] ([fdo#112068 ])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb7/igt@gem_persistent_relocs@forked-thrash-inactive.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb5/igt@gem_persistent_relocs@forked-thrash-inactive.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy:
- shard-hsw: [PASS][16] -> [DMESG-WARN][17] ([fdo#111870])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw6/igt@gem_userptr_blits@map-fixed-invalidate-busy.html
* igt@i915_selftest@live_hangcheck:
- shard-hsw: [PASS][18] -> [DMESG-FAIL][19] ([fdo#111991])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw2/igt@i915_selftest@live_hangcheck.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw1/igt@i915_selftest@live_hangcheck.html
* igt@i915_selftest@mock_requests:
- shard-glk: [PASS][20] -> [INCOMPLETE][21] ([fdo#103359] / [k.org#198133])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-glk2/igt@i915_selftest@mock_requests.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-glk9/igt@i915_selftest@mock_requests.html
* igt@kms_color@pipe-b-legacy-gamma:
- shard-kbl: [PASS][22] -> [FAIL][23] ([fdo#104782])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl4/igt@kms_color@pipe-b-legacy-gamma.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-kbl7/igt@kms_color@pipe-b-legacy-gamma.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-iclb: [PASS][24] -> [FAIL][25] ([fdo#103167]) +6 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- shard-kbl: [PASS][26] -> [DMESG-WARN][27] ([fdo#108566]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl1/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-kbl3/igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][28] -> [SKIP][29] ([fdo#109441]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb8/igt@kms_psr@psr2_sprite_plane_move.html
* igt@perf_pmu@busy-no-semaphores-vcs1:
- shard-iclb: [PASS][30] -> [SKIP][31] ([fdo#112080]) +11 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@perf_pmu@busy-no-semaphores-vcs1.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb6/igt@perf_pmu@busy-no-semaphores-vcs1.html
#### Possible fixes ####
* igt@gem_ctx_isolation@bcs0-s3:
- {shard-tglb}: [INCOMPLETE][32] ([fdo#111832]) -> [PASS][33] +1 similar issue
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb2/igt@gem_ctx_isolation@bcs0-s3.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb8/igt@gem_ctx_isolation@bcs0-s3.html
* {igt@gem_ctx_persistence@vcs1-cleanup}:
- shard-iclb: [SKIP][34] ([fdo#109276] / [fdo#112080]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@gem_ctx_persistence@vcs1-cleanup.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@gem_ctx_persistence@vcs1-cleanup.html
* {igt@gem_ctx_persistence@vecs0-mixed-process}:
- {shard-tglb}: [FAIL][36] -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb3/igt@gem_ctx_persistence@vecs0-mixed-process.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb5/igt@gem_ctx_persistence@vecs0-mixed-process.html
* igt@gem_ctx_switch@queue-light:
- {shard-tglb}: [INCOMPLETE][38] ([fdo#111672]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb6/igt@gem_ctx_switch@queue-light.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb1/igt@gem_ctx_switch@queue-light.html
* igt@gem_eio@in-flight-suspend:
- {shard-tglb}: [INCOMPLETE][40] ([fdo#111832] / [fdo#111850] / [fdo#112081]) -> [PASS][41]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb2/igt@gem_eio@in-flight-suspend.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb8/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@unwedge-stress:
- shard-snb: [FAIL][42] ([fdo#109661]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb5/igt@gem_eio@unwedge-stress.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb6/igt@gem_eio@unwedge-stress.html
* igt@gem_exec_parallel@vcs1-fds:
- shard-iclb: [SKIP][44] ([fdo#112080]) -> [PASS][45] +11 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@gem_exec_parallel@vcs1-fds.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@gem_exec_parallel@vcs1-fds.html
* igt@gem_exec_schedule@preempt-queue-bsd:
- shard-iclb: [SKIP][46] ([fdo#112146]) -> [PASS][47] +8 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb2/igt@gem_exec_schedule@preempt-queue-bsd.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb8/igt@gem_exec_schedule@preempt-queue-bsd.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-iclb: [TIMEOUT][48] ([fdo#112068 ]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb3/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing:
- shard-snb: [FAIL][50] ([fdo#112037]) -> [PASS][51]
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb5/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb7/igt@gem_persistent_relocs@forked-interruptible-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-hsw: [DMESG-WARN][52] ([fdo#111870]) -> [PASS][53] +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-snb: [DMESG-WARN][54] ([fdo#111870]) -> [PASS][55] +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-snb7/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_selftest@mock_requests:
- shard-skl: [INCOMPLETE][56] -> [PASS][57]
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl8/igt@i915_selftest@mock_requests.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl6/igt@i915_selftest@mock_requests.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- {shard-tglb}: [INCOMPLETE][58] ([fdo#111832] / [fdo#111850]) -> [PASS][59]
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb1/igt@i915_suspend@fence-restore-tiled2untiled.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb5/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@sysfs-reader:
- shard-apl: [DMESG-WARN][60] ([fdo#108566]) -> [PASS][61] +6 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl6/igt@i915_suspend@sysfs-reader.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl2/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding:
- shard-skl: [FAIL][62] ([fdo#103232]) -> [PASS][63]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl1/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl4/igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][64] ([fdo#105767]) -> [PASS][65]
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled:
- shard-skl: [FAIL][66] ([fdo#103184] / [fdo#103232]) -> [PASS][67]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl5/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl10/igt@kms_draw_crc@draw-method-rgb565-mmap-wc-untiled.html
* igt@kms_flip@flip-vs-dpms-off-vs-modeset:
- shard-apl: [INCOMPLETE][68] ([fdo#103927]) -> [PASS][69]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl2/igt@kms_flip@flip-vs-dpms-off-vs-modeset.html
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl1/igt@kms_flip@flip-vs-dpms-off-vs-modeset.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
- shard-iclb: [FAIL][70] ([fdo#103167]) -> [PASS][71] +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render:
- {shard-tglb}: [FAIL][72] ([fdo#103167]) -> [PASS][73] +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-tglb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-tglb3/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-render.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-FAIL][74] ([fdo#103375] / [fdo#108566]) -> [PASS][75]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-kbl4/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][76] ([fdo#108145] / [fdo#110403]) -> [PASS][77]
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl10/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl7/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [FAIL][78] ([fdo#108145]) -> [PASS][79] +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-skl5/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_psr@psr2_sprite_mmap_cpu:
- shard-iclb: [SKIP][80] ([fdo#109441]) -> [PASS][81] +2 similar issues
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb4/igt@kms_psr@psr2_sprite_mmap_cpu.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_cpu.html
* igt@kms_setmode@basic:
- shard-apl: [FAIL][82] ([fdo#99912]) -> [PASS][83]
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl2/igt@kms_setmode@basic.html
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl6/igt@kms_setmode@basic.html
- shard-hsw: [FAIL][84] ([fdo#99912]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-hsw1/igt@kms_setmode@basic.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-hsw1/igt@kms_setmode@basic.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-kbl: [DMESG-WARN][86] ([fdo#108566]) -> [PASS][87] +5 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-kbl3/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-kbl7/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
* igt@prime_vgem@fence-wait-bsd2:
- shard-iclb: [SKIP][88] ([fdo#109276]) -> [PASS][89] +14 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-iclb8/igt@prime_vgem@fence-wait-bsd2.html
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-iclb1/igt@prime_vgem@fence-wait-bsd2.html
* igt@tools_test@tools_test:
- shard-apl: [SKIP][90] ([fdo#109271]) -> [PASS][91]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7242/shard-apl4/igt@tools_test@tools_test.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/shard-apl3/igt@tools_test@tools_test.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109276]: https://bugs.freedesktop.org/show_bug.cgi?id=109276
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109661]: https://bugs.freedesktop.org/show_bug.cgi?id=109661
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110841]: https://bugs.freedesktop.org/show_bug.cgi?id=110841
[fdo#111672]: https://bugs.freedesktop.org/show_bug.cgi?id=111672
[fdo#111747]: https://bugs.freedesktop.org/show_bug.cgi?id=111747
[fdo#111832]: https://bugs.freedesktop.org/show_bug.cgi?id=111832
[fdo#111850]: https://bugs.freedesktop.org/show_bug.cgi?id=111850
[fdo#111870]: https://bugs.freedesktop.org/show_bug.cgi?id=111870
[fdo#111991]: https://bugs.freedesktop.org/show_bug.cgi?id=111991
[fdo#112037]: https://bugs.freedesktop.org/show_bug.cgi?id=112037
[fdo#112068 ]: https://bugs.freedesktop.org/show_bug.cgi?id=112068
[fdo#112080]: https://bugs.freedesktop.org/show_bug.cgi?id=112080
[fdo#112081]: https://bugs.freedesktop.org/show_bug.cgi?id=112081
[fdo#112146]: https://bugs.freedesktop.org/show_bug.cgi?id=112146
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15113/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [v2] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-12-03 5:05 ` Nathan Chancellor
0 siblings, 0 replies; 21+ messages in thread
From: Nathan Chancellor @ 2019-12-03 5:05 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Nov 01, 2019 at 07:21:16PM +0000, Chris Wilson wrote:
> Avoid
>
> drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
>
> simply by inverting the predicate and reversing the ternary.
>
> v2: More the long lines into their own function so there is no confusion
> on operator precedence.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
I don't see this applied to drm-intel yet (unless I am blind) and clang
warns about this as well.
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [v2] drm/i915/perf: Reverse a ternary to make sparse happy
@ 2019-12-03 5:05 ` Nathan Chancellor
0 siblings, 0 replies; 21+ messages in thread
From: Nathan Chancellor @ 2019-12-03 5:05 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
On Fri, Nov 01, 2019 at 07:21:16PM +0000, Chris Wilson wrote:
> Avoid
>
> drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
>
> simply by inverting the predicate and reversing the ternary.
>
> v2: More the long lines into their own function so there is no confusion
> on operator precedence.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
I don't see this applied to drm-intel yet (unless I am blind) and clang
warns about this as well.
Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [v2] drm/i915/perf: Reverse a ternary to make sparse happy
2019-12-03 5:05 ` [Intel-gfx] " Nathan Chancellor
(?)
@ 2019-12-03 9:11 ` Chris Wilson
-1 siblings, 0 replies; 21+ messages in thread
From: Chris Wilson @ 2019-12-03 9:11 UTC (permalink / raw)
To: Nathan Chancellor; +Cc: intel-gfx
Quoting Nathan Chancellor (2019-12-03 05:05:22)
> On Fri, Nov 01, 2019 at 07:21:16PM +0000, Chris Wilson wrote:
> > Avoid
> >
> > drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
> >
> > simply by inverting the predicate and reversing the ternary.
> >
> > v2: More the long lines into their own function so there is no confusion
> > on operator precedence.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> > Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
> I don't see this applied to drm-intel yet (unless I am blind) and clang
> warns about this as well.
It's in tip. I guess you are looking at the linux-next branch that gets
frozen for the merge window.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2019-12-03 9:11 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-01 18:18 [PATCH] drm/i915/perf: Reverse a ternary to make sparse happy Chris Wilson
2019-11-01 18:18 ` [Intel-gfx] " Chris Wilson
2019-11-01 18:23 ` Lionel Landwerlin
2019-11-01 18:23 ` [Intel-gfx] " Lionel Landwerlin
2019-11-01 19:12 ` Umesh Nerlige Ramappa
2019-11-01 19:12 ` [Intel-gfx] " Umesh Nerlige Ramappa
2019-11-01 19:21 ` [PATCH v2] " Chris Wilson
2019-11-01 19:21 ` [Intel-gfx] " Chris Wilson
2019-11-01 19:31 ` Umesh Nerlige Ramappa
2019-11-01 19:31 ` [Intel-gfx] " Umesh Nerlige Ramappa
2019-12-03 5:05 ` [v2] " Nathan Chancellor
2019-12-03 5:05 ` [Intel-gfx] " Nathan Chancellor
2019-12-03 9:11 ` Chris Wilson
2019-11-01 19:36 ` ✗ Fi.CI.CHECKPATCH: warning for drm/i915/perf: Reverse a ternary to make sparse happy (rev2) Patchwork
2019-11-01 19:36 ` [Intel-gfx] " Patchwork
2019-11-01 19:37 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-11-01 19:37 ` [Intel-gfx] " Patchwork
2019-11-01 20:11 ` ✓ Fi.CI.BAT: success " Patchwork
2019-11-01 20:11 ` [Intel-gfx] " Patchwork
2019-11-03 7:35 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-11-03 7:35 ` [Intel-gfx] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.