* [U-Boot] [PATCH] buildman: Fix problem with non-existent output directories
@ 2019-11-01 21:47 Tom Rini
2019-11-02 3:54 ` Bin Meng
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2019-11-01 21:47 UTC (permalink / raw)
To: u-boot
Now that we have buildman telling genboards.cfg to use an output
directory we need to ensure that it exists.
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg")
Signed-off-by: Tom Rini <trini@konsulko.com>
---
tools/buildman/control.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index 9787b8674761..5988ada72b75 100644
--- a/tools/buildman/control.py
+++ b/tools/buildman/control.py
@@ -201,6 +201,8 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
# Work out what subset of the boards we are building
if not boards:
+ if not os.path.exists(options.output_dir):
+ os.mkdir(options.output_dir)
board_file = os.path.join(options.output_dir, 'boards.cfg')
genboardscfg = os.path.join(options.git, 'tools/genboardscfg.py')
status = subprocess.call([genboardscfg, '-o', board_file])
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] buildman: Fix problem with non-existent output directories
2019-11-01 21:47 [U-Boot] [PATCH] buildman: Fix problem with non-existent output directories Tom Rini
@ 2019-11-02 3:54 ` Bin Meng
2019-11-02 16:47 ` Tom Rini
2019-11-19 20:14 ` [U-Boot] [PATCHv2] " Tom Rini
0 siblings, 2 replies; 6+ messages in thread
From: Bin Meng @ 2019-11-02 3:54 UTC (permalink / raw)
To: u-boot
On Sat, Nov 2, 2019 at 5:48 AM Tom Rini <trini@konsulko.com> wrote:
>
> Now that we have buildman telling genboards.cfg to use an output
> directory we need to ensure that it exists.
>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> tools/buildman/control.py | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/buildman/control.py b/tools/buildman/control.py
> index 9787b8674761..5988ada72b75 100644
> --- a/tools/buildman/control.py
> +++ b/tools/buildman/control.py
> @@ -201,6 +201,8 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
>
> # Work out what subset of the boards we are building
> if not boards:
> + if not os.path.exists(options.output_dir):
> + os.mkdir(options.output_dir)
Use os.makedirs() ?
> board_file = os.path.join(options.output_dir, 'boards.cfg')
> genboardscfg = os.path.join(options.git, 'tools/genboardscfg.py')
> status = subprocess.call([genboardscfg, '-o', board_file])
> --
Regards,
Bin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] buildman: Fix problem with non-existent output directories
2019-11-02 3:54 ` Bin Meng
@ 2019-11-02 16:47 ` Tom Rini
2019-11-19 20:14 ` [U-Boot] [PATCHv2] " Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2019-11-02 16:47 UTC (permalink / raw)
To: u-boot
On Sat, Nov 02, 2019 at 11:54:44AM +0800, Bin Meng wrote:
> On Sat, Nov 2, 2019 at 5:48 AM Tom Rini <trini@konsulko.com> wrote:
> >
> > Now that we have buildman telling genboards.cfg to use an output
> > directory we need to ensure that it exists.
> >
> > Cc: Bin Meng <bmeng.cn@gmail.com>
> > Cc: Simon Glass <sjg@chromium.org>
> > Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg")
> > Signed-off-by: Tom Rini <trini@konsulko.com>
> > ---
> > tools/buildman/control.py | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/buildman/control.py b/tools/buildman/control.py
> > index 9787b8674761..5988ada72b75 100644
> > --- a/tools/buildman/control.py
> > +++ b/tools/buildman/control.py
> > @@ -201,6 +201,8 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
> >
> > # Work out what subset of the boards we are building
> > if not boards:
> > + if not os.path.exists(options.output_dir):
> > + os.mkdir(options.output_dir)
>
> Use os.makedirs() ?
Ah, in case we need more than one directory made? OK, I'll do v2
shortly.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191102/a66f6574/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCHv2] buildman: Fix problem with non-existent output directories
2019-11-02 3:54 ` Bin Meng
2019-11-02 16:47 ` Tom Rini
@ 2019-11-19 20:14 ` Tom Rini
2019-11-20 1:33 ` Bin Meng
2019-11-24 14:56 ` Tom Rini
1 sibling, 2 replies; 6+ messages in thread
From: Tom Rini @ 2019-11-19 20:14 UTC (permalink / raw)
To: u-boot
Now that we have buildman telling genboards.cfg to use an output
directory we need to ensure that it exists.
Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: Simon Glass <sjg@chromium.org>
Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg")
Signed-off-by: Tom Rini <trini@konsulko.com>
---
Changes in v2:
- Use os.makedirs() per Bin
---
tools/buildman/control.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tools/buildman/control.py b/tools/buildman/control.py
index 216012d00168..c55a65d0c30b 100644
--- a/tools/buildman/control.py
+++ b/tools/buildman/control.py
@@ -201,6 +201,8 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
# Work out what subset of the boards we are building
if not boards:
+ if not os.path.exists(options.output_dir):
+ os.makedirs(options.output_dir)
board_file = os.path.join(options.output_dir, 'boards.cfg')
genboardscfg = os.path.join(options.git, 'tools/genboardscfg.py')
status = subprocess.call([genboardscfg, '-o', board_file])
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCHv2] buildman: Fix problem with non-existent output directories
2019-11-19 20:14 ` [U-Boot] [PATCHv2] " Tom Rini
@ 2019-11-20 1:33 ` Bin Meng
2019-11-24 14:56 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Bin Meng @ 2019-11-20 1:33 UTC (permalink / raw)
To: u-boot
On Wed, Nov 20, 2019 at 4:14 AM Tom Rini <trini@konsulko.com> wrote:
>
> Now that we have buildman telling genboards.cfg to use an output
> directory we need to ensure that it exists.
>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> Changes in v2:
> - Use os.makedirs() per Bin
> ---
> tools/buildman/control.py | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCHv2] buildman: Fix problem with non-existent output directories
2019-11-19 20:14 ` [U-Boot] [PATCHv2] " Tom Rini
2019-11-20 1:33 ` Bin Meng
@ 2019-11-24 14:56 ` Tom Rini
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2019-11-24 14:56 UTC (permalink / raw)
To: u-boot
On Tue, Nov 19, 2019 at 03:14:33PM -0500, Tom Rini wrote:
> Now that we have buildman telling genboards.cfg to use an output
> directory we need to ensure that it exists.
>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: Simon Glass <sjg@chromium.org>
> Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg")
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191124/eb72a80b/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-24 14:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-01 21:47 [U-Boot] [PATCH] buildman: Fix problem with non-existent output directories Tom Rini
2019-11-02 3:54 ` Bin Meng
2019-11-02 16:47 ` Tom Rini
2019-11-19 20:14 ` [U-Boot] [PATCHv2] " Tom Rini
2019-11-20 1:33 ` Bin Meng
2019-11-24 14:56 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.