All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net] dccp: do not leak jiffies on the wire
@ 2019-11-04 15:57 Eric Dumazet
  2019-11-04 19:37 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2019-11-04 15:57 UTC (permalink / raw)
  To: David S . Miller; +Cc: netdev, Eric Dumazet, Eric Dumazet, Thiemo Nagel

For some reason I missed the case of DCCP passive
flows in my previous patch.

Fixes: a904a0693c18 ("inet: stop leaking jiffies on the wire")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Thiemo Nagel <tnagel@google.com>
---
 net/dccp/ipv4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index 0d8f782c25ccc031e5322beccb0242ee42b032b9..d19557c6d04b58a3eccad3d7971522fad666157b 100644
--- a/net/dccp/ipv4.c
+++ b/net/dccp/ipv4.c
@@ -416,7 +416,7 @@ struct sock *dccp_v4_request_recv_sock(const struct sock *sk,
 	RCU_INIT_POINTER(newinet->inet_opt, rcu_dereference(ireq->ireq_opt));
 	newinet->mc_index  = inet_iif(skb);
 	newinet->mc_ttl	   = ip_hdr(skb)->ttl;
-	newinet->inet_id   = jiffies;
+	newinet->inet_id   = prandom_u32();
 
 	if (dst == NULL && (dst = inet_csk_route_child_sock(sk, newsk, req)) == NULL)
 		goto put_and_exit;
-- 
2.24.0.rc1.363.gb1bccd3e3d-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] dccp: do not leak jiffies on the wire
  2019-11-04 15:57 [PATCH net] dccp: do not leak jiffies on the wire Eric Dumazet
@ 2019-11-04 19:37 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-11-04 19:37 UTC (permalink / raw)
  To: edumazet; +Cc: netdev, eric.dumazet, tnagel

From: Eric Dumazet <edumazet@google.com>
Date: Mon,  4 Nov 2019 07:57:55 -0800

> For some reason I missed the case of DCCP passive
> flows in my previous patch.
> 
> Fixes: a904a0693c18 ("inet: stop leaking jiffies on the wire")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Thiemo Nagel <tnagel@google.com>

Applied and queued up for -stable, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-11-04 19:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 15:57 [PATCH net] dccp: do not leak jiffies on the wire Eric Dumazet
2019-11-04 19:37 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.