All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present
@ 2019-10-31 21:48 ` Manasi Navare
  0 siblings, 0 replies; 30+ messages in thread
From: Manasi Navare @ 2019-10-31 21:48 UTC (permalink / raw)
  To: intel-gfx, dri-devel; +Cc: Dave Airlie

In case of tiled displays, if we hotplug just one connector,
fbcon currently just selects the preferred mode and if it is
tiled mode then that becomes a problem if rest of the tiles are
not present.
So in the fbdev driver on hotplug when we probe the client modeset,
we we dont find all the connectors for all tiles, then on a connector
with one tile, just fallback to the first available non tiled mode
to display over a single connector.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Suggested-by: Dave Airlie <airlied@redhat.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Dave Airlie <airlied@redhat.com>
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
 drivers/gpu/drm/drm_client_modeset.c | 29 ++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/drivers/gpu/drm/drm_client_modeset.c b/drivers/gpu/drm/drm_client_modeset.c
index 895b73f23079..e28a723587db 100644
--- a/drivers/gpu/drm/drm_client_modeset.c
+++ b/drivers/gpu/drm/drm_client_modeset.c
@@ -114,6 +114,20 @@ drm_client_find_modeset(struct drm_client_dev *client, struct drm_crtc *crtc)
 	return NULL;
 }
 
+static struct drm_display_mode *
+drm_connector_fallback_non_tiled_mode(struct drm_connector *connector)
+{
+	struct drm_display_mode *mode;
+
+	list_for_each_entry(mode, &connector->modes, head) {
+		if (mode->hdisplay == connector->tile_h_size &&
+		    mode->vdisplay == connector->tile_v_size)
+			continue;
+		return mode;
+	}
+	return NULL;
+}
+
 static struct drm_display_mode *
 drm_connector_has_preferred_mode(struct drm_connector *connector, int width, int height)
 {
@@ -348,8 +362,17 @@ static bool drm_client_target_preferred(struct drm_connector **connectors,
 	struct drm_connector *connector;
 	u64 conn_configured = 0;
 	int tile_pass = 0;
+	int num_tiled_conns = 0;
 	int i;
 
+	for (i = 0; i < connector_count; i++) {
+		connector = connectors[i];
+		if (!connector->has_tile)
+			continue;
+
+		num_tiled_conns ++;
+	}
+
 retry:
 	for (i = 0; i < connector_count; i++) {
 		connector = connectors[i];
@@ -394,6 +417,12 @@ static bool drm_client_target_preferred(struct drm_connector **connectors,
 				      connector->base.id, connector->tile_group ? connector->tile_group->id : 0);
 			modes[i] = drm_connector_has_preferred_mode(connector, width, height);
 		}
+		if (connector->has_tile &&
+		    num_tiled_conns < connector->num_h_tile * connector->num_v_tile) {
+			DRM_DEBUG_KMS("Falling back to non tiled mode on Connector %d\n",
+				      connector->base.id);
+			modes[i] = drm_connector_fallback_non_tiled_mode(connector);
+		}
 		/* No preferred modes, pick one off the list */
 		if (!modes[i] && !list_empty(&connector->modes)) {
 			list_for_each_entry(modes[i], &connector->modes, head)
-- 
2.19.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 30+ messages in thread
end of thread, other threads:[~2019-11-06 23:54 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 21:48 [PATCH] drm/fbdev: Fallback to non tiled mode if all tiles not present Manasi Navare
2019-10-31 21:48 ` [Intel-gfx] " Manasi Navare
2019-10-31 21:48 ` Manasi Navare
2019-10-31 23:13 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-10-31 23:13   ` [Intel-gfx] " Patchwork
2019-10-31 23:41 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-31 23:41   ` [Intel-gfx] " Patchwork
2019-11-02  8:42 ` ✓ Fi.CI.IGT: " Patchwork
2019-11-02  8:42   ` [Intel-gfx] " Patchwork
2019-11-04  9:18 ` [Intel-gfx] [PATCH] " Daniel Vetter
2019-11-04  9:18   ` Daniel Vetter
     [not found]   ` <CAMwc25oYjL3K7dcikX-oM_Y4ZP1ZRwUDKvsKO69vg81ZU6Xg8A@mail.gmail.com>
2019-11-04 18:14     ` Daniel Vetter
2019-11-04 18:14       ` [Intel-gfx] " Daniel Vetter
2019-11-04 18:14       ` Daniel Vetter
2019-11-04 21:03     ` Manasi Navare
2019-11-04 21:03       ` [Intel-gfx] " Manasi Navare
2019-11-04 21:03       ` Manasi Navare
2019-11-06  2:50       ` Dave Airlie
2019-11-06  2:50         ` Dave Airlie
2019-11-06 23:54         ` Manasi Navare
2019-11-06 23:54           ` Manasi Navare
2019-11-06  2:47 ` Dave Airlie
2019-11-06  2:47   ` [Intel-gfx] " Dave Airlie
2019-11-06  2:47   ` Dave Airlie
2019-11-06 11:34   ` Daniel Stone
2019-11-06 11:34     ` [Intel-gfx] " Daniel Stone
2019-11-06 11:34     ` Daniel Stone
2019-11-06 20:37   ` Manasi Navare
2019-11-06 20:37     ` [Intel-gfx] " Manasi Navare
2019-11-06 20:37     ` Manasi Navare

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.