* [Buildroot] [PATCH 1/1] package/rng-tools: needs NPTL
@ 2019-10-30 5:58 Bernd Kuhls
2019-10-30 9:38 ` Matthew Weber
2019-11-04 20:48 ` Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Bernd Kuhls @ 2019-10-30 5:58 UTC (permalink / raw)
To: buildroot
Fixes:
http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/rng-tools/Config.in | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/package/rng-tools/Config.in b/package/rng-tools/Config.in
index 7218aeac97..71514260e6 100644
--- a/package/rng-tools/Config.in
+++ b/package/rng-tools/Config.in
@@ -1,7 +1,8 @@
config BR2_PACKAGE_RNG_TOOLS
bool "rng-tools"
depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS || !(BR2_i386 || BR2_x86_64 || BR2_powerpc64le) # libgcrypt
- depends on BR2_TOOLCHAIN_HAS_THREADS
+ # pthread_setaffinity_np
+ depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
select BR2_PACKAGE_ARGP_STANDALONE if BR2_TOOLCHAIN_USES_UCLIBC || BR2_TOOLCHAIN_USES_MUSL
select BR2_PACKAGE_JITTERENTROPY_LIBRARY
# For rdrand & darn ligcrypt is required and it's not obvious to users
@@ -12,5 +13,5 @@ config BR2_PACKAGE_RNG_TOOLS
http://sourceforge.net/projects/gkernel/
-comment "rng-tools needs a toolchain w/ threads"
- depends on !BR2_TOOLCHAIN_HAS_THREADS
+comment "rng-tools needs a toolchain w/ NPTL"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/rng-tools: needs NPTL
2019-10-30 5:58 [Buildroot] [PATCH 1/1] package/rng-tools: needs NPTL Bernd Kuhls
@ 2019-10-30 9:38 ` Matthew Weber
2019-10-30 9:44 ` Matthew Weber
2019-11-04 20:48 ` Thomas Petazzoni
1 sibling, 1 reply; 6+ messages in thread
From: Matthew Weber @ 2019-10-30 9:38 UTC (permalink / raw)
To: buildroot
Bernd,
On Wed, Oct 30, 2019 at 12:58 AM Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>
> Fixes:
> http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
$ ./utils/check-package package/rng-tools/*
99 lines processed
0 warnings generated
Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/rng-tools: needs NPTL
2019-10-30 9:38 ` Matthew Weber
@ 2019-10-30 9:44 ` Matthew Weber
2019-10-30 20:53 ` Arnout Vandecappelle
0 siblings, 1 reply; 6+ messages in thread
From: Matthew Weber @ 2019-10-30 9:44 UTC (permalink / raw)
To: buildroot
Bernd,
On Wed, Oct 30, 2019 at 4:38 AM Matthew Weber
<matthew.weber@rockwellcollins.com> wrote:
>
> Bernd,
>
>
> On Wed, Oct 30, 2019 at 12:58 AM Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/
> >
> > Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
>
> $ ./utils/check-package package/rng-tools/*
> 99 lines processed
> 0 warnings generated
>
> Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>
Looks like the next thread related build failure will be musl related.
./utils/test-pkg -p rng-tools -d testbuild
br-arm-full [1/6]: OK
br-arm-cortex-a9-glibc [2/6]: OK
br-arm-cortex-m4-full [3/6]: SKIPPED
br-x86-64-musl [4/6]: FAILED
br-arm-full-static [5/6]: OK
sourcery-arm [6/6]: OK
rngd_jitter.c:(.text+0x7da): undefined reference to `pthread_yield'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/rng-tools: needs NPTL
2019-10-30 9:44 ` Matthew Weber
@ 2019-10-30 20:53 ` Arnout Vandecappelle
2019-10-31 7:38 ` Matthew Weber
0 siblings, 1 reply; 6+ messages in thread
From: Arnout Vandecappelle @ 2019-10-30 20:53 UTC (permalink / raw)
To: buildroot
On 30/10/2019 10:44, Matthew Weber wrote:
> Bernd,
>
> On Wed, Oct 30, 2019 at 4:38 AM Matthew Weber
> <matthew.weber@rockwellcollins.com> wrote:
>>
>> Bernd,
>>
>>
>> On Wed, Oct 30, 2019 at 12:58 AM Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
>>>
>>> Fixes:
>>> http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/
>>>
>>> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
>>
>> $ ./utils/check-package package/rng-tools/*
>> 99 lines processed
>> 0 warnings generated
>>
>> Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>
>
> Looks like the next thread related build failure will be musl related.
>
> ./utils/test-pkg -p rng-tools -d testbuild
> br-arm-full [1/6]: OK
> br-arm-cortex-a9-glibc [2/6]: OK
> br-arm-cortex-m4-full [3/6]: SKIPPED
> br-x86-64-musl [4/6]: FAILED
> br-arm-full-static [5/6]: OK
> sourcery-arm [6/6]: OK
>
>
> rngd_jitter.c:(.text+0x7da): undefined reference to `pthread_yield'
man pthread_yield:
This call is nonstandard, but present on several other systems. Use the
standardized sched_yield(2) instead.
Should be simple enough to patch.
Regards,
Arnout
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/rng-tools: needs NPTL
2019-10-30 20:53 ` Arnout Vandecappelle
@ 2019-10-31 7:38 ` Matthew Weber
0 siblings, 0 replies; 6+ messages in thread
From: Matthew Weber @ 2019-10-31 7:38 UTC (permalink / raw)
To: buildroot
Arnout,
On Wed, Oct 30, 2019 at 3:53 PM Arnout Vandecappelle <arnout@mind.be> wrote:
>
>
>
> On 30/10/2019 10:44, Matthew Weber wrote:
> > Bernd,
> >
> > On Wed, Oct 30, 2019 at 4:38 AM Matthew Weber
> > <matthew.weber@rockwellcollins.com> wrote:
> >>
> >> Bernd,
> >>
> >>
> >> On Wed, Oct 30, 2019 at 12:58 AM Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> >>>
> >>> Fixes:
> >>> http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/
> >>>
> >>> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> >>
> >> $ ./utils/check-package package/rng-tools/*
> >> 99 lines processed
> >> 0 warnings generated
> >>
> >> Reviewed-by: Matt Weber <matthew.weber@rockwellcollins.com>
> >
> > Looks like the next thread related build failure will be musl related.
> >
> > ./utils/test-pkg -p rng-tools -d testbuild
> > br-arm-full [1/6]: OK
> > br-arm-cortex-a9-glibc [2/6]: OK
> > br-arm-cortex-m4-full [3/6]: SKIPPED
> > br-x86-64-musl [4/6]: FAILED
> > br-arm-full-static [5/6]: OK
> > sourcery-arm [6/6]: OK
> >
> >
> > rngd_jitter.c:(.text+0x7da): undefined reference to `pthread_yield'
>
> man pthread_yield:
>
> This call is nonstandard, but present on several other systems. Use the
> standardized sched_yield(2) instead.
>
> Should be simple enough to patch.
Looks like upstream had a commit
http://patchwork.ozlabs.org/patch/1187237/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH 1/1] package/rng-tools: needs NPTL
2019-10-30 5:58 [Buildroot] [PATCH 1/1] package/rng-tools: needs NPTL Bernd Kuhls
2019-10-30 9:38 ` Matthew Weber
@ 2019-11-04 20:48 ` Thomas Petazzoni
1 sibling, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2019-11-04 20:48 UTC (permalink / raw)
To: buildroot
On Wed, 30 Oct 2019 06:58:50 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> Fixes:
> http://autobuild.buildroot.net/results/e18/e1815b96997fb7def688e0aeb5d342fc64dbb64d/
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/rng-tools/Config.in | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-04 20:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 5:58 [Buildroot] [PATCH 1/1] package/rng-tools: needs NPTL Bernd Kuhls
2019-10-30 9:38 ` Matthew Weber
2019-10-30 9:44 ` Matthew Weber
2019-10-30 20:53 ` Arnout Vandecappelle
2019-10-31 7:38 ` Matthew Weber
2019-11-04 20:48 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.