All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk
@ 2019-11-04  8:19 ` Peng Fan
  0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2019-11-04  8:19 UTC (permalink / raw)
  To: sboyd, shawnguo, s.hauer, festevam, Abel Vesa
  Cc: kernel, dl-linux-imx, Anson Huang, Jacky Bai, linux-clk,
	linux-arm-kernel, linux-kernel, Leonard Crestez, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
without ipg clk. Actually there are ipg clks for other sai clks,
let's add IMX8MN_CLK_SAI7_IPG clk.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clk/imx/clk-imx8mn.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index 838f6e2347f1..5e801892c631 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
 	clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk", "ipg_audio_root", base + 0x43b0, 0);
 	clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk", "ipg_audio_root", base + 0x45f0, 0);
 	clks[IMX8MN_CLK_SAI7_ROOT] = imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0, &share_count_sai7);
+	clks[IMX8MN_CLK_SAI7_IPG] = imx_clk_hw_gate2_shared2("sai7_ipg_clk", "ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
 
 	clks[IMX8MN_CLK_DRAM_ALT_ROOT] = imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
 
-- 
2.16.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk
@ 2019-11-04  8:19 ` Peng Fan
  0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2019-11-04  8:19 UTC (permalink / raw)
  To: sboyd, shawnguo, s.hauer, festevam, Abel Vesa
  Cc: Peng Fan, Jacky Bai, Anson Huang, linux-kernel, dl-linux-imx,
	kernel, Leonard Crestez, linux-clk, linux-arm-kernel

From: Peng Fan <peng.fan@nxp.com>

It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
without ipg clk. Actually there are ipg clks for other sai clks,
let's add IMX8MN_CLK_SAI7_IPG clk.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/clk/imx/clk-imx8mn.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
index 838f6e2347f1..5e801892c631 100644
--- a/drivers/clk/imx/clk-imx8mn.c
+++ b/drivers/clk/imx/clk-imx8mn.c
@@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
 	clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk", "ipg_audio_root", base + 0x43b0, 0);
 	clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk", "ipg_audio_root", base + 0x45f0, 0);
 	clks[IMX8MN_CLK_SAI7_ROOT] = imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0, &share_count_sai7);
+	clks[IMX8MN_CLK_SAI7_IPG] = imx_clk_hw_gate2_shared2("sai7_ipg_clk", "ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
 
 	clks[IMX8MN_CLK_DRAM_ALT_ROOT] = imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
 
-- 
2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* RE: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk
  2019-11-04  8:19 ` Peng Fan
@ 2019-11-04  8:21   ` Peng Fan
  -1 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2019-11-04  8:21 UTC (permalink / raw)
  To: sboyd, shawnguo, s.hauer, festevam, Abel Vesa
  Cc: kernel, dl-linux-imx, Anson Huang, Jacky Bai, linux-clk,
	linux-arm-kernel, linux-kernel, Leonard Crestez

> Subject: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk

Missed to add, patch was made based on clk_hw API patch
https://patchwork.kernel.org/patch/11224941/

Thanks,
Peng.
> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
> without ipg clk. Actually there are ipg clks for other sai clks, let's add
> IMX8MN_CLK_SAI7_IPG clk.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/clk/imx/clk-imx8mn.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 838f6e2347f1..5e801892c631 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct
> platform_device *pdev)
>  	clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk",
> "ipg_audio_root", base + 0x43b0, 0);
>  	clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk",
> "ipg_audio_root", base + 0x45f0, 0);
>  	clks[IMX8MN_CLK_SAI7_ROOT] =
> imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0,
> &share_count_sai7);
> +	clks[IMX8MN_CLK_SAI7_IPG] =
> imx_clk_hw_gate2_shared2("sai7_ipg_clk",
> +"ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
> 
>  	clks[IMX8MN_CLK_DRAM_ALT_ROOT] =
> imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
> 
> --
> 2.16.4


^ permalink raw reply	[flat|nested] 6+ messages in thread
* RE: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk
@ 2019-11-04  8:21   ` Peng Fan
  0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2019-11-04  8:21 UTC (permalink / raw)
  To: sboyd, shawnguo, s.hauer, festevam, Abel Vesa
  Cc: Jacky Bai, Anson Huang, linux-kernel, dl-linux-imx, kernel,
	Leonard Crestez, linux-clk, linux-arm-kernel

> Subject: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk

Missed to add, patch was made based on clk_hw API patch
https://patchwork.kernel.org/patch/11224941/

Thanks,
Peng.
> 
> From: Peng Fan <peng.fan@nxp.com>
> 
> It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
> without ipg clk. Actually there are ipg clks for other sai clks, let's add
> IMX8MN_CLK_SAI7_IPG clk.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/clk/imx/clk-imx8mn.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 838f6e2347f1..5e801892c631 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct
> platform_device *pdev)
>  	clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk",
> "ipg_audio_root", base + 0x43b0, 0);
>  	clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk",
> "ipg_audio_root", base + 0x45f0, 0);
>  	clks[IMX8MN_CLK_SAI7_ROOT] =
> imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0,
> &share_count_sai7);
> +	clks[IMX8MN_CLK_SAI7_IPG] =
> imx_clk_hw_gate2_shared2("sai7_ipg_clk",
> +"ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
> 
>  	clks[IMX8MN_CLK_DRAM_ALT_ROOT] =
> imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
> 
> --
> 2.16.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk
  2019-11-04  8:19 ` Peng Fan
@ 2019-11-05 11:36   ` Abel Vesa
  -1 siblings, 0 replies; 6+ messages in thread
From: Abel Vesa @ 2019-11-05 11:36 UTC (permalink / raw)
  To: Peng Fan
  Cc: sboyd, shawnguo, s.hauer, festevam, kernel, dl-linux-imx,
	Anson Huang, Jacky Bai, linux-clk, linux-arm-kernel,
	linux-kernel, Leonard Crestez

On 19-11-04 08:19:33, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
> without ipg clk. Actually there are ipg clks for other sai clks,
> let's add IMX8MN_CLK_SAI7_IPG clk.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> ---
>  drivers/clk/imx/clk-imx8mn.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 838f6e2347f1..5e801892c631 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
>  	clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk", "ipg_audio_root", base + 0x43b0, 0);
>  	clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk", "ipg_audio_root", base + 0x45f0, 0);
>  	clks[IMX8MN_CLK_SAI7_ROOT] = imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0, &share_count_sai7);
> +	clks[IMX8MN_CLK_SAI7_IPG] = imx_clk_hw_gate2_shared2("sai7_ipg_clk", "ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
>  
>  	clks[IMX8MN_CLK_DRAM_ALT_ROOT] = imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
>  
> -- 
> 2.16.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk
@ 2019-11-05 11:36   ` Abel Vesa
  0 siblings, 0 replies; 6+ messages in thread
From: Abel Vesa @ 2019-11-05 11:36 UTC (permalink / raw)
  To: Peng Fan
  Cc: Jacky Bai, Anson Huang, sboyd, shawnguo, s.hauer, linux-kernel,
	dl-linux-imx, kernel, Leonard Crestez, festevam, linux-clk,
	linux-arm-kernel

On 19-11-04 08:19:33, Peng Fan wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> It does not make sense to use shared count for IMX8MN_CLK_SAI7_ROOT
> without ipg clk. Actually there are ipg clks for other sai clks,
> let's add IMX8MN_CLK_SAI7_IPG clk.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

Reviewed-by: Abel Vesa <abel.vesa@nxp.com>

> ---
>  drivers/clk/imx/clk-imx8mn.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c
> index 838f6e2347f1..5e801892c631 100644
> --- a/drivers/clk/imx/clk-imx8mn.c
> +++ b/drivers/clk/imx/clk-imx8mn.c
> @@ -556,6 +556,7 @@ static int imx8mn_clocks_probe(struct platform_device *pdev)
>  	clks[IMX8MN_CLK_SDMA2_ROOT] = imx_clk_hw_gate4("sdma2_clk", "ipg_audio_root", base + 0x43b0, 0);
>  	clks[IMX8MN_CLK_SDMA3_ROOT] = imx_clk_hw_gate4("sdma3_clk", "ipg_audio_root", base + 0x45f0, 0);
>  	clks[IMX8MN_CLK_SAI7_ROOT] = imx_clk_hw_gate2_shared2("sai7_root_clk", "sai7", base + 0x4650, 0, &share_count_sai7);
> +	clks[IMX8MN_CLK_SAI7_IPG] = imx_clk_hw_gate2_shared2("sai7_ipg_clk", "ipg_audio_root", base + 0x4650, 0, &share_count_sai7);
>  
>  	clks[IMX8MN_CLK_DRAM_ALT_ROOT] = imx_clk_hw_fixed_factor("dram_alt_root", "dram_alt", 1, 4);
>  
> -- 
> 2.16.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-11-05 11:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04  8:19 [PATCH] clk: imx: imx8mn: add IMX8MN_CLK_SAI7_IPG clk Peng Fan
2019-11-04  8:19 ` Peng Fan
2019-11-04  8:21 ` Peng Fan
2019-11-04  8:21   ` Peng Fan
2019-11-05 11:36 ` Abel Vesa
2019-11-05 11:36   ` Abel Vesa

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.