* [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add writeback support
@ 2019-11-05 12:22 Arkadiusz Hiler
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 2/4] kms_writeback: Add initial writeback tests Arkadiusz Hiler
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Arkadiusz Hiler @ 2019-11-05 12:22 UTC (permalink / raw)
To: igt-dev
From: Brian Starkey <brian.starkey@arm.com>
Add support in igt_kms for writeback connectors, with the ability
to attach framebuffers.
v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before
drmModeGetResources()
Signed-off-by: Brian Starkey <brian.starkey@arm.com>
[rebased and updated to the latest igt style]
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Reviewed-by: Simon Ser <contact@emersion.fr>
Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
lib/igt_kms.c | 59 +++++++++++++++++++++++++++++++++++++++++++++++++++
lib/igt_kms.h | 6 ++++++
2 files changed, 65 insertions(+)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index e9b80b9b..2d7eabc6 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -412,6 +412,9 @@ const char * const igt_connector_prop_names[IGT_NUM_CONNECTOR_PROPS] = {
[IGT_CONNECTOR_VRR_CAPABLE] = "vrr_capable",
[IGT_CONNECTOR_HDCP_CONTENT_TYPE] = "HDCP Content Type",
[IGT_CONNECTOR_LINK_STATUS] = "link-status",
+ [IGT_CONNECTOR_WRITEBACK_PIXEL_FORMATS] = "WRITEBACK_PIXEL_FORMATS",
+ [IGT_CONNECTOR_WRITEBACK_FB_ID] = "WRITEBACK_FB_ID",
+ [IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR] = "WRITEBACK_OUT_FENCE_PTR",
};
/*
@@ -644,6 +647,7 @@ static const struct type_name connector_type_names[] = {
{ DRM_MODE_CONNECTOR_VIRTUAL, "Virtual" },
{ DRM_MODE_CONNECTOR_DSI, "DSI" },
{ DRM_MODE_CONNECTOR_DPI, "DPI" },
+ { DRM_MODE_CONNECTOR_WRITEBACK, "Writeback" },
{}
};
@@ -1853,6 +1857,14 @@ static void igt_output_reset(igt_output_t *output)
if (igt_output_has_prop(output, IGT_CONNECTOR_CONTENT_PROTECTION))
igt_output_set_prop_enum(output, IGT_CONNECTOR_CONTENT_PROTECTION,
"Undesired");
+
+ if (igt_output_has_prop(output, IGT_CONNECTOR_WRITEBACK_FB_ID))
+ igt_output_set_prop_value(output, IGT_CONNECTOR_WRITEBACK_FB_ID, 0);
+
+ if (igt_output_has_prop(output, IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR)) {
+ igt_output_clear_prop_changed(output, IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR);
+ output->writeback_out_fence_fd = -1;
+ }
}
/**
@@ -1866,6 +1878,8 @@ static void igt_output_reset(igt_output_t *output)
* - %IGT_CONNECTOR_CRTC_ID
* - %IGT_CONNECTOR_BROADCAST_RGB (if applicable)
* %IGT_CONNECTOR_CONTENT_PROTECTION (if applicable)
+ * - %IGT_CONNECTOR_WRITEBACK_FB_ID
+ * - %IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR
* - igt_output_override_mode() to default.
*
* For pipes:
@@ -1935,6 +1949,8 @@ void igt_display_require(igt_display_t *display, int drm_fd)
display->drm_fd = drm_fd;
+ drmSetClientCap(drm_fd, DRM_CLIENT_CAP_WRITEBACK_CONNECTORS, 1);
+
resources = drmModeGetResources(display->drm_fd);
if (!resources)
goto out;
@@ -2228,6 +2244,11 @@ static void igt_output_fini(igt_output_t *output)
kmstest_free_connector_config(&output->config);
free(output->name);
output->name = NULL;
+
+ if (output->writeback_out_fence_fd != -1) {
+ close(output->writeback_out_fence_fd);
+ output->writeback_out_fence_fd = -1;
+ }
}
/**
@@ -3290,6 +3311,11 @@ static void igt_atomic_prepare_connector_commit(igt_output_t *output, drmModeAto
output->props[i],
output->values[i]));
}
+
+ if (output->writeback_out_fence_fd != -1) {
+ close(output->writeback_out_fence_fd);
+ output->writeback_out_fence_fd = -1;
+ }
}
/*
@@ -3412,6 +3438,16 @@ display_commit_changed(igt_display_t *display, enum igt_commit_style s)
else
/* no modeset in universal commit, no change to crtc. */
output->changed &= 1 << IGT_CONNECTOR_CRTC_ID;
+
+ if (s == COMMIT_ATOMIC) {
+ if (igt_output_is_prop_changed(output, IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR))
+ igt_assert(output->writeback_out_fence_fd >= 0);
+
+ output->values[IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR] = 0;
+ output->values[IGT_CONNECTOR_WRITEBACK_FB_ID] = 0;
+ igt_output_clear_prop_changed(output, IGT_CONNECTOR_WRITEBACK_FB_ID);
+ igt_output_clear_prop_changed(output, IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR);
+ }
}
if (display->first_commit) {
@@ -4084,6 +4120,29 @@ void igt_pipe_request_out_fence(igt_pipe_t *pipe)
igt_pipe_obj_set_prop_value(pipe, IGT_CRTC_OUT_FENCE_PTR, (ptrdiff_t)&pipe->out_fence_fd);
}
+/**
+ * igt_output_set_writeback_fb:
+ * @output: Target output
+ * @fb: Target framebuffer
+ *
+ * This function sets the given @fb to be used as the target framebuffer for the
+ * writeback engine at the next atomic commit. It will also request a writeback
+ * out fence that will contain the fd number of the out fence created by KMS if
+ * the given @fb is valid.
+ */
+void igt_output_set_writeback_fb(igt_output_t *output, struct igt_fb *fb)
+{
+ igt_display_t *display = output->display;
+
+ LOG(display, "%s: output_set_writeback_fb(%d)\n", output->name, fb ? fb->fb_id : 0);
+
+ igt_output_set_prop_value(output, IGT_CONNECTOR_WRITEBACK_FB_ID, fb ? fb->fb_id : 0);
+ /* only request a writeback out fence if the framebuffer is valid */
+ if (fb)
+ igt_output_set_prop_value(output, IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR,
+ (ptrdiff_t)&output->writeback_out_fence_fd);
+}
+
/**
* igt_wait_for_vblank_count:
* @drm_fd: A drm file descriptor
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 7193f9a5..9bf70acf 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -125,6 +125,9 @@ enum igt_atomic_connector_properties {
IGT_CONNECTOR_VRR_CAPABLE,
IGT_CONNECTOR_HDCP_CONTENT_TYPE,
IGT_CONNECTOR_LINK_STATUS,
+ IGT_CONNECTOR_WRITEBACK_PIXEL_FORMATS,
+ IGT_CONNECTOR_WRITEBACK_FB_ID,
+ IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR,
IGT_NUM_CONNECTOR_PROPS
};
@@ -365,6 +368,8 @@ typedef struct {
bool use_override_mode;
drmModeModeInfo override_mode;
+ int32_t writeback_out_fence_fd;
+
/* bitmask of changed properties */
uint64_t changed;
@@ -423,6 +428,7 @@ igt_plane_t *igt_output_get_plane_type_index(igt_output_t *output,
igt_output_t *igt_output_from_connector(igt_display_t *display,
drmModeConnector *connector);
const drmModeModeInfo *igt_std_1024_mode_get(void);
+void igt_output_set_writeback_fb(igt_output_t *output, struct igt_fb *fb);
igt_plane_t *igt_pipe_get_plane_type(igt_pipe_t *pipe, int plane_type);
int igt_pipe_count_plane_type(igt_pipe_t *pipe, int plane_type);
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 2/4] kms_writeback: Add initial writeback tests
2019-11-05 12:22 [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add writeback support Arkadiusz Hiler
@ 2019-11-05 12:22 ` Arkadiusz Hiler
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 3/4] lib: Add function to hash a framebuffer Arkadiusz Hiler
` (4 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Arkadiusz Hiler @ 2019-11-05 12:22 UTC (permalink / raw)
To: igt-dev
From: Brian Starkey <brian.starkey@arm.com>
Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and
WRITEBACK_FB_ID properties on writeback connectors, ensuring their
behaviour is correct.
V6: Simon Ser
- Add igt documentation with igt_describe and IGT_TEST_DESCRIPTION
- Drop kmstest_force_connector with FORCE_CONNECTOR_ON in
kms_writeback_get_output since userspace won't do this operation
- Add an igt_debug statement in case we don't use writeback output
- Drop flags parameter from do_writeback_test
- Remove do_writeback_test "igt_assert(*out_fence_ptr == -1)" after
igt_display_try_commit_atomic
- Rename writeback_fb_id to writeback_test_fb
- Rework writeback_test_fb for checking buffer
- Move some tests from invalid_out_fence to writeback_test_fb
- Replace ret != 0 checking by ret == -EINVAL after invoke
do_writeback_test
- Assert on igt_output_get_plane_type()
- Replace igt_fb_mod_to_tiling to DRM_FORMAT_MOD_LINEAR
- Rename tests
- Replace int ret by unsigned int fd_id when calling igt_create_fb
Signed-off-by: Brian Starkey <brian.starkey@arm.com>
[rebased and updated do_writeback_test() function to address feedback]
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
[rebased and updated the patch to address feedback]
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
tests/Makefile.sources | 1 +
tests/kms_writeback.c | 290 +++++++++++++++++++++++++++++++++++++++++
tests/meson.build | 1 +
3 files changed, 292 insertions(+)
create mode 100644 tests/kms_writeback.c
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 093eb57f..55a3aedd 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -81,6 +81,7 @@ TESTS_progs = \
kms_universal_plane \
kms_vblank \
kms_vrr \
+ kms_writeback \
meta_test \
perf \
perf_pmu \
diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
new file mode 100644
index 00000000..a373ec4d
--- /dev/null
+++ b/tests/kms_writeback.c
@@ -0,0 +1,290 @@
+/*
+ * (C) COPYRIGHT 2017 ARM Limited. All rights reserved.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ */
+
+#include <errno.h>
+#include <stdbool.h>
+#include <stdio.h>
+#include <string.h>
+
+#include "igt.h"
+#include "igt_core.h"
+#include "igt_fb.h"
+
+IGT_TEST_DESCRIPTION("Exercise writeback feature.");
+
+static drmModePropertyBlobRes *get_writeback_formats_blob(igt_output_t *output)
+{
+ drmModePropertyBlobRes *blob = NULL;
+ uint64_t blob_id;
+ int ret;
+
+ ret = kmstest_get_property(output->display->drm_fd,
+ output->config.connector->connector_id,
+ DRM_MODE_OBJECT_CONNECTOR,
+ igt_connector_prop_names[IGT_CONNECTOR_WRITEBACK_PIXEL_FORMATS],
+ NULL, &blob_id, NULL);
+ if (ret)
+ blob = drmModeGetPropertyBlob(output->display->drm_fd, blob_id);
+
+ igt_assert(blob);
+
+ return blob;
+}
+
+static bool check_writeback_config(igt_display_t *display, igt_output_t *output)
+{
+ igt_fb_t input_fb, output_fb;
+ igt_plane_t *plane;
+ uint32_t writeback_format = DRM_FORMAT_XRGB8888;
+ int width, height, ret;
+ unsigned int fb_id;
+ drmModeModeInfo override_mode = {
+ .clock = 25175,
+ .hdisplay = 640,
+ .hsync_start = 656,
+ .hsync_end = 752,
+ .htotal = 800,
+ .hskew = 0,
+ .vdisplay = 480,
+ .vsync_start = 490,
+ .vsync_end = 492,
+ .vtotal = 525,
+ .vscan = 0,
+ .vrefresh = 60,
+ .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
+ .name = {"640x480-60"},
+ };
+ igt_output_override_mode(output, &override_mode);
+
+ width = override_mode.hdisplay;
+ height = override_mode.vdisplay;
+
+ fb_id = igt_create_fb(display->drm_fd, width, height, DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &input_fb);
+ igt_assert(fb_id >= 0);
+
+ fb_id = igt_create_fb(display->drm_fd, width, height, writeback_format, DRM_FORMAT_MOD_LINEAR, &output_fb);
+ igt_assert(fb_id >= 0);
+
+ plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_plane_set_fb(plane, &input_fb);
+ igt_output_set_writeback_fb(output, &output_fb);
+
+ ret = igt_display_try_commit_atomic(display, DRM_MODE_ATOMIC_TEST_ONLY |
+ DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
+ igt_plane_set_fb(plane, NULL);
+ igt_remove_fb(display->drm_fd, &input_fb);
+ igt_remove_fb(display->drm_fd, &output_fb);
+
+ return !ret;
+}
+
+static igt_output_t *kms_writeback_get_output(igt_display_t *display)
+{
+ int i;
+
+ for (i = 0; i < display->n_outputs; i++) {
+ igt_output_t *output = &display->outputs[i];
+ int j;
+
+ if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_WRITEBACK)
+ continue;
+
+ for (j = 0; j < igt_display_get_n_pipes(display); j++) {
+ igt_output_set_pipe(output, j);
+
+ if (check_writeback_config(display, output)) {
+ igt_debug("Using connector %u:%s on pipe %d\n",
+ output->config.connector->connector_id,
+ output->name, j);
+ return output;
+ }
+ }
+
+ /* Restore any connectors we don't use, so we don't trip on them later */
+ kmstest_force_connector(display->drm_fd, output->config.connector, FORCE_CONNECTOR_UNSPECIFIED);
+ }
+
+ igt_debug("The device does not enable writeback\n");
+
+ return NULL;
+}
+
+static void check_writeback_fb_id(igt_output_t *output)
+{
+ uint64_t check_fb_id;
+
+ check_fb_id = igt_output_get_prop(output, IGT_CONNECTOR_WRITEBACK_FB_ID);
+ igt_assert(check_fb_id == 0);
+}
+
+static int do_writeback_test(igt_output_t *output, uint32_t fb_id,
+ int32_t *out_fence_ptr, bool ptr_valid)
+{
+ int ret;
+ int flags = DRM_MODE_ATOMIC_ALLOW_MODESET;
+ igt_display_t *display = output->display;
+ struct kmstest_connector_config *config = &output->config;
+
+ igt_output_set_prop_value(output, IGT_CONNECTOR_CRTC_ID, config->crtc->crtc_id);
+ igt_output_set_prop_value(output, IGT_CONNECTOR_WRITEBACK_FB_ID, fb_id);
+ igt_output_set_prop_value(output, IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR, (uint64_t)out_fence_ptr);
+
+ if (ptr_valid)
+ *out_fence_ptr = 0;
+
+ ret = igt_display_try_commit_atomic(display, flags, NULL);
+
+ /* WRITEBACK_FB_ID must always read as zero */
+ check_writeback_fb_id(output);
+
+ return ret;
+}
+
+static void invalid_output_fence(igt_output_t *output, igt_fb_t *valid_fb)
+{
+ int ret;
+
+ ret = do_writeback_test(output, valid_fb->fb_id, (int32_t *)0x8, false);
+ igt_assert(ret == -EFAULT);
+}
+
+static void writeback_test_fb(igt_output_t *output, igt_fb_t *valid_fb, igt_fb_t *invalid_fb)
+{
+
+ int ret;
+ int32_t out_fence;
+
+ /* Valid output buffer */
+ ret = do_writeback_test(output, valid_fb->fb_id, NULL, false);
+ igt_assert(ret == 0);
+
+ /* Invalid object for WRITEBACK_FB_ID */
+ ret = do_writeback_test(output, output->id, NULL, false);
+ igt_assert(ret == -EINVAL);
+
+ /* Zero WRITEBACK_FB_ID */
+ ret = do_writeback_test(output, 0, NULL, false);
+ igt_assert(ret == 0);
+
+ /* No output buffer, but the WRITEBACK_OUT_FENCE_PTR set. */
+ ret = do_writeback_test(output, 0, &out_fence, true);
+ igt_assert(ret == -EINVAL);
+
+ /* Invalid output buffer. */
+ ret = do_writeback_test(output, invalid_fb->fb_id, &out_fence, true);
+ igt_assert(ret == -EINVAL);
+}
+
+igt_main
+{
+ igt_display_t display;
+ igt_output_t *output;
+ igt_plane_t *plane;
+ igt_fb_t input_fb;
+ drmModeModeInfo mode;
+ unsigned int fb_id;
+
+ memset(&display, 0, sizeof(display));
+
+ igt_fixture {
+ display.drm_fd = drm_open_driver_master(DRIVER_ANY);
+ igt_display_require(&display, display.drm_fd);
+
+ kmstest_set_vt_graphics_mode();
+
+ igt_display_require(&display, display.drm_fd);
+
+ igt_require(display.is_atomic);
+
+ output = kms_writeback_get_output(&display);
+ igt_require(output);
+
+ if (output->use_override_mode)
+ memcpy(&mode, &output->override_mode, sizeof(mode));
+ else
+ memcpy(&mode, &output->config.default_mode, sizeof(mode));
+
+ plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+ igt_assert(plane);
+
+ fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,
+ mode.vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ &input_fb);
+ igt_assert(fb_id >= 0);
+ igt_plane_set_fb(plane, &input_fb);
+ }
+
+ igt_describe("Check writeback formats");
+ igt_subtest("pixel-formats") {
+ drmModePropertyBlobRes *formats_blob = get_writeback_formats_blob(output);
+ const char *valid_chars = "0123456 ABCGNRUVXY";
+ unsigned int i;
+ char *c;
+
+ /*
+ * We don't have a comprehensive list of formats, so just check
+ * that the blob length is sensible and that it doesn't contain
+ * any outlandish characters
+ */
+ igt_assert(!(formats_blob->length % 4));
+ c = formats_blob->data;
+ for (i = 0; i < formats_blob->length; i++)
+ igt_assert_f(strchr(valid_chars, c[i]),
+ "Unexpected character %c\n", c[i]);
+ }
+
+ igt_describe("This test validates if the writeback core identify an "
+ "invalid output");
+ igt_subtest("invalid-output-fb") {
+ invalid_output_fence(output, &input_fb);
+ }
+
+ igt_describe("Test writeback with valid and invalid framebuffer");
+ igt_subtest("writeback-test-framebuffer") {
+ igt_fb_t output_fb, invalid_fb;
+ fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,
+ mode.vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &output_fb);
+ igt_require(fb_id > 0);
+
+ fb_id = igt_create_fb(display.drm_fd, mode.hdisplay / 2,
+ mode.vdisplay / 2,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ &invalid_fb);
+ igt_require(fb_id > 0);
+
+ writeback_test_fb(output, &output_fb, &invalid_fb);
+
+ igt_remove_fb(display.drm_fd, &output_fb);
+ igt_remove_fb(display.drm_fd, &invalid_fb);
+ }
+
+ igt_fixture {
+ igt_remove_fb(display.drm_fd, &input_fb);
+ igt_display_fini(&display);
+ }
+}
diff --git a/tests/meson.build b/tests/meson.build
index 3f3eee27..5a6aac95 100644
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -66,6 +66,7 @@ test_progs = [
'kms_universal_plane',
'kms_vblank',
'kms_vrr',
+ 'kms_writeback',
'meta_test',
'panfrost_get_param',
'panfrost_gem_new',
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 3/4] lib: Add function to hash a framebuffer
2019-11-05 12:22 [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add writeback support Arkadiusz Hiler
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 2/4] kms_writeback: Add initial writeback tests Arkadiusz Hiler
@ 2019-11-05 12:22 ` Arkadiusz Hiler
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 4/4] kms_writeback: Add writeback-check-output Arkadiusz Hiler
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Arkadiusz Hiler @ 2019-11-05 12:22 UTC (permalink / raw)
To: igt-dev
From: Brian Starkey <brian.starkey@arm.com>
To use writeback buffers as a CRC source, we need to be able to hash
them. Implement a simple FVA-1a hashing routine for this purpose.
Doing a bytewise hash on the framebuffer directly can be very slow if
the memory is noncached. By making a copy of each line in the FB first
(which can take advantage of word-access speedup), we can do the hash
on a cached copy, which is much faster (10x speedup on my platform).
V6: Simon Sir
- Replace #define by plain uint32_t variables
- Return -EINVAL in case fb->num_planes != 1
- Directly assign the mmap result to ptr
- No need to copy the whole stride, just copy fb->width * cpp since
we're only going to read that
v5: use igt_memcpy_from_wc() instead of plain memcpy, as suggested by
Chris Wilson
Signed-off-by: Brian Starkey <brian.starkey@arm.com>
[rebased and updated to the most recent API]
Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>
[rebased and updated the patch to address feedback]
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Reviewed-by: Simon Ser <simon.ser@intel.com>
Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
lib/igt_fb.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++++
lib/igt_fb.h | 2 ++
2 files changed, 70 insertions(+)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 4adca967..6e15be86 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -3481,6 +3481,74 @@ bool igt_fb_supported_format(uint32_t drm_format)
return true;
}
+/*
+ * This implements the FNV-1a hashing algorithm instead of CRC, for
+ * simplicity
+ * http://www.isthe.com/chongo/tech/comp/fnv/index.html
+ *
+ * hash = offset_basis
+ * for each octet_of_data to be hashed
+ * hash = hash xor octet_of_data
+ * hash = hash * FNV_prime
+ * return hash
+ *
+ * 32 bit offset_basis = 2166136261
+ * 32 bit FNV_prime = 224 + 28 + 0x93 = 16777619
+ */
+int igt_fb_get_crc(struct igt_fb *fb, igt_crc_t *crc)
+{
+ uint32_t FNV1a_OFFSET_BIAS = 2166136261;
+ uint32_t FNV1a_PRIME = 16777619;
+ uint32_t hash;
+ void *map;
+ char *ptr, *line = NULL;
+ int x, y, cpp = igt_drm_format_to_bpp(fb->drm_format) / 8;
+ uint32_t stride = calc_plane_stride(fb, 0);
+
+ if (fb->num_planes != 1)
+ return -EINVAL;
+
+ if (fb->is_dumb)
+ ptr = kmstest_dumb_map_buffer(fb->fd, fb->gem_handle, fb->size,
+ PROT_READ);
+ else
+ ptr = gem_mmap__gtt(fb->fd, fb->gem_handle, fb->size,
+ PROT_READ);
+
+ /*
+ * Framebuffers are often uncached, which can make byte-wise accesses
+ * very slow. We copy each line of the FB into a local buffer to speed
+ * up the hashing.
+ */
+ line = malloc(stride);
+ if (!line) {
+ munmap(map, fb->size);
+ return -ENOMEM;
+ }
+
+ hash = FNV1a_OFFSET_BIAS;
+
+ for (y = 0; y < fb->height; y++, ptr += stride) {
+
+ igt_memcpy_from_wc(line, ptr, fb->width * cpp);
+
+ for (x = 0; x < fb->width * cpp; x++) {
+ hash ^= line[x];
+ hash *= FNV1a_PRIME;
+ }
+ }
+
+ crc->n_words = 1;
+ crc->crc[0] = hash;
+
+ free(line);
+ munmap(map, fb->size);
+
+ return 0;
+#undef FNV1a_OFFSET_BIAS
+#undef FNV1a_PRIME
+}
+
/**
* igt_format_is_yuv:
* @drm_format: drm fourcc
diff --git a/lib/igt_fb.h b/lib/igt_fb.h
index 69132b41..d2394638 100644
--- a/lib/igt_fb.h
+++ b/lib/igt_fb.h
@@ -202,5 +202,7 @@ int igt_format_plane_bpp(uint32_t drm_format, int plane);
void igt_format_array_fill(uint32_t **formats_array, unsigned int *count,
bool allow_yuv);
+int igt_fb_get_crc(struct igt_fb *fb, igt_crc_t *crc);
+
#endif /* __IGT_FB_H__ */
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 4/4] kms_writeback: Add writeback-check-output
2019-11-05 12:22 [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add writeback support Arkadiusz Hiler
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 2/4] kms_writeback: Add initial writeback tests Arkadiusz Hiler
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 3/4] lib: Add function to hash a framebuffer Arkadiusz Hiler
@ 2019-11-05 12:22 ` Arkadiusz Hiler
2019-11-05 12:41 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Arkadiusz Hiler @ 2019-11-05 12:22 UTC (permalink / raw)
To: igt-dev
From: Brian Starkey <brian.starkey@arm.com>
Add a test which makes commits using the writeback connector, and
checks the output buffer hash to make sure it is/isn't written as
appropriate.
V6: Simon Ser
- Add igt documentation with igt_describe
- Replace int ret by unsigned int fd_id when calling igt_create_fb
- Add a descriptive error message if sync_fence_wait fail
- Replace color_idx variable by i
- Use in_fb instead of out_fb for getting the expected CRC
- Drop unnecessary parentheses
- Replace igt_fb_mod_to_tiling to DRM_FORMAT_MOD_LINEAR
Signed-off-by: Brian Starkey <brian.starkey@arm.com>
[rebased and updated the patch to address feedback]
Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Reviewed-by: Liviu Dudau <Liviu.Dudau@arm.com>
---
tests/kms_writeback.c | 123 ++++++++++++++++++++++++++++++++++++++++++
1 file changed, 123 insertions(+)
diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index a373ec4d..068595b9 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -30,6 +30,7 @@
#include "igt.h"
#include "igt_core.h"
#include "igt_fb.h"
+#include "sw_sync.h"
IGT_TEST_DESCRIPTION("Exercise writeback feature.");
@@ -196,6 +197,115 @@ static void writeback_test_fb(igt_output_t *output, igt_fb_t *valid_fb, igt_fb_t
igt_assert(ret == -EINVAL);
}
+static void fill_fb(igt_fb_t *fb, double color[3])
+{
+ cairo_t *cr = igt_get_cairo_ctx(fb->fd, fb);
+ igt_assert(cr);
+
+ igt_paint_color(cr, 0, 0, fb->width, fb->height,
+ color[0], color[1], color[2]);
+}
+
+static void get_and_wait_out_fence(igt_output_t *output)
+{
+ int ret;
+
+ igt_assert(output->writeback_out_fence_fd >= 0);
+
+ ret = sync_fence_wait(output->writeback_out_fence_fd, 1000);
+ igt_assert_f(ret == 0, "sync_fence_wait failed: %s\n", strerror(-ret));
+ close(output->writeback_out_fence_fd);
+ output->writeback_out_fence_fd = -1;
+}
+
+static void writeback_sequence(igt_output_t *output, igt_plane_t *plane,
+ igt_fb_t *in_fb, igt_fb_t *out_fbs[], int n_commits)
+{
+ int i;
+ double in_fb_colors[2][3] = {
+ { 1.0, 0.0, 0.0 },
+ { 0.0, 1.0, 0.0 },
+ };
+ double clear_color[3] = { 1.0, 1.0, 1.0 };
+ igt_crc_t cleared_crc, out_expected;
+
+ for (i = 0; i < n_commits; i++) {
+ /* Change the input color each time */
+ fill_fb(in_fb, in_fb_colors[i % 2]);
+
+ if (out_fbs[i]) {
+ igt_crc_t out_before;
+
+ /* Get the expected CRC */
+ igt_fb_get_crc(in_fb, &out_expected);
+
+ fill_fb(out_fbs[i], clear_color);
+ if (i == 0)
+ igt_fb_get_crc(out_fbs[i], &cleared_crc);
+ igt_fb_get_crc(out_fbs[i], &out_before);
+ igt_assert_crc_equal(&cleared_crc, &out_before);
+ }
+
+ /* Commit */
+ igt_plane_set_fb(plane, in_fb);
+ igt_output_set_writeback_fb(output, out_fbs[i]);
+
+ igt_display_commit_atomic(output->display,
+ DRM_MODE_ATOMIC_ALLOW_MODESET,
+ NULL);
+ if (out_fbs[i])
+ get_and_wait_out_fence(output);
+
+ /* Make sure the old output buffer is untouched */
+ if (i > 0 && out_fbs[i - 1] && out_fbs[i] != out_fbs[i - 1]) {
+ igt_crc_t out_prev;
+ igt_fb_get_crc(out_fbs[i - 1], &out_prev);
+ igt_assert_crc_equal(&cleared_crc, &out_prev);
+ }
+
+ /* Make sure this output buffer is written */
+ if (out_fbs[i]) {
+ igt_crc_t out_after;
+ igt_fb_get_crc(out_fbs[i], &out_after);
+ igt_assert_crc_equal(&out_expected, &out_after);
+
+ /* And clear it, for the next time */
+ fill_fb(out_fbs[i], clear_color);
+ }
+ }
+}
+
+static void writeback_check_output(igt_output_t *output, igt_plane_t *plane,
+ igt_fb_t *input_fb, igt_fb_t *output_fb)
+{
+ igt_fb_t *out_fbs[2] = { 0 };
+ igt_fb_t second_out_fb;
+ unsigned int fb_id;
+
+ /* One commit, with a writeback. */
+ writeback_sequence(output, plane, input_fb, &output_fb, 1);
+
+ /* Two commits, the second with no writeback */
+ out_fbs[0] = output_fb;
+ writeback_sequence(output, plane, input_fb, out_fbs, 2);
+
+ /* Two commits, both with writeback */
+ out_fbs[1] = output_fb;
+ writeback_sequence(output, plane, input_fb, out_fbs, 2);
+
+ fb_id = igt_create_fb(output_fb->fd,
+ output_fb->width, output_fb->height,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &second_out_fb);
+ igt_require(fb_id > 0);
+
+ /* Two commits, with different writeback buffers */
+ out_fbs[1] = &second_out_fb;
+ writeback_sequence(output, plane, input_fb, out_fbs, 2);
+
+ igt_remove_fb(output_fb->fd, &second_out_fb);
+}
+
igt_main
{
igt_display_t display;
@@ -283,6 +393,19 @@ igt_main
igt_remove_fb(display.drm_fd, &invalid_fb);
}
+ igt_describe("Check writeback output with CRC validation");
+ igt_subtest("writeback-check-output") {
+ igt_fb_t output_fb;
+ fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,
+ mode.vdisplay, DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR, &output_fb);
+ igt_require(fb_id > 0);
+
+ writeback_check_output(output, plane, &input_fb, &output_fb);
+
+ igt_remove_fb(display.drm_fd, &output_fb);
+ }
+
igt_fixture {
igt_remove_fb(display.drm_fd, &input_fb);
igt_display_fini(&display);
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
2019-11-05 12:22 [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add writeback support Arkadiusz Hiler
` (2 preceding siblings ...)
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 4/4] kms_writeback: Add writeback-check-output Arkadiusz Hiler
@ 2019-11-05 12:41 ` Patchwork
2019-11-05 12:50 ` Arkadiusz Hiler
2019-11-05 12:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-11-05 23:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2019-11-05 12:41 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
URL : https://patchwork.freedesktop.org/series/68992/
State : warning
== Summary ==
Did not get list of undocumented tests for this run, something is wrong!
Other than that, pipeline status: FAILED.
see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/76331 for more details
== Logs ==
For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/76331
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
2019-11-05 12:22 [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add writeback support Arkadiusz Hiler
` (3 preceding siblings ...)
2019-11-05 12:41 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support Patchwork
@ 2019-11-05 12:47 ` Patchwork
2019-11-05 23:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-11-05 12:47 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
URL : https://patchwork.freedesktop.org/series/68992/
State : success
== Summary ==
CI Bug Log - changes from IGT_5263 -> IGTPW_3652
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_3652 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3652, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3652:
### IGT changes ###
#### Warnings ####
* igt@kms_chamelium@vga-hpd-fast:
- fi-icl-u2: [SKIP][1] ([fdo#109309]) -> [SKIP][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/fi-icl-u2/igt@kms_chamelium@vga-hpd-fast.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/fi-icl-u2/igt@kms_chamelium@vga-hpd-fast.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_chamelium@vga-hpd-fast:
- {fi-icl-u4}: [SKIP][3] ([fdo#109309]) -> [SKIP][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/fi-icl-u4/igt@kms_chamelium@vga-hpd-fast.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/fi-icl-u4/igt@kms_chamelium@vga-hpd-fast.html
Known issues
------------
Here are the changes found in IGTPW_3652 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_basic@bad-close:
- fi-icl-u3: [PASS][5] -> [DMESG-WARN][6] ([fdo#107724]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/fi-icl-u3/igt@gem_basic@bad-close.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/fi-icl-u3/igt@gem_basic@bad-close.html
#### Possible fixes ####
* igt@gem_mmap_gtt@basic-write-gtt:
- fi-icl-u3: [DMESG-WARN][7] ([fdo#107724]) -> [PASS][8] +1 similar issue
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/fi-icl-u3/igt@gem_mmap_gtt@basic-write-gtt.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/fi-icl-u3/igt@gem_mmap_gtt@basic-write-gtt.html
* igt@i915_selftest@live_gem_contexts:
- fi-bsw-nick: [INCOMPLETE][9] ([fdo# 111542]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/fi-bsw-nick/igt@i915_selftest@live_gem_contexts.html
- fi-bsw-n3050: [INCOMPLETE][11] ([fdo# 111542]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/fi-bsw-n3050/igt@i915_selftest@live_gem_contexts.html
* igt@i915_selftest@live_requests:
- {fi-tgl-u}: [INCOMPLETE][13] ([fdo#112057]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/fi-tgl-u/igt@i915_selftest@live_requests.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/fi-tgl-u/igt@i915_selftest@live_requests.html
#### Warnings ####
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][15] ([fdo#111045] / [fdo#111096]) -> [FAIL][16] ([fdo#111407])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo# 111542]: https://bugs.freedesktop.org/show_bug.cgi?id= 111542
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#111045]: https://bugs.freedesktop.org/show_bug.cgi?id=111045
[fdo#111096]: https://bugs.freedesktop.org/show_bug.cgi?id=111096
[fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407
[fdo#112057]: https://bugs.freedesktop.org/show_bug.cgi?id=112057
Participating hosts (52 -> 43)
------------------------------
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-bwr-2160 fi-ctg-p8600 fi-gdg-551 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5263 -> IGTPW_3652
CI-20190529: 20190529
CI_DRM_7261: 0df0545b3693fbc84f91af17499f204437e7ac6a @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3652: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/index.html
IGT_5263: 8a5d44dc5e51622cd43f23c2cf24d44c24a0564d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Testlist changes ==
+igt@kms_writeback@invalid-output-fb
+igt@kms_writeback@pixel-formats
+igt@kms_writeback@writeback-check-output
+igt@kms_writeback@writeback-test-framebuffer
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
2019-11-05 12:41 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support Patchwork
@ 2019-11-05 12:50 ` Arkadiusz Hiler
2019-11-05 13:41 ` Petri Latvala
0 siblings, 1 reply; 9+ messages in thread
From: Arkadiusz Hiler @ 2019-11-05 12:50 UTC (permalink / raw)
To: igt-dev, Rodrigo Siqueira
On Tue, Nov 05, 2019 at 12:41:40PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
> URL : https://patchwork.freedesktop.org/series/68992/
> State : warning
>
> == Summary ==
>
> Did not get list of undocumented tests for this run, something is wrong!
>
> Other than that, pipeline status: FAILED.
>
> see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/76331 for more details
>
> == Logs ==
>
> For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/76331
fails to compile for armhf and mips
FAILED: tests/59830eb@@kms_writeback@exe/kms_writeback.c.o
/usr/bin/arm-linux-gnueabihf-gcc -Itests/59830eb@@kms_writeback@exe -Itests -I../tests -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/valgrind -I/usr/include/alsa -I/usr/include/libdrm/nouveau -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/59830eb@@kms_writeback@exe/kms_writeback.c.o' -MF 'tests/59830eb@@kms_writeback@exe/kms_writeback.c.o.d' -o 'tests/59830eb@@kms_writeback@exe/kms_writeback.c.o' -c ../tests/kms_writeback.c
In file included from ../lib/igt.h:39:0,
from ../tests/kms_writeback.c:30:
../tests/kms_writeback.c: In function ‘do_writeback_test’:
../tests/kms_writeback.c:152:75: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
igt_output_set_prop_value(output, IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR, (uint64_t)out_fence_ptr);
^
../lib/igt_kms.h:650:29: note: in definition of macro ‘igt_output_set_prop_value’
(output)->values[prop] = (value); \
^~~~~
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
2019-11-05 12:50 ` Arkadiusz Hiler
@ 2019-11-05 13:41 ` Petri Latvala
0 siblings, 0 replies; 9+ messages in thread
From: Petri Latvala @ 2019-11-05 13:41 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
On Tue, Nov 05, 2019 at 02:50:46PM +0200, Arkadiusz Hiler wrote:
> On Tue, Nov 05, 2019 at 12:41:40PM +0000, Patchwork wrote:
> > == Series Details ==
> >
> > Series: series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
> > URL : https://patchwork.freedesktop.org/series/68992/
> > State : warning
> >
> > == Summary ==
> >
> > Did not get list of undocumented tests for this run, something is wrong!
> >
> > Other than that, pipeline status: FAILED.
> >
> > see https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/76331 for more details
> >
> > == Logs ==
> >
> > For more details see: https://gitlab.freedesktop.org/gfx-ci/igt-ci-tags/pipelines/76331
>
> fails to compile for armhf and mips
>
> FAILED: tests/59830eb@@kms_writeback@exe/kms_writeback.c.o
> /usr/bin/arm-linux-gnueabihf-gcc -Itests/59830eb@@kms_writeback@exe -Itests -I../tests -I../include/drm-uapi -Ilib -I../lib -I../lib/stubs/syscalls -I. -I../ -I../lib/stubs/drm -I/usr/include/cairo -I/usr/include/glib-2.0 -I/usr/lib/arm-linux-gnueabihf/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/libdrm -I/usr/include/valgrind -I/usr/include/alsa -I/usr/include/libdrm/nouveau -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=gnu11 -O2 -g -D_GNU_SOURCE -include config.h -D_FORTIFY_SOURCE=2 -Wbad-function-cast -Wdeclaration-after-statement -Wformat=2 -Wlogical-op -Wmissing-declarations -Wmissing-format-attribute -Wmissing-noreturn -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wuninitialized -Wunused -Wno-clobbered -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-pointer-arith -Wno-sign-compare -Wno-type-limits -Wno-unused-parameter -Wno-unused-result -Werror=address -Werror=array-bounds -Werror=implicit -Werror=init-self -Werror=int-to-pointer-cast -Werror=main -Werror=missing-braces -Werror=nonnull -Werror=pointer-to-int-cast -Werror=return-type -Werror=sequence-point -Werror=trigraphs -Werror=write-strings -fno-builtin-malloc -fno-builtin-calloc -pthread -MD -MQ 'tests/59830eb@@kms_writeback@exe/kms_writeback.c.o' -MF 'tests/59830eb@@kms_writeback@exe/kms_writeback.c.o.d' -o 'tests/59830eb@@kms_writeback@exe/kms_writeback.c.o' -c ../tests/kms_writeback.c
> In file included from ../lib/igt.h:39:0,
> from ../tests/kms_writeback.c:30:
> ../tests/kms_writeback.c: In function ‘do_writeback_test’:
> ../tests/kms_writeback.c:152:75: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
> igt_output_set_prop_value(output, IGT_CONNECTOR_WRITEBACK_OUT_FENCE_PTR, (uint64_t)out_fence_ptr);
> ^
> ../lib/igt_kms.h:650:29: note: in definition of macro ‘igt_output_set_prop_value’
> (output)->values[prop] = (value); \
lib/ioctl_wrappers has from_user_pointer() and to_user_pointer() for that conversion.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
2019-11-05 12:22 [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add writeback support Arkadiusz Hiler
` (4 preceding siblings ...)
2019-11-05 12:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2019-11-05 23:43 ` Patchwork
5 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2019-11-05 23:43 UTC (permalink / raw)
To: Arkadiusz Hiler; +Cc: igt-dev
== Series Details ==
Series: series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support
URL : https://patchwork.freedesktop.org/series/68992/
State : failure
== Summary ==
CI Bug Log - changes from IGT_5263_full -> IGTPW_3652_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_3652_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_3652_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_3652_full:
### IGT changes ###
#### Possible regressions ####
* igt@debugfs_test@read_all_entries_display_off:
- shard-snb: [PASS][1] -> [FAIL][2] +2 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-snb7/igt@debugfs_test@read_all_entries_display_off.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-snb1/igt@debugfs_test@read_all_entries_display_off.html
* igt@debugfs_test@read_all_entries_display_on:
- shard-hsw: [PASS][3] -> [FAIL][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-hsw7/igt@debugfs_test@read_all_entries_display_on.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-hsw1/igt@debugfs_test@read_all_entries_display_on.html
- shard-iclb: [PASS][5] -> [FAIL][6] +2 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb1/igt@debugfs_test@read_all_entries_display_on.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb5/igt@debugfs_test@read_all_entries_display_on.html
- shard-kbl: [PASS][7] -> [FAIL][8] +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-kbl3/igt@debugfs_test@read_all_entries_display_on.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-kbl1/igt@debugfs_test@read_all_entries_display_on.html
- shard-apl: [PASS][9] -> [FAIL][10] +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-apl6/igt@debugfs_test@read_all_entries_display_on.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-apl2/igt@debugfs_test@read_all_entries_display_on.html
- shard-glk: [PASS][11] -> [FAIL][12] +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-glk1/igt@debugfs_test@read_all_entries_display_on.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-glk4/igt@debugfs_test@read_all_entries_display_on.html
* {igt@kms_writeback@invalid-output-fb} (NEW):
- {shard-tglb}: NOTRUN -> [SKIP][13] +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb5/igt@kms_writeback@invalid-output-fb.html
* {igt@kms_writeback@writeback-check-output} (NEW):
- shard-iclb: NOTRUN -> [SKIP][14] +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb8/igt@kms_writeback@writeback-check-output.html
#### Warnings ####
* igt@kms_crtc_background_color:
- shard-iclb: [SKIP][15] ([fdo#109305]) -> [SKIP][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb6/igt@kms_crtc_background_color.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb8/igt@kms_crtc_background_color.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-d-planes:
- shard-iclb: [SKIP][17] ([fdo#112010]) -> [SKIP][18] +11 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-d-planes.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb8/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-d-planes.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@debugfs_test@read_all_entries_display_off:
- {shard-tglb}: NOTRUN -> [FAIL][19]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb9/igt@debugfs_test@read_all_entries_display_off.html
* igt@gem_linear_blits@normal:
- {shard-tglb}: [PASS][20] -> [INCOMPLETE][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-tglb4/igt@gem_linear_blits@normal.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb9/igt@gem_linear_blits@normal.html
* igt@gem_tiled_fence_blits@normal:
- {shard-tglb}: [PASS][22] -> [DMESG-FAIL][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-tglb6/igt@gem_tiled_fence_blits@normal.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb9/igt@gem_tiled_fence_blits@normal.html
* igt@kms_crtc_background_color:
- {shard-tglb}: [SKIP][24] ([fdo#110529]) -> [SKIP][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-tglb6/igt@kms_crtc_background_color.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb7/igt@kms_crtc_background_color.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc:
- {shard-tglb}: NOTRUN -> [SKIP][26] +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite:
- {shard-tglb}: [SKIP][27] ([fdo#111825]) -> [SKIP][28] +4 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb9/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-pwrite.html
* {igt@kms_plane@pixel-format-pipe-d-planes-source-clamping}:
- shard-iclb: [SKIP][29] ([fdo#112010]) -> [SKIP][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb3/igt@kms_plane@pixel-format-pipe-d-planes-source-clamping.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb7/igt@kms_plane@pixel-format-pipe-d-planes-source-clamping.html
* igt@kms_rmfb@close-fd:
- {shard-tglb}: [PASS][31] -> [FAIL][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-tglb3/igt@kms_rmfb@close-fd.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb3/igt@kms_rmfb@close-fd.html
New tests
---------
New tests have been introduced between IGT_5263_full and IGTPW_3652_full:
### New IGT tests (4) ###
* igt@kms_writeback@invalid-output-fb:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_writeback@pixel-formats:
- Statuses : 6 skip(s)
- Exec time: [0.0] s
* igt@kms_writeback@writeback-check-output:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
* igt@kms_writeback@writeback-test-framebuffer:
- Statuses : 7 skip(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in IGTPW_3652_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@vcs1-dirty-switch:
- shard-iclb: [PASS][33] -> [SKIP][34] ([fdo#109276] / [fdo#112080])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb1/igt@gem_ctx_isolation@vcs1-dirty-switch.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb8/igt@gem_ctx_isolation@vcs1-dirty-switch.html
* igt@gem_ctx_switch@vcs1-heavy-queue:
- shard-iclb: [PASS][35] -> [SKIP][36] ([fdo#112080]) +8 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb4/igt@gem_ctx_switch@vcs1-heavy-queue.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb8/igt@gem_ctx_switch@vcs1-heavy-queue.html
* igt@gem_eio@reset-stress:
- shard-snb: [PASS][37] -> [FAIL][38] ([fdo#109661])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-snb6/igt@gem_eio@reset-stress.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-snb1/igt@gem_eio@reset-stress.html
* igt@gem_exec_schedule@independent-bsd2:
- shard-iclb: [PASS][39] -> [SKIP][40] ([fdo#109276]) +15 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb1/igt@gem_exec_schedule@independent-bsd2.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb6/igt@gem_exec_schedule@independent-bsd2.html
* igt@gem_exec_schedule@preempt-other-chain-bsd:
- shard-iclb: [PASS][41] -> [SKIP][42] ([fdo#112146]) +9 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb8/igt@gem_exec_schedule@preempt-other-chain-bsd.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb2/igt@gem_exec_schedule@preempt-other-chain-bsd.html
* igt@gem_persistent_relocs@forked-interruptible-thrashing:
- shard-snb: [PASS][43] -> [FAIL][44] ([fdo#112037])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-snb2/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-snb4/igt@gem_persistent_relocs@forked-interruptible-thrashing.html
* igt@gem_userptr_blits@dmabuf-sync:
- shard-snb: [PASS][45] -> [DMESG-WARN][46] ([fdo#111870]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-snb1/igt@gem_userptr_blits@dmabuf-sync.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-snb1/igt@gem_userptr_blits@dmabuf-sync.html
* igt@gem_userptr_blits@sync-unmap-cycles:
- shard-hsw: [PASS][47] -> [DMESG-WARN][48] ([fdo#111870]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-hsw5/igt@gem_userptr_blits@sync-unmap-cycles.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-hsw8/igt@gem_userptr_blits@sync-unmap-cycles.html
* igt@i915_selftest@mock_requests:
- shard-glk: [PASS][49] -> [DMESG-WARN][50] ([fdo#112158])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-glk7/igt@i915_selftest@mock_requests.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-glk8/igt@i915_selftest@mock_requests.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- shard-apl: [PASS][51] -> [DMESG-WARN][52] ([fdo#108566]) +1 similar issue
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-apl1/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@i915_suspend@sysfs-reader:
- shard-kbl: [PASS][53] -> [DMESG-WARN][54] ([fdo#108566]) +2 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-kbl4/igt@i915_suspend@sysfs-reader.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-kbl6/igt@i915_suspend@sysfs-reader.html
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: [PASS][55] -> [FAIL][56] ([fdo#104873])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-glk8/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-glk7/igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic.html
* igt@kms_flip@flip-vs-expired-vblank:
- shard-hsw: [PASS][57] -> [INCOMPLETE][58] ([fdo#103540]) +2 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-hsw7/igt@kms_flip@flip-vs-expired-vblank.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-hsw1/igt@kms_flip@flip-vs-expired-vblank.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt:
- shard-iclb: [PASS][59] -> [FAIL][60] ([fdo#103167]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb8/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-shrfb-msflip-blt.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes:
- shard-iclb: [PASS][61] -> [INCOMPLETE][62] ([fdo#107713] / [fdo#110042])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb3/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-b-planes.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][63] -> [SKIP][64] ([fdo#109441]) +1 similar issue
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb6/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_setmode@basic:
- shard-kbl: [PASS][65] -> [FAIL][66] ([fdo#99912])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-kbl7/igt@kms_setmode@basic.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-kbl2/igt@kms_setmode@basic.html
#### Possible fixes ####
* igt@gem_busy@busy-vcs1:
- shard-iclb: [SKIP][67] ([fdo#112080]) -> [PASS][68] +13 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb8/igt@gem_busy@busy-vcs1.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb1/igt@gem_busy@busy-vcs1.html
* {igt@gem_ctx_persistence@vcs1-mixed-process}:
- shard-iclb: [SKIP][69] ([fdo#109276] / [fdo#112080]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb6/igt@gem_ctx_persistence@vcs1-mixed-process.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb4/igt@gem_ctx_persistence@vcs1-mixed-process.html
* {igt@gem_eio@kms}:
- shard-kbl: [DMESG-WARN][71] ([fdo#105345]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-kbl2/igt@gem_eio@kms.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-kbl4/igt@gem_eio@kms.html
- {shard-tglb}: [INCOMPLETE][73] ([fdo#111887]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-tglb9/igt@gem_eio@kms.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb2/igt@gem_eio@kms.html
* igt@gem_exec_balancer@smoke:
- shard-iclb: [SKIP][75] ([fdo#110854]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb7/igt@gem_exec_balancer@smoke.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb2/igt@gem_exec_balancer@smoke.html
* igt@gem_exec_gttfill@basic:
- {shard-tglb}: [INCOMPLETE][77] ([fdo#111593]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-tglb6/igt@gem_exec_gttfill@basic.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb8/igt@gem_exec_gttfill@basic.html
* igt@gem_exec_schedule@preempt-bsd:
- shard-iclb: [SKIP][79] ([fdo#112146]) -> [PASS][80] +3 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb4/igt@gem_exec_schedule@preempt-bsd.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb8/igt@gem_exec_schedule@preempt-bsd.html
* igt@gem_exec_schedule@preempt-queue-chain-bsd2:
- {shard-tglb}: [INCOMPLETE][81] ([fdo#111677]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-tglb6/igt@gem_exec_schedule@preempt-queue-chain-bsd2.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb7/igt@gem_exec_schedule@preempt-queue-chain-bsd2.html
* igt@gem_userptr_blits@map-fixed-invalidate-busy-gup:
- shard-snb: [DMESG-WARN][83] ([fdo#111870]) -> [PASS][84] +2 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-snb1/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-snb2/igt@gem_userptr_blits@map-fixed-invalidate-busy-gup.html
* {igt@i915_pm_dc@dc6-psr}:
- shard-iclb: [FAIL][85] ([fdo#110548]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-iclb6/igt@i915_pm_dc@dc6-psr.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-iclb5/igt@i915_pm_dc@dc6-psr.html
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: [SKIP][87] ([fdo#109271]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-kbl1/igt@i915_pm_rc6_residency@rc6-accuracy.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-kbl1/igt@i915_pm_rc6_residency@rc6-accuracy.html
- shard-snb: [SKIP][89] ([fdo#109271]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-snb6/igt@i915_pm_rc6_residency@rc6-accuracy.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-snb2/igt@i915_pm_rc6_residency@rc6-accuracy.html
* igt@i915_suspend@fence-restore-tiled2untiled:
- {shard-tglb}: [INCOMPLETE][91] ([fdo#111832] / [fdo#111850]) -> [PASS][92] +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-tglb2/igt@i915_suspend@fence-restore-tiled2untiled.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-tglb3/igt@i915_suspend@fence-restore-tiled2untiled.html
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-hsw: [DMESG-WARN][93] -> [PASS][94]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-hsw2/igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-hsw7/igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b.html
* igt@kms_cursor_crc@pipe-b-cursor-size-change:
- shard-kbl: [FAIL][95] ([fdo#103232]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-kbl6/igt@kms_cursor_crc@pipe-b-cursor-size-change.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-kbl2/igt@kms_cursor_crc@pipe-b-cursor-size-change.html
- shard-apl: [FAIL][97] ([fdo#103232]) -> [PASS][98]
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-apl6/igt@kms_cursor_crc@pipe-b-cursor-size-change.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-size-change.html
* igt@kms_flip@flip-vs-suspend:
- shard-hsw: [INCOMPLETE][99] ([fdo#103540]) -> [PASS][100]
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-hsw2/igt@kms_flip@flip-vs-suspend.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-hsw1/igt@kms_flip@flip-vs-suspend.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][101] ([fdo#108566]) -> [PASS][102] +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-apl1/igt@kms_flip@flip-vs-suspend-interruptible.html
- shard-kbl: [DMESG-WARN][103] ([fdo#108566]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5263/shard-kbl3/igt@kms_flip@flip-vs-suspend-interruptible.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-pwrite:
- shard-iclb: [FAIL][105] ([fdo#103167]) -> [PASS][106] +5 similar
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3652/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2019-11-05 23:43 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 12:22 [igt-dev] [PATCH i-g-t 1/4] lib/igt_kms: Add writeback support Arkadiusz Hiler
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 2/4] kms_writeback: Add initial writeback tests Arkadiusz Hiler
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 3/4] lib: Add function to hash a framebuffer Arkadiusz Hiler
2019-11-05 12:22 ` [igt-dev] [PATCH i-g-t 4/4] kms_writeback: Add writeback-check-output Arkadiusz Hiler
2019-11-05 12:41 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [i-g-t,1/4] lib/igt_kms: Add writeback support Patchwork
2019-11-05 12:50 ` Arkadiusz Hiler
2019-11-05 13:41 ` Petri Latvala
2019-11-05 12:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2019-11-05 23:43 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.